99424 2012-10-15 23:59:55 -0700 Code to reverse a GlyphBuffer range is repeated in several places 2012-10-16 10:08:48 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 742877 0 mitz 2012-10-15 23:59:55 -0700 Code to reverse a GlyphBuffer range is repeated in several places 742880 1 168873 mitz 2012-10-16 00:03:12 -0700 Created attachment 168873 Introduce and deploy GlyphBuffer::reverse 743238 2 mitz 2012-10-16 10:08:48 -0700 Fixed in <http://trac.webkit.org/r131468>. 168873 2012-10-16 00:03:12 -0700 2012-10-16 09:22:44 -0700 Introduce and deploy GlyphBuffer::reverse bug-99424-20121016000211.patch text/plain 6035 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTQyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEwLTE1ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgQ29kZSB0byByZXZlcnNlIGEgR2x5 cGhCdWZmZXIgcmFuZ2UgaXMgcmVwZWF0ZWQgaW4gc2V2ZXJhbCBwbGFjZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5NDI0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9G b250RmFzdFBhdGguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6Z2V0R2x5cGhzQW5kQWR2 YW5jZXNGb3JTaW1wbGVUZXh0KTogUmVwbGFjZWQgZm9yIGxvb3Agd2l0aCBhIGNhbGwgdG8KKyAg ICAgICAgR2x5cGhCdWZmZXI6OnJldmVyc2UuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv R2x5cGhCdWZmZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OkdseXBoQnVmZmVyOjpyZXZlcnNlKTog QWRkZWQuIFJldmVyc2VzIHRoZSBnaXZlbiByYW5nZS4KKyAgICAgICAgKFdlYkNvcmU6OkdseXBo QnVmZmVyOjpzd2FwKTogTWFkZSBwcml2YXRlLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L1dpZHRoSXRlcmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YXBwbHlGb250VHJhbnNmb3Jt cyk6IFJlcGxhY2VkIGZvciBsb29wcyB3aXRoIGNhbGxzIHRvIEdseXBoQnVmZmVyOjpyZXZlcnNl IGFuZAorICAgICAgICBjb3JyZWN0ZWQgdGhlaXIgYm91bmRzLgorICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL21hYy9Gb250Q29tcGxleFRleHRNYWMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Rm9udDo6Z2V0R2x5cGhzQW5kQWR2YW5jZXNGb3JDb21wbGV4VGV4dCk6IFJlcGxhY2VkIGZvciBs b29wIHdpdGggYSBjYWxsIHRvCisgICAgICAgIEdseXBoQnVmZmVyOjpyYW5nZS4KKwogMjAxMi0x MC0xNSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHNv bWUgYXBwZWFyYW5jZSBnbGl0Y2hlcyBvZiBtdWx0aXBsZSBmaWVsZHMgaW5wdXQgZWxlbWVudHMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRGYXN0UGF0aC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhc3RQ YXRoLmNwcAkocmV2aXNpb24gMTMxNDEyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvRm9udEZhc3RQYXRoLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzQ3LDEwICszNDcsOCBA QCBmbG9hdCBGb250OjpnZXRHbHlwaHNBbmRBZHZhbmNlc0ZvclNpbXBsCiAgICAgfSBlbHNlCiAg ICAgICAgIGluaXRpYWxBZHZhbmNlID0gYmVmb3JlV2lkdGg7CiAKLSAgICBpZiAocnVuLnJ0bCgp KSB7Ci0gICAgICAgIGZvciAoaW50IGkgPSAwLCBlbmQgPSBnbHlwaEJ1ZmZlci5zaXplKCkgLSAx OyBpIDwgZW5kOyArK2ksIC0tZW5kKQotICAgICAgICAgICAgZ2x5cGhCdWZmZXIuc3dhcChpLCBl bmQpOwotICAgIH0KKyAgICBpZiAocnVuLnJ0bCgpKQorICAgICAgICBnbHlwaEJ1ZmZlci5yZXZl cnNlKDAsIGdseXBoQnVmZmVyLnNpemUoKSk7CiAKICAgICByZXR1cm4gaW5pdGlhbEFkdmFuY2U7 CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HbHlwaEJ1ZmZlci5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dseXBoQnVm ZmVyLmgJKHJldmlzaW9uIDEzMTQxMikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dseXBoQnVmZmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTExNiwyNyArMTE2LDYgQEAgcHVi bGljOgogCiAgICAgY29uc3QgU2ltcGxlRm9udERhdGEqIGZvbnREYXRhQXQoaW50IGluZGV4KSBj b25zdCB7IHJldHVybiBtX2ZvbnREYXRhW2luZGV4XTsgfQogICAgIAotICAgIHZvaWQgc3dhcChp bnQgaW5kZXgxLCBpbnQgaW5kZXgyKQotICAgIHsKLSAgICAgICAgY29uc3QgU2ltcGxlRm9udERh dGEqIGYgPSBtX2ZvbnREYXRhW2luZGV4MV07Ci0gICAgICAgIG1fZm9udERhdGFbaW5kZXgxXSA9 IG1fZm9udERhdGFbaW5kZXgyXTsKLSAgICAgICAgbV9mb250RGF0YVtpbmRleDJdID0gZjsKLQot ICAgICAgICBHbHlwaEJ1ZmZlckdseXBoIGcgPSBtX2dseXBoc1tpbmRleDFdOwotICAgICAgICBt X2dseXBoc1tpbmRleDFdID0gbV9nbHlwaHNbaW5kZXgyXTsKLSAgICAgICAgbV9nbHlwaHNbaW5k ZXgyXSA9IGc7Ci0KLSAgICAgICAgR2x5cGhCdWZmZXJBZHZhbmNlIHMgPSBtX2FkdmFuY2VzW2lu ZGV4MV07Ci0gICAgICAgIG1fYWR2YW5jZXNbaW5kZXgxXSA9IG1fYWR2YW5jZXNbaW5kZXgyXTsK LSAgICAgICAgbV9hZHZhbmNlc1tpbmRleDJdID0gczsKLQotI2lmIFBMQVRGT1JNKFdJTikKLSAg ICAgICAgRmxvYXRTaXplIG9mZnNldCA9IG1fb2Zmc2V0c1tpbmRleDFdOwotICAgICAgICBtX29m ZnNldHNbaW5kZXgxXSA9IG1fb2Zmc2V0c1tpbmRleDJdOwotICAgICAgICBtX29mZnNldHNbaW5k ZXgyXSA9IG9mZnNldDsKLSNlbmRpZgotICAgIH0KLQogICAgIEdseXBoIGdseXBoQXQoaW50IGlu ZGV4KSBjb25zdAogICAgIHsKICNpZiBVU0UoQ0FJUk8pIHx8IChQTEFURk9STShXWCkgJiYgZGVm aW5lZCh3eFVTRV9DQUlSTykgJiYgd3hVU0VfQ0FJUk8pCkBAIC0yMDgsNiArMTg3LDEyIEBAIHB1 YmxpYzoKICAgICB9CiAjZW5kaWYKIAorICAgIHZvaWQgcmV2ZXJzZShpbnQgZnJvbSwgaW50IGxl bmd0aCkKKyAgICB7CisgICAgICAgIGZvciAoaW50IGkgPSBmcm9tLCBlbmQgPSBmcm9tICsgbGVu Z3RoIC0gMTsgaSA8IGVuZDsgKytpLCAtLWVuZCkKKyAgICAgICAgICAgIHN3YXAoaSwgZW5kKTsK KyAgICB9CisKICAgICB2b2lkIGV4cGFuZExhc3RBZHZhbmNlKGZsb2F0IHdpZHRoKQogICAgIHsK ICAgICAgICAgQVNTRVJUKCFpc0VtcHR5KCkpOwpAQCAtMjE2LDYgKzIwMSwyNyBAQCBwdWJsaWM6 CiAgICAgfQogCiBwcml2YXRlOgorICAgIHZvaWQgc3dhcChpbnQgaW5kZXgxLCBpbnQgaW5kZXgy KQorICAgIHsKKyAgICAgICAgY29uc3QgU2ltcGxlRm9udERhdGEqIGYgPSBtX2ZvbnREYXRhW2lu ZGV4MV07CisgICAgICAgIG1fZm9udERhdGFbaW5kZXgxXSA9IG1fZm9udERhdGFbaW5kZXgyXTsK KyAgICAgICAgbV9mb250RGF0YVtpbmRleDJdID0gZjsKKworICAgICAgICBHbHlwaEJ1ZmZlckds eXBoIGcgPSBtX2dseXBoc1tpbmRleDFdOworICAgICAgICBtX2dseXBoc1tpbmRleDFdID0gbV9n bHlwaHNbaW5kZXgyXTsKKyAgICAgICAgbV9nbHlwaHNbaW5kZXgyXSA9IGc7CisKKyAgICAgICAg R2x5cGhCdWZmZXJBZHZhbmNlIHMgPSBtX2FkdmFuY2VzW2luZGV4MV07CisgICAgICAgIG1fYWR2 YW5jZXNbaW5kZXgxXSA9IG1fYWR2YW5jZXNbaW5kZXgyXTsKKyAgICAgICAgbV9hZHZhbmNlc1tp bmRleDJdID0gczsKKworI2lmIFBMQVRGT1JNKFdJTikKKyAgICAgICAgRmxvYXRTaXplIG9mZnNl dCA9IG1fb2Zmc2V0c1tpbmRleDFdOworICAgICAgICBtX29mZnNldHNbaW5kZXgxXSA9IG1fb2Zm c2V0c1tpbmRleDJdOworICAgICAgICBtX29mZnNldHNbaW5kZXgyXSA9IG9mZnNldDsKKyNlbmRp ZgorICAgIH0KKwogICAgIFZlY3Rvcjxjb25zdCBTaW1wbGVGb250RGF0YSosIDIwNDg+IG1fZm9u dERhdGE7CiAgICAgVmVjdG9yPEdseXBoQnVmZmVyR2x5cGgsIDIwNDg+IG1fZ2x5cGhzOwogICAg IFZlY3RvcjxHbHlwaEJ1ZmZlckFkdmFuY2UsIDIwNDg+IG1fYWR2YW5jZXM7CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNwcAko cmV2aXNpb24gMTMxNDEyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvV2lk dGhJdGVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNiwxNyArMTE2LDEzIEBAIHN0YXRp YyBpbmxpbmUgZmxvYXQgYXBwbHlGb250VHJhbnNmb3JtcygKICAgICBmb3IgKGludCBpID0gbGFz dEdseXBoQ291bnQ7IGkgPCBnbHlwaEJ1ZmZlclNpemU7ICsraSkKICAgICAgICAgd2lkdGhEaWZm ZXJlbmNlIC09IGFkdmFuY2VzW2ldLndpZHRoKCk7CiAKLSAgICBpZiAoIWx0cikgewotICAgICAg ICBmb3IgKGludCBpID0gMCwgZW5kID0gZ2x5cGhCdWZmZXItPnNpemUoKSAtIDE7IGkgPCBnbHlw aEJ1ZmZlci0+c2l6ZSgpIC8gMjsgKytpLCAtLWVuZCkKLSAgICAgICAgICAgIGdseXBoQnVmZmVy LT5zd2FwKGksIGVuZCk7Ci0gICAgfQorICAgIGlmICghbHRyKQorICAgICAgICBnbHlwaEJ1ZmZl ci0+cmV2ZXJzZShsYXN0R2x5cGhDb3VudCwgZ2x5cGhCdWZmZXJTaXplIC0gbGFzdEdseXBoQ291 bnQpOwogCiAgICAgZm9udERhdGEtPmFwcGx5VHJhbnNmb3JtcyhnbHlwaEJ1ZmZlci0+Z2x5cGhz KGxhc3RHbHlwaENvdW50KSwgYWR2YW5jZXMgKyBsYXN0R2x5cGhDb3VudCwgZ2x5cGhCdWZmZXJT aXplIC0gbGFzdEdseXBoQ291bnQsIHR5cGVzZXR0aW5nRmVhdHVyZXMpOwogCi0gICAgaWYgKCFs dHIpIHsKLSAgICAgICAgZm9yIChpbnQgaSA9IDAsIGVuZCA9IGdseXBoQnVmZmVyLT5zaXplKCkg LSAxOyBpIDwgZ2x5cGhCdWZmZXItPnNpemUoKSAvIDI7ICsraSwgLS1lbmQpCi0gICAgICAgICAg ICBnbHlwaEJ1ZmZlci0+c3dhcChpLCBlbmQpOwotICAgIH0KKyAgICBpZiAoIWx0cikKKyAgICAg ICAgZ2x5cGhCdWZmZXItPnJldmVyc2UobGFzdEdseXBoQ291bnQsIGdseXBoQnVmZmVyU2l6ZSAt IGxhc3RHbHlwaENvdW50KTsKIAogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY2hhcmFjdGVy c1RyZWF0ZWRBc1NwYWNlLnNpemUoKTsgKytpKSB7CiAgICAgICAgIGludCBzcGFjZU9mZnNldCA9 IGNoYXJhY3RlcnNUcmVhdGVkQXNTcGFjZVtpXS5maXJzdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q29tcGxleFRleHRNYWMuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q29tcGxleFRleHRN YWMuY3BwCShyZXZpc2lvbiAxMzE0MTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9tYWMvRm9udENvbXBsZXhUZXh0TWFjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTEsOCAr OTEsNyBAQCBmbG9hdCBGb250OjpnZXRHbHlwaHNBbmRBZHZhbmNlc0ZvckNvbXBsCiAKICAgICBp ZiAocnVuLnJ0bCgpKSB7CiAgICAgICAgIGluaXRpYWxBZHZhbmNlID0gY29udHJvbGxlci50b3Rh bFdpZHRoKCkgKyBjb250cm9sbGVyLmZpbmFsUm91bmRpbmdXaWR0aCgpIC0gYWZ0ZXJXaWR0aDsK LSAgICAgICAgZm9yIChpbnQgaSA9IDAsIGVuZCA9IGdseXBoQnVmZmVyLnNpemUoKSAtIDE7IGkg PCBlbmQ7ICsraSwgLS1lbmQpCi0gICAgICAgICAgICBnbHlwaEJ1ZmZlci5zd2FwKGksIGVuZCk7 CisgICAgICAgIGdseXBoQnVmZmVyLnJldmVyc2UoMCwgZ2x5cGhCdWZmZXIuc2l6ZSgpKTsKICAg ICB9IGVsc2UKICAgICAgICAgaW5pdGlhbEFkdmFuY2UgPSBiZWZvcmVXaWR0aDsKIAo=