99402 2012-10-15 18:12:40 -0700 Add 8 bit path to Document::isValidName() for the non ASCII case 2012-10-16 19:47:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 99420 1 msaboff msaboff shinyak webkit.review.bot oldest_to_newest 742678 0 msaboff 2012-10-15 18:12:40 -0700 If a name passed into isValidName() fails the isValidNameASCII() check and it is an 8 bit string, it is up-converted to a 16 bit string. 742700 1 168833 msaboff 2012-10-15 18:34:01 -0700 Created attachment 168833 Patch 742737 2 168833 darin 2012-10-15 20:00:15 -0700 Comment on attachment 168833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168833&action=review OK. Annoying to have to repeat the code like this; would be nicer if there was a simple way to use a template for this. > Source/WebCore/ChangeLog:3 > + Add 8 bit patch to Document::isValidName() for the non ASCII case patch -> path 742754 3 168833 webkit.review.bot 2012-10-15 20:29:20 -0700 Comment on attachment 168833 Patch Clearing flags on attachment: 168833 Committed r131403: <http://trac.webkit.org/changeset/131403> 742755 4 webkit.review.bot 2012-10-15 20:29:23 -0700 All reviewed patches have been landed. Closing bug. 742851 5 webkit.review.bot 2012-10-15 23:33:06 -0700 Re-opened since this is blocked by bug 99420 743253 6 ap 2012-10-16 10:26:39 -0700 Has the patch been rolled back in? 743667 7 msaboff 2012-10-16 16:10:17 -0700 (In reply to comment #5) > Re-opened since this is blocked by bug 99420 Change set r131403 appears to be rolled back in with change set r131425 <http://trac.webkit.org/changeset/131425>. Can we close this defect? 743811 8 shinyak 2012-10-16 19:47:41 -0700 (In reply to comment #7) > (In reply to comment #5) > > Re-opened since this is blocked by bug 99420 > > Change set r131403 appears to be rolled back in with change set r131425 <http://trac.webkit.org/changeset/131425>. > > Can we close this defect? Ohya. Yes. We can close this. Sorry for bothering you. 168833 2012-10-15 18:34:01 -0700 2012-10-15 20:29:20 -0700 Patch 99402.patch text/plain 2309 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTM5MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE1ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCA4IGJpdCBwYXRjaCB0 byBEb2N1bWVudDo6aXNWYWxpZE5hbWUoKSBmb3IgdGhlIG5vbiBBU0NJSSBjYXNlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTQwMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIDggYml0IHBhdGgg dG8gY29tcGxldGUgdGhlIHByb2Nlc3Npbmcgb2YgYW4gOCBiaXQgbmFtZXMgd2l0aG91dCB1cC1j b252ZXJ0aW5nLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OmlzVmFsaWROYW1lTm9uQVNDSUkpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6Omlz VmFsaWROYW1lKToKKwogMjAxMi0xMC0xNSAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgcGFnZSB2aXNpYmlsaXR5IGhpZGRlbiBoaXN0 b2dyYW1zCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDEzMTMxMSkKKysr IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5MjMs NiArMzkyMywxOSBAQCBTdHJpbmcgRG9jdW1lbnQ6Omxhc3RNb2RpZmllZCgpIGNvbnN0CiAgICAg cmV0dXJuIFN0cmluZzo6Zm9ybWF0KCIlMDJkLyUwMmQvJTA0ZCAlMDJkOiUwMmQ6JTAyZCIsIGRh dGUubW9udGgoKSArIDEsIGRhdGUubW9udGhEYXkoKSwgZGF0ZS5mdWxsWWVhcigpLCBkYXRlLmhv dXIoKSwgZGF0ZS5taW51dGUoKSwgZGF0ZS5zZWNvbmQoKSk7CiB9CiAKK3N0YXRpYyBib29sIGlz VmFsaWROYW1lTm9uQVNDSUkoY29uc3QgTENoYXIqIGNoYXJhY3RlcnMsIHVuc2lnbmVkIGxlbmd0 aCkKK3sKKyAgICBpZiAoIWlzVmFsaWROYW1lU3RhcnQoY2hhcmFjdGVyc1swXSkpCisgICAgICAg IHJldHVybiBmYWxzZTsKKworICAgIGZvciAodW5zaWduZWQgaSA9IDE7IGkgPCBsZW5ndGg7ICsr aSkgeworICAgICAgICBpZiAoIWlzVmFsaWROYW1lUGFydChjaGFyYWN0ZXJzW2ldKSkKKyAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwogc3Rh dGljIGJvb2wgaXNWYWxpZE5hbWVOb25BU0NJSShjb25zdCBVQ2hhciogY2hhcmFjdGVycywgdW5z aWduZWQgbGVuZ3RoKQogewogICAgIHVuc2lnbmVkIGkgPSAwOwpAQCAtMzk2MywxNiArMzk3Niwy MCBAQCBib29sIERvY3VtZW50Ojppc1ZhbGlkTmFtZShjb25zdCBTdHJpbmcmCiAgICAgaWYgKCFs ZW5ndGgpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0 ZXJzOwogICAgIGlmIChuYW1lLmlzOEJpdCgpKSB7Ci0gICAgICAgIGlmIChpc1ZhbGlkTmFtZUFT Q0lJKG5hbWUuY2hhcmFjdGVyczgoKSwgbGVuZ3RoKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVl OwotICAgICAgICBjaGFyYWN0ZXJzID0gbmFtZS5jaGFyYWN0ZXJzKCk7Ci0gICAgfSBlbHNlIHsK LSAgICAgICAgY2hhcmFjdGVycyA9IG5hbWUuY2hhcmFjdGVyczE2KCk7CisgICAgICAgIGNvbnN0 IExDaGFyKiBjaGFyYWN0ZXJzID0gbmFtZS5jaGFyYWN0ZXJzOCgpOworCiAgICAgICAgIGlmIChp c1ZhbGlkTmFtZUFTQ0lJKGNoYXJhY3RlcnMsIGxlbmd0aCkpCiAgICAgICAgICAgICByZXR1cm4g dHJ1ZTsKKworICAgICAgICByZXR1cm4gaXNWYWxpZE5hbWVOb25BU0NJSShjaGFyYWN0ZXJzLCBs ZW5ndGgpOwogICAgIH0KKworICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzID0gbmFtZS5jaGFy YWN0ZXJzMTYoKTsKKworICAgIGlmIChpc1ZhbGlkTmFtZUFTQ0lJKGNoYXJhY3RlcnMsIGxlbmd0 aCkpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAgcmV0dXJuIGlzVmFsaWROYW1lTm9uQVND SUkoY2hhcmFjdGVycywgbGVuZ3RoKTsKIH0KIAo=