99370 2012-10-15 14:38:33 -0700 Inspector: Don't trip assert when inspecting an empty db 2012-10-16 15:00:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan alecflett jsbell vsevik webkit.review.bot oldest_to_newest 742466 0 dgrogan 2012-10-15 14:38:33 -0700 Inspector: Don't fire assert when inspecting an empty db 742470 1 168787 dgrogan 2012-10-15 14:38:49 -0700 Created attachment 168787 Patch 742509 2 dgrogan 2012-10-15 15:21:34 -0700 Josh, could you take a look at this? Vsevik, could you review this? This fixes the assert I get when running with epg's idb directory in a debug build of chrome. After I fixed that I noticed that the inspector was printing errors: [22373:22373:1015/141603:ERROR:CONSOLE(828)] "Uncaught TypeError: Cannot read property 'databaseId' of undefined", source: chrome-devtools://devtools/devtools.html?docked=true&dockSide=bottom&toolbarColor=rgba(242,241,240,1)&textColor=rgba(76,76,76,1) (828) The js change stops those from spewing but I don't how this._database isn't initialized before the call to select. 742522 3 168787 jsbell 2012-10-15 15:36:40 -0700 Comment on attachment 168787 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168787&action=review > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:107 > + virtual void onUpgradeNeeded(int64_t, PassRefPtr<WebCore::IDBTransactionBackendInterface>, PassRefPtr<WebCore::IDBDatabaseBackendInterface>) OVERRIDE { } LGTM. > Source/WebCore/inspector/front-end/ResourcesPanel.js:1659 > + // FIXME: Why does this happen sometimes? But since IDB is async and this._database is populated in update() in response to _indexedDBLoaded() firing, perhaps the selection can be set earlier programmatically? (This is really a question for the Inspector folks.) 742923 4 vsevik 2012-10-16 01:05:31 -0700 Could you please use http://webkit.org/new-inspector-bug to report inspector bugs? We use this link to automatically select correct component and add folks to the cc. 742924 5 168787 vsevik 2012-10-16 01:05:45 -0700 Comment on attachment 168787 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168787&action=review >> Source/WebCore/inspector/front-end/ResourcesPanel.js:1659 >> + // FIXME: Why does this happen sometimes? > > But since IDB is async and this._database is populated in update() in response to _indexedDBLoaded() firing, perhaps the selection can be set earlier programmatically? > > (This is really a question for the Inspector folks.) This is just hiding the manifestation of the problem without fixing it. Please revert before landing. I filed https://bugs.webkit.org/show_bug.cgi?id=99434 for that issue, I can fix it myself. 743527 6 169018 dgrogan 2012-10-16 14:00:02 -0700 Created attachment 169018 Patch for landing 743530 7 dgrogan 2012-10-16 14:00:45 -0700 (In reply to comment #4) > Could you please use http://webkit.org/new-inspector-bug to report inspector bugs? We use this link to automatically select correct component and add folks to the cc. Sure, thanks for letting me know. 743603 8 169018 webkit.review.bot 2012-10-16 15:00:37 -0700 Comment on attachment 169018 Patch for landing Clearing flags on attachment: 169018 Committed r131511: <http://trac.webkit.org/changeset/131511> 743604 9 webkit.review.bot 2012-10-16 15:00:43 -0700 All reviewed patches have been landed. Closing bug. 168787 2012-10-15 14:38:49 -0700 2012-10-16 14:00:00 -0700 Patch bug-99370-20121015143739.patch text/plain 2455 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGRkOWQ2YWRjMWFiYWFk ZWJiOTUyZTk5MjZhNjM4ZmFmZDAxM2E3MS4uNGFhOWMxY2VmMzZiYzczOWNhOTZhYzNkNTExYjdh YTk4MmE2NmQ2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTE1ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbnNwZWN0b3I6IERv bid0IGZpcmUgYXNzZXJ0IHdoZW4gaW5zcGVjdGluZyBhbiBlbXB0eSBkYgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkzNzAKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JJ bmRleGVkREJBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLklE QkRhdGFiYXNlVHJlZUVsZW1lbnQucHJvdG90eXBlLm9uc2VsZWN0KToKKwogMjAxMi0xMC0xNSAg Um9iIEJ1aXMgIDxyYnVpc0ByaW0uY29tPgogCiAgICAgICAgIFJlbW92ZSBSZW5kZXJUZXh0Q29u dHJvbDo6aXNTZWxlY3RhYmxlRWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JJbmRleGVkREJBZ2VudC5jcHAKaW5kZXggMTk0ZDdhNTczY2YwZDQ3YjRm MDFlOTBhYTJkNGE0YjVhZjcxNDc3OC4uZDMzNGNhNWFmYzgyZDE0YzMwZTVjODE1MzQyMzYyMTU4 YjM0Y2VmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvcklu ZGV4ZWREQkFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y SW5kZXhlZERCQWdlbnQuY3BwCkBAIC0xMDQsNiArMTA0LDcgQEAgcHVibGljOgogICAgIHZpcnR1 YWwgdm9pZCBvblN1Y2Nlc3MoUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+LCBQYXNz UmVmUHRyPElEQktleT4sIGNvbnN0IElEQktleVBhdGgmKSBPVkVSUklERSB7IH0KICAgICB2aXJ0 dWFsIHZvaWQgb25TdWNjZXNzKFBhc3NSZWZQdHI8SURCS2V5PiwgUGFzc1JlZlB0cjxJREJLZXk+ LCBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4pIE9WRVJSSURFIHsgfQogICAgIHZp cnR1YWwgdm9pZCBvblN1Y2Nlc3NXaXRoUHJlZmV0Y2goY29uc3QgVmVjdG9yPFJlZlB0cjxJREJL ZXk+ID4mLCBjb25zdCBWZWN0b3I8UmVmUHRyPElEQktleT4gPiYsIGNvbnN0IFZlY3RvcjxSZWZQ dHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiA+JikgT1ZFUlJJREUgeyB9CisgICAgdmlydHVhbCB2 b2lkIG9uVXBncmFkZU5lZWRlZChpbnQ2NF90LCBQYXNzUmVmUHRyPFdlYkNvcmU6OklEQlRyYW5z YWN0aW9uQmFja2VuZEludGVyZmFjZT4sIFBhc3NSZWZQdHI8V2ViQ29yZTo6SURCRGF0YWJhc2VC YWNrZW5kSW50ZXJmYWNlPikgT1ZFUlJJREUgeyB9CiAgICAgdmlydHVhbCB2b2lkIG9uQmxvY2tl ZCgpIE9WRVJSSURFIHsgfQogfTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKaW5kZXggYzUwNWM5N2UwZmQ1OGEwOTMzMDBh NTk4ZjQxYzA3YWQzN2Q0Y2U3OC4uOTRlOWRmYTUzYzQ2NjFhNjI0M2Q4NWQ0YTYyMjVkZGQwZTMw MTZlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNv dXJjZXNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jl c291cmNlc1BhbmVsLmpzCkBAIC0xNjU2LDYgKzE2NTYsOSBAQCBXZWJJbnNwZWN0b3IuSURCRGF0 YWJhc2VUcmVlRWxlbWVudC5wcm90b3R5cGUgPSB7CiAKICAgICBvbnNlbGVjdDogZnVuY3Rpb24o KQogICAgIHsKKyAgICAgICAgLy8gRklYTUU6IFdoeSBkb2VzIHRoaXMgaGFwcGVuIHNvbWV0aW1l cz8KKyAgICAgICAgaWYgKCF0aGlzLl9kYXRhYmFzZSkKKyAgICAgICAgICAgIHJldHVybjsKICAg ICAgICAgV2ViSW5zcGVjdG9yLkJhc2VTdG9yYWdlVHJlZUVsZW1lbnQucHJvdG90eXBlLm9uc2Vs ZWN0LmNhbGwodGhpcyk7CiAgICAgICAgIGlmICghdGhpcy5fdmlldykKICAgICAgICAgICAgIHRo aXMuX3ZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLklEQkRhdGFiYXNlVmlldyh0aGlzLl9kYXRhYmFz ZSk7Cg== 169018 2012-10-16 14:00:02 -0700 2012-10-16 15:00:37 -0700 Patch for landing bug-99370-20121016135850.patch text/plain 1671 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2Y5ODQ5YWUzYWVkM2Zh MGQ3YjYxYjJjMzViODE0NTU3MjFkYjQ2Zi4uMDYwMDFhMTZlMTZhODRhMDQ4ZTUxZDFhNzE4NmY2 NDNiNjc0YWNlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTE1ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbnNwZWN0b3I6IERv bid0IGZpcmUgYXNzZXJ0IHdoZW4gaW5zcGVjdGluZyBhbiBlbXB0eSBkYgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkzNzAKKworICAgICAgICBSZXZp ZXdlZCBieSBWc2V2b2xvZCBWbGFzb3YuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9y SW5kZXhlZERCQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTItMTAtMTYgIFhp YW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21p dW1dIEFuZHJvaWQ6IE5lZWQgYSB3YXkgdG8gZ2V0IGFwcHJvcHJpYXRlIGZvbnQgZm9yIHNvbWUg c3BlY2lmaWMgY2hhcmFjdGVycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JJbmRleGVkREJBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9ySW5kZXhlZERCQWdlbnQuY3BwCmluZGV4IDExMDU3YzMzMGQ0MTlkZjQ5Y2Q0Mzkx NDNkNWIwNTllODQ5MGEwOWUuLmQwNDUxNzBmNTBiNzM2ZTIwMmVkMmIyNGQzNjM3NWRmMDllZGQ4 ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJbmRleGVk REJBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckluZGV4 ZWREQkFnZW50LmNwcApAQCAtMTA0LDYgKzEwNCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZv aWQgb25TdWNjZXNzKFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiwgUGFzc1JlZlB0 cjxJREJLZXk+LCBjb25zdCBJREJLZXlQYXRoJikgT1ZFUlJJREUgeyB9CiAgICAgdmlydHVhbCB2 b2lkIG9uU3VjY2VzcyhQYXNzUmVmUHRyPElEQktleT4sIFBhc3NSZWZQdHI8SURCS2V5PiwgUGFz c1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+KSBPVkVSUklERSB7IH0KICAgICB2aXJ0dWFs IHZvaWQgb25TdWNjZXNzV2l0aFByZWZldGNoKGNvbnN0IFZlY3RvcjxSZWZQdHI8SURCS2V5PiA+ JiwgY29uc3QgVmVjdG9yPFJlZlB0cjxJREJLZXk+ID4mLCBjb25zdCBWZWN0b3I8UmVmUHRyPFNl cmlhbGl6ZWRTY3JpcHRWYWx1ZT4gPiYpIE9WRVJSSURFIHsgfQorICAgIHZpcnR1YWwgdm9pZCBv blVwZ3JhZGVOZWVkZWQoaW50NjRfdCwgUGFzc1JlZlB0cjxXZWJDb3JlOjpJREJUcmFuc2FjdGlv bkJhY2tlbmRJbnRlcmZhY2U+LCBQYXNzUmVmUHRyPFdlYkNvcmU6OklEQkRhdGFiYXNlQmFja2Vu ZEludGVyZmFjZT4pIE9WRVJSSURFIHsgfQogICAgIHZpcnR1YWwgdm9pZCBvbkJsb2NrZWQoKSBP VkVSUklERSB7IH0KIH07CiAK