99367 2012-10-15 14:23:54 -0700 Remove unused WTF_NEW_HASHMAP_ITERATORS_INTERFACE #define 2012-10-16 12:06:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82784 1 enne enne benjamin dglazkov enne eric peter+ews webkit.review.bot oldest_to_newest 742446 0 enne 2012-10-15 14:23:54 -0700 Remove unused WTF_NEW_HASHMAP_ITERATORS_INTERFACE #define 742451 1 168784 enne 2012-10-15 14:25:58 -0700 Created attachment 168784 Patch 742455 2 enne 2012-10-15 14:28:22 -0700 Not quite ready to land yet, just uploading a patch to say that I intend to remove this define soon. Waiting on these three patches to land: https://codereview.chromium.org/11150024/ https://codereview.chromium.org/11144023/ https://codereview.chromium.org/11142025/ ...and then those changes to roll into WK. 742513 3 benjamin 2012-10-15 15:23:29 -0700 Sweet! 742593 4 168784 peter+ews 2012-10-15 16:54:41 -0700 Comment on attachment 168784 Patch Attachment 168784 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14286810 742669 5 168784 webkit.review.bot 2012-10-15 18:05:36 -0700 Comment on attachment 168784 Patch Attachment 168784 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14299874 743289 6 168971 enne 2012-10-16 10:47:05 -0700 Created attachment 168971 For ews 743393 7 168971 webkit.review.bot 2012-10-16 12:06:23 -0700 Comment on attachment 168971 For ews Clearing flags on attachment: 168971 Committed r131484: <http://trac.webkit.org/changeset/131484> 743395 8 webkit.review.bot 2012-10-16 12:06:28 -0700 All reviewed patches have been landed. Closing bug. 168784 2012-10-15 14:25:58 -0700 2012-10-16 10:47:03 -0700 Patch bug-99367-20121015142448.patch text/plain 1421 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGUxZTYwZWI4Y2EwZjFlZTIyMTYyMmVj MzZlY2I1ZTg5ZGMwZDQyZmQuLmY2MjljZTIwYThiMjBjYjIyOGMxNWJjZDE0OWJiZWNiMDUzZGRi MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAtMTUgIEFkcmllbm5lIFdhbGtlciAgPGVu bmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIFdURl9ORVdfSEFTSE1BUF9J VEVSQVRPUlNfSU5URVJGQUNFICNkZWZpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk5MzY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRG9lcyB3aGF0IGl0IHNheXMgb24gdGhlIHRpbi4KKworICAgICAg ICAqIHd0Zi9IYXNoVHJhaXRzLmg6CisKIDIwMTItMTAtMTUgIEdlb3JnZSBTdGFpa29zICA8c3Rh aWtvc0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBZGFwdCB0byBQbGF0Zm9y bSBBUEkgY2hhbmdlcyBpbiBzdHJpbmcgaGFuZGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL0hhc2hUcmFpdHMuaCBiL1NvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaAppbmRleCA4YjA3 Y2Y0NTkxZGIyZTI1N2QyODZiMDc5NTczOTc5OGRiYWEyNDZmLi44ODAzNDA4N2MxMjlhNzFlYzg0 NTcxYTEzOWU3MzFmMTg4ZjZlNjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVHJh aXRzLmgKKysrIGIvU291cmNlL1dURi93dGYvSGFzaFRyYWl0cy5oCkBAIC0xNjUsOSArMTY1LDYg QEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHJldHVybiBIYXNoVHJhaXRzRW1wdHlWYWx1ZUNo ZWNrZXI8VHJhaXRzLCBUcmFpdHM6Omhhc0lzRW1wdHlWYWx1ZUZ1bmN0aW9uPjo6aXNFbXB0eVZh bHVlKHZhbHVlKTsKICAgICB9CiAKLS8vIFdvcmthcm91bmQgZnJvbSBDaHJvbWl1bS4gU2VlIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Mjc4NC4KLSNkZWZpbmUgV1RG X05FV19IQVNITUFQX0lURVJBVE9SU19JTlRFUkZBQ0UgMQotCiAgICAgdGVtcGxhdGU8dHlwZW5h bWUgRmlyc3RUcmFpdHNBcmcsIHR5cGVuYW1lIFNlY29uZFRyYWl0c0FyZz4KICAgICBzdHJ1Y3Qg UGFpckhhc2hUcmFpdHMgOiBHZW5lcmljSGFzaFRyYWl0czxzdGQ6OnBhaXI8dHlwZW5hbWUgRmly c3RUcmFpdHNBcmc6OlRyYWl0VHlwZSwgdHlwZW5hbWUgU2Vjb25kVHJhaXRzQXJnOjpUcmFpdFR5 cGU+ID4gewogICAgICAgICB0eXBlZGVmIEZpcnN0VHJhaXRzQXJnIEZpcnN0VHJhaXRzOwo= 168971 2012-10-16 10:47:05 -0700 2012-10-16 12:06:23 -0700 For ews bug-99367-20121016104554.patch text/plain 1391 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGEwNzkzMzU4ZjdhNDc3NTFhZjg2NDky ZmY0ZGQxODFhNWI4NjAyMmEuLjU3MzFkODk2ZmZlOTM3ZTdjNjQ3MTJhZTU2YjhhMGFiN2MyNmZj NTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTAtMTUgIEFkcmllbm5lIFdhbGtlciAgPGVu bmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIFdURl9ORVdfSEFTSE1BUF9J VEVSQVRPUlNfSU5URVJGQUNFICNkZWZpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk5MzY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9i aW5zb24uCisKKyAgICAgICAgRG9lcyB3aGF0IGl0IHNheXMgb24gdGhlIHRpbi4KKworICAgICAg ICAqIHd0Zi9IYXNoVHJhaXRzLmg6CisKIDIwMTItMTAtMTUgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBXVEY6OmZhc3REZWxldGVBbGxWYWx1ZXMo KS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0hhc2hUcmFpdHMuaCBiL1NvdXJjZS9XVEYv d3RmL0hhc2hUcmFpdHMuaAppbmRleCA4YjA3Y2Y0NTkxZGIyZTI1N2QyODZiMDc5NTczOTc5OGRi YWEyNDZmLi44ODAzNDA4N2MxMjlhNzFlYzg0NTcxYTEzOWU3MzFmMTg4ZjZlNjc0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVHJhaXRzLmgKKysrIGIvU291cmNlL1dURi93dGYvSGFz aFRyYWl0cy5oCkBAIC0xNjUsOSArMTY1LDYgQEAgbmFtZXNwYWNlIFdURiB7CiAgICAgICAgIHJl dHVybiBIYXNoVHJhaXRzRW1wdHlWYWx1ZUNoZWNrZXI8VHJhaXRzLCBUcmFpdHM6Omhhc0lzRW1w dHlWYWx1ZUZ1bmN0aW9uPjo6aXNFbXB0eVZhbHVlKHZhbHVlKTsKICAgICB9CiAKLS8vIFdvcmth cm91bmQgZnJvbSBDaHJvbWl1bS4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04Mjc4NC4KLSNkZWZpbmUgV1RGX05FV19IQVNITUFQX0lURVJBVE9SU19JTlRFUkZB Q0UgMQotCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgRmlyc3RUcmFpdHNBcmcsIHR5cGVuYW1lIFNl Y29uZFRyYWl0c0FyZz4KICAgICBzdHJ1Y3QgUGFpckhhc2hUcmFpdHMgOiBHZW5lcmljSGFzaFRy YWl0czxzdGQ6OnBhaXI8dHlwZW5hbWUgRmlyc3RUcmFpdHNBcmc6OlRyYWl0VHlwZSwgdHlwZW5h bWUgU2Vjb25kVHJhaXRzQXJnOjpUcmFpdFR5cGU+ID4gewogICAgICAgICB0eXBlZGVmIEZpcnN0 VHJhaXRzQXJnIEZpcnN0VHJhaXRzOwo=