99339 2012-10-15 10:57:05 -0700 Make RenderTable columns() and columnPositions() return a const reference 2012-10-15 14:52:28 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix eric webkit.review.bot oldest_to_newest 742182 0 jchaffraix 2012-10-15 10:57:05 -0700 The 2 functions currently return a mutable Vector reference. Only FixedTableLayout and AutoTableLayout are expected to change the values, yet most of the code is allowed to. The easy fix is to add a setter as needed so that unintended modifications are caught by the compiler. Patch forthcoming. 742196 1 168743 jchaffraix 2012-10-15 11:09:48 -0700 Created attachment 168743 Proposed change. Added more constness and a getter. 742482 2 168743 webkit.review.bot 2012-10-15 14:52:25 -0700 Comment on attachment 168743 Proposed change. Added more constness and a getter. Clearing flags on attachment: 168743 Committed r131366: <http://trac.webkit.org/changeset/131366> 742483 3 webkit.review.bot 2012-10-15 14:52:28 -0700 All reviewed patches have been landed. Closing bug. 168743 2012-10-15 11:09:48 -0700 2012-10-15 14:52:24 -0700 Proposed change. Added more constness and a getter. bug-99339-20121015110839.patch text/plain 5845 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTRlODk0OGZhNWE1Y2Nl NWJjNzQ1ZjkzY2MyNzI2MzZmMzMxM2I5YS4uM2QxYzc3NWZhNWVlNzc3MTk4YzAxNDY5YzNiZmU2 M2ViOWVmZDM2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDEyLTEwLTE1ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIE1ha2UgUmVu ZGVyVGFibGUgY29sdW1ucygpIGFuZCBjb2x1bW5Qb3NpdGlvbnMoKSByZXR1cm4gYSBjb25zdCBy ZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk5MzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIDIgZ2V0dGVycyB3ZXJlIHJldHVybmluZyBhIG5vbi1jb25zdCByZWZlcmVuY2UuIFRoaXMg bWVhbnMgdGhhdCBjYWxsZXJzCisgICAgICAgIGNvdWxkIGhhdmUgbW9kaWZpZWQgdGhlIFZlY3Rv cidzIHdoZXJlIG9ubHkgRml4ZWRUYWJsZUxheW91dCBhbmQgQXV0b1RhYmxlTGF5b3V0CisgICAg ICAgIHdlcmUgZXhwZWN0ZWQgdG8gKGZvciBjb2x1bW5Qb3NpdGlvbnMoKSwgbm8gb25lIHNob3Vs ZCBtb2RpZnkgY29sdW1ucygpKS4KKworICAgICAgICBSZWZhY3RvcmluZyBjb3ZlcmVkIGJ5IGV4 aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBdXRvVGFibGVMYXlvdXQ6OmxheW91dCk6CisgICAgICAgICog cmVuZGVyaW5nL0ZpeGVkVGFibGVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rml4ZWRU YWJsZUxheW91dDo6bGF5b3V0KToKKyAgICAgICAgVXBkYXRlZCB0aG9zZSBmdW5jdGlvbnMgdG8g dXNlIHRoZSBuZXcgc2V0dGVyLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlLmg6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZTo6Y29sdW1ucyk6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJUYWJsZTo6Y29sdW1uUG9zaXRpb25zKToKKyAgICAgICAgTWFkZSB0aGUgMiBm dW5jdGlvbnMgcmV0dXJuIGEgY29uc3QgcmVmZXJlbmNlLiBUaGV5IGFyZSBhbHNvIGNvbnN0IG5v dyEKKworICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OnNldENvbHVtblBvc2l0aW9uKToK KyAgICAgICAgQWRkZWQgdGhpcyBzZXR0ZXIuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy VGFibGVTZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlU2VjdGlvbjo6 YWRkQ2VsbCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZVNlY3Rpb246OnNldENlbGxM b2dpY2FsV2lkdGhzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlU2VjdGlvbjo6ZGly dGllZENvbHVtbnMpOgorICAgICAgICBVcGRhdGVkIHRvIHVzZSBhIGNvbnN0IHJlZmVyZW5jZS4K KwogMjAxMi0xMC0xNSAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IENTUCBzb3VyY2UgZXhwcmVzc2lvbnMgc2hvdWxkIHN1cHBvcnQgcGF0aHMgYXQgZmlsZS1sZXZl bCBncmFudWxhcml0eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9BdXRv VGFibGVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91 dC5jcHAKaW5kZXggZGFlNWExNWVhZTljZDlhODNjYzAxMjliOWU5MTJlMDk3MmMzMjU2OS4uMDhl Y2ZmOTBlMGQyZTE5YzAxMDc1ODU2MjZmMTZhNjFlODgyNTkyYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxheW91dC5jcHAKQEAgLTc3MSwxMCArNzcxLDEwIEBAIHZv aWQgQXV0b1RhYmxlTGF5b3V0OjpsYXlvdXQoKQogCiAgICAgaW50IHBvcyA9IDA7CiAgICAgZm9y IChzaXplX3QgaSA9IDA7IGkgPCBuRWZmQ29sczsgKytpKSB7Ci0gICAgICAgIG1fdGFibGUtPmNv bHVtblBvc2l0aW9ucygpW2ldID0gcG9zOworICAgICAgICBtX3RhYmxlLT5zZXRDb2x1bW5Qb3Np dGlvbihpLCBwb3MpOwogICAgICAgICBwb3MgKz0gbV9sYXlvdXRTdHJ1Y3RbaV0uY29tcHV0ZWRM b2dpY2FsV2lkdGggKyBtX3RhYmxlLT5oQm9yZGVyU3BhY2luZygpOwogICAgIH0KLSAgICBtX3Rh YmxlLT5jb2x1bW5Qb3NpdGlvbnMoKVttX3RhYmxlLT5jb2x1bW5Qb3NpdGlvbnMoKS5zaXplKCkg LSAxXSA9IHBvczsKKyAgICBtX3RhYmxlLT5zZXRDb2x1bW5Qb3NpdGlvbihtX3RhYmxlLT5jb2x1 bW5Qb3NpdGlvbnMoKS5zaXplKCkgLSAxLCBwb3MpOwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvRml4ZWRUYWJsZUxheW91dC5jcHAKaW5kZXggMzNlYmNlYTU3OWQ4NThlY2Nk OGY0NWM1M2JjMTg3MzNlNDNiNjY4NS4uMmEwOGFkNmI1Y2QzOWM4Nzk1Y2FmN2QxMTE5Yzk0NDdj N2Q3OTM0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpeGVkVGFibGVM YXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaXhlZFRhYmxlTGF5b3V0 LmNwcApAQCAtMzA5LDEyICszMDksMTIgQEAgdm9pZCBGaXhlZFRhYmxlTGF5b3V0OjpsYXlvdXQo KQogICAgIAogICAgIGludCBwb3MgPSAwOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBu RWZmQ29sczsgaSsrKSB7Ci0gICAgICAgIG1fdGFibGUtPmNvbHVtblBvc2l0aW9ucygpW2ldID0g cG9zOworICAgICAgICBtX3RhYmxlLT5zZXRDb2x1bW5Qb3NpdGlvbihpLCBwb3MpOwogICAgICAg ICBwb3MgKz0gY2FsY1dpZHRoW2ldICsgaHNwYWNpbmc7CiAgICAgfQogICAgIGludCBjb2xQb3Np dGlvbnNTaXplID0gbV90YWJsZS0+Y29sdW1uUG9zaXRpb25zKCkuc2l6ZSgpOwogICAgIGlmIChj b2xQb3NpdGlvbnNTaXplID4gMCkKLSAgICAgICAgbV90YWJsZS0+Y29sdW1uUG9zaXRpb25zKClb Y29sUG9zaXRpb25zU2l6ZSAtIDFdID0gcG9zOworICAgICAgICBtX3RhYmxlLT5zZXRDb2x1bW5Q b3NpdGlvbihjb2xQb3NpdGlvbnNTaXplIC0gMSwgcG9zKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxl LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuaAppbmRleCBmNThmMWNi NjMwZGIyYTllM2I0M2M0MWUyMmI1Yjg1YzQzNzY5NTYzLi42YTc3NjQ2ODQ3ODg3Y2QxODI3ZDM5 ZTllZjIwMTZmZGMxNmU2MTgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGFibGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUu aApAQCAtMTQzLDggKzE0MywxMyBAQCBwdWJsaWM6CiAgICAgICAgIHJlY2FsY1NlY3Rpb25zKCk7 CiAgICAgfQogCi0gICAgVmVjdG9yPENvbHVtblN0cnVjdD4mIGNvbHVtbnMoKSB7IHJldHVybiBt X2NvbHVtbnM7IH0KLSAgICBWZWN0b3I8aW50PiYgY29sdW1uUG9zaXRpb25zKCkgeyByZXR1cm4g bV9jb2x1bW5Qb3M7IH0KKyAgICBjb25zdCBWZWN0b3I8Q29sdW1uU3RydWN0PiYgY29sdW1ucygp IGNvbnN0IHsgcmV0dXJuIG1fY29sdW1uczsgfQorICAgIGNvbnN0IFZlY3RvcjxpbnQ+JiBjb2x1 bW5Qb3NpdGlvbnMoKSBjb25zdCB7IHJldHVybiBtX2NvbHVtblBvczsgfQorICAgIHZvaWQgc2V0 Q29sdW1uUG9zaXRpb24odW5zaWduZWQgaW5kZXgsIGludCBwb3NpdGlvbikKKyAgICB7CisgICAg ICAgIG1fY29sdW1uUG9zW2luZGV4XSA9IHBvc2l0aW9uOworICAgIH0KKwogICAgIFJlbmRlclRh YmxlU2VjdGlvbiogaGVhZGVyKCkgY29uc3QgeyByZXR1cm4gbV9oZWFkOyB9CiAgICAgUmVuZGVy VGFibGVTZWN0aW9uKiBmb290ZXIoKSBjb25zdCB7IHJldHVybiBtX2Zvb3Q7IH0KICAgICBSZW5k ZXJUYWJsZVNlY3Rpb24qIGZpcnN0Qm9keSgpIGNvbnN0IHsgcmV0dXJuIG1fZmlyc3RCb2R5OyB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9u LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCmlu ZGV4IGE5ZTE2Njc1YWJiZGNiYWI3ZjVjZDgxNDZmYjQ1MGFmZTNjZjM5YWMuLjcyZTgyNmQ4OGM1 MjgxM2E0YzQ5OWQ1MGQ5MjI5NjM2MjE5OTkwZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCkBAIC0yMTIsNyArMjEyLDcgQEAgdm9pZCBS ZW5kZXJUYWJsZVNlY3Rpb246OmFkZENlbGwoUmVuZGVyVGFibGVDZWxsKiBjZWxsLCBSZW5kZXJU YWJsZVJvdyogcm93KQogCiAgICAgdW5zaWduZWQgclNwYW4gPSBjZWxsLT5yb3dTcGFuKCk7CiAg ICAgdW5zaWduZWQgY1NwYW4gPSBjZWxsLT5jb2xTcGFuKCk7Ci0gICAgVmVjdG9yPFJlbmRlclRh YmxlOjpDb2x1bW5TdHJ1Y3Q+JiBjb2x1bW5zID0gdGFibGUoKS0+Y29sdW1ucygpOworICAgIGNv bnN0IFZlY3RvcjxSZW5kZXJUYWJsZTo6Q29sdW1uU3RydWN0PiYgY29sdW1ucyA9IHRhYmxlKCkt PmNvbHVtbnMoKTsKICAgICB1bnNpZ25lZCBuQ29scyA9IGNvbHVtbnMuc2l6ZSgpOwogICAgIHVu c2lnbmVkIGluc2VydGlvblJvdyA9IHJvdy0+cm93SW5kZXgoKTsKIApAQCAtMjYzLDcgKzI2Myw3 IEBAIHZvaWQgUmVuZGVyVGFibGVTZWN0aW9uOjphZGRDZWxsKFJlbmRlclRhYmxlQ2VsbCogY2Vs bCwgUmVuZGVyVGFibGVSb3cqIHJvdykKIAogdm9pZCBSZW5kZXJUYWJsZVNlY3Rpb246OnNldENl bGxMb2dpY2FsV2lkdGhzKCkKIHsKLSAgICBWZWN0b3I8aW50PiYgY29sdW1uUG9zID0gdGFibGUo KS0+Y29sdW1uUG9zaXRpb25zKCk7CisgICAgY29uc3QgVmVjdG9yPGludD4mIGNvbHVtblBvcyA9 IHRhYmxlKCktPmNvbHVtblBvc2l0aW9ucygpOwogCiAgICAgTGF5b3V0U3RhdGVNYWludGFpbmVy IHN0YXRlUHVzaGVyKHZpZXcoKSk7CiAKQEAgLTEwMzQsNyArMTAzNCw3IEBAIENlbGxTcGFuIFJl bmRlclRhYmxlU2VjdGlvbjo6ZGlydGllZENvbHVtbnMoY29uc3QgTGF5b3V0UmVjdCYgZGFtYWdl UmVjdCkgY29uc3QKIAogICAgIENlbGxTcGFuIGNvdmVyZWRDb2x1bW5zID0gc3Bhbm5lZENvbHVt bnMoZGFtYWdlUmVjdCk7CiAKLSAgICBWZWN0b3I8aW50PiYgY29sdW1uUG9zID0gdGFibGUoKS0+ Y29sdW1uUG9zaXRpb25zKCk7CisgICAgY29uc3QgVmVjdG9yPGludD4mIGNvbHVtblBvcyA9IHRh YmxlKCktPmNvbHVtblBvc2l0aW9ucygpOwogICAgIC8vIFRvIHJlcGFpbnQgdGhlIGJvcmRlciB3 ZSBtaWdodCBuZWVkIHRvIHJlcGFpbnQgZmlyc3Qgb3IgbGFzdCBjb2x1bW4gZXZlbiBpZiB0aGV5 IGFyZSBub3Qgc3Bhbm5lZCB0aGVtc2VsdmVzLgogICAgIGlmIChjb3ZlcmVkQ29sdW1ucy5zdGFy dCgpID49IGNvbHVtblBvcy5zaXplKCkgLSAxICYmIGNvbHVtblBvc1tjb2x1bW5Qb3Muc2l6ZSgp IC0gMV0gKyB0YWJsZSgpLT5vdXRlckJvcmRlckVuZCgpID49IGRhbWFnZVJlY3QueCgpKQogICAg ICAgICAtLWNvdmVyZWRDb2x1bW5zLnN0YXJ0KCk7Cg==