99331 2012-10-15 08:34:11 -0700 We should avoid weakCompareAndSwap when parallel GC is disabled 2012-10-15 10:35:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 79668 98792 1 mhahnenberg mhahnenberg fpizlo gaborb galpeter loki ossy rgabor zherczeg oldest_to_newest 742061 0 mhahnenberg 2012-10-15 08:34:11 -0700 CopiedBlock::reportLiveBytes uses weakCompareAndSwap, which some platforms don't support. For platforms that don't have parallel GC enabled, we should just use a normal store. 742072 1 168718 mhahnenberg 2012-10-15 08:39:28 -0700 Created attachment 168718 Patch 742078 2 mhahnenberg 2012-10-15 08:41:18 -0700 *** Bug 99328 has been marked as a duplicate of this bug. *** 742099 3 168727 mhahnenberg 2012-10-15 09:08:51 -0700 Created attachment 168727 Patch 742158 4 168727 fpizlo 2012-10-15 10:31:48 -0700 Comment on attachment 168727 Patch You could have also said ENABLE(COMPARE_AND_SWAP) 742165 5 mhahnenberg 2012-10-15 10:35:19 -0700 Committed r131318: <http://trac.webkit.org/changeset/131318> 168718 2012-10-15 08:39:28 -0700 2012-10-15 09:08:49 -0700 Patch bug-99331-20121015083819.patch text/plain 2120 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMxMzAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTEwLTE1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgV2Ugc2hvdWxkIGF2b2lkIHdlYWtDb21wYXJlQW5kU3dhcCB3aGVuIHBhcmFsbGVs IEdDIGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTMzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENvcGllZEJsb2NrOjpyZXBvcnRMaXZlQnl0ZXMgYW5kIGRpZEV2YWN1YXRlQnl0ZXMg dXNlcyB3ZWFrQ29tcGFyZUFuZFN3YXAsIHdoaWNoIHNvbWUgcGxhdGZvcm1zIAorICAgICAgICBk b24ndCBzdXBwb3J0LiBGb3IgcGxhdGZvcm1zIHRoYXQgZG9uJ3QgaGF2ZSBwYXJhbGxlbCBHQyBl bmFibGVkLCB3ZSBzaG91bGQganVzdCB1c2UgYSBub3JtYWwgc3RvcmUuCisKKyAgICAgICAgKiBo ZWFwL0NvcGllZEJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvcGllZEJsb2NrOjpyZXBvcnRMaXZl Qnl0ZXMpOgorICAgICAgICAoSlNDOjpDb3BpZWRCbG9jazo6ZGlkRXZhY3VhdGVCeXRlcyk6CisK IDIwMTItMTAtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeCBtYWtlIGRpc3RjaGVjay4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZEJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQmxvY2suaAkocmV2aXNpb24gMTMxMzAzKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAt MTE5LDEyICsxMTksMTYgQEAgaW5saW5lIENvcGllZEJsb2NrOjpDb3BpZWRCbG9jayhSZWdpb24q IAogCiBpbmxpbmUgdm9pZCBDb3BpZWRCbG9jazo6cmVwb3J0TGl2ZUJ5dGVzKHVuc2lnbmVkIGJ5 dGVzKQogeworI2lmIEVOQUJMRShQQVJBTExFTF9HQykKICAgICB1bnNpZ25lZCBvbGRWYWx1ZSA9 IDA7CiAgICAgdW5zaWduZWQgbmV3VmFsdWUgPSAwOwogICAgIGRvIHsKICAgICAgICAgb2xkVmFs dWUgPSBtX2xpdmVCeXRlczsKICAgICAgICAgbmV3VmFsdWUgPSBvbGRWYWx1ZSArIGJ5dGVzOwog ICAgIH0gd2hpbGUgKCFXVEY6OndlYWtDb21wYXJlQW5kU3dhcCgmbV9saXZlQnl0ZXMsIG9sZFZh bHVlLCBuZXdWYWx1ZSkpOworI2Vsc2UKKyAgICBtX2xpdmVCeXRlcyArPSBieXRlczsKKyNlbmRp ZgogfQogCiBpbmxpbmUgdm9pZCBDb3BpZWRCbG9jazo6ZGlkU3Vydml2ZUdDKCkKQEAgLTEzNiw2 ICsxNDAsNyBAQCBpbmxpbmUgdm9pZCBDb3BpZWRCbG9jazo6ZGlkU3Vydml2ZUdDKCkKIGlubGlu ZSBib29sIENvcGllZEJsb2NrOjpkaWRFdmFjdWF0ZUJ5dGVzKHVuc2lnbmVkIGJ5dGVzKQogewog ICAgIEFTU0VSVChtX2xpdmVCeXRlcyA+PSBieXRlcyk7CisjaWYgRU5BQkxFKFBBUkFMTEVMX0dD KQogICAgIHVuc2lnbmVkIG9sZFZhbHVlID0gMDsKICAgICB1bnNpZ25lZCBuZXdWYWx1ZSA9IDA7 CiAgICAgZG8gewpAQCAtMTQ0LDYgKzE0OSw5IEBAIGlubGluZSBib29sIENvcGllZEJsb2NrOjpk aWRFdmFjdWF0ZUJ5dGUKICAgICB9IHdoaWxlICghV1RGOjp3ZWFrQ29tcGFyZUFuZFN3YXAoJm1f bGl2ZUJ5dGVzLCBvbGRWYWx1ZSwgbmV3VmFsdWUpKTsKICAgICBBU1NFUlQobV9saXZlQnl0ZXMg PCBvbGRWYWx1ZSk7CiAgICAgcmV0dXJuICFuZXdWYWx1ZTsKKyNlbHNlCisgICAgbV9saXZlQnl0 ZXMgLT0gYnl0ZXM7CisjZW5kaWYKIH0KIAogaW5saW5lIGJvb2wgQ29waWVkQmxvY2s6OmNhbkJl UmVjeWNsZWQoKQo= 168727 2012-10-15 09:08:51 -0700 2012-10-15 10:31:48 -0700 Patch bug-99331-20121015090742.patch text/plain 2147 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMxMzAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTEwLTE1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgV2Ugc2hvdWxkIGF2b2lkIHdlYWtDb21wYXJlQW5kU3dhcCB3aGVuIHBhcmFsbGVs IEdDIGlzIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTMzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIENvcGllZEJsb2NrOjpyZXBvcnRMaXZlQnl0ZXMgYW5kIGRpZEV2YWN1YXRlQnl0ZXMg dXNlcyB3ZWFrQ29tcGFyZUFuZFN3YXAsIHdoaWNoIHNvbWUgcGxhdGZvcm1zIAorICAgICAgICBk b24ndCBzdXBwb3J0LiBGb3IgcGxhdGZvcm1zIHRoYXQgZG9uJ3QgaGF2ZSBwYXJhbGxlbCBHQyBl bmFibGVkLCB3ZSBzaG91bGQganVzdCB1c2UgYSBub3JtYWwgc3RvcmUuCisKKyAgICAgICAgKiBo ZWFwL0NvcGllZEJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvcGllZEJsb2NrOjpyZXBvcnRMaXZl Qnl0ZXMpOgorICAgICAgICAoSlNDOjpDb3BpZWRCbG9jazo6ZGlkRXZhY3VhdGVCeXRlcyk6CisK IDIwMTItMTAtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQuIEZpeCBtYWtlIGRpc3RjaGVjay4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9oZWFwL0NvcGllZEJsb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQmxvY2suaAkocmV2aXNpb24gMTMxMzAzKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAt MTE5LDEyICsxMTksMTYgQEAgaW5saW5lIENvcGllZEJsb2NrOjpDb3BpZWRCbG9jayhSZWdpb24q IAogCiBpbmxpbmUgdm9pZCBDb3BpZWRCbG9jazo6cmVwb3J0TGl2ZUJ5dGVzKHVuc2lnbmVkIGJ5 dGVzKQogeworI2lmIEVOQUJMRShQQVJBTExFTF9HQykKICAgICB1bnNpZ25lZCBvbGRWYWx1ZSA9 IDA7CiAgICAgdW5zaWduZWQgbmV3VmFsdWUgPSAwOwogICAgIGRvIHsKICAgICAgICAgb2xkVmFs dWUgPSBtX2xpdmVCeXRlczsKICAgICAgICAgbmV3VmFsdWUgPSBvbGRWYWx1ZSArIGJ5dGVzOwog ICAgIH0gd2hpbGUgKCFXVEY6OndlYWtDb21wYXJlQW5kU3dhcCgmbV9saXZlQnl0ZXMsIG9sZFZh bHVlLCBuZXdWYWx1ZSkpOworI2Vsc2UKKyAgICBtX2xpdmVCeXRlcyArPSBieXRlczsKKyNlbmRp ZgogfQogCiBpbmxpbmUgdm9pZCBDb3BpZWRCbG9jazo6ZGlkU3Vydml2ZUdDKCkKQEAgLTEzNiw2 ICsxNDAsNyBAQCBpbmxpbmUgdm9pZCBDb3BpZWRCbG9jazo6ZGlkU3Vydml2ZUdDKCkKIGlubGlu ZSBib29sIENvcGllZEJsb2NrOjpkaWRFdmFjdWF0ZUJ5dGVzKHVuc2lnbmVkIGJ5dGVzKQogewog ICAgIEFTU0VSVChtX2xpdmVCeXRlcyA+PSBieXRlcyk7CisjaWYgRU5BQkxFKFBBUkFMTEVMX0dD KQogICAgIHVuc2lnbmVkIG9sZFZhbHVlID0gMDsKICAgICB1bnNpZ25lZCBuZXdWYWx1ZSA9IDA7 CiAgICAgZG8gewpAQCAtMTQ0LDYgKzE0OSwxMCBAQCBpbmxpbmUgYm9vbCBDb3BpZWRCbG9jazo6 ZGlkRXZhY3VhdGVCeXRlCiAgICAgfSB3aGlsZSAoIVdURjo6d2Vha0NvbXBhcmVBbmRTd2FwKCZt X2xpdmVCeXRlcywgb2xkVmFsdWUsIG5ld1ZhbHVlKSk7CiAgICAgQVNTRVJUKG1fbGl2ZUJ5dGVz IDwgb2xkVmFsdWUpOwogICAgIHJldHVybiAhbmV3VmFsdWU7CisjZWxzZQorICAgIG1fbGl2ZUJ5 dGVzIC09IGJ5dGVzOworICAgIHJldHVybiAhbV9saXZlQnl0ZXM7CisjZW5kaWYKIH0KIAogaW5s aW5lIGJvb2wgQ29waWVkQmxvY2s6OmNhbkJlUmVjeWNsZWQoKQo=