99322 2012-10-15 07:01:49 -0700 [EFL][WK2] Display tooltip in MiniBrowser 2012-10-25 19:38:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 742022 0 jinwoo7.song 2012-10-15 07:01:49 -0700 Display tooltip in MiniBrowser using elm_object_tooltip_text_set(). 742026 1 168707 jinwoo7.song 2012-10-15 07:07:33 -0700 Created attachment 168707 Patch 746910 2 168707 gyuyoung.kim 2012-10-19 23:18:33 -0700 Comment on attachment 168707 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168707&action=review > Tools/MiniBrowser/efl/main.c:529 > +on_tooltip_text_set(void *user_data, Evas_Object *obj, void *event_info) MiniBrowser's been used *webview* for Evas_Object variable name. > Tools/MiniBrowser/efl/main.c:532 > + char *message = (char *)event_info; tooltip message is sent as const char. So, I think you have to use const char. > Tools/MiniBrowser/efl/main.c:544 > +on_tooltip_text_unset(void *user_data, Evas_Object *obj, void *event_info) ditto. 746967 3 cdumez 2012-10-20 04:54:03 -0700 *** Bug 99846 has been marked as a duplicate of this bug. *** 746968 4 cdumez 2012-10-20 04:59:58 -0700 Can you please take a look at my patch from Bug 99846 ? It seems simpler and it was working fine based on my testing. Feel free to inspire from it. 746969 5 168707 cdumez 2012-10-20 05:02:54 -0700 Comment on attachment 168707 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168707&action=review > Tools/MiniBrowser/efl/main.c:58 > + Evas_Object *tooltip; Why do we need to keep a pointer to the tooltip? > Tools/MiniBrowser/efl/main.c:539 > + evas_object_move(window->tooltip, x, y); Why do we need to move it? > Tools/MiniBrowser/efl/main.c:664 > + app_data->tooltip = elm_label_add(app_data->window); Why do we need a label? 747010 6 jinwoo7.song 2012-10-20 16:15:24 -0700 (In reply to comment #4) > Can you please take a look at my patch from Bug 99846 ? > It seems simpler and it was working fine based on my testing. Feel free to inspire from it. Yes, it seems simpler way, but I see an error message from elementary. Is it a bug from elementary? How do you think about this? ERR<4848>:elementary elm_label.c:400 elm_label_add() could not add 0x27641c0 as sub object of 0x250deb0' 747047 7 cdumez 2012-10-21 00:00:21 -0700 (In reply to comment #6) > (In reply to comment #4) > > Can you please take a look at my patch from Bug 99846 ? > > It seems simpler and it was working fine based on my testing. Feel free to inspire from it. > > Yes, it seems simpler way, but I see an error message from elementary. Is it a bug from elementary? How do you think about this? > ERR<4848>:elementary elm_label.c:400 elm_label_add() could not add 0x27641c0 as sub object of 0x250deb0' Yes, I have seen this error on the terminal too. It looks like an elementary bug but the visual output looks correct. 750937 8 170677 jinwoo7.song 2012-10-25 09:50:25 -0700 Created attachment 170677 Patch 750943 9 jinwoo7.song 2012-10-25 09:54:01 -0700 I refined the patch referring to Chris's simpler approach. 750947 10 170677 cdumez 2012-10-25 09:55:39 -0700 Comment on attachment 170677 Patch LGTM. 751456 11 170677 webkit.review.bot 2012-10-25 19:38:05 -0700 Comment on attachment 170677 Patch Clearing flags on attachment: 170677 Committed r132560: <http://trac.webkit.org/changeset/132560> 751457 12 webkit.review.bot 2012-10-25 19:38:09 -0700 All reviewed patches have been landed. Closing bug. 168707 2012-10-15 07:07:33 -0700 2012-10-25 09:50:19 -0700 Patch bug-99322-20121015230623.patch text/plain 3456 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2VmOTdjMmRkZDIxNGEzOWMzNDU0ZGJhMjZmNDk1YTll ZmJmMWQ1NS4uNzUxYzgwN2JlYmFmMmQ0ZGIxYjg0YjA5M2U2ZjBkMzg5NTBlZjMwOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTEwLTE1ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdIERpc3BsYXkgdG9vbHRpcCBpbiBNaW5pQnJvd3NlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkzMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNwbGF5IHRvb2x0 aXAgaW4gTWluaUJyb3dzZXIgdXNpbmcgZWxtX29iamVjdF90b29sdGlwX3RleHRfc2V0KCkuCisK KyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAgICAoX0Jyb3dzZXJfV2lu ZG93KToKKyAgICAgICAgKG9uX3Rvb2x0aXBfdGV4dF9zZXQpOgorICAgICAgICAob25fdG9vbHRp cF90ZXh0X3Vuc2V0KToKKyAgICAgICAgKHdpbmRvd19jcmVhdGUpOgorCiAyMDEyLTEwLTExICBL aW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1d IFJlbW92ZXMgdW5uZWNlc3NhcnkgZGVwZW5kZW5jaWVzIGluIER1bXBSZW5kZXJUcmVlLmd5cApk aWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93 c2VyL2VmbC9tYWluLmMKaW5kZXggZWUwM2I4ODU3OTA1ZTE4ZWE4ODczNjkyOTVmNTcwY2RhMWU3 N2ZiNi4uMmM0YzY3YmY4N2E0NjdiNDQzNTkyMmNlN2EzMDA0MmQ3ODhlMGY1NSAxMDA2NDQKLS0t IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9l ZmwvbWFpbi5jCkBAIC01NSw2ICs1NSw3IEBAIHR5cGVkZWYgc3RydWN0IF9Ccm93c2VyX1dpbmRv dyB7CiAgICAgRXZhc19PYmplY3QgKnVybF9iYXI7CiAgICAgRXZhc19PYmplY3QgKmJhY2tfYnV0 dG9uOwogICAgIEV2YXNfT2JqZWN0ICpmb3J3YXJkX2J1dHRvbjsKKyAgICBFdmFzX09iamVjdCAq dG9vbHRpcDsKIH0gQnJvd3Nlcl9XaW5kb3c7CiAKIHN0YXRpYyBjb25zdCBFY29yZV9HZXRvcHQg b3B0aW9ucyA9IHsKQEAgLTUyNSw2ICs1MjYsMjkgQEAgb25famF2YXNjcmlwdF9wcm9tcHQoRXdr X1ZpZXdfU21hcnRfRGF0YSAqc21hcnREYXRhLCBjb25zdCBjaGFyICptZXNzYWdlLCBjb25zdAog fQogCiBzdGF0aWMgdm9pZAorb25fdG9vbHRpcF90ZXh0X3NldCh2b2lkICp1c2VyX2RhdGEsIEV2 YXNfT2JqZWN0ICpvYmosIHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgQnJvd3Nlcl9XaW5kb3cg KndpbmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsKKyAgICBjaGFyICptZXNzYWdl ID0gKGNoYXIgKilldmVudF9pbmZvOworCisgICAgRXZhc19Db29yZCB4LCB5OworICAgIEV2YXMg KmV2YXMgPSBldmFzX29iamVjdF9ldmFzX2dldCh3aW5kb3ctPndpbmRvdyk7CisgICAgZXZhc19w b2ludGVyX2NhbnZhc194eV9nZXQoZXZhcywgJngsICZ5KTsKKworICAgIGVsbV9vYmplY3RfdG9v bHRpcF90ZXh0X3NldCh3aW5kb3ctPnRvb2x0aXAsIG1lc3NhZ2UpOworICAgIGV2YXNfb2JqZWN0 X21vdmUod2luZG93LT50b29sdGlwLCB4LCB5KTsKKyAgICBlbG1fb2JqZWN0X3Rvb2x0aXBfc2hv dyh3aW5kb3ctPnRvb2x0aXApOworfQorCitzdGF0aWMgdm9pZAorb25fdG9vbHRpcF90ZXh0X3Vu c2V0KHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKm9iaiwgdm9pZCAqZXZlbnRfaW5mbykK K3sKKyAgICBCcm93c2VyX1dpbmRvdyAqd2luZG93ID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9k YXRhOworCisgICAgZWxtX29iamVjdF90b29sdGlwX2hpZGUod2luZG93LT50b29sdGlwKTsKK30K Kworc3RhdGljIHZvaWQKIG9uX2hvbWVfYnV0dG9uX2NsaWNrZWQodm9pZCAqdXNlcl9kYXRhLCBF dmFzX09iamVjdCAqaG9tZV9idXR0b24sIHZvaWQgKmV2ZW50X2luZm8pCiB7CiAgICAgQnJvd3Nl cl9XaW5kb3cgKmFwcF9kYXRhID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9kYXRhOwpAQCAtNjM2 LDYgKzY2MCw5IEBAIHN0YXRpYyBCcm93c2VyX1dpbmRvdyAqd2luZG93X2NyZWF0ZShjb25zdCBj aGFyICp1cmwpCiAgICAgZWxtX2JveF9wYWNrX2VuZChob3Jpem9udGFsX2xheW91dCwgaG9tZV9i dXR0b24pOwogICAgIGV2YXNfb2JqZWN0X3Nob3coaG9tZV9idXR0b24pOwogCisgICAgLyogQ3Jl YXRlIFRvb2x0aXAgKi8KKyAgICBhcHBfZGF0YS0+dG9vbHRpcCA9IGVsbV9sYWJlbF9hZGQoYXBw X2RhdGEtPndpbmRvdyk7CisKICAgICAvKiBDcmVhdGUgd2VidmlldyAqLwogICAgIEV3a19WaWV3 X1NtYXJ0X0NsYXNzICpld2tWaWV3Q2xhc3MgPSBtaW5pQnJvd3NlclZpZXdTbWFydENsYXNzKCk7 CiAgICAgZXdrVmlld0NsYXNzLT5ydW5famF2YXNjcmlwdF9hbGVydCA9IG9uX2phdmFzY3JpcHRf YWxlcnQ7CkBAIC02NjIsNiArNjg5LDggQEAgc3RhdGljIEJyb3dzZXJfV2luZG93ICp3aW5kb3df Y3JlYXRlKGNvbnN0IGNoYXIgKnVybCkKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19h ZGQoYXBwX2RhdGEtPndlYnZpZXcsICJ0aXRsZSxjaGFuZ2VkIiwgb25fdGl0bGVfY2hhbmdlZCwg YXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+ d2VidmlldywgInVybCxjaGFuZ2VkIiwgb25fdXJsX2NoYW5nZWQsIGFwcF9kYXRhKTsKICAgICBl dmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJiYWNrLGZv cndhcmQsbGlzdCxjaGFuZ2VkIiwgb25fYmFja19mb3J3YXJkX2xpc3RfY2hhbmdlZCwgYXBwX2Rh dGEpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2Vidmll dywgInRvb2x0aXAsdGV4dCxzZXQiLCBvbl90b29sdGlwX3RleHRfc2V0LCBhcHBfZGF0YSk7Cisg ICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAidG9v bHRpcCx0ZXh0LHVuc2V0Iiwgb25fdG9vbHRpcF90ZXh0X3Vuc2V0LCBhcHBfZGF0YSk7CiAKICAg ICBldmFzX29iamVjdF9ldmVudF9jYWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsIEVWQVNf Q0FMTEJBQ0tfS0VZX0RPV04sIG9uX2tleV9kb3duLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmpl Y3RfZXZlbnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCBFVkFTX0NBTExCQUNLX01P VVNFX0RPV04sIG9uX21vdXNlX2Rvd24sIGFwcF9kYXRhKTsK 170677 2012-10-25 09:50:25 -0700 2012-10-25 19:38:04 -0700 Patch bug-99322-20121026014857.patch text/plain 2611 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNDg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDAyMDkwN2JjY2YyYTM3NjEwNDdjMjY1MTY2Zjc4M2Iw MzI1NjRmMy4uNmU0OTgwOTBlY2MxMjBkOTg4OTYyYmQ1NTk2MTdiYjFiY2VhZTBjNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEwLTI1ICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXVtXSzJdIERpc3BsYXkgdG9vbHRpcCBpbiBNaW5pQnJvd3NlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkzMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNwbGF5IHRvb2x0 aXAgaW4gTWluaUJyb3dzZXIgdXNpbmcgZWxtX29iamVjdF90b29sdGlwX3RleHRfc2V0KCkuCisK KyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAgICAob25fdG9vbHRpcF90 ZXh0X3NldCk6CisgICAgICAgIChvbl90b29sdGlwX3RleHRfdW5zZXQpOgorICAgICAgICAod2lu ZG93X2NyZWF0ZSk6CisKIDIwMTItMTAtMjUgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5v cmc+CiAKICAgICAgICAgW1F0XSBBZGp1c3QgbGlicmFyeSBuYW1lIGluIHdlYmtpdGRpcnMucG0g YWZ0ZXIgcjEzMTMwMC4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMg Yi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IGU5ZGRiOGQ2ODI5MDg5MWM2Y2Q4 Zjc4YjExYzQyZmEzODg2OGQxM2UuLjZlZTFkNmVkNzRhODgyNWQ5MTA0NTBlOWE2Mjk3ZWRiZGJh MWQ0MDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9v bHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpAQCAtNTY3LDYgKzU2NywyNCBAQCBvbl9qYXZhc2Ny aXB0X3Byb21wdChFd2tfVmlld19TbWFydF9EYXRhICpzbWFydERhdGEsIGNvbnN0IGNoYXIgKm1l c3NhZ2UsIGNvbnN0CiB9CiAKIHN0YXRpYyB2b2lkCitvbl90b29sdGlwX3RleHRfc2V0KHZvaWQg KnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKm9iaiwgdm9pZCAqZXZlbnRfaW5mbykKK3sKKyAgICBC cm93c2VyX1dpbmRvdyAqd2luZG93ID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9kYXRhOworICAg IGNvbnN0IGNoYXIqIG1lc3NhZ2UgPSAoY29uc3QgY2hhciopZXZlbnRfaW5mbzsKKworICAgIGVs bV9vYmplY3RfdG9vbHRpcF90ZXh0X3NldCh3aW5kb3ctPndlYnZpZXcsIG1lc3NhZ2UpOworICAg IGVsbV9vYmplY3RfdG9vbHRpcF9zaG93KHdpbmRvdy0+d2Vidmlldyk7Cit9CisKK3N0YXRpYyB2 b2lkCitvbl90b29sdGlwX3RleHRfdW5zZXQodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAq b2JqLCB2b2lkICpldmVudF9pbmZvKQoreworICAgIEJyb3dzZXJfV2luZG93ICp3aW5kb3cgPSAo QnJvd3Nlcl9XaW5kb3cgKil1c2VyX2RhdGE7CisKKyAgICBlbG1fb2JqZWN0X3Rvb2x0aXBfdW5z ZXQod2luZG93LT53ZWJ2aWV3KTsKK30KKworc3RhdGljIHZvaWQKIG9uX2hvbWVfYnV0dG9uX2Ns aWNrZWQodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVjdCAqaG9tZV9idXR0b24sIHZvaWQgKmV2 ZW50X2luZm8pCiB7CiAgICAgQnJvd3Nlcl9XaW5kb3cgKmFwcF9kYXRhID0gKEJyb3dzZXJfV2lu ZG93ICopdXNlcl9kYXRhOwpAQCAtNzA2LDYgKzcyNCw4IEBAIHN0YXRpYyBCcm93c2VyX1dpbmRv dyAqd2luZG93X2NyZWF0ZShjb25zdCBjaGFyICp1cmwpCiAgICAgZXZhc19vYmplY3Rfc21hcnRf Y2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAidGl0bGUsY2hhbmdlZCIsIG9uX3RpdGxl X2NoYW5nZWQsIGFwcF9kYXRhKTsKICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQo YXBwX2RhdGEtPndlYnZpZXcsICJ1cmwsY2hhbmdlZCIsIG9uX3VybF9jaGFuZ2VkLCBhcHBfZGF0 YSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3 LCAiYmFjayxmb3J3YXJkLGxpc3QsY2hhbmdlZCIsIG9uX2JhY2tfZm9yd2FyZF9saXN0X2NoYW5n ZWQsIGFwcF9kYXRhKTsKKyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoYXBwX2Rh dGEtPndlYnZpZXcsICJ0b29sdGlwLHRleHQsc2V0Iiwgb25fdG9vbHRpcF90ZXh0X3NldCwgYXBw X2RhdGEpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2Vi dmlldywgInRvb2x0aXAsdGV4dCx1bnNldCIsIG9uX3Rvb2x0aXBfdGV4dF91bnNldCwgYXBwX2Rh dGEpOwogCiAgICAgZXZhc19vYmplY3RfZXZlbnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2 aWV3LCBFVkFTX0NBTExCQUNLX0tFWV9ET1dOLCBvbl9rZXlfZG93biwgYXBwX2RhdGEpOwogICAg IGV2YXNfb2JqZWN0X2V2ZW50X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgRVZBU19D QUxMQkFDS19NT1VTRV9ET1dOLCBvbl9tb3VzZV9kb3duLCBhcHBfZGF0YSk7Cg==