99316 2012-10-15 06:10:26 -0700 Web Inspector: display "disconnected" message when remote debugging terminates 2012-10-17 05:49:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik webkit.review.bot yurys oldest_to_newest 741991 0 pfeldman 2012-10-15 06:10:26 -0700 Otherwise, it is not clear that the front-end is no longer functional. 741992 1 168697 pfeldman 2012-10-15 06:12:02 -0700 Created attachment 168697 Patch 744176 2 168697 caseq 2012-10-17 05:16:56 -0700 Comment on attachment 168697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168697&action=review > Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:232 > + WebInspector.HelpScreen.call(this, WebInspector.UIString("Debug target terminated")); add a localizedString for that? > Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:235 > + p.textContent = WebInspector.UIString("This remote debugging client is no longer functional. Please re-attach to the new target."); ditto > Source/WebCore/inspector/front-end/inspector.js:338 > + WebInspector.socket.onclose = function() { { => next line 744178 3 169164 pfeldman 2012-10-17 05:23:08 -0700 Created attachment 169164 Patch 744191 4 169164 webkit.review.bot 2012-10-17 05:48:57 -0700 Comment on attachment 169164 Patch Clearing flags on attachment: 169164 Committed r131591: <http://trac.webkit.org/changeset/131591> 744192 5 webkit.review.bot 2012-10-17 05:49:01 -0700 All reviewed patches have been landed. Closing bug. 168697 2012-10-15 06:12:02 -0700 2012-10-17 05:23:02 -0700 Patch bug-99316-20121015171052.patch text/plain 2659 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGJhNzQyMmE4ZWUwNjk0 MDVkODI0MTIxOTE1ZTQwOGIzMWVkMmYzNC4uZDA3OWYwOWFlZGJmZDFjZDNkYmY3YTMwY2ExOWNi NjBjNGFlNDUzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTE1ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRpc3BsYXkgImRpc2Nvbm5lY3RlZCIgbWVzc2FnZSB3aGVuIHJlbW90ZSBkZWJ1Z2dpbmcg dGVybWluYXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTkzMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBPdGhlcndpc2UsIGl0IGlzIG5vdCBjbGVhciB0aGF0IHRoZSBmcm9udC1lbmQgaXMgbm8gbG9u Z2VyIGZ1bmN0aW9uYWwuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luc3BlY3Rv ckZyb250ZW5kSG9zdFN0dWIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVtb3RlRGVidWdn aW5nVGVybWluYXRlZFNjcmVlbik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkLldlYkluc3BlY3Rvci5zb2Nr ZXQub25jbG9zZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkKToKKwogMjAxMi0xMC0x NSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wcm92ZSBj b2RlIG9mIExvY2FsZU1hYy5tbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzCmluZGV4IGQ3 MDZiNTk3NzYzOTdiMWFiNzI3N2YzZmRmNzM2MDFiOWE2ZTI4ZDYuLmNlM2EzMGFhZTVmYjQ3MzZi NTZjNDk4MTVhOTMwZGZkNWNjYTE4Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMK QEAgLTIyMiwzICsyMjIsMTkgQEAgV2ViSW5zcGVjdG9yLkNsaXBib2FyZEFjY2Vzc0RlbmllZFNj cmVlbi5wcm90b3R5cGUgPSB7CiB9CiAKIH0KKworLyoqCisgKiBAY29uc3RydWN0b3IKKyAqIEBl eHRlbmRzIHtXZWJJbnNwZWN0b3IuSGVscFNjcmVlbn0KKyAqLworV2ViSW5zcGVjdG9yLlJlbW90 ZURlYnVnZ2luZ1Rlcm1pbmF0ZWRTY3JlZW4gPSBmdW5jdGlvbigpCit7CisgICAgV2ViSW5zcGVj dG9yLkhlbHBTY3JlZW4uY2FsbCh0aGlzLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkRlYnVnIHRh cmdldCB0ZXJtaW5hdGVkIikpOworICAgIHZhciBwID0gdGhpcy5jb250ZW50RWxlbWVudC5jcmVh dGVDaGlsZCgicCIpOworICAgIHAuYWRkU3R5bGVDbGFzcygiaGVscC1zZWN0aW9uIik7CisgICAg cC50ZXh0Q29udGVudCA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiVGhpcyByZW1vdGUgZGVidWdn aW5nIGNsaWVudCBpcyBubyBsb25nZXIgZnVuY3Rpb25hbC4gUGxlYXNlIHJlLWF0dGFjaCB0byB0 aGUgbmV3IHRhcmdldC4iKTsKK30KKworV2ViSW5zcGVjdG9yLlJlbW90ZURlYnVnZ2luZ1Rlcm1p bmF0ZWRTY3JlZW4ucHJvdG90eXBlID0geworICAgIF9fcHJvdG9fXzogV2ViSW5zcGVjdG9yLkhl bHBTY3JlZW4ucHJvdG90eXBlCit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvaW5zcGVjdG9yLmpzCmluZGV4IDJlZTYwYmUxODc3NGRjYjlhYjljMDQ4ODI0MmEzZGE2 OTM1NWVhNjQuLmQyYTRkM2EyZDk5ZmM1YjBiZGQzODc4YzAxZmM3MzQwZjVlN2RlZjAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0z MzUsNiArMzM1LDkgQEAgV2ViSW5zcGVjdG9yLmxvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICAgICAg ICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5zZW5kTWVzc2FnZVRvQmFja2VuZCA9IFdlYkluc3Bl Y3Rvci5zb2NrZXQuc2VuZC5iaW5kKFdlYkluc3BlY3Rvci5zb2NrZXQpOwogICAgICAgICAgICAg V2ViSW5zcGVjdG9yLmRvTG9hZGVkRG9uZSgpOwogICAgICAgICB9CisgICAgICAgIFdlYkluc3Bl Y3Rvci5zb2NrZXQub25jbG9zZSA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgKG5ldyBXZWJJ bnNwZWN0b3IuUmVtb3RlRGVidWdnaW5nVGVybWluYXRlZFNjcmVlbigpKS5zaG93TW9kYWwoKTsK KyAgICAgICAgfQogICAgICAgICByZXR1cm47CiAgICAgfQogCg== 169164 2012-10-17 05:23:08 -0700 2012-10-17 05:48:57 -0700 Patch bug-99316-20121017162154.patch text/plain 3505 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGJhNzQyMmE4ZWUwNjk0 MDVkODI0MTIxOTE1ZTQwOGIzMWVkMmYzNC4uZDA3OWYwOWFlZGJmZDFjZDNkYmY3YTMwY2ExOWNi NjBjNGFlNDUzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTE1ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRpc3BsYXkgImRpc2Nvbm5lY3RlZCIgbWVzc2FnZSB3aGVuIHJlbW90ZSBkZWJ1Z2dpbmcg dGVybWluYXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTkzMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBPdGhlcndpc2UsIGl0IGlzIG5vdCBjbGVhciB0aGF0IHRoZSBmcm9udC1lbmQgaXMgbm8gbG9u Z2VyIGZ1bmN0aW9uYWwuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luc3BlY3Rv ckZyb250ZW5kSG9zdFN0dWIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVtb3RlRGVidWdn aW5nVGVybWluYXRlZFNjcmVlbik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkLldlYkluc3BlY3Rvci5zb2Nr ZXQub25jbG9zZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkKToKKwogMjAxMi0xMC0x NSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW1wcm92ZSBj b2RlIG9mIExvY2FsZU1hYy5tbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5s cHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9s b2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDExNTZkMzU4NTkxMjQ0OTk1MTUyZWRkMzA3MTk3Mjdk NWYwNzdkNjUuLjI5MDg2MWIxNDVmMDVhZDkwZDEzYTQ3YjQ3OThiYzI1OGQ4MTMyMmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKQEAg LTc1MSwzICs3NTEsNSBAQCBsb2NhbGl6ZWRTdHJpbmdzWyIlcyAoJXMlcykiXSA9ICIlcyAoJXMl cykiOwogbG9jYWxpemVkU3RyaW5nc1siUnVubmluZyBhdWRpdCJdID0gIlJ1bm5pbmcgYXVkaXQi OwogbG9jYWxpemVkU3RyaW5nc1siQ29sbGVjdGluZyBjb250ZW504oCmIl0gPSAiQ29sbGVjdGlu ZyBjb250ZW504oCmIjsKIGxvY2FsaXplZFN0cmluZ3NbIldyaXRpbmcgZmlsZeKApiJdID0gIldy aXRpbmcgZmlsZeKApiI7Citsb2NhbGl6ZWRTdHJpbmdzWyJEZWJ1ZyB0YXJnZXQgdGVybWluYXRl ZCJdID0gIkRlYnVnIHRhcmdldCB0ZXJtaW5hdGVkIjsKK2xvY2FsaXplZFN0cmluZ3NbIlRoaXMg cmVtb3RlIGRlYnVnZ2luZyBjbGllbnQgaXMgbm8gbG9uZ2VyIGZ1bmN0aW9uYWwuIFBsZWFzZSBy ZS1hdHRhY2ggdG8gdGhlIG5ldyB0YXJnZXQuIl0gPSAiVGhpcyByZW1vdGUgZGVidWdnaW5nIGNs aWVudCBpcyBubyBsb25nZXIgZnVuY3Rpb25hbC4gUGxlYXNlIHJlLWF0dGFjaCB0byB0aGUgbmV3 IHRhcmdldC4iOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzCmluZGV4IGQ3MDZiNTk3NzYz OTdiMWFiNzI3N2YzZmRmNzM2MDFiOWE2ZTI4ZDYuLmNlM2EzMGFhZTVmYjQ3MzZiNTZjNDk4MTVh OTMwZGZkNWNjYTE4Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMKQEAgLTIyMiwz ICsyMjIsMTkgQEAgV2ViSW5zcGVjdG9yLkNsaXBib2FyZEFjY2Vzc0RlbmllZFNjcmVlbi5wcm90 b3R5cGUgPSB7CiB9CiAKIH0KKworLyoqCisgKiBAY29uc3RydWN0b3IKKyAqIEBleHRlbmRzIHtX ZWJJbnNwZWN0b3IuSGVscFNjcmVlbn0KKyAqLworV2ViSW5zcGVjdG9yLlJlbW90ZURlYnVnZ2lu Z1Rlcm1pbmF0ZWRTY3JlZW4gPSBmdW5jdGlvbigpCit7CisgICAgV2ViSW5zcGVjdG9yLkhlbHBT Y3JlZW4uY2FsbCh0aGlzLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkRlYnVnIHRhcmdldCB0ZXJt aW5hdGVkIikpOworICAgIHZhciBwID0gdGhpcy5jb250ZW50RWxlbWVudC5jcmVhdGVDaGlsZCgi cCIpOworICAgIHAuYWRkU3R5bGVDbGFzcygiaGVscC1zZWN0aW9uIik7CisgICAgcC50ZXh0Q29u dGVudCA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiVGhpcyByZW1vdGUgZGVidWdnaW5nIGNsaWVu dCBpcyBubyBsb25nZXIgZnVuY3Rpb25hbC4gUGxlYXNlIHJlLWF0dGFjaCB0byB0aGUgbmV3IHRh cmdldC4iKTsKK30KKworV2ViSW5zcGVjdG9yLlJlbW90ZURlYnVnZ2luZ1Rlcm1pbmF0ZWRTY3Jl ZW4ucHJvdG90eXBlID0geworICAgIF9fcHJvdG9fXzogV2ViSW5zcGVjdG9yLkhlbHBTY3JlZW4u cHJvdG90eXBlCit9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL2luc3BlY3Rvci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5z cGVjdG9yLmpzCmluZGV4IDJlZTYwYmUxODc3NGRjYjlhYjljMDQ4ODI0MmEzZGE2OTM1NWVhNjQu LmQyYTRkM2EyZDk5ZmM1YjBiZGQzODc4YzAxZmM3MzQwZjVlN2RlZjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzCkBAIC0zMzUsNiArMzM1 LDkgQEAgV2ViSW5zcGVjdG9yLmxvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICAgICAgICAgIEluc3Bl Y3RvckZyb250ZW5kSG9zdC5zZW5kTWVzc2FnZVRvQmFja2VuZCA9IFdlYkluc3BlY3Rvci5zb2Nr ZXQuc2VuZC5iaW5kKFdlYkluc3BlY3Rvci5zb2NrZXQpOwogICAgICAgICAgICAgV2ViSW5zcGVj dG9yLmRvTG9hZGVkRG9uZSgpOwogICAgICAgICB9CisgICAgICAgIFdlYkluc3BlY3Rvci5zb2Nr ZXQub25jbG9zZSA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgKG5ldyBXZWJJbnNwZWN0b3Iu UmVtb3RlRGVidWdnaW5nVGVybWluYXRlZFNjcmVlbigpKS5zaG93TW9kYWwoKTsKKyAgICAgICAg fQogICAgICAgICByZXR1cm47CiAgICAgfQogCg==