99311 2012-10-15 05:25:34 -0700 REGRESSION(130613): Reintroduces crashes when using soup's timeout functionality 2012-10-15 07:47:21 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 d-r d-r alex cgarcia mrobinson oldest_to_newest 741962 0 d-r 2012-10-15 05:25:34 -0700 r130613 had + cleanupSoupRequestOperation(handle.get()); in requestTimeoutCallback(gpointer data). This had been intentionally removed in the crash fix bug 98055. While working on XHR2 timeout support, I am hitting this crash again, let's remove it. 741968 1 168688 d-r 2012-10-15 05:33:28 -0700 Created attachment 168688 Patch 742038 2 168688 d-r 2012-10-15 07:47:13 -0700 Comment on attachment 168688 Patch Clearing flags on attachment: 168688 Committed r131301: <http://trac.webkit.org/changeset/131301> 742039 3 d-r 2012-10-15 07:47:21 -0700 All reviewed patches have been landed. Closing bug. 168688 2012-10-15 05:33:28 -0700 2012-10-15 07:47:13 -0700 Patch bug-99311-20121015153527.patch text/plain 1972 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEyN2MzNWI4NTgxYTlh MWFkZmFhOGRmOTU1YTE4ZDc1YWRkY2QzYS4uMGRhNzgyMjQzMjNmMWJlOWMwM2E0ZGI0MmZlZDAz NmFhMjIwY2NjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTE1ICBEb21p bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg UkVHUkVTU0lPTigxMzA2MTMpOiBSZWludHJvZHVjZXMgY3Jhc2hlcyB3aGVuIHVzaW5nIHNvdXAn cyB0aW1lb3V0IGZ1bmN0aW9uYWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk5MzExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZpbmcgdGhlIGNsZWFudXBTb3VwUmVxdWVzdE9wZXJhdGlvbiBj YWxsLCBzaW5jZSB0aGUgY2FuY2VsKCkgY2FsbCB3aWxsIGV2ZW50dWFsbHkgdHJpZ2dlciB0aGUK KyAgICAgICAgY2xlYW51cCBhbHJlYWR5IHNldHRpbmcgdGhlIHJpZ2h0IGZsYWcuIENsZWFuaW5n IHRoZSBoYW5kbGUgYWxyZWFkeSBoZXJlIHdpbGwgcmVzdWx0IGluIGNyYXNoZXMgd2hlbgorICAg ICAgICB1c2luZyB0aGUgc291cCB0aW1lb3V0IGZ1bmN0aW9uYWxpdHkuCisgICAgICAgIFRoZSBl eHBsaWNpdCBjbGVhbnVwIGNhbGwgcmVpbnRyb2R1Y2VkIGluIHIxMzA2MTMsIGFmdGVyIGl0IGhh ZCBiZWVuIHByZXZpb3VzbHkgcmVtb3ZlZCBpbiByMTMwMzQ4LgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cywgdGVzdHMgdGhhdCBjYXRjaCB0aGlzIHdpbGwgYmUgcGFydCBvZiBidWcgNzQ4MDIgZm9y IFhIUiB0aW1lb3V0IHN1cHBvcnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlcXVlc3RUaW1lb3V0 Q2FsbGJhY2spOgorCiAyMDEyLTEwLTEyICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOTUkgcmVtb3ZlIGhhbmQgbWFkZSBv YmplY3QgYnVpbGRlcnMgd2l0aCBhdXRvbWF0aWMgYnVpbGRlci4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKaW5kZXggNmRhMWZkMWQzNjVhOTE0MGNhMTM0MmEzODBjZWMwZDg2MjdhOGEzNS4uYjFlOTJm OGM0MmJiZWE1NzU2YTUzMGRkYjRkOGZhZjAwOTg2NzM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKQEAgLTEwMDIsNyArMTAwMiw2IEBAIHN0YXRpYyBnYm9vbGVhbiByZXF1ZXN0VGltZW91dENh bGxiYWNrKGdwb2ludGVyIGRhdGEpCiB7CiAgICAgUmVmUHRyPFJlc291cmNlSGFuZGxlPiBoYW5k bGUgPSBzdGF0aWNfY2FzdDxSZXNvdXJjZUhhbmRsZSo+KGRhdGEpOwogICAgIGhhbmRsZS0+Y2xp ZW50KCktPmRpZEZhaWwoaGFuZGxlLmdldCgpLCBSZXNvdXJjZUVycm9yOjp0aW1lb3V0RXJyb3Io aGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5tX2ZpcnN0UmVxdWVzdC51cmwoKS5zdHJpbmcoKSkpOwot ICAgIGNsZWFudXBTb3VwUmVxdWVzdE9wZXJhdGlvbihoYW5kbGUuZ2V0KCkpOwogICAgIGhhbmRs ZS0+Y2FuY2VsKCk7CiAKICAgICByZXR1cm4gRkFMU0U7Cg==