99299 2012-10-15 01:21:05 -0700 [EFL] Provide logging for OnlineState detection code 2012-10-15 12:21:14 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 741836 0 cdumez 2012-10-15 01:21:05 -0700 It would be useful to provide logging for OnlineState detection code in NetworkStateNotifier.cpp to help with debugging. 741838 1 168644 cdumez 2012-10-15 01:24:13 -0700 Created attachment 168644 Patch 742265 2 168644 webkit.review.bot 2012-10-15 12:21:09 -0700 Comment on attachment 168644 Patch Clearing flags on attachment: 168644 Committed r131333: <http://trac.webkit.org/changeset/131333> 742266 3 webkit.review.bot 2012-10-15 12:21:14 -0700 All reviewed patches have been landed. Closing bug. 168644 2012-10-15 01:24:13 -0700 2012-10-15 12:21:09 -0700 Patch 99299_networkstate_logging.patch text/plain 2614 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MTI3YzM1Li5jZmJlNWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMTUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBQcm92aWRlIGxvZ2dpbmcgZm9yIE9ubGluZVN0YXRlIGRl dGVjdGlvbiBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05OTI5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBsb2dnaW5nIHRvIE5ldHdvcmtTdGF0ZU5vdGlmaWVyRWZsLmNwcCB0byBmYWNpbGl0 YXRlCisgICAgICAgIGRlYnVnZ2luZyBvZiB0aGlzIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2VmbC9OZXR3b3JrU3RhdGVOb3RpZmllckVmbC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpOZXR3b3JrU3RhdGVOb3RpZmllcjo6dXBkYXRlU3RhdGUpOgorCiAyMDEyLTEwLTEyICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBOTUkgcmVtb3ZlIGhhbmQgbWFkZSBvYmplY3QgYnVpbGRlcnMgd2l0aCBhdXRvbWF0aWMg YnVpbGRlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvZWZs L05ldHdvcmtTdGF0ZU5vdGlmaWVyRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvZWZsL05ldHdvcmtTdGF0ZU5vdGlmaWVyRWZsLmNwcAppbmRleCA0YjFhNDdmLi5hMDg0 ODkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2VmbC9OZXR3 b3JrU3RhdGVOb3RpZmllckVmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9lZmwvTmV0d29ya1N0YXRlTm90aWZpZXJFZmwuY3BwCkBAIC01MSw2ICs1MSw4IEBAIHZv aWQgTmV0d29ya1N0YXRlTm90aWZpZXI6OnVwZGF0ZVN0YXRlKCkKICAgICAvLyBBc3N1bWUgdGhh dCB3ZSdyZSBvZmZsaW5lIHVudGlsIHByb3ZlbiBvdGhlcndpc2UuCiAgICAgbV9pc09uTGluZSA9 IGZhbHNlOwogCisgICAgTE9HKE5ldHdvcmssICJDaGVja2luZyBvbmxpbmUgc3RhdGUuLi4iKTsK KwogICAgIEVpbmFfTGlzdCogbmV0d29ya0ludGVyZmFjZXMgPSBlZXplX25ldF9saXN0KCk7CiAK ICAgICBFaW5hX0xpc3QqIGxpc3Q7CkBAIC02NSwxNyArNjcsMjYgQEAgdm9pZCBOZXR3b3JrU3Rh dGVOb3RpZmllcjo6dXBkYXRlU3RhdGUoKQogCiAgICAgICAgIC8vIFNraXAgaW50ZXJmYWNlcyB0 aGF0IGFyZSBub3QgdXAuCiAgICAgICAgIGNvbnN0IGNoYXIqIHN0YXRlID0gZWV6ZV9uZXRfYXR0 cmlidXRlX2dldChuZXR3b3JrSW50ZXJmYWNlLCB1ZGV2T3BlcnN0YXRlQXR0cmlidXRlKTsKKyAg ICAgICAgTE9HKE5ldHdvcmssICJGb3VuZCBuZXR3b3JrIGludGVyZmFjZSBcIiVzXCIgd2l0aCBz dGF0ZTogXCIlc1wiIiwgc3lzcGF0aCwgc3RhdGUpOwogICAgICAgICBpZiAoIXN0YXRlIHx8IHN0 cmNtcChzdGF0ZSwgdWRldk9wZXJzdGF0ZVVwKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAg ICAgICAgIC8vIENoZWNrIGlmIHRoZSBpbnRlcmZhY2UgaGFzIGFuIElQIGFkZHJlc3MuCiAgICAg ICAgIGVlemVfbmV0X3NjYW4obmV0d29ya0ludGVyZmFjZSk7CiAgICAgICAgIGlmIChlZXplX25l dF9hZGRyX2dldChuZXR3b3JrSW50ZXJmYWNlLCBFRVpFX05FVF9BRERSX1RZUEVfSVApIHx8IGVl emVfbmV0X2FkZHJfZ2V0KG5ldHdvcmtJbnRlcmZhY2UsIEVFWkVfTkVUX0FERFJfVFlQRV9JUDYp KSB7CisjaWYgIUxPR19ESVNBQkxFRAorICAgICAgICAgICAgY29uc3QgY2hhciogaXBBZGRyZXNz ID0gZWV6ZV9uZXRfYWRkcl9nZXQobmV0d29ya0ludGVyZmFjZSwgRUVaRV9ORVRfQUREUl9UWVBF X0lQKTsKKyAgICAgICAgICAgIGlmICghaXBBZGRyZXNzKQorICAgICAgICAgICAgICAgIGlwQWRk cmVzcyA9IGVlemVfbmV0X2FkZHJfZ2V0KG5ldHdvcmtJbnRlcmZhY2UsIEVFWkVfTkVUX0FERFJf VFlQRV9JUDYpOworICAgICAgICAgICAgTE9HKE5ldHdvcmssICJOZXR3b3JrIGludGVyZmFjZSBh dCAlcyBoYXMgdGhlIGZvbGxvd2luZyBJUCBhZGRyZXNzOiAlcyIsIHN5c3BhdGgsIGlwQWRkcmVz cyk7CisjZW5kaWYKICAgICAgICAgICAgIG1faXNPbkxpbmUgPSB0cnVlOwogICAgICAgICAgICAg YnJlYWs7CiAgICAgICAgIH0KICAgICB9CiAKKyAgICBMT0coTmV0d29yaywgIkRldGVjdGVkIG9u bGluZSBzdGF0ZSBpcyBcIiVzXCIiLCBtX2lzT25MaW5lID8gIm9ubGluZSIgOiAib2ZmbGluZSIp OworCiAgICAgRUlOQV9MSVNUX0ZSRUUobmV0d29ya0ludGVyZmFjZXMsIGRhdGEpCiAgICAgICAg IGVlemVfbmV0X2ZyZWUoc3RhdGljX2Nhc3Q8RWV6ZV9OZXQqPihkYXRhKSk7CiB9Cg==