99297 2012-10-15 01:09:03 -0700 [EFL] should make plugin process debugging easier (PLUGIN_PROCESS_COMMAND_PREFIX) 2012-10-23 05:33:20 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99583 1 jussi.kukkonen jussi.kukkonen andersca ap cdumez kenneth rakuco sam webkit.review.bot oldest_to_newest 741832 0 jussi.kukkonen 2012-10-15 01:09:03 -0700 I'd like to add support for PLUGIN_PROCESS_CMD_PREFIX environment variable to make debugging easier (on a debug build). Then you could do PLUGIN_PROCESS_CMD_PREFIX="xterm gdb --args" MiniBrowser url/to/something/with/plugins and end up debugging the right process without tracking forks and all that. This would be similar to WEB_PROCESS_CMD_PREFIX implemented by a couple of ports (which we should maybe move to non-port specific files as well, but that's another bug). 741870 1 168653 jussi.kukkonen 2012-10-15 02:12:50 -0700 Created attachment 168653 Patch 742144 2 ap 2012-10-15 10:20:08 -0700 A nitpick: please don't abbreviate "command". Looks reasonable to me, Anders or Sam should review. 742545 3 168653 sam 2012-10-15 16:00:22 -0700 Comment on attachment 168653 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168653&action=review > Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:82 > + const char* cmdPrefix = getenv("PLUGIN_PROCESS_CMD_PREFIX"); > + if (cmdPrefix && *cmdPrefix) > + launchOptions.processCmdPrefix = String::fromUTF8(cmdPrefix); > +#endif Won't this break non-EFL builds since they don't have the launchOptions.processCmdPrefix member. I would prefer if you clean this up by adding platformInitializeLaunchOptions() that is implemented separately. 742979 4 jussi.kukkonen 2012-10-16 02:07:40 -0700 (In reply to comment #2) > A nitpick: please don't abbreviate "command". I was trying to be in line with WEB_PROCESS_CMD_PREFIX, but the code variable name I can of course change. (In reply to comment #3) > Won't this break non-EFL builds since they don't have the launchOptions.processCmdPrefix member. I would prefer if you clean this up by adding platformInitializeLaunchOptions() that is implemented separately. Oops, you are correct, managed to misread ProcessLauncher.h. I'll add a platformInitializeLaunchOptions first, thanks. 743168 5 ap 2012-10-16 08:35:41 -0700 > I was trying to be in line with WEB_PROCESS_CMD_PREFIX, but the code variable name I can of course change. That one also looks like it should be renamed, of course. > Oops, you are correct, managed to misread ProcessLauncher.h. I'll add a platformInitializeLaunchOptions first, thanks. Why are EWS bots all green then? 744141 6 jussi.kukkonen 2012-10-17 04:35:31 -0700 (In reply to comment #5) > > Oops, you are correct, managed to misread ProcessLauncher.h. I'll add a platformInitializeLaunchOptions first, thanks. > > Why are EWS bots all green then? I assumed the EWS bots build Release, so the ifdef would be skipped. Admitedly I don't actually know if this is true... 744201 7 169170 jussi.kukkonen 2012-10-17 06:05:42 -0700 Created attachment 169170 Patch 744202 8 jussi.kukkonen 2012-10-17 06:10:28 -0700 (In reply to comment #3) > I would prefer if you clean this up by adding platformInitializeLaunchOptions() that is implemented separately. I hope this patch on top of the on in bug 99583 is what you were thinking of. This patch still includes the "#if PLATFORM(EFL)" inside PluginProcessProxyUnix.cpp -- I have a feeling GTK would also like this feature but that should probably happen in another bug because that would mean changing the ProcessLauncher header and presumably WebProcessProxyGtk as well. 744267 9 ap 2012-10-17 08:41:46 -0700 > I assumed the EWS bots build Release, so the ifdef would be skipped. Indeed. 748423 10 170097 jussi.kukkonen 2012-10-23 02:45:04 -0700 Created attachment 170097 Patch 748532 11 170097 webkit.review.bot 2012-10-23 05:33:14 -0700 Comment on attachment 170097 Patch Clearing flags on attachment: 170097 Committed r132209: <http://trac.webkit.org/changeset/132209> 748533 12 webkit.review.bot 2012-10-23 05:33:20 -0700 All reviewed patches have been landed. Closing bug. 168653 2012-10-15 02:12:50 -0700 2012-10-17 06:05:34 -0700 Patch bug-99297-20121015121141.patch text/plain 1556 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTY0YzYwMjczZTI2OGEx YmE4YmU3NDkyYzQ2OTY4NjQ4NzIxOWVkYi4uMDA2MjFlY2ZmN2RhNTBjNjkyNjdlY2MzNzZiOWZm ZDdhMTBiZDY2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTE1ICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBzaG91bGQg bWFrZSBwbHVnaW4gcHJvY2VzcyBkZWJ1Z2dpbmcgZWFzaWVyIChQTFVHSU5fUFJPQ0VTU19DTURf UFJFRklYIGVudiB2YXIpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05OTI5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBzdXBwb3J0IGZvciBQTFVHSU5fUFJPQ0VTU19DTURfUFJFRklYIGVudmlyb25t ZW50IHZhcmlhYmxlIHRvIG1ha2UgcGx1Z2luCisgICAgICAgIGRlYnVnZ2luZyBlYXNpZXIuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzUHJveHk6OlBsdWdpblByb2Nlc3NQcm94eSk6CisK IDIwMTItMTAtMTQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBGaXggdGhlIHdvcmxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1BsdWdpbnMvUGx1Z2luUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QbHVnaW5zL1BsdWdpblByb2Nlc3NQcm94eS5jcHAKaW5kZXggNzc5NmNmZTk3YTU1MjRlZDBi OThiNzU3YWE0M2NlZmQ1NjU3ZGEyNi4uMmFkMTY0MzVlYjBlYzUwNGY0OTk0MDA4MjcwN2I0NTIw YTZmMmNmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvUGx1 Z2luUHJvY2Vzc1Byb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lu cy9QbHVnaW5Qcm9jZXNzUHJveHkuY3BwCkBAIC03NSw2ICs3NSwxMiBAQCBQbHVnaW5Qcm9jZXNz UHJveHk6OlBsdWdpblByb2Nlc3NQcm94eShQbHVnaW5Qcm9jZXNzTWFuYWdlciogUGx1Z2luUHJv Y2Vzc01hbmFnZQogI2VuZGlmCiAjZW5kaWYKIAorI2lmbmRlZiBOREVCVUcKKyAgICBjb25zdCBj aGFyKiBjbWRQcmVmaXggPSBnZXRlbnYoIlBMVUdJTl9QUk9DRVNTX0NNRF9QUkVGSVgiKTsKKyAg ICBpZiAoY21kUHJlZml4ICYmICpjbWRQcmVmaXgpCisgICAgICAgIGxhdW5jaE9wdGlvbnMucHJv Y2Vzc0NtZFByZWZpeCA9IFN0cmluZzo6ZnJvbVVURjgoY21kUHJlZml4KTsKKyNlbmRpZgorCiAg ICAgbV9wcm9jZXNzTGF1bmNoZXIgPSBQcm9jZXNzTGF1bmNoZXI6OmNyZWF0ZSh0aGlzLCBsYXVu Y2hPcHRpb25zKTsKIH0KIAo= 169170 2012-10-17 06:05:42 -0700 2012-10-23 02:45:00 -0700 Patch bug-99297-20121017160428.patch text/plain 1951 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGE1OGQ0MTBlOWJkZTFm ZjExODc4NjNmN2QzZjBlYjFmMzE2NGRjNy4uOWQ5ZGRiOGM3MzcxYmRmNmYyYzk2ODg3YjA0OWVi ZjlkMGE1ZGYyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTEwLTE3ICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KIAorICAgICAgICBbRUZMXSBN YWtlIHBsdWdpbiBwcm9jZXNzIGRlYnVnZ2luZyBlYXNpZXIgKFBMVUdJTl9QUk9DRVNTX0NPTU1B TkRfUFJFRklYKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTkyOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgc3VwcG9ydCBmb3IgUExVR0lOX1BST0NFU1NfQ09NTUFORF9QUkVGSVggZW52aXJvbm1l bnQgdmFyaWFibGUsIHRvIGFsbG93IGVhc2llcgorICAgICAgICBwbHVnaW4gZGVidWdnaW5nIHdp dGggZS5nLjoKKyAgICAgICAgJCBQTFVHSU5fUFJPQ0VTU19DT01NQU5EX1BSRUZJWD0ieHRlcm0g Z2RiIC0tYXJncyIgTWluaUJyb3dzZXIKKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL3Vu aXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblBy b2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplTGF1bmNoT3B0aW9ucyk6CisgICAgICAgIChX ZWJLaXQpOgorCisyMDEyLTEwLTE3ICBKdXNzaSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGlu dGVsLmNvbT4KKwogICAgICAgICBBZGQgUGx1Z2luUHJvY2Vzc1Byb3h5OjpwbGF0Zm9ybUluaXRp YWxpemVMYXVuY2hPcHRpb25zCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05OTU4MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv UGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAppbmRleCBj N2E4OTIyZTEyZTA0ZTM3MjE1M2NhODVmYTcxNzJjNjI1ZmI3YTEyLi40MDVhYWQyOTBhYTdjZTRh Mzc4MTU0MDA0ZGY1YTU5MTMyZTQ4NDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5j cHAKQEAgLTQ1LDYgKzQ1LDEzIEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiB2b2lkIFBsdWdpblBy b2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplTGF1bmNoT3B0aW9ucyhQcm9jZXNzTGF1bmNo ZXI6OkxhdW5jaE9wdGlvbnMmIGxhdW5jaE9wdGlvbnMsIGNvbnN0IFBsdWdpbk1vZHVsZUluZm8m IHBsdWdpbkluZm8pCiB7CisjaWYgUExBVEZPUk0oRUZMKQorI2lmbmRlZiBOREVCVUcKKyAgICBj b25zdCBjaGFyKiBjb21tYW5kUHJlZml4ID0gZ2V0ZW52KCJQTFVHSU5fUFJPQ0VTU19DT01NQU5E X1BSRUZJWCIpOworICAgIGlmIChjb21tYW5kUHJlZml4ICYmICpjb21tYW5kUHJlZml4KQorICAg ICAgICBsYXVuY2hPcHRpb25zLnByb2Nlc3NDbWRQcmVmaXggPSBTdHJpbmc6OmZyb21VVEY4KGNv bW1hbmRQcmVmaXgpOworI2VuZGlmCisjZW5kaWYKIH0KIAogdm9pZCBQbHVnaW5Qcm9jZXNzUHJv eHk6OnBsYXRmb3JtSW5pdGlhbGl6ZVBsdWdpblByb2Nlc3MoUGx1Z2luUHJvY2Vzc0NyZWF0aW9u UGFyYW1ldGVycyYpCg== 170097 2012-10-23 02:45:04 -0700 2012-10-23 05:33:14 -0700 Patch bug-99297-20121023124341.patch text/plain 2067 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjFiZDVmNTFmMmRhNjU3 NGQyMmExNjUxOTJhYjY1MzE1MGE0MTU5Mi4uODdhZDRiZTk3ODZkNDVlNmYyNGVjZTZiMTM3ZTM3 MjE0ZTgxMzEzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTIzICBKdXNz aSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBN YWtlIHBsdWdpbiBwcm9jZXNzIGRlYnVnZ2luZyBlYXNpZXIgKFBMVUdJTl9QUk9DRVNTX0NPTU1B TkRfUFJFRklYKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTkyOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgc3VwcG9ydCBmb3IgUExVR0lOX1BST0NFU1NfQ09NTUFORF9QUkVGSVggZW52aXJvbm1l bnQgdmFyaWFibGUsIHRvIGFsbG93IGVhc2llcgorICAgICAgICBwbHVnaW4gZGVidWdnaW5nIHdp dGggZS5nLjoKKyAgICAgICAgJCBQTFVHSU5fUFJPQ0VTU19DT01NQU5EX1BSRUZJWD0ieHRlcm0g Z2RiIC0tYXJncyIgTWluaUJyb3dzZXIKKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5zL3Vu aXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblBy b2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplTGF1bmNoT3B0aW9ucyk6CisgICAgICAgIChX ZWJLaXQpOgorCiAyMDEyLTEwLTIyICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1lcmdlICJkb2NrZWQiIHN0YXRlIGludG8g dGhlICJkb2NrIHNpZGUiIGVudW0uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAppbmRl eCA2NGM3YmM0ODU3NDE2ZGJlYTkzZDQ0YTFmMDI2ODNlZTA4YWY2ZTQ2Li4xODllMjEzNzkxNGQ5 YjY4YTUxNjc1YTdiNjA0MzU3MWUzY2VlZjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQcm94eVVuaXguY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5p eC5jcHAKQEAgLTQzLDggKzQzLDE1IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1l c3BhY2UgV2ViS2l0IHsKIAotdm9pZCBQbHVnaW5Qcm9jZXNzUHJveHk6OnBsYXRmb3JtSW5pdGlh bGl6ZUxhdW5jaE9wdGlvbnMoUHJvY2Vzc0xhdW5jaGVyOjpMYXVuY2hPcHRpb25zJiwgY29uc3Qg UGx1Z2luTW9kdWxlSW5mbyYpCit2b2lkIFBsdWdpblByb2Nlc3NQcm94eTo6cGxhdGZvcm1Jbml0 aWFsaXplTGF1bmNoT3B0aW9ucyhQcm9jZXNzTGF1bmNoZXI6OkxhdW5jaE9wdGlvbnMmIGxhdW5j aE9wdGlvbnMsIGNvbnN0IFBsdWdpbk1vZHVsZUluZm8mKQogeworI2lmIFBMQVRGT1JNKEVGTCkg JiYgIWRlZmluZWQoTkRFQlVHKQorICAgIGNvbnN0IGNoYXIqIGNvbW1hbmRQcmVmaXggPSBnZXRl bnYoIlBMVUdJTl9QUk9DRVNTX0NPTU1BTkRfUFJFRklYIik7CisgICAgaWYgKGNvbW1hbmRQcmVm aXggJiYgKmNvbW1hbmRQcmVmaXgpCisgICAgICAgIGxhdW5jaE9wdGlvbnMucHJvY2Vzc0NtZFBy ZWZpeCA9IFN0cmluZzo6ZnJvbVVURjgoY29tbWFuZFByZWZpeCk7CisjZWxzZQorICAgIFVOVVNF RF9QQVJBTShsYXVuY2hPcHRpb25zKTsKKyNlbmRpZgogfQogCiB2b2lkIFBsdWdpblByb2Nlc3NQ cm94eTo6cGxhdGZvcm1Jbml0aWFsaXplUGx1Z2luUHJvY2VzcyhQbHVnaW5Qcm9jZXNzQ3JlYXRp b25QYXJhbWV0ZXJzJikK