99268 2012-10-14 11:12:45 -0700 prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense 2012-12-20 09:28:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz ap rniwa tkent oldest_to_newest 741576 0 mitz 2012-10-14 11:12:45 -0700 prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense 741577 1 168584 mitz 2012-10-14 11:14:28 -0700 Created attachment 168584 Add "Additional information" line only for change logs under Source 742149 2 ap 2012-10-15 10:25:24 -0700 I'm actually finding this location more more useful for non-source changes. When you only modify tests, rationale on top is usually most appropriate, while for source code changes, it's often just bug title and per-function comments. Also, there is a lot of source code under Tools. 742154 3 mitz 2012-10-15 10:28:43 -0700 I find that having the instructions on how to write a change log entry in the change log entry template is a nuisance. 742411 4 168584 ap 2012-10-15 14:10:50 -0700 Comment on attachment 168584 Add "Additional information" line only for change logs under Source I'm not sure why I didn't mark this r-, I totally meant to. 742414 5 ap 2012-10-15 14:11:25 -0700 > I find that having the instructions on how to write a change log entry in the change log entry template is a nuisance. Sounds like they should be removed unconditionally then. 742422 6 mitz 2012-10-15 14:15:11 -0700 (In reply to comment #5) > > I find that having the instructions on how to write a change log entry in the change log entry template is a nuisance. > > Sounds like they should be removed unconditionally then. I’d prefer that. 762160 7 ap 2012-11-08 14:09:48 -0800 As for rationale - contributors frequently forget to remove this line regardless of location, which is a waste of everyone's time. 795239 8 180291 mitz 2012-12-20 00:33:52 -0800 Created attachment 180291 Never add the “Additional information” line 795240 9 rniwa 2012-12-20 00:36:42 -0800 This was added in http://trac.webkit.org/changeset/122192. 795242 10 rniwa 2012-12-20 00:44:01 -0800 I think we can solve the problem of new contributors not inserting the description at the right place by improving http://www.webkit.org/coding/contributing.html#changelogs 795264 11 rniwa 2012-12-20 01:19:33 -0800 (In reply to comment #10) > I think we can solve the problem of new contributors not inserting the description at the right place by improving http://www.webkit.org/coding/contributing.html#changelogs Submitted a patch on https://bugs.webkit.org/show_bug.cgi?id=105506. 795488 12 mitz 2012-12-20 09:28:08 -0800 Fixed in <http://trac.webkit.org/r138259>. 168584 2012-10-14 11:14:28 -0700 2012-12-20 00:33:52 -0800 Add "Additional information" line only for change logs under Source bug-99268-20121014111324.patch text/plain 1973 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMTI2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTEwLTE0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgcHJlcGFyZS1DaGFuZ2VMb2cgYWRkcyAiQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBv ZiB0aGUgY2hhbmdlIHN1Y2ggYXMgYXBwcm9hY2gsIHJhdGlvbmFsZSIgd2hlcmUgaXQgZG9lc24n dCBtYWtlIHNlbnNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05OTI2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKyAgICAgICAgKGdlbmVyYXRlTmV3Q2hh bmdlTG9ncyk6IENoYW5nZWQgdG8gYWRkIHRoZSAiQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBvZiB0 aGUgY2hhbmdlIiBsaW5lIG9ubHkKKyAgICAgICAgZm9yIGNoYW5nZSBsb2dzIHVuZGVyIFNvdXJj ZS4KKwogMjAxMi0xMC0xMyAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgog CiAgICAgICAgIFtUZXN0UmVzdWx0U2VydmVyXSBVbml0IHRlc3RzIHJlcXVpcmUgYW4gdXBkYXRl IGFmdGVyIHIxMzEyMzkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwkocmV2aXNpb24gMTMx MjY3KQorKysgVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtNDk5LDkgKzQ5OSwxNCBAQCBzdWIgZ2VuZXJhdGVOZXdDaGFuZ2VMb2dzKCQkJCQkJCQkJCQk KQogICAgICAgICBwcmludCBDSEFOR0VfTE9HIG5vcm1hbGl6ZUxpbmVFbmRpbmdzKCJcbiIsICRl bmRsKTsKIAogICAgICAgICBwcmludCBDSEFOR0VfTE9HIG5vcm1hbGl6ZUxpbmVFbmRpbmdzKCIg ICAgICAgIFJldmlld2VkIGJ5ICRyZXZpZXdlci5cblxuIiwgJGVuZGwpOwotICAgICAgICBwcmlu dCBDSEFOR0VfTE9HIG5vcm1hbGl6ZUxpbmVFbmRpbmdzKCIgICAgICAgIEFkZGl0aW9uYWwgaW5m b3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25hbGUuIFBsZWFz ZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLlxuXG4iLCAkZW5k bCk7CiAKLSAgICAgICAgaWYgKCRwcmVmaXggPX4gbS9XZWJDb3JlLyB8fCBgcHdkYCA9fiBtL1dl YkNvcmUvKSB7CisgICAgICAgIG15ICRjd2QgPSBgcHdkYDsKKworICAgICAgICBpZiAoJHByZWZp eCA9fiBtLyhcL3xeKVNvdXJjZS8gfHwgJGN3ZCA9fiBtL1wvU291cmNlLykgeworICAgICAgICAg ICAgcHJpbnQgQ0hBTkdFX0xPRyBub3JtYWxpemVMaW5lRW5kaW5ncygiICAgICAgICBBZGRpdGlv bmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFuZ2Ugc3VjaCBhcyBhcHByb2FjaCwgcmF0aW9uYWxl LiBQbGVhc2UgYWRkIHBlci1mdW5jdGlvbiBkZXNjcmlwdGlvbnMgYmVsb3cgKE9PUFMhKS5cblxu IiwgJGVuZGwpOworICAgICAgICB9CisKKyAgICAgICAgaWYgKCRwcmVmaXggPX4gbS9XZWJDb3Jl LyB8fCAkY3dkID1+IG0vV2ViQ29yZS8pIHsKICAgICAgICAgICAgIGlmIChAJGFkZGVkUmVncmVz c2lvblRlc3RzKSB7CiAgICAgICAgICAgICAgICAgcHJpbnQgQ0hBTkdFX0xPRyBub3JtYWxpemVM aW5lRW5kaW5ncyh0ZXN0TGlzdEZvckNoYW5nZUxvZyhzb3J0IEAkYWRkZWRSZWdyZXNzaW9uVGVz dHMpLCAkZW5kbCk7CiAgICAgICAgICAgICB9IGVsc2Ugewo= 180291 2012-12-20 00:33:52 -0800 2012-12-20 01:02:13 -0800 Never add the “Additional information” line 99268_r2.diff text/plain 1396 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzODIyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTEyLTIwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgcHJlcGFyZS1DaGFuZ2VMb2cgYWRkcyAiQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBv ZiB0aGUgY2hhbmdlIHN1Y2ggYXMgYXBwcm9hY2gsIHJhdGlvbmFsZSIgd2hlcmUgaXQgZG9lc24n dCBtYWtlIHNlbnNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05OTI2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKyAgICAgICAgKGdlbmVyYXRlTmV3Q2hh bmdlTG9ncyk6IFJlbW92ZWQgdGhlICJBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFu Z2UiIGxpbmUuCisKIDIwMTItMTItMTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUGVyZlRlc3QucGFyc2Vfb3V0cHV0IGRvZXMgdG9vIG11Y2gKSW5kZXg6IFRv b2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy9wcmVwYXJlLUNoYW5nZUxvZwkocmV2aXNpb24gMTM4MjE0KQorKysgVG9vbHMvU2NyaXB0cy9w cmVwYXJlLUNoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtNDk5LDcgKzQ5OSw2IEBAIHN1YiBn ZW5lcmF0ZU5ld0NoYW5nZUxvZ3MoJCQkJCQkJCQkJCQpCiAgICAgICAgIHByaW50IENIQU5HRV9M T0cgbm9ybWFsaXplTGluZUVuZGluZ3MoIlxuIiwgJGVuZGwpOwogCiAgICAgICAgIHByaW50IENI QU5HRV9MT0cgbm9ybWFsaXplTGluZUVuZGluZ3MoIiAgICAgICAgUmV2aWV3ZWQgYnkgJHJldmll d2VyLlxuXG4iLCAkZW5kbCk7Ci0gICAgICAgIHByaW50IENIQU5HRV9MT0cgbm9ybWFsaXplTGlu ZUVuZGluZ3MoIiAgICAgICAgQWRkaXRpb25hbCBpbmZvcm1hdGlvbiBvZiB0aGUgY2hhbmdlIHN1 Y2ggYXMgYXBwcm9hY2gsIHJhdGlvbmFsZS4gUGxlYXNlIGFkZCBwZXItZnVuY3Rpb24gZGVzY3Jp cHRpb25zIGJlbG93IChPT1BTISkuXG5cbiIsICRlbmRsKTsKIAogICAgICAgICBpZiAoJHByZWZp eCA9fiBtL1dlYkNvcmUvIHx8IGBwd2RgID1+IG0vV2ViQ29yZS8pIHsKICAgICAgICAgICAgIGlm IChAJGFkZGVkUmVncmVzc2lvblRlc3RzKSB7Cg==