<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>99265</bug_id>
          
          <creation_ts>2012-10-14 00:33:13 -0700</creation_ts>
          <short_desc>[EFL][WK2] Display page favicons in MiniBrowser</short_desc>
          <delta_ts>2012-10-15 23:31:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>99087</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>kenneth</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>741555</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-14 00:33:13 -0700</bug_when>
    <thetext>We should use the new Favicon API from Bug 99087 and display page favicons in MiniBrowser.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>741565</commentid>
    <comment_count>1</comment_count>
      <attachid>168582</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-14 06:22:00 -0700</bug_when>
    <thetext>Created attachment 168582
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>741566</commentid>
    <comment_count>2</comment_count>
      <attachid>168582</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-14 06:26:57 -0700</bug_when>
    <thetext>Comment on attachment 168582
Patch

Attachment 168582 did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14311012</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742358</commentid>
    <comment_count>3</comment_count>
      <attachid>168769</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-15 13:27:27 -0700</bug_when>
    <thetext>Created attachment 168769
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742677</commentid>
    <comment_count>4</comment_count>
      <attachid>168769</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-15 18:12:28 -0700</bug_when>
    <thetext>Comment on attachment 168769
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168769&amp;action=review

&gt; Tools/MiniBrowser/efl/main.c:345
&gt; +        evas_object_ref(icon);

You remove icon object without doing unref at 334 line. So, do you need to increase ref count here ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742785</commentid>
    <comment_count>5</comment_count>
      <attachid>168769</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-15 21:55:16 -0700</bug_when>
    <thetext>Comment on attachment 168769
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168769&amp;action=review

&gt; Tools/MiniBrowser/efl/main.c:335
&gt; +        evas_object_del(old_icon);

Right, I probably need to unref() here as well.

&gt;&gt; Tools/MiniBrowser/efl/main.c:345
&gt;&gt; +        evas_object_ref(icon);
&gt; 
&gt; You remove icon object without doing unref at 334 line. So, do you need to increase ref count here ?

Yes, the caller will unref() the icon after the callback is called so the callback should ref() it if it wishes to use / keep it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742810</commentid>
    <comment_count>6</comment_count>
      <attachid>168855</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-15 22:43:39 -0700</bug_when>
    <thetext>Created attachment 168855
Patch for landing

Could someone please cq+ ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742824</commentid>
    <comment_count>7</comment_count>
      <attachid>168855</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2012-10-15 22:59:02 -0700</bug_when>
    <thetext>Comment on attachment 168855
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=168855&amp;action=review

&gt; Tools/MiniBrowser/efl/main.c:335
&gt; +        evas_object_unref(icon);

Could you explain why you do unref *icon* instead of *old_icon* ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742829</commentid>
    <comment_count>8</comment_count>
      <attachid>168855</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-15 23:04:16 -0700</bug_when>
    <thetext>Comment on attachment 168855
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=168855&amp;action=review

&gt;&gt; Tools/MiniBrowser/efl/main.c:335
&gt;&gt; +        evas_object_unref(icon);
&gt; 
&gt; Could you explain why you do unref *icon* instead of *old_icon* ?

because I did not properly wake up yet :) Thanks for catching this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742837</commentid>
    <comment_count>9</comment_count>
      <attachid>168864</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2012-10-15 23:10:35 -0700</bug_when>
    <thetext>Created attachment 168864
Patch for landing

Fixed wrong unref (Thanks Gyuyoung).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742847</commentid>
    <comment_count>10</comment_count>
      <attachid>168864</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-15 23:31:07 -0700</bug_when>
    <thetext>Comment on attachment 168864
Patch for landing

Clearing flags on attachment: 168864

Committed r131416: &lt;http://trac.webkit.org/changeset/131416&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742848</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-15 23:31:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>168582</attachid>
            <date>2012-10-14 06:22:00 -0700</date>
            <delta_ts>2012-10-15 13:27:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>99265_minibrowser_favicons.patch</filename>
            <type>text/plain</type>
            <size>3840</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNzNh
OTlhLi5hODk0YzI0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMTQgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIERpc3BsYXkg
cGFnZSBmYXZpY29ucyBpbiBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBEaXNwbGF5IGN1cnJlbnQgcGFnZSBmYXZpY29uIGluIHRoZSBV
UkwgYmFyLgorICAgICAgICBUaGlzIHVzZXMgdGhlIG5ldyBmYXZpY29uIGRhdGFiYXNlIEFQSSBp
bgorICAgICAgICBFRkwgV2ViS2l0Mi4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWlu
LmM6CisgICAgICAgIChvbl9mYXZpY29uX3JlY2VpdmVkKToKKyAgICAgICAgKG9uX3ZpZXdfaWNv
bl9jaGFuZ2VkKToKKyAgICAgICAgKHdpbmRvd19jcmVhdGUpOgorCiAyMDEyLTEwLTEyICBUb21t
eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIENyZWF0aW5nIGEg
TWVkaWFTdHJlYW0gc3Vic2NyaXB0aW9uIGluIHdhdGNobGlzdApkaWZmIC0tZ2l0IGEvVG9vbHMv
TWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5k
ZXggZWUwM2I4OC4uOTAzNDdmOCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21h
aW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0zMjIsNiArMzIyLDQz
IEBAIG9uX2Rvd25sb2FkX2ZhaWxlZCh2b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICp3ZWJ2
aWV3LCB2b2lkICpldmVudF9pbmZvKQogICAgIGluZm8oIkRvd25sb2FkIGZhaWxlZCFcbiIpOwog
fQogCitzdGF0aWMgdm9pZAorb25fZmF2aWNvbl9yZWNlaXZlZChjb25zdCBjaGFyICpwYWdlX3Vy
bCwgRXZhc19PYmplY3QgKmljb24sIHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgQnJvd3Nlcl9X
aW5kb3cgKmFwcF9kYXRhID0gKEJyb3dzZXJfV2luZG93ICopZXZlbnRfaW5mbzsKKyAgICBpZiAo
c3RyY21wKHBhZ2VfdXJsLCBld2tfdmlld191cmxfZ2V0KGFwcF9kYXRhLT53ZWJ2aWV3KSkpCisg
ICAgICAgIHJldHVybjsKKworICAgIC8qIFJlbW92ZSBwcmV2aW91cyBpY29uIGZyb20gVVJMIGJh
ciAqLworICAgIEV2YXNfT2JqZWN0ICpvbGRfaWNvbiA9IGVsbV9vYmplY3RfcGFydF9jb250ZW50
X3Vuc2V0KGFwcF9kYXRhLT51cmxfYmFyLCAiaWNvbiIpOworICAgIGlmIChvbGRfaWNvbikKKyAg
ICAgICAgZXZhc19vYmplY3RfZGVsKG9sZF9pY29uKTsKKworICAgIC8qIFNob3cgbmV3IGljb24g
aW4gVVJMIGJhciAqLworICAgIGlmIChpY29uKSB7CisgICAgICAgIC8qIFdvcmthcm91bmQgZm9y
IGljb24gZGlzcGxheSBidWc6CisgICAgICAgICAqIGh0dHA6Ly90cmFjLmVubGlnaHRlbm1lbnQu
b3JnL2UvdGlja2V0LzE2MTYgKi8KKyAgICAgICAgZXZhc19vYmplY3Rfc2l6ZV9oaW50X21pbl9z
ZXQoaWNvbiwgNDgsIDI0KTsKKyAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZmlsbGVkX3NldChp
Y29uLCBFSU5BX0ZBTFNFKTsKKyAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZmlsbF9zZXQoaWNv
biwgMjQsIDAsIDI0LCAyNCk7CisgICAgICAgIGVsbV9vYmplY3RfcGFydF9jb250ZW50X3NldChh
cHBfZGF0YS0+dXJsX2JhciwgImljb24iLCBpY29uKTsKKyAgICAgICAgZXZhc19vYmplY3RfcmVm
KGljb24pOworICAgIH0KK30KKworc3RhdGljIHZvaWQKK29uX3ZpZXdfaWNvbl9jaGFuZ2VkKHZv
aWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCit7
CisgICAgQnJvd3Nlcl9XaW5kb3cgKmFwcF9kYXRhID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9k
YXRhOworICAgIC8qIFJldHJpZXZlIHRoZSB2aWV3J3MgZmF2aWNvbiAqLworICAgIEV3a19Db250
ZXh0ICpjb250ZXh0ID0gZXdrX3ZpZXdfY29udGV4dF9nZXQod2Vidmlldyk7CisgICAgRXdrX0Zh
dmljb25fRGF0YWJhc2UgKmljb25fZGF0YWJhc2UgPSBld2tfY29udGV4dF9mYXZpY29uX2RhdGFi
YXNlX2dldChjb250ZXh0KTsKKworICAgIGNvbnN0IGNoYXIgKnBhZ2VfdXJsID0gZXdrX3ZpZXdf
dXJsX2dldCh3ZWJ2aWV3KTsKKyAgICBFdmFzICpldmFzID0gZXZhc19vYmplY3RfZXZhc19nZXQo
d2Vidmlldyk7CisgICAgZXdrX2Zhdmljb25fZGF0YWJhc2VfYXN5bmNfaWNvbl9nZXQoaWNvbl9k
YXRhYmFzZSwgcGFnZV91cmwsIGV2YXMsIG9uX2Zhdmljb25fcmVjZWl2ZWQsIGFwcF9kYXRhKTsK
K30KKwogc3RhdGljIGludAogcXVpdChFaW5hX0Jvb2wgc3VjY2VzcywgY29uc3QgY2hhciAqbXNn
KQogewpAQCAtNjEwLDYgKzY0Nyw3IEBAIHN0YXRpYyBCcm93c2VyX1dpbmRvdyAqd2luZG93X2Ny
ZWF0ZShjb25zdCBjaGFyICp1cmwpCiAgICAgLyogQ3JlYXRlIFVSTCBiYXIgKi8KICAgICBhcHBf
ZGF0YS0+dXJsX2JhciA9IGVsbV9lbnRyeV9hZGQoYXBwX2RhdGEtPndpbmRvdyk7CiAgICAgZWxt
X2VudHJ5X3Njcm9sbGFibGVfc2V0KGFwcF9kYXRhLT51cmxfYmFyLCBFSU5BX1RSVUUpOworICAg
IGVsbV9lbnRyeV9zY3JvbGxiYXJfcG9saWN5X3NldChhcHBfZGF0YS0+dXJsX2JhciwgRUxNX1ND
Uk9MTEVSX1BPTElDWV9PRkYsIEVMTV9TQ1JPTExFUl9QT0xJQ1lfT0ZGKTsKICAgICBlbG1fZW50
cnlfc2luZ2xlX2xpbmVfc2V0KGFwcF9kYXRhLT51cmxfYmFyLCBFSU5BX1RSVUUpOwogICAgIGVs
bV9lbnRyeV9jbnBfbW9kZV9zZXQoYXBwX2RhdGEtPnVybF9iYXIsIEVMTV9DTlBfTU9ERV9QTEFJ
TlRFWFQpOwogICAgIGVsbV9lbnRyeV90ZXh0X3N0eWxlX3VzZXJfcHVzaChhcHBfZGF0YS0+dXJs
X2JhciwgIkRFRkFVTFQ9J2ZvbnRfc2l6ZT0xOCciKTsKQEAgLTY1Nyw2ICs2OTUsNyBAQCBzdGF0
aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoY29uc3QgY2hhciAqdXJsKQogICAgIGV2
YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2Fk
LGZhaWxlZCIsIG9uX2Rvd25sb2FkX2ZhaWxlZCwgYXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0
X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2FkLGZpbmlzaGVk
Iiwgb25fZG93bmxvYWRfZmluaXNoZWQsIGFwcF9kYXRhKTsKICAgICBldmFzX29iamVjdF9zbWFy
dF9jYWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJkb3dubG9hZCxyZXF1ZXN0Iiwgb25f
ZG93bmxvYWRfcmVxdWVzdCwgYXBwX2RhdGEpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxi
YWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImljb24sY2hhbmdlZCIsIG9uX3ZpZXdfaWNvbl9j
aGFuZ2VkLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFw
cF9kYXRhLT53ZWJ2aWV3LCAibG9hZCxlcnJvciIsIG9uX2Vycm9yLCBhcHBfZGF0YSk7CiAgICAg
ZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAibG9hZCxw
cm9ncmVzcyIsIG9uX3Byb2dyZXNzLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRf
Y2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAidGl0bGUsY2hhbmdlZCIsIG9uX3RpdGxl
X2NoYW5nZWQsIGFwcF9kYXRhKTsK
</data>
<flag name="commit-queue"
          id="181602"
          type_id="3"
          status="-"
          setter="gyuyoung.kim"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>168769</attachid>
            <date>2012-10-15 13:27:27 -0700</date>
            <delta_ts>2012-10-15 22:43:39 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>minibrowser_favicons.patch</filename>
            <type>text/plain</type>
            <size>3840</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNzNh
OTlhLi5hODk0YzI0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMTQgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIERpc3BsYXkg
cGFnZSBmYXZpY29ucyBpbiBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBEaXNwbGF5IGN1cnJlbnQgcGFnZSBmYXZpY29uIGluIHRoZSBV
UkwgYmFyLgorICAgICAgICBUaGlzIHVzZXMgdGhlIG5ldyBmYXZpY29uIGRhdGFiYXNlIEFQSSBp
bgorICAgICAgICBFRkwgV2ViS2l0Mi4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWlu
LmM6CisgICAgICAgIChvbl9mYXZpY29uX3JlY2VpdmVkKToKKyAgICAgICAgKG9uX3ZpZXdfaWNv
bl9jaGFuZ2VkKToKKyAgICAgICAgKHdpbmRvd19jcmVhdGUpOgorCiAyMDEyLTEwLTEyICBUb21t
eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAgICAgIENyZWF0aW5nIGEg
TWVkaWFTdHJlYW0gc3Vic2NyaXB0aW9uIGluIHdhdGNobGlzdApkaWZmIC0tZ2l0IGEvVG9vbHMv
TWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5k
ZXggZWUwM2I4OC4uOTAzNDdmOCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21h
aW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0zMjIsNiArMzIyLDQz
IEBAIG9uX2Rvd25sb2FkX2ZhaWxlZCh2b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICp3ZWJ2
aWV3LCB2b2lkICpldmVudF9pbmZvKQogICAgIGluZm8oIkRvd25sb2FkIGZhaWxlZCFcbiIpOwog
fQogCitzdGF0aWMgdm9pZAorb25fZmF2aWNvbl9yZWNlaXZlZChjb25zdCBjaGFyICpwYWdlX3Vy
bCwgRXZhc19PYmplY3QgKmljb24sIHZvaWQgKmV2ZW50X2luZm8pCit7CisgICAgQnJvd3Nlcl9X
aW5kb3cgKmFwcF9kYXRhID0gKEJyb3dzZXJfV2luZG93ICopZXZlbnRfaW5mbzsKKyAgICBpZiAo
c3RyY21wKHBhZ2VfdXJsLCBld2tfdmlld191cmxfZ2V0KGFwcF9kYXRhLT53ZWJ2aWV3KSkpCisg
ICAgICAgIHJldHVybjsKKworICAgIC8qIFJlbW92ZSBwcmV2aW91cyBpY29uIGZyb20gVVJMIGJh
ciAqLworICAgIEV2YXNfT2JqZWN0ICpvbGRfaWNvbiA9IGVsbV9vYmplY3RfcGFydF9jb250ZW50
X3Vuc2V0KGFwcF9kYXRhLT51cmxfYmFyLCAiaWNvbiIpOworICAgIGlmIChvbGRfaWNvbikKKyAg
ICAgICAgZXZhc19vYmplY3RfZGVsKG9sZF9pY29uKTsKKworICAgIC8qIFNob3cgbmV3IGljb24g
aW4gVVJMIGJhciAqLworICAgIGlmIChpY29uKSB7CisgICAgICAgIC8qIFdvcmthcm91bmQgZm9y
IGljb24gZGlzcGxheSBidWc6CisgICAgICAgICAqIGh0dHA6Ly90cmFjLmVubGlnaHRlbm1lbnQu
b3JnL2UvdGlja2V0LzE2MTYgKi8KKyAgICAgICAgZXZhc19vYmplY3Rfc2l6ZV9oaW50X21pbl9z
ZXQoaWNvbiwgNDgsIDI0KTsKKyAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZmlsbGVkX3NldChp
Y29uLCBFSU5BX0ZBTFNFKTsKKyAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZmlsbF9zZXQoaWNv
biwgMjQsIDAsIDI0LCAyNCk7CisgICAgICAgIGVsbV9vYmplY3RfcGFydF9jb250ZW50X3NldChh
cHBfZGF0YS0+dXJsX2JhciwgImljb24iLCBpY29uKTsKKyAgICAgICAgZXZhc19vYmplY3RfcmVm
KGljb24pOworICAgIH0KK30KKworc3RhdGljIHZvaWQKK29uX3ZpZXdfaWNvbl9jaGFuZ2VkKHZv
aWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCit7
CisgICAgQnJvd3Nlcl9XaW5kb3cgKmFwcF9kYXRhID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9k
YXRhOworICAgIC8qIFJldHJpZXZlIHRoZSB2aWV3J3MgZmF2aWNvbiAqLworICAgIEV3a19Db250
ZXh0ICpjb250ZXh0ID0gZXdrX3ZpZXdfY29udGV4dF9nZXQod2Vidmlldyk7CisgICAgRXdrX0Zh
dmljb25fRGF0YWJhc2UgKmljb25fZGF0YWJhc2UgPSBld2tfY29udGV4dF9mYXZpY29uX2RhdGFi
YXNlX2dldChjb250ZXh0KTsKKworICAgIGNvbnN0IGNoYXIgKnBhZ2VfdXJsID0gZXdrX3ZpZXdf
dXJsX2dldCh3ZWJ2aWV3KTsKKyAgICBFdmFzICpldmFzID0gZXZhc19vYmplY3RfZXZhc19nZXQo
d2Vidmlldyk7CisgICAgZXdrX2Zhdmljb25fZGF0YWJhc2VfYXN5bmNfaWNvbl9nZXQoaWNvbl9k
YXRhYmFzZSwgcGFnZV91cmwsIGV2YXMsIG9uX2Zhdmljb25fcmVjZWl2ZWQsIGFwcF9kYXRhKTsK
K30KKwogc3RhdGljIGludAogcXVpdChFaW5hX0Jvb2wgc3VjY2VzcywgY29uc3QgY2hhciAqbXNn
KQogewpAQCAtNjEwLDYgKzY0Nyw3IEBAIHN0YXRpYyBCcm93c2VyX1dpbmRvdyAqd2luZG93X2Ny
ZWF0ZShjb25zdCBjaGFyICp1cmwpCiAgICAgLyogQ3JlYXRlIFVSTCBiYXIgKi8KICAgICBhcHBf
ZGF0YS0+dXJsX2JhciA9IGVsbV9lbnRyeV9hZGQoYXBwX2RhdGEtPndpbmRvdyk7CiAgICAgZWxt
X2VudHJ5X3Njcm9sbGFibGVfc2V0KGFwcF9kYXRhLT51cmxfYmFyLCBFSU5BX1RSVUUpOworICAg
IGVsbV9lbnRyeV9zY3JvbGxiYXJfcG9saWN5X3NldChhcHBfZGF0YS0+dXJsX2JhciwgRUxNX1ND
Uk9MTEVSX1BPTElDWV9PRkYsIEVMTV9TQ1JPTExFUl9QT0xJQ1lfT0ZGKTsKICAgICBlbG1fZW50
cnlfc2luZ2xlX2xpbmVfc2V0KGFwcF9kYXRhLT51cmxfYmFyLCBFSU5BX1RSVUUpOwogICAgIGVs
bV9lbnRyeV9jbnBfbW9kZV9zZXQoYXBwX2RhdGEtPnVybF9iYXIsIEVMTV9DTlBfTU9ERV9QTEFJ
TlRFWFQpOwogICAgIGVsbV9lbnRyeV90ZXh0X3N0eWxlX3VzZXJfcHVzaChhcHBfZGF0YS0+dXJs
X2JhciwgIkRFRkFVTFQ9J2ZvbnRfc2l6ZT0xOCciKTsKQEAgLTY1Nyw2ICs2OTUsNyBAQCBzdGF0
aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoY29uc3QgY2hhciAqdXJsKQogICAgIGV2
YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2Fk
LGZhaWxlZCIsIG9uX2Rvd25sb2FkX2ZhaWxlZCwgYXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0
X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2FkLGZpbmlzaGVk
Iiwgb25fZG93bmxvYWRfZmluaXNoZWQsIGFwcF9kYXRhKTsKICAgICBldmFzX29iamVjdF9zbWFy
dF9jYWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJkb3dubG9hZCxyZXF1ZXN0Iiwgb25f
ZG93bmxvYWRfcmVxdWVzdCwgYXBwX2RhdGEpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxi
YWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImljb24sY2hhbmdlZCIsIG9uX3ZpZXdfaWNvbl9j
aGFuZ2VkLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFw
cF9kYXRhLT53ZWJ2aWV3LCAibG9hZCxlcnJvciIsIG9uX2Vycm9yLCBhcHBfZGF0YSk7CiAgICAg
ZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAibG9hZCxw
cm9ncmVzcyIsIG9uX3Byb2dyZXNzLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRf
Y2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAidGl0bGUsY2hhbmdlZCIsIG9uX3RpdGxl
X2NoYW5nZWQsIGFwcF9kYXRhKTsK
</data>
<flag name="review"
          id="181841"
          type_id="1"
          status="+"
          setter="gyuyoung.kim"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>168855</attachid>
            <date>2012-10-15 22:43:39 -0700</date>
            <delta_ts>2012-10-15 23:10:35 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>99265_minibrowser_favicons.patch</filename>
            <type>text/plain</type>
            <size>3897</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ODA1
NzZkLi4xZjkwZDFiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMTUgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIERpc3BsYXkg
cGFnZSBmYXZpY29ucyBpbiBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyNjUKKworICAgICAgICBSZXZpZXdlZCBieSBHeXV5b3Vu
ZyBLaW0uCisKKyAgICAgICAgRGlzcGxheSBjdXJyZW50IHBhZ2UgZmF2aWNvbiBpbiB0aGUgVVJM
IGJhci4KKyAgICAgICAgVGhpcyB1c2VzIHRoZSBuZXcgZmF2aWNvbiBkYXRhYmFzZSBBUEkgaW4K
KyAgICAgICAgRUZMIFdlYktpdDIuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5j
OgorICAgICAgICAob25fZmF2aWNvbl9yZWNlaXZlZCk6CisgICAgICAgIChvbl92aWV3X2ljb25f
Y2hhbmdlZCk6CisgICAgICAgICh3aW5kb3dfY3JlYXRlKToKKwogMjAxMi0xMC0xNSAgU2ltb24g
RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdGhlIHVy
bCBiYXIgaW4gTWluaUJyb3dzZXIgd2hlbiBnZXR0aW5nIHRoZSBjb21taXR0ZWQgVVJMCmRpZmYg
LS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIv
ZWZsL21haW4uYwppbmRleCA4ZjUwNTdmLi40NjRlZjFkIDEwMDY0NAotLS0gYS9Ub29scy9NaW5p
QnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAg
LTMyMiw2ICszMjIsNDUgQEAgb25fZG93bmxvYWRfZmFpbGVkKHZvaWQgKnVzZXJfZGF0YSwgRXZh
c19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiAgICAgaW5mbygiRG93bmxvYWQg
ZmFpbGVkIVxuIik7CiB9CiAKK3N0YXRpYyB2b2lkCitvbl9mYXZpY29uX3JlY2VpdmVkKGNvbnN0
IGNoYXIgKnBhZ2VfdXJsLCBFdmFzX09iamVjdCAqaWNvbiwgdm9pZCAqZXZlbnRfaW5mbykKK3sK
KyAgICBCcm93c2VyX1dpbmRvdyAqYXBwX2RhdGEgPSAoQnJvd3Nlcl9XaW5kb3cgKilldmVudF9p
bmZvOworICAgIGlmIChzdHJjbXAocGFnZV91cmwsIGV3a192aWV3X3VybF9nZXQoYXBwX2RhdGEt
PndlYnZpZXcpKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgLyogUmVtb3ZlIHByZXZpb3VzIGlj
b24gZnJvbSBVUkwgYmFyICovCisgICAgRXZhc19PYmplY3QgKm9sZF9pY29uID0gZWxtX29iamVj
dF9wYXJ0X2NvbnRlbnRfdW5zZXQoYXBwX2RhdGEtPnVybF9iYXIsICJpY29uIik7CisgICAgaWYg
KG9sZF9pY29uKSB7CisgICAgICAgIGV2YXNfb2JqZWN0X3VucmVmKGljb24pOworICAgICAgICBl
dmFzX29iamVjdF9kZWwob2xkX2ljb24pOworICAgIH0KKworICAgIC8qIFNob3cgbmV3IGljb24g
aW4gVVJMIGJhciAqLworICAgIGlmIChpY29uKSB7CisgICAgICAgIC8qIFdvcmthcm91bmQgZm9y
IGljb24gZGlzcGxheSBidWc6CisgICAgICAgICAqIGh0dHA6Ly90cmFjLmVubGlnaHRlbm1lbnQu
b3JnL2UvdGlja2V0LzE2MTYgKi8KKyAgICAgICAgZXZhc19vYmplY3Rfc2l6ZV9oaW50X21pbl9z
ZXQoaWNvbiwgNDgsIDI0KTsKKyAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZmlsbGVkX3NldChp
Y29uLCBFSU5BX0ZBTFNFKTsKKyAgICAgICAgZXZhc19vYmplY3RfaW1hZ2VfZmlsbF9zZXQoaWNv
biwgMjQsIDAsIDI0LCAyNCk7CisgICAgICAgIGVsbV9vYmplY3RfcGFydF9jb250ZW50X3NldChh
cHBfZGF0YS0+dXJsX2JhciwgImljb24iLCBpY29uKTsKKyAgICAgICAgZXZhc19vYmplY3RfcmVm
KGljb24pOworICAgIH0KK30KKworc3RhdGljIHZvaWQKK29uX3ZpZXdfaWNvbl9jaGFuZ2VkKHZv
aWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCit7
CisgICAgQnJvd3Nlcl9XaW5kb3cgKmFwcF9kYXRhID0gKEJyb3dzZXJfV2luZG93ICopdXNlcl9k
YXRhOworICAgIC8qIFJldHJpZXZlIHRoZSB2aWV3J3MgZmF2aWNvbiAqLworICAgIEV3a19Db250
ZXh0ICpjb250ZXh0ID0gZXdrX3ZpZXdfY29udGV4dF9nZXQod2Vidmlldyk7CisgICAgRXdrX0Zh
dmljb25fRGF0YWJhc2UgKmljb25fZGF0YWJhc2UgPSBld2tfY29udGV4dF9mYXZpY29uX2RhdGFi
YXNlX2dldChjb250ZXh0KTsKKworICAgIGNvbnN0IGNoYXIgKnBhZ2VfdXJsID0gZXdrX3ZpZXdf
dXJsX2dldCh3ZWJ2aWV3KTsKKyAgICBFdmFzICpldmFzID0gZXZhc19vYmplY3RfZXZhc19nZXQo
d2Vidmlldyk7CisgICAgZXdrX2Zhdmljb25fZGF0YWJhc2VfYXN5bmNfaWNvbl9nZXQoaWNvbl9k
YXRhYmFzZSwgcGFnZV91cmwsIGV2YXMsIG9uX2Zhdmljb25fcmVjZWl2ZWQsIGFwcF9kYXRhKTsK
K30KKwogc3RhdGljIGludAogcXVpdChFaW5hX0Jvb2wgc3VjY2VzcywgY29uc3QgY2hhciAqbXNn
KQogewpAQCAtNjEwLDYgKzY0OSw3IEBAIHN0YXRpYyBCcm93c2VyX1dpbmRvdyAqd2luZG93X2Ny
ZWF0ZShjb25zdCBjaGFyICp1cmwpCiAgICAgLyogQ3JlYXRlIFVSTCBiYXIgKi8KICAgICBhcHBf
ZGF0YS0+dXJsX2JhciA9IGVsbV9lbnRyeV9hZGQoYXBwX2RhdGEtPndpbmRvdyk7CiAgICAgZWxt
X2VudHJ5X3Njcm9sbGFibGVfc2V0KGFwcF9kYXRhLT51cmxfYmFyLCBFSU5BX1RSVUUpOworICAg
IGVsbV9lbnRyeV9zY3JvbGxiYXJfcG9saWN5X3NldChhcHBfZGF0YS0+dXJsX2JhciwgRUxNX1ND
Uk9MTEVSX1BPTElDWV9PRkYsIEVMTV9TQ1JPTExFUl9QT0xJQ1lfT0ZGKTsKICAgICBlbG1fZW50
cnlfc2luZ2xlX2xpbmVfc2V0KGFwcF9kYXRhLT51cmxfYmFyLCBFSU5BX1RSVUUpOwogICAgIGVs
bV9lbnRyeV9jbnBfbW9kZV9zZXQoYXBwX2RhdGEtPnVybF9iYXIsIEVMTV9DTlBfTU9ERV9QTEFJ
TlRFWFQpOwogICAgIGVsbV9lbnRyeV90ZXh0X3N0eWxlX3VzZXJfcHVzaChhcHBfZGF0YS0+dXJs
X2JhciwgIkRFRkFVTFQ9J2ZvbnRfc2l6ZT0xOCciKTsKQEAgLTY1Nyw2ICs2OTcsNyBAQCBzdGF0
aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRvd19jcmVhdGUoY29uc3QgY2hhciAqdXJsKQogICAgIGV2
YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2Fk
LGZhaWxlZCIsIG9uX2Rvd25sb2FkX2ZhaWxlZCwgYXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0
X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImRvd25sb2FkLGZpbmlzaGVk
Iiwgb25fZG93bmxvYWRfZmluaXNoZWQsIGFwcF9kYXRhKTsKICAgICBldmFzX29iamVjdF9zbWFy
dF9jYWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJkb3dubG9hZCxyZXF1ZXN0Iiwgb25f
ZG93bmxvYWRfcmVxdWVzdCwgYXBwX2RhdGEpOworICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxi
YWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImljb24sY2hhbmdlZCIsIG9uX3ZpZXdfaWNvbl9j
aGFuZ2VkLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFw
cF9kYXRhLT53ZWJ2aWV3LCAibG9hZCxlcnJvciIsIG9uX2Vycm9yLCBhcHBfZGF0YSk7CiAgICAg
ZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAibG9hZCxw
cm9ncmVzcyIsIG9uX3Byb2dyZXNzLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmplY3Rfc21hcnRf
Y2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAidGl0bGUsY2hhbmdlZCIsIG9uX3RpdGxl
X2NoYW5nZWQsIGFwcF9kYXRhKTsK
</data>
<flag name="commit-queue"
          id="181954"
          type_id="3"
          status="-"
          setter="cdumez"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>168864</attachid>
            <date>2012-10-15 23:10:35 -0700</date>
            <delta_ts>2012-10-15 23:31:07 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>99265_minibrowser_favicons.patch</filename>
            <type>text/plain</type>
            <size>3901</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3ODA1
NzZkLi4xZjkwZDFiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMTUgIENocmlzdG9waGUgRHVtZXogIDxj
aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIERpc3BsYXkg
cGFnZSBmYXZpY29ucyBpbiBNaW5pQnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyNjUKKworICAgICAgICBSZXZpZXdlZCBieSBHeXV5b3Vu
ZyBLaW0uCisKKyAgICAgICAgRGlzcGxheSBjdXJyZW50IHBhZ2UgZmF2aWNvbiBpbiB0aGUgVVJM
IGJhci4KKyAgICAgICAgVGhpcyB1c2VzIHRoZSBuZXcgZmF2aWNvbiBkYXRhYmFzZSBBUEkgaW4K
KyAgICAgICAgRUZMIFdlYktpdDIuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5j
OgorICAgICAgICAob25fZmF2aWNvbl9yZWNlaXZlZCk6CisgICAgICAgIChvbl92aWV3X2ljb25f
Y2hhbmdlZCk6CisgICAgICAgICh3aW5kb3dfY3JlYXRlKToKKwogMjAxMi0xMC0xNSAgU2ltb24g
RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdGhlIHVy
bCBiYXIgaW4gTWluaUJyb3dzZXIgd2hlbiBnZXR0aW5nIHRoZSBjb21taXR0ZWQgVVJMCmRpZmYg
LS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIv
ZWZsL21haW4uYwppbmRleCA4ZjUwNTdmLi43MTc5NmRlIDEwMDY0NAotLS0gYS9Ub29scy9NaW5p
QnJvd3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAg
LTMyMiw2ICszMjIsNDUgQEAgb25fZG93bmxvYWRfZmFpbGVkKHZvaWQgKnVzZXJfZGF0YSwgRXZh
c19PYmplY3QgKndlYnZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiAgICAgaW5mbygiRG93bmxvYWQg
ZmFpbGVkIVxuIik7CiB9CiAKK3N0YXRpYyB2b2lkCitvbl9mYXZpY29uX3JlY2VpdmVkKGNvbnN0
IGNoYXIgKnBhZ2VfdXJsLCBFdmFzX09iamVjdCAqaWNvbiwgdm9pZCAqZXZlbnRfaW5mbykKK3sK
KyAgICBCcm93c2VyX1dpbmRvdyAqYXBwX2RhdGEgPSAoQnJvd3Nlcl9XaW5kb3cgKilldmVudF9p
bmZvOworICAgIGlmIChzdHJjbXAocGFnZV91cmwsIGV3a192aWV3X3VybF9nZXQoYXBwX2RhdGEt
PndlYnZpZXcpKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgLyogUmVtb3ZlIHByZXZpb3VzIGlj
b24gZnJvbSBVUkwgYmFyICovCisgICAgRXZhc19PYmplY3QgKm9sZF9pY29uID0gZWxtX29iamVj
dF9wYXJ0X2NvbnRlbnRfdW5zZXQoYXBwX2RhdGEtPnVybF9iYXIsICJpY29uIik7CisgICAgaWYg
KG9sZF9pY29uKSB7CisgICAgICAgIGV2YXNfb2JqZWN0X3VucmVmKG9sZF9pY29uKTsKKyAgICAg
ICAgZXZhc19vYmplY3RfZGVsKG9sZF9pY29uKTsKKyAgICB9CisKKyAgICAvKiBTaG93IG5ldyBp
Y29uIGluIFVSTCBiYXIgKi8KKyAgICBpZiAoaWNvbikgeworICAgICAgICAvKiBXb3JrYXJvdW5k
IGZvciBpY29uIGRpc3BsYXkgYnVnOgorICAgICAgICAgKiBodHRwOi8vdHJhYy5lbmxpZ2h0ZW5t
ZW50Lm9yZy9lL3RpY2tldC8xNjE2ICovCisgICAgICAgIGV2YXNfb2JqZWN0X3NpemVfaGludF9t
aW5fc2V0KGljb24sIDQ4LCAyNCk7CisgICAgICAgIGV2YXNfb2JqZWN0X2ltYWdlX2ZpbGxlZF9z
ZXQoaWNvbiwgRUlOQV9GQUxTRSk7CisgICAgICAgIGV2YXNfb2JqZWN0X2ltYWdlX2ZpbGxfc2V0
KGljb24sIDI0LCAwLCAyNCwgMjQpOworICAgICAgICBlbG1fb2JqZWN0X3BhcnRfY29udGVudF9z
ZXQoYXBwX2RhdGEtPnVybF9iYXIsICJpY29uIiwgaWNvbik7CisgICAgICAgIGV2YXNfb2JqZWN0
X3JlZihpY29uKTsKKyAgICB9Cit9CisKK3N0YXRpYyB2b2lkCitvbl92aWV3X2ljb25fY2hhbmdl
ZCh2b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICp3ZWJ2aWV3LCB2b2lkICpldmVudF9pbmZv
KQoreworICAgIEJyb3dzZXJfV2luZG93ICphcHBfZGF0YSA9IChCcm93c2VyX1dpbmRvdyAqKXVz
ZXJfZGF0YTsKKyAgICAvKiBSZXRyaWV2ZSB0aGUgdmlldydzIGZhdmljb24gKi8KKyAgICBFd2tf
Q29udGV4dCAqY29udGV4dCA9IGV3a192aWV3X2NvbnRleHRfZ2V0KHdlYnZpZXcpOworICAgIEV3
a19GYXZpY29uX0RhdGFiYXNlICppY29uX2RhdGFiYXNlID0gZXdrX2NvbnRleHRfZmF2aWNvbl9k
YXRhYmFzZV9nZXQoY29udGV4dCk7CisKKyAgICBjb25zdCBjaGFyICpwYWdlX3VybCA9IGV3a192
aWV3X3VybF9nZXQod2Vidmlldyk7CisgICAgRXZhcyAqZXZhcyA9IGV2YXNfb2JqZWN0X2V2YXNf
Z2V0KHdlYnZpZXcpOworICAgIGV3a19mYXZpY29uX2RhdGFiYXNlX2FzeW5jX2ljb25fZ2V0KGlj
b25fZGF0YWJhc2UsIHBhZ2VfdXJsLCBldmFzLCBvbl9mYXZpY29uX3JlY2VpdmVkLCBhcHBfZGF0
YSk7Cit9CisKIHN0YXRpYyBpbnQKIHF1aXQoRWluYV9Cb29sIHN1Y2Nlc3MsIGNvbnN0IGNoYXIg
Km1zZykKIHsKQEAgLTYxMCw2ICs2NDksNyBAQCBzdGF0aWMgQnJvd3Nlcl9XaW5kb3cgKndpbmRv
d19jcmVhdGUoY29uc3QgY2hhciAqdXJsKQogICAgIC8qIENyZWF0ZSBVUkwgYmFyICovCiAgICAg
YXBwX2RhdGEtPnVybF9iYXIgPSBlbG1fZW50cnlfYWRkKGFwcF9kYXRhLT53aW5kb3cpOwogICAg
IGVsbV9lbnRyeV9zY3JvbGxhYmxlX3NldChhcHBfZGF0YS0+dXJsX2JhciwgRUlOQV9UUlVFKTsK
KyAgICBlbG1fZW50cnlfc2Nyb2xsYmFyX3BvbGljeV9zZXQoYXBwX2RhdGEtPnVybF9iYXIsIEVM
TV9TQ1JPTExFUl9QT0xJQ1lfT0ZGLCBFTE1fU0NST0xMRVJfUE9MSUNZX09GRik7CiAgICAgZWxt
X2VudHJ5X3NpbmdsZV9saW5lX3NldChhcHBfZGF0YS0+dXJsX2JhciwgRUlOQV9UUlVFKTsKICAg
ICBlbG1fZW50cnlfY25wX21vZGVfc2V0KGFwcF9kYXRhLT51cmxfYmFyLCBFTE1fQ05QX01PREVf
UExBSU5URVhUKTsKICAgICBlbG1fZW50cnlfdGV4dF9zdHlsZV91c2VyX3B1c2goYXBwX2RhdGEt
PnVybF9iYXIsICJERUZBVUxUPSdmb250X3NpemU9MTgnIik7CkBAIC02NTcsNiArNjk3LDcgQEAg
c3RhdGljIEJyb3dzZXJfV2luZG93ICp3aW5kb3dfY3JlYXRlKGNvbnN0IGNoYXIgKnVybCkKICAg
ICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJkb3du
bG9hZCxmYWlsZWQiLCBvbl9kb3dubG9hZF9mYWlsZWQsIGFwcF9kYXRhKTsKICAgICBldmFzX29i
amVjdF9zbWFydF9jYWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJkb3dubG9hZCxmaW5p
c2hlZCIsIG9uX2Rvd25sb2FkX2ZpbmlzaGVkLCBhcHBfZGF0YSk7CiAgICAgZXZhc19vYmplY3Rf
c21hcnRfY2FsbGJhY2tfYWRkKGFwcF9kYXRhLT53ZWJ2aWV3LCAiZG93bmxvYWQscmVxdWVzdCIs
IG9uX2Rvd25sb2FkX3JlcXVlc3QsIGFwcF9kYXRhKTsKKyAgICBldmFzX29iamVjdF9zbWFydF9j
YWxsYmFja19hZGQoYXBwX2RhdGEtPndlYnZpZXcsICJpY29uLGNoYW5nZWQiLCBvbl92aWV3X2lj
b25fY2hhbmdlZCwgYXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2Fk
ZChhcHBfZGF0YS0+d2VidmlldywgImxvYWQsZXJyb3IiLCBvbl9lcnJvciwgYXBwX2RhdGEpOwog
ICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgImxv
YWQscHJvZ3Jlc3MiLCBvbl9wcm9ncmVzcywgYXBwX2RhdGEpOwogICAgIGV2YXNfb2JqZWN0X3Nt
YXJ0X2NhbGxiYWNrX2FkZChhcHBfZGF0YS0+d2VidmlldywgInRpdGxlLGNoYW5nZWQiLCBvbl90
aXRsZV9jaGFuZ2VkLCBhcHBfZGF0YSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>