<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>99256</bug_id>
          
          <creation_ts>2012-10-13 19:09:13 -0700</creation_ts>
          <short_desc>Use class extension rather than a void* member for new Objective-C WebProcessPlugIn SPI</short_desc>
          <delta_ts>2012-10-13 19:21:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sam Weinig">sam</reporter>
          <assigned_to name="Sam Weinig">sam</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>741535</commentid>
    <comment_count>0</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-10-13 19:09:13 -0700</bug_when>
    <thetext>Use class extension rather than a void* member for new Objective-C WebProcessPlugIn SPI</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>741536</commentid>
    <comment_count>1</comment_count>
      <attachid>168571</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-10-13 19:14:36 -0700</bug_when>
    <thetext>Created attachment 168571
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>741537</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-10-13 19:16:41 -0700</bug_when>
    <thetext>Attachment 168571 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebKit2/ChangeLog&apos;, u&apos;Source/WebKit...&quot; exit_code: 1
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:30:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:30:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>741538</commentid>
    <comment_count>3</comment_count>
      <attachid>168571</attachid>
    <who name="">mitz</who>
    <bug_when>2012-10-13 19:17:37 -0700</bug_when>
    <thetext>Comment on attachment 168571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=168571&amp;action=review

&gt; Source/WebKit2/ChangeLog:8
&gt; +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

:\</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>741539</commentid>
    <comment_count>4</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-10-13 19:20:35 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; (From update of attachment 168571 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=168571&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:8
&gt; &gt; +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
&gt; 
&gt; :\

:(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>741540</commentid>
    <comment_count>5</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2012-10-13 19:21:30 -0700</bug_when>
    <thetext>Committed r131264: &lt;http://trac.webkit.org/changeset/131264&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>168571</attachid>
            <date>2012-10-13 19:14:36 -0700</date>
            <delta_ts>2012-10-13 19:17:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99256-20121013191318.patch</filename>
            <type>text/plain</type>
            <size>13115</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggM2YzOTJlMWFjMzg3MTlk
MTFlZGE4YjgwNzQ2YzRmZmEzZGRkYzIyMC4uMzY5NjNiNTE2MWYyZTE2MDA1NTNlY2M5N2U2OGJm
M2RmMzQ3ZWUzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQwIEBACisyMDEyLTEwLTEzICBTYW0g
V2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXNlIGNsYXNzIGV4dGVuc2lvbiBy
YXRoZXIgdGhhbiBhIHZvaWQqIG1lbWJlciBmb3IgbmV3IE9iamVjdGl2ZS1DIFdlYlByb2Nlc3NQ
bHVnSW4gU1BJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD05OTI1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkZGl0aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCBy
YXRpb25hbGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09Q
UyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2Vi
UHJvY2Vzc1BsdWdJbi5oOgorICAgICAgICBSZW1vdmUgdGhlIHZvaWQqIG1lbWJlci4KKworICAg
ICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQbHVn
SW4ubW06CisgICAgICAgIE1vdmUgbWVtYmVycyBmcm9tIHRoZSBXS1dlYlByb2Nlc3NQbHVnSW5D
b250cm9sbGVyRGF0YSBzdHJ1Y3QgdG8gYSBjbGFzcyBleHRlbnNpb24uCisKKyAgICAgICAgKGRp
ZENyZWF0ZVBhZ2UpOgorICAgICAgICAod2lsbERlc3Ryb3lQYWdlKToKKyAgICAgICAgKC1bV0tX
ZWJQcm9jZXNzUGx1Z0luQ29udHJvbGxlciBfaW5pdFdpdGhQcmluY2lwYWxDbGFzc0luc3RhbmNl
OmJ1bmRsZVJlZjpdKToKKyAgICAgICAgRGlyZWN0bHkgYWNjZXNzIHRoZSBtZW1iZXJzIGluc3Rl
YWQgb2YgdXNpbmcgcHJvcGVydGllcywgbm93IHRoYXQgaXQgaXMgbm90IGluY29udmVuaWVudC4K
KworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nl
c3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIuaDoKKyAgICAgICAgUmVtb3ZlIHRoZSB2
b2lkKiBtZW1iZXIuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9t
YWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyLm1tOgorICAgICAg
ICBNb3ZlIG1lbWJlcnMgZnJvbSB0aGUgV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRD
b250cm9sbGVyRGF0YSBzdHJ1Y3QgdG8gYSBjbGFzcyBleHRlbnNpb24uCisgICAgICAgIAorICAg
ICAgICAoLVtXS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIgX2luaXRX
aXRoQnVuZGxlUGFnZVJlZjpdKToKKyAgICAgICAgKC1bV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3Nl
ckNvbnRleHRDb250cm9sbGVyIF9idW5kbGVQYWdlUmVmXSk6CisgICAgICAgIFJlbW92ZSB1bm5l
Y2Vzc2FyeSBjYXN0cy4uCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ
SS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVySW50ZXJuYWwu
aDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9j
ZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyUHJpdmF0ZS5oOgorICAgICAgICBBZGQg
c3BhY2UgYmVmb3JlIHRoZSBwYXJlbnRoZXNpcyBvZiBhIGNhdGVnb3J5IHRvIGJlIGNvbnNpc3Rl
bnQuCisgCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2Vi
UHJvY2Vzc1BsdWdJbkludGVybmFsLmg6CisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSBmb3J3
YXJkIGRlY2xhcmUuCisKIDIwMTItMTAtMTMgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29t
PgogCiAgICAgICAgIEFkZCBhIHByaXZhdGUgaGVhZGVyIGZvciBXS1dlYlByb2Nlc3NQbHVnSW5C
cm93c2VyQ29udGV4dENvbnRyb2xsZXIgdGhhdCBkZWZpbmVzIGEgcHJvcGVydHkgZm9yIGdldHRp
bmcgdGhlIFdLQnVuZGxlUGFnZVJlZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv
Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1BsdWdJbi5oIGIvU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1Bs
dWdJbi5oCmluZGV4IDM4Y2JjOTM4MDFlMzA1N2YwZTA3NzFjMTM0MmY1NDA0YzY4ZTI5MWQuLjRh
N2NjNTBhNjYxOTI0Yjc2NDA2MzViYzkzMjQ3NWU5YzM2MTZlMTUgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQ
bHVnSW4uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ
SS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luLmgKQEAgLTM5LDExICszOSw3IEBACiBAZW5kCiAKIFdL
X0VYUE9SVAotQGludGVyZmFjZSBXS1dlYlByb2Nlc3NQbHVnSW5Db250cm9sbGVyIDogTlNPYmpl
Y3QgewotQHByaXZhdGUKLSAgICB2b2lkICpfcHJpdmF0ZTsKLX0KLQorQGludGVyZmFjZSBXS1dl
YlByb2Nlc3NQbHVnSW5Db250cm9sbGVyIDogTlNPYmplY3QKIEBlbmQKIAogI2VuZGlmIC8vIGRl
ZmluZWQoX19MUDY0X18pICYmIGRlZmluZWQoX19jbGFuZ19fKQpkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1Bs
dWdJbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21h
Yy9XS1dlYlByb2Nlc3NQbHVnSW4ubW0KaW5kZXggZGZjNGE3YzBkZWNkZWZkMzE2MGIyYzE3YjIy
YmE2N2ViZGFmMzIzMS4uZDk2N2VjMjliNzQ2NGI5MGFlNmIzZWNkNGZmZmQ3MjdlMzUwYjkxZSAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkv
bWFjL1dLV2ViUHJvY2Vzc1BsdWdJbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz
L0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luLm1tCkBAIC0zOSwzMyAr
MzksMjUgQEAKIAogdHlwZWRlZiBIYXNoTWFwPFdLQnVuZGxlUGFnZVJlZiwgUmV0YWluUHRyPFdL
V2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlciAqPiA+IEJ1bmRsZVBhZ2VX
cmFwcGVyQ2FjaGU7CiAKLXN0cnVjdCBXS1dlYlByb2Nlc3NQbHVnSW5Db250cm9sbGVyRGF0YSB7
CitAaW50ZXJmYWNlIFdLV2ViUHJvY2Vzc1BsdWdJbkNvbnRyb2xsZXIgKCkgewogICAgIFJldGFp
blB0cjxpZDxXS1dlYlByb2Nlc3NQbHVnSW4+ID4gX3ByaW5jaXBhbENsYXNzSW5zdGFuY2U7CiAg
ICAgV0tSZXRhaW5QdHI8V0tCdW5kbGVSZWY+IF9idW5kbGVSZWY7CiAgICAgQnVuZGxlUGFnZVdy
YXBwZXJDYWNoZSBfYnVuZGxlUGFnZVdyYXBwZXJDYWNoZTsKLX07Ci0KLUBpbnRlcmZhY2UgV0tX
ZWJQcm9jZXNzUGx1Z0luQ29udHJvbGxlciAoKQotCi1AcHJvcGVydHkocmVhZG9ubHkpIGlkPFdL
V2ViUHJvY2Vzc1BsdWdJbj4gX3ByaW5jaXBhbENsYXNzSW5zdGFuY2U7Ci1AcHJvcGVydHkocmVh
ZG9ubHkpIFdLQnVuZGxlUmVmIF9idW5kbGVSZWY7Ci1AcHJvcGVydHkocmVhZG9ubHkpIEJ1bmRs
ZVBhZ2VXcmFwcGVyQ2FjaGUmIF9idW5kbGVQYWdlV3JhcHBlckNhY2hlOwotCit9CiBAZW5kCiAK
LQogQGltcGxlbWVudGF0aW9uIFdLV2ViUHJvY2Vzc1BsdWdJbkNvbnRyb2xsZXIgKEludGVybmFs
KQogCiBzdGF0aWMgdm9pZCBkaWRDcmVhdGVQYWdlKFdLQnVuZGxlUmVmIGJ1bmRsZSwgV0tCdW5k
bGVQYWdlUmVmIHBhZ2UsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CiAgICAgV0tXZWJQcm9j
ZXNzUGx1Z0luQ29udHJvbGxlciAqcGx1Z0luQ29udHJvbGxlciA9IChXS1dlYlByb2Nlc3NQbHVn
SW5Db250cm9sbGVyICopY2xpZW50SW5mbzsKLSAgICBpZDxXS1dlYlByb2Nlc3NQbHVnSW4+IHBy
aW5jaXBhbENsYXNzSW5zdGFuY2UgPSBwbHVnSW5Db250cm9sbGVyLl9wcmluY2lwYWxDbGFzc0lu
c3RhbmNlOworICAgIGlkPFdLV2ViUHJvY2Vzc1BsdWdJbj4gcHJpbmNpcGFsQ2xhc3NJbnN0YW5j
ZSA9IHBsdWdJbkNvbnRyb2xsZXItPl9wcmluY2lwYWxDbGFzc0luc3RhbmNlLmdldCgpOwogCiAg
ICAgaWYgKFtwcmluY2lwYWxDbGFzc0luc3RhbmNlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0
b3Iod2ViUHJvY2Vzc1BsdWdJbjpkaWRDcmVhdGVCcm93c2VyQ29udGV4dENvbnRyb2xsZXI6KV0p
IHsKLSAgICAgICAgQVNTRVJUKCFwbHVnSW5Db250cm9sbGVyLl9idW5kbGVQYWdlV3JhcHBlckNh
Y2hlLmNvbnRhaW5zKHBhZ2UpKTsKKyAgICAgICAgQVNTRVJUKCFwbHVnSW5Db250cm9sbGVyLT5f
YnVuZGxlUGFnZVdyYXBwZXJDYWNoZS5jb250YWlucyhwYWdlKSk7CiAKICAgICAgICAgV0tXZWJQ
cm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyKiBicm93c2VyQ29udGV4dENvbnRy
b2xsZXIgPSBbW1dLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlciBhbGxv
Y10gX2luaXRXaXRoQnVuZGxlUGFnZVJlZjpwYWdlXTsKLSAgICAgICAgcGx1Z0luQ29udHJvbGxl
ci5fYnVuZGxlUGFnZVdyYXBwZXJDYWNoZS5zZXQocGFnZSwgYnJvd3NlckNvbnRleHRDb250cm9s
bGVyKTsKKyAgICAgICAgcGx1Z0luQ29udHJvbGxlci0+X2J1bmRsZVBhZ2VXcmFwcGVyQ2FjaGUu
c2V0KHBhZ2UsIGJyb3dzZXJDb250ZXh0Q29udHJvbGxlcik7CiAKICAgICAgICAgW3ByaW5jaXBh
bENsYXNzSW5zdGFuY2Ugd2ViUHJvY2Vzc1BsdWdJbjpwbHVnSW5Db250cm9sbGVyIGRpZENyZWF0
ZUJyb3dzZXJDb250ZXh0Q29udHJvbGxlcjpicm93c2VyQ29udGV4dENvbnRyb2xsZXJdOwogICAg
IH0KQEAgLTc0LDEyICs2NiwxMiBAQCBzdGF0aWMgdm9pZCBkaWRDcmVhdGVQYWdlKFdLQnVuZGxl
UmVmIGJ1bmRsZSwgV0tCdW5kbGVQYWdlUmVmIHBhZ2UsIGNvbnN0IHZvaWQqCiBzdGF0aWMgdm9p
ZCB3aWxsRGVzdHJveVBhZ2UoV0tCdW5kbGVSZWYgYnVuZGxlLCBXS0J1bmRsZVBhZ2VSZWYgcGFn
ZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIHsKICAgICBXS1dlYlByb2Nlc3NQbHVnSW5Db250
cm9sbGVyICpwbHVnSW5Db250cm9sbGVyID0gKFdLV2ViUHJvY2Vzc1BsdWdJbkNvbnRyb2xsZXIg
KiljbGllbnRJbmZvOwotICAgIGlkPFdLV2ViUHJvY2Vzc1BsdWdJbj4gcHJpbmNpcGFsQ2xhc3NJ
bnN0YW5jZSA9IHBsdWdJbkNvbnRyb2xsZXIuX3ByaW5jaXBhbENsYXNzSW5zdGFuY2U7CisgICAg
aWQ8V0tXZWJQcm9jZXNzUGx1Z0luPiBwcmluY2lwYWxDbGFzc0luc3RhbmNlID0gcGx1Z0luQ29u
dHJvbGxlci0+X3ByaW5jaXBhbENsYXNzSW5zdGFuY2UuZ2V0KCk7CiAKICAgICAvLyBJZiB3ZSBu
ZXZlciBhZGRlZCB0aGUgYnVuZGxlIHBhZ2UgdG8gdGhlIGNhY2hlLCB3aGljaCBjYW4gaGFwcGVu
IGlmIHdlYlByb2Nlc3NQbHVnSW46ZGlkQ3JlYXRlQnJvd3NlckNvbnRleHRDb250cm9sbGVyOiBp
cyBub3QgaW1wbGVtZW50ZWQsCiAgICAgLy8gdGhlcmUgaXMgbm8gcmVhc29uIHRvIGNhbGwgd2Vi
UHJvY2Vzc1BsdWdJbjp3aWxsRGVzdHJveUJyb3dzZXJDb250ZXh0Q29udHJvbGxlcjosIHNvIGRv
bid0LgotICAgIEJ1bmRsZVBhZ2VXcmFwcGVyQ2FjaGU6Oml0ZXJhdG9yIGl0ID0gcGx1Z0luQ29u
dHJvbGxlci5fYnVuZGxlUGFnZVdyYXBwZXJDYWNoZS5maW5kKHBhZ2UpOwotICAgIGlmIChpdCA9
PSBwbHVnSW5Db250cm9sbGVyLl9idW5kbGVQYWdlV3JhcHBlckNhY2hlLmVuZCgpKSB7CisgICAg
QnVuZGxlUGFnZVdyYXBwZXJDYWNoZTo6aXRlcmF0b3IgaXQgPSBwbHVnSW5Db250cm9sbGVyLT5f
YnVuZGxlUGFnZVdyYXBwZXJDYWNoZS5maW5kKHBhZ2UpOworICAgIGlmIChpdCA9PSBwbHVnSW5D
b250cm9sbGVyLT5fYnVuZGxlUGFnZVdyYXBwZXJDYWNoZS5lbmQoKSkgewogICAgICAgICBBU1NF
UlQoIVtwcmluY2lwYWxDbGFzc0luc3RhbmNlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Io
d2ViUHJvY2Vzc1BsdWdJbjpkaWRDcmVhdGVCcm93c2VyQ29udGV4dENvbnRyb2xsZXI6KV0pOwog
ICAgICAgICByZXR1cm47CiAgICAgfQpAQCAtODcsNyArNzksNyBAQCBzdGF0aWMgdm9pZCB3aWxs
RGVzdHJveVBhZ2UoV0tCdW5kbGVSZWYgYnVuZGxlLCBXS0J1bmRsZVBhZ2VSZWYgcGFnZSwgY29u
c3Qgdm9pZAogICAgIGlmIChbcHJpbmNpcGFsQ2xhc3NJbnN0YW5jZSByZXNwb25kc1RvU2VsZWN0
b3I6QHNlbGVjdG9yKHdlYlByb2Nlc3NQbHVnSW46d2lsbERlc3Ryb3lCcm93c2VyQ29udGV4dENv
bnRyb2xsZXI6KV0pCiAgICAgICAgIFtwcmluY2lwYWxDbGFzc0luc3RhbmNlIHdlYlByb2Nlc3NQ
bHVnSW46cGx1Z0luQ29udHJvbGxlciB3aWxsRGVzdHJveUJyb3dzZXJDb250ZXh0Q29udHJvbGxl
cjppdC0+dmFsdWUuZ2V0KCldOwogCi0gICAgcGx1Z0luQ29udHJvbGxlci5fYnVuZGxlUGFnZVdy
YXBwZXJDYWNoZS5yZW1vdmUoaXQpOworICAgIHBsdWdJbkNvbnRyb2xsZXItPl9idW5kbGVQYWdl
V3JhcHBlckNhY2hlLnJlbW92ZShpdCk7CiB9CiAKIHN0YXRpYyB2b2lkIHNldFVwQnVuZGxlQ2xp
ZW50KFdLV2ViUHJvY2Vzc1BsdWdJbkNvbnRyb2xsZXIgKnBsdWdJbkNvbnRyb2xsZXIsIFdLQnVu
ZGxlUmVmIGJ1bmRsZVJlZikKQEAgLTExNyw5ICsxMDksOCBAQCBzdGF0aWMgV0tXZWJQcm9jZXNz
UGx1Z0luQ29udHJvbGxlciAqc2hhcmVkSW5zdGFuY2U7CiAgICAgaWYgKCFzZWxmKQogICAgICAg
ICByZXR1cm4gbmlsOwogCi0gICAgX3ByaXZhdGUgPSBuZXcgV0tXZWJQcm9jZXNzUGx1Z0luQ29u
dHJvbGxlckRhdGE7Ci0gICAgc3RhdGljX2Nhc3Q8V0tXZWJQcm9jZXNzUGx1Z0luQ29udHJvbGxl
ckRhdGEqPihfcHJpdmF0ZSktPl9wcmluY2lwYWxDbGFzc0luc3RhbmNlID0gcHJpbmNpcGFsQ2xh
c3NJbnN0YW5jZTsKLSAgICBzdGF0aWNfY2FzdDxXS1dlYlByb2Nlc3NQbHVnSW5Db250cm9sbGVy
RGF0YSo+KF9wcml2YXRlKS0+X2J1bmRsZVJlZiA9IGJ1bmRsZVJlZjsKKyAgICBfcHJpbmNpcGFs
Q2xhc3NJbnN0YW5jZSA9IHByaW5jaXBhbENsYXNzSW5zdGFuY2U7CisgICAgX2J1bmRsZVJlZiA9
IGJ1bmRsZVJlZjsKIAogICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoIXNoYXJlZEluc3RhbmNlLCAi
V0tXZWJQcm9jZXNzUGx1Z0luQ29udHJvbGxlciBpbml0aWFsaXplZCBtdWx0aXBsZSB0aW1lcy4i
KTsKICAgICBzaGFyZWRJbnN0YW5jZSA9IHNlbGY7CkBAIC0xMjksMzEgKzEyMCwxMCBAQCBzdGF0
aWMgV0tXZWJQcm9jZXNzUGx1Z0luQ29udHJvbGxlciAqc2hhcmVkSW5zdGFuY2U7CiAgICAgcmV0
dXJuIHNlbGY7CiB9CiAKLS0gKHZvaWQpZGVhbGxvYwotewotICAgIGRlbGV0ZSBzdGF0aWNfY2Fz
dDxXS1dlYlByb2Nlc3NQbHVnSW5Db250cm9sbGVyRGF0YSo+KF9wcml2YXRlKTsKLSAgICBbc3Vw
ZXIgZGVhbGxvY107Ci19Ci0KIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdLV2ViUHJvY2Vzc1Bs
dWdJbkNvbnRyb2xsZXIKIAotLSAoaWQ8V0tXZWJQcm9jZXNzUGx1Z0luPilfcHJpbmNpcGFsQ2xh
c3NJbnN0YW5jZQotewotICAgIHJldHVybiBzdGF0aWNfY2FzdDxXS1dlYlByb2Nlc3NQbHVnSW5D
b250cm9sbGVyRGF0YSo+KF9wcml2YXRlKS0+X3ByaW5jaXBhbENsYXNzSW5zdGFuY2UuZ2V0KCk7
Ci19Ci0KLS0gKFdLQnVuZGxlUmVmKV9idW5kbGVSZWYKLXsKLSAgICByZXR1cm4gc3RhdGljX2Nh
c3Q8V0tXZWJQcm9jZXNzUGx1Z0luQ29udHJvbGxlckRhdGEqPihfcHJpdmF0ZSktPl9idW5kbGVS
ZWYuZ2V0KCk7Ci19Ci0KLS0gKEJ1bmRsZVBhZ2VXcmFwcGVyQ2FjaGUmKV9idW5kbGVQYWdlV3Jh
cHBlckNhY2hlCi17Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PFdLV2ViUHJvY2Vzc1BsdWdJbkNv
bnRyb2xsZXJEYXRhKj4oX3ByaXZhdGUpLT5fYnVuZGxlUGFnZVdyYXBwZXJDYWNoZTsKLX0KLQog
QGVuZAogCiAjZW5kaWYgLy8gZGVmaW5lZChfX0xQNjRfXykgJiYgZGVmaW5lZChfX2NsYW5nX18p
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQ
SS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyLmggYi9Tb3Vy
Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNz
UGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyLmgKaW5kZXggYjY1Nzg0ZjU0MGNiMjhiNjZl
MjU1ZGRlYTcyNjZiMmFmZmNkZmYyMi4uNWEwZGI4ZDA1ZTAxZjAzODU3NTNmN2ZmYTliZGUzY2Rh
YzRkNTNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1
bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlci5o
CisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9X
S1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIuaApAQCAtMzEsMTAgKzMx
LDcgQEAKIEBjbGFzcyBXS0RPTURvY3VtZW50OwogCiBXS19FWFBPUlQKLUBpbnRlcmZhY2UgV0tX
ZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyIDogTlNPYmplY3QgewotQHBy
aXZhdGUKLSAgICB2b2lkICpfZGF0YTsKLX0KK0BpbnRlcmZhY2UgV0tXZWJQcm9jZXNzUGx1Z0lu
QnJvd3NlckNvbnRleHRDb250cm9sbGVyIDogTlNPYmplY3QKIAogQHByb3BlcnR5KHJlYWRvbmx5
KSBXS0RPTURvY3VtZW50ICptYWluRnJhbWVEb2N1bWVudDsKIApkaWZmIC0tZ2l0IGEvU291cmNl
L1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vzc1Bs
dWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl
c3MvSW5qZWN0ZWRCdW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4
dENvbnRyb2xsZXIubW0KaW5kZXggODZhNGY0NDAxMTYyZGFiMjg1YzkzZDNiOTE3YzA2NTQzMjQy
NzU5OS4uM2QzOWJlMDMzNzg5ZWJkZGQ5NGNmMWNkMzYwYjg0MDIwYzYwMTk1YiAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2Vi
UHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2Vi
S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0lu
QnJvd3NlckNvbnRleHRDb250cm9sbGVyLm1tCkBAIC00MCwxMCArNDAsMTEgQEAKICNpbXBvcnQg
PFdlYkNvcmUvRG9jdW1lbnQuaD4KICNpbXBvcnQgPFdlYkNvcmUvRnJhbWUuaD4KIAotc3RydWN0
IFdLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlckRhdGEgeworQGludGVy
ZmFjZSBXS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIgKCkgewogICAg
IC8vIFVuZGVybHlpbmcgV0tCdW5kbGVQYWdlUmVmLgogICAgIFdLUmV0YWluUHRyPFdLQnVuZGxl
UGFnZVJlZj4gX2J1bmRsZVBhZ2VSZWY7Ci19OworfQorQGVuZAogCiBAaW1wbGVtZW50YXRpb24g
V0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyIChJbnRlcm5hbCkKIApA
QCAtNTMsMTggKzU0LDExIEBAIHN0cnVjdCBXS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4
dENvbnRyb2xsZXJEYXRhIHsKICAgICBpZiAoIXNlbGYpCiAgICAgICAgIHJldHVybiBuaWw7CiAK
LSAgICBfZGF0YSA9IG5ldyBXS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xs
ZXJEYXRhOwotICAgIHN0YXRpY19jYXN0PFdLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0
Q29udHJvbGxlckRhdGEqPihfZGF0YSktPl9idW5kbGVQYWdlUmVmID0gYnVuZGxlUGFnZVJlZjsK
KyAgICBfYnVuZGxlUGFnZVJlZiA9IGJ1bmRsZVBhZ2VSZWY7CiAKICAgICByZXR1cm4gc2VsZjsK
IH0KIAotLSAodm9pZClkZWFsbG9jCi17Ci0gICAgZGVsZXRlIHN0YXRpY19jYXN0PFdLV2ViUHJv
Y2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlckRhdGEqPihfZGF0YSk7Ci0gICAgW3N1
cGVyIGRlYWxsb2NdOwotfQotCiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXS1dlYlByb2Nlc3NQ
bHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIKQEAgLTgwLDExICs3NCwxMSBAQCBzdHJ1Y3Qg
V0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyRGF0YSB7CiAKIEBlbmQK
IAotQGltcGxlbWVudGF0aW9uIFdLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJv
bGxlcihQcml2YXRlKQorQGltcGxlbWVudGF0aW9uIFdLV2ViUHJvY2Vzc1BsdWdJbkJyb3dzZXJD
b250ZXh0Q29udHJvbGxlciAoUHJpdmF0ZSkKIAogLSAoV0tCdW5kbGVQYWdlUmVmKV9idW5kbGVQ
YWdlUmVmCiB7Ci0gICAgcmV0dXJuIHN0YXRpY19jYXN0PFdLV2ViUHJvY2Vzc1BsdWdJbkJyb3dz
ZXJDb250ZXh0Q29udHJvbGxlckRhdGEqPihfZGF0YSktPl9idW5kbGVQYWdlUmVmLmdldCgpOwor
ICAgIHJldHVybiBfYnVuZGxlUGFnZVJlZi5nZXQoKTsKIH0KIAogQGVuZApkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJv
Y2Vzc1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlckludGVybmFsLmggYi9Tb3VyY2UvV2Vi
S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0lu
QnJvd3NlckNvbnRleHRDb250cm9sbGVySW50ZXJuYWwuaAppbmRleCBkZDE1MmRhYWYzMTk5NGU2
ZGYxYjUwYzFiNTgzNzQwZTU4ZmMzODg4Li42MmYwNjIzOGFlZTFlOTI4MDgyZDA5YzVjY2EzOWM0
YTZmMjcwODNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVk
QnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVy
SW50ZXJuYWwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl
L0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVySW50ZXJu
YWwuaApAQCAtMjcsNyArMjcsNyBAQAogCiAjaW1wb3J0ICJXS1dlYlByb2Nlc3NQbHVnSW5Ccm93
c2VyQ29udGV4dENvbnRyb2xsZXIuaCIKIAotQGludGVyZmFjZSBXS1dlYlByb2Nlc3NQbHVnSW5C
cm93c2VyQ29udGV4dENvbnRyb2xsZXIoSW50ZXJuYWwpCitAaW50ZXJmYWNlIFdLV2ViUHJvY2Vz
c1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlciAoSW50ZXJuYWwpCiAKIC0gKGlkKV9pbml0
V2l0aEJ1bmRsZVBhZ2VSZWY6KFdLQnVuZGxlUGFnZVJlZilidW5kbGVQYWdlUmVmOwogCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMv
V0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyUHJpdmF0ZS5oIGIvU291
cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFjL1dLV2ViUHJvY2Vz
c1BsdWdJbkJyb3dzZXJDb250ZXh0Q29udHJvbGxlclByaXZhdGUuaAppbmRleCAwMWEyMGQ3MzI5
YjFhN2U4ZjgwNTE3NDczYWRhMTg4OWNkMmM4OWIwLi41OWFhYzEwOGNlODI1OWRkMzBiYjVjNDJh
NmU1YzQxMzUxNzk2ZmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0lu
amVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250
cm9sbGVyUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRC
dW5kbGUvQVBJL21hYy9XS1dlYlByb2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXJQ
cml2YXRlLmgKQEAgLTI3LDcgKzI3LDcgQEAKIAogI2ltcG9ydCA8V2ViS2l0Mi9XS1dlYlByb2Nl
c3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIuaD4KIAotQGludGVyZmFjZSBXS1dlYlBy
b2Nlc3NQbHVnSW5Ccm93c2VyQ29udGV4dENvbnRyb2xsZXIoUHJpdmF0ZSkKK0BpbnRlcmZhY2Ug
V0tXZWJQcm9jZXNzUGx1Z0luQnJvd3NlckNvbnRleHRDb250cm9sbGVyIChQcml2YXRlKQogCiBA
cHJvcGVydHkocmVhZG9ubHkpIFdLQnVuZGxlUGFnZVJlZiBfYnVuZGxlUGFnZVJlZjsKIApkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvbWFj
L1dLV2ViUHJvY2Vzc1BsdWdJbkludGVybmFsLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz
L0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luSW50ZXJuYWwuaAppbmRl
eCA1NmY1NGM4ZGI5Njk4ZjA3YWUwOTMyYmQ4MmQ2YzUwODdiMzdkODVlLi41OGIzY2MzZjc4MmIz
N2NmNTE3NjA4NjBjODhmMWU3MzNlZTAzNTY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9X
ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9tYWMvV0tXZWJQcm9jZXNzUGx1Z0luSW50ZXJu
YWwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9t
YWMvV0tXZWJQcm9jZXNzUGx1Z0luSW50ZXJuYWwuaApAQCAtMjcsMTAgKzI3LDYgQEAKIAogI2lt
cG9ydCAiV0tXZWJQcm9jZXNzUGx1Z0luLmgiCiAKLW5hbWVzcGFjZSBXZWJLaXQgewotY2xhc3Mg
SW5qZWN0ZWRCdW5kbGU7Ci19Ci0KIEBpbnRlcmZhY2UgV0tXZWJQcm9jZXNzUGx1Z0luQ29udHJv
bGxlciAoSW50ZXJuYWwpCiAKICsgKFdLV2ViUHJvY2Vzc1BsdWdJbkNvbnRyb2xsZXIgKilfc2hh
cmVkOwo=
</data>
<flag name="review"
          id="181594"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>