<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>99243</bug_id>
          
          <creation_ts>2012-10-13 00:35:49 -0700</creation_ts>
          <short_desc>FEImage::m_document is never cleared. Why not?</short_desc>
          <delta_ts>2012-11-01 06:57:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>SVG</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adam Barth">abarth</reporter>
          <assigned_to name="Stephen Chenney">schenney</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>d-r</cc>
    
    <cc>eric</cc>
    
    <cc>fmalita</cc>
    
    <cc>inferno</cc>
    
    <cc>krit</cc>
    
    <cc>mjs</cc>
    
    <cc>pdr</cc>
    
    <cc>rniwa</cc>
    
    <cc>schenney</cc>
    
    <cc>senorblanco</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>741443</commentid>
    <comment_count>0</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-13 00:35:49 -0700</bug_when>
    <thetext>As far as I can tell, there&apos;s no mechanism for clearing FEImage::m_document after the Document has been destroyed.  Given that FEImage is RefCounted, it seems very likely that FEImage can be kept alive after the Document is destroyed.  I tried to chase down how we might be able to do that, but I got lost in SVG filter land.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742153</commentid>
    <comment_count>1</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-15 10:28:16 -0700</bug_when>
    <thetext>I&apos;m in that space now. It&apos;s a complete disaster area. I&apos;ll try to figure this one out too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742177</commentid>
    <comment_count>2</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-15 10:50:55 -0700</bug_when>
    <thetext>I don&apos;t think this is a problem. The document is only used when the filter is actually applied, and as far as I know you cannot apply a filter unless it is in the document. Furthermore, if the filter leaves the document the FilterEffect objects will be destroyed or marked dirty (forcing regeneration).

The RefCounted on such objects does not indicate that they are held outside of FilterData objects, rather it seems to be to simplify management of pointers in SVGFilterBuilder. The FEImage filter effect is SVG-only and is only held inside SVGFilterBuilder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742485</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-15 14:55:36 -0700</bug_when>
    <thetext>Thanks for investigating this issue!  Would you be willing to add a comment explaining this to the m_document declaration so that we won&apos;t get scared the next time we audit this code?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>742503</commentid>
    <comment_count>4</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-15 15:17:46 -0700</bug_when>
    <thetext>Reopened to comment appropriately.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>744522</commentid>
    <comment_count>5</comment_count>
      <attachid>169239</attachid>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-17 12:58:23 -0700</bug_when>
    <thetext>Created attachment 169239
Patch

Is this what you had in mind?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>744540</commentid>
    <comment_count>6</comment_count>
      <attachid>169239</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-10-17 13:14:03 -0700</bug_when>
    <thetext>Comment on attachment 169239
Patch

Yes, great.  I&apos;ll leave this patch for someone who can verify the comment to review.  Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754406</commentid>
    <comment_count>7</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-30 08:52:47 -0700</bug_when>
    <thetext>I added an assert to the destructor for the FEImage filter effect and verified that it is destructed when it&apos;s target is removed from the document. These tests demonstrate the behavior. The assert stacks show the FEImage being destructed whenever its target (the thing that will try to use it) is detached.

To summarize: Only a target renderer ever tries to use the m_document in the filter effect. When the target is added to the document the filter is created. When the target is removed from the document the filters are destroyed. JS cannot hold references to this data - it is entirely internal. Hence, there is no point at which a filter can exist without a valid document.

svg/filters/feImage-remove-target.svg
svg/filters/feImage-target-reappend-to-document.svg
svg/filters/feImage-target-remove-from-document.svg
svg/filters/feImage-target-add-to-document.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg

Is that sufficient verification to R+ the comment?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754444</commentid>
    <comment_count>8</comment_count>
    <who name="Dirk Schulze">krit</who>
    <bug_when>2012-10-30 09:36:36 -0700</bug_when>
    <thetext>If it is wrong, why not fixing it? The comment is not really helpful. Make this bug no security bug anymore and fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754455</commentid>
    <comment_count>9</comment_count>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2012-10-30 09:55:44 -0700</bug_when>
    <thetext>If this pointer is not actually a dangling reference hazard, then there is nothing to fix. I can see the value of adding a comment explaining that, so no one goes on a wild goose chase, but it seems a bit verbose for WebKit style. Is there a way to get the point across more concisely? I think the comment can just state that the pointer can&apos;t be used to access free memory despite never being cleared, without giving the full detailed explanation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754472</commentid>
    <comment_count>10</comment_count>
      <attachid>171475</attachid>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-30 10:10:07 -0700</bug_when>
    <thetext>Created attachment 171475
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754474</commentid>
    <comment_count>11</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-30 10:15:03 -0700</bug_when>
    <thetext>Maciej is right that this is never dangling and there&apos;s no point in fixing it. The only possible code change would be to explicitly set m_document to null before destroying the object, but there&apos;s no point at all in that.

I&apos;ve come up with a one line comment (a bit longer). Actually, it just occurred to me that I should reference this bug, so I&apos;ll give it another pass.

Also, there is no need for this to be a security issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754480</commentid>
    <comment_count>12</comment_count>
      <attachid>171478</attachid>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-30 10:17:30 -0700</bug_when>
    <thetext>Created attachment 171478
Patch

Much more concise, yet still informative.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754503</commentid>
    <comment_count>13</comment_count>
      <attachid>171478</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-10-30 10:44:23 -0700</bug_when>
    <thetext>Comment on attachment 171478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171478&amp;action=review

&gt; Source/WebCore/svg/graphics/filters/SVGFEImage.h:58
&gt; +    // m_document will never be a dangling reference. See https://bugs.webkit.org/show_bug.cgi?id=99243

Better justification would be to explain why here as well.  This is not an Element, so it doesn&apos;t keep the document alive.  I assume this is held off of a renderer?  Can this also be held off of a CSSValue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754516</commentid>
    <comment_count>14</comment_count>
      <attachid>171478</attachid>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-30 11:04:13 -0700</bug_when>
    <thetext>Comment on attachment 171478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171478&amp;action=review

&gt;&gt; Source/WebCore/svg/graphics/filters/SVGFEImage.h:58
&gt;&gt; +    // m_document will never be a dangling reference. See https://bugs.webkit.org/show_bug.cgi?id=99243
&gt; 
&gt; Better justification would be to explain why here as well.  This is not an Element, so it doesn&apos;t keep the document alive.  I assume this is held off of a renderer?  Can this also be held off of a CSSValue?

This object is only held by a SVGFilterBuilder which in turn is held by a RenderSVGResourceFilter::FilterData object, which in turn is held by a RenderSVGResourceFilter object which is a renderer. Nothing else at all holds references to FEImage. Any changes to CSS properties (including SVG attributes) that affect the filter cause the FilterData and hence FEImage object to be destroyed and recreated. CSS Filters cannot use SVGFEImage.

The only way that FEImage::m_document is used is to look up the renderer for the image it is drawing. It will only do that during applyResource, which is only called when the target for the filter (the thing that will draw it) is painted, which only happens if the target is in the document. If the target is in the document then FEImage::m_document is valid. If the target is not in the document then it both cannot be painted and there is no FEImage object to have a dangling reference.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754770</commentid>
    <comment_count>15</comment_count>
      <attachid>171478</attachid>
    <who name="Dirk Schulze">krit</who>
    <bug_when>2012-10-30 16:18:29 -0700</bug_when>
    <thetext>Comment on attachment 171478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171478&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        Adding a comment to explain why the failure to clear m_document is not a problem.

Please say that this will be refactored with another patch.

&gt;&gt;&gt; Source/WebCore/svg/graphics/filters/SVGFEImage.h:58
&gt;&gt;&gt; +    // m_document will never be a dangling reference. See https://bugs.webkit.org/show_bug.cgi?id=99243
&gt;&gt; 
&gt;&gt; Better justification would be to explain why here as well.  This is not an Element, so it doesn&apos;t keep the document alive.  I assume this is held off of a renderer?  Can this also be held off of a CSSValue?
&gt; 
&gt; This object is only held by a SVGFilterBuilder which in turn is held by a RenderSVGResourceFilter::FilterData object, which in turn is held by a RenderSVGResourceFilter object which is a renderer. Nothing else at all holds references to FEImage. Any changes to CSS properties (including SVG attributes) that affect the filter cause the FilterData and hence FEImage object to be destroyed and recreated. CSS Filters cannot use SVGFEImage.
&gt; 
&gt; The only way that FEImage::m_document is used is to look up the renderer for the image it is drawing. It will only do that during applyResource, which is only called when the target for the filter (the thing that will draw it) is painted, which only happens if the target is in the document. If the target is in the document then FEImage::m_document is valid. If the target is not in the document then it both cannot be painted and there is no FEImage object to have a dangling reference.

Please add a link to this bug report, and open the bug report after landing again. Can be dependent on your refactoring patch later. After refactoring you just close it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>754791</commentid>
    <comment_count>16</comment_count>
      <attachid>171478</attachid>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-10-30 16:47:04 -0700</bug_when>
    <thetext>Comment on attachment 171478
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171478&amp;action=review

&gt;&gt; Source/WebCore/ChangeLog:8
&gt;&gt; +        Adding a comment to explain why the failure to clear m_document is not a problem.
&gt; 
&gt; Please say that this will be refactored with another patch.

But it won&apos;t be refactored, at least not to my knowledge. The comment exists so that _if_ there is ever a patch that changes the behavior the patch author will know the situation. Or if anyone, like Adam, is doing a security review they will have context in which to understand why this is not a security problem.

&gt;&gt;&gt;&gt; Source/WebCore/svg/graphics/filters/SVGFEImage.h:58
&gt;&gt;&gt;&gt; +    // m_document will never be a dangling reference. See https://bugs.webkit.org/show_bug.cgi?id=99243
&gt;&gt;&gt; 
&gt;&gt;&gt; Better justification would be to explain why here as well.  This is not an Element, so it doesn&apos;t keep the document alive.  I assume this is held off of a renderer?  Can this also be held off of a CSSValue?
&gt;&gt; 
&gt;&gt; This object is only held by a SVGFilterBuilder which in turn is held by a RenderSVGResourceFilter::FilterData object, which in turn is held by a RenderSVGResourceFilter object which is a renderer. Nothing else at all holds references to FEImage. Any changes to CSS properties (including SVG attributes) that affect the filter cause the FilterData and hence FEImage object to be destroyed and recreated. CSS Filters cannot use SVGFEImage.
&gt;&gt; 
&gt;&gt; The only way that FEImage::m_document is used is to look up the renderer for the image it is drawing. It will only do that during applyResource, which is only called when the target for the filter (the thing that will draw it) is painted, which only happens if the target is in the document. If the target is in the document then FEImage::m_document is valid. If the target is not in the document then it both cannot be painted and there is no FEImage object to have a dangling reference.
&gt; 
&gt; Please add a link to this bug report, and open the bug report after landing again. Can be dependent on your refactoring patch later. After refactoring you just close it.

There is a link to this bug report. Did you mean something else?

Again, there is no plan for a future patch at this time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>755765</commentid>
    <comment_count>17</comment_count>
    <who name="Dirk Schulze">krit</who>
    <bug_when>2012-10-31 18:04:32 -0700</bug_when>
    <thetext>(In reply to comment #16)
&gt; (From update of attachment 171478 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=171478&amp;action=review
&gt; 
&gt; &gt;&gt; Source/WebCore/ChangeLog:8
&gt; &gt;&gt; +        Adding a comment to explain why the failure to clear m_document is not a problem.
&gt; &gt; 
&gt; &gt; Please say that this will be refactored with another patch.
&gt; 
&gt; But it won&apos;t be refactored, at least not to my knowledge. The comment exists so that _if_ there is ever a patch that changes the behavior the patch author will know the situation. Or if anyone, like Adam, is doing a security review they will have context in which to understand why this is not a security problem.
&gt; 
&gt; &gt;&gt;&gt;&gt; Source/WebCore/svg/graphics/filters/SVGFEImage.h:58
&gt; &gt;&gt;&gt;&gt; +    // m_document will never be a dangling reference. See https://bugs.webkit.org/show_bug.cgi?id=99243
&gt; &gt;&gt;&gt; 
&gt; &gt;&gt;&gt; Better justification would be to explain why here as well.  This is not an Element, so it doesn&apos;t keep the document alive.  I assume this is held off of a renderer?  Can this also be held off of a CSSValue?
&gt; &gt;&gt; 
&gt; &gt;&gt; This object is only held by a SVGFilterBuilder which in turn is held by a RenderSVGResourceFilter::FilterData object, which in turn is held by a RenderSVGResourceFilter object which is a renderer. Nothing else at all holds references to FEImage. Any changes to CSS properties (including SVG attributes) that affect the filter cause the FilterData and hence FEImage object to be destroyed and recreated. CSS Filters cannot use SVGFEImage.
&gt; &gt;&gt; 
&gt; &gt;&gt; The only way that FEImage::m_document is used is to look up the renderer for the image it is drawing. It will only do that during applyResource, which is only called when the target for the filter (the thing that will draw it) is painted, which only happens if the target is in the document. If the target is in the document then FEImage::m_document is valid. If the target is not in the document then it both cannot be painted and there is no FEImage object to have a dangling reference.
&gt; &gt; 
&gt; &gt; Please add a link to this bug report, and open the bug report after landing again. Can be dependent on your refactoring patch later. After refactoring you just close it.
&gt; 
&gt; There is a link to this bug report. Did you mean something else?
&gt; 
&gt; Again, there is no plan for a future patch at this time.

Hm, ok. Then land it :P</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>756183</commentid>
    <comment_count>18</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2012-11-01 06:57:37 -0700</bug_when>
    <thetext>Committed r133158: &lt;http://trac.webkit.org/changeset/133158&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>169239</attachid>
            <date>2012-10-17 12:58:23 -0700</date>
            <delta_ts>2012-10-30 10:10:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99243-20121017155711.patch</filename>
            <type>text/plain</type>
            <size>1679</size>
            <attacher name="Stephen Chenney">schenney</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTYzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTE3ICBTdGVwaGVu
IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRkVJbWFnZTo6bV9k
b2N1bWVudCBhcHBlYXJzIHRvIGJlIHVzZWFibGUgYWZ0ZXIgZnJlZQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyNDMKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgYSBjb21tZW50IHRvIGV4cGxh
aW4gd2h5IHRoZSBmYWlsdXJlIHRvIGNsZWFyIG1fZG9jdW1lbnQgaXMgbm90IGEgcHJvYmxlbS4K
KworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBubyBjb2RlIGNoYW5nZSBhdCBhbGwuCisK
KyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRUltYWdlLmg6CisgICAgICAgIChG
RUltYWdlKTogQWRkIGEgY29tbWVudCBvbiB0aGUgbGlmZXRpbWUgb2YgbV9kb2N1bWVudC4KKwog
MjAxMi0xMC0xNyAgRGFuIENhcm5leSAgPGRjYXJuZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBC
aW5kIGlzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbiB0byB3b3JsZApJbmRleDogU291cmNlL1dl
YkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv
dXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZFSW1hZ2UuaAkocmV2aXNpb24g
MTMxNjMwKQorKysgU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRkVJbWFn
ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCw2ICs1NCwxMiBAQCBwcml2YXRlOgogICAgIFJlbmRl
ck9iamVjdCogcmVmZXJlbmNlZFJlbmRlcmVyKCkgY29uc3Q7CiAKICAgICBSZWZQdHI8SW1hZ2U+
IG1faW1hZ2U7CisKKyAgICAvLyBUaGUgbV9kb2N1bWVudCBoZXJlIGlzIGFzc2lnbmVkIHdoZW4g
dGhlIEZpbHRlckVmZmVjdCBpcyBjcmVhdGVkIGFuZCBuZXZlciBtb2RpZmllZCBvdGhlcndpc2Uu
CisgICAgLy8gVGhpcyBpcyBzYWZlLCBldmVuIGlmIHRoZSBkb2N1bWVudCBpcyBkZWxldGVkLCBi
ZWNhdXNlIG1fZG9jdW1lbnQgaXMgb25seSB1c2VkIHdoZW4gdGhlCisgICAgLy8gZmlsdGVyIGlz
IGFwcGxpZWQgYW5kIHRoZSBmaWx0ZXIgY2FuIG9ubHkgYmUgYXBwbGllZCB3aGVuIHRoZXJlIGlz
IGEgZG9jdW1lbnQuCisgICAgLy8gRnVydGhlcm1vcmUsIHRoaXMgb2JqZWN0IGlzIGRlc3Ryb3ll
ZCBhbmQgcmVjcmVhdGVkIHdoZW4gdGhlIGRvY3VtZW50IGNoYW5nZXMuCisgICAgLy8gVGhlcmUg
aXMgbm8gQVBJIHRvIG90aGVyd2lzZSBhY2Nlc3MgbV9kb2N1bWVudC4KICAgICBEb2N1bWVudCog
bV9kb2N1bWVudDsKICAgICBTdHJpbmcgbV9ocmVmOwogICAgIFNWR1ByZXNlcnZlQXNwZWN0UmF0
aW8gbV9wcmVzZXJ2ZUFzcGVjdFJhdGlvOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171475</attachid>
            <date>2012-10-30 10:10:07 -0700</date>
            <delta_ts>2012-10-30 10:17:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99243-20121030130832.patch</filename>
            <type>text/plain</type>
            <size>1426</size>
            <attacher name="Stephen Chenney">schenney</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjkxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTMwICBTdGVwaGVu
IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRkVJbWFnZTo6bV9k
b2N1bWVudCBhcHBlYXJzIHRvIGJlIHVzZWFibGUgYWZ0ZXIgZnJlZQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyNDMKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgYSBjb21tZW50IHRvIGV4cGxh
aW4gd2h5IHRoZSBmYWlsdXJlIHRvIGNsZWFyIG1fZG9jdW1lbnQgaXMgbm90IGEgcHJvYmxlbS4K
KworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBubyBjb2RlIGNoYW5nZSBhdCBhbGwuCisK
KyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRUltYWdlLmg6CisgICAgICAgIChG
RUltYWdlKTogQWRkIGEgY29tbWVudCBvbiB0aGUgbGlmZXRpbWUgb2YgbV9kb2N1bWVudC4KKwog
MjAxMi0xMC0zMCAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdl
YiBJbnNwZWN0b3I6IEFzc29jaWF0ZSBjb25zb2xlIG1lc3NhZ2VzIHdpdGggdGhlIHJlcXVlc3Rz
IHRoYXQgY2F1c2VkIHRoZW0uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmls
dGVycy9TVkdGRUltYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBo
aWNzL2ZpbHRlcnMvU1ZHRkVJbWFnZS5oCShyZXZpc2lvbiAxMzI5MTgpCisrKyBTb3VyY2UvV2Vi
Q29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRUltYWdlLmgJKHdvcmtpbmcgY29weSkKQEAg
LTU0LDYgKzU0LDggQEAgcHJpdmF0ZToKICAgICBSZW5kZXJPYmplY3QqIHJlZmVyZW5jZWRSZW5k
ZXJlcigpIGNvbnN0OwogCiAgICAgUmVmUHRyPEltYWdlPiBtX2ltYWdlOworCisgICAgLy8gVGhp
cyBGRUltYWdlIG9iamVjdCBuZXZlciBsaXZlcyBiZXlvbmQgdGhlIGxpZmUgb2YgdGhlIG1fZG9j
dW1lbnQgc2V0IGF0IGNvbnN0cnVjdGlvbjsgbV9kb2N1bWVudCB3aWxsIG5ldmVyIGJlIGEgZGFu
Z2xpbmcgcmVmZXJlbmNlLgogICAgIERvY3VtZW50KiBtX2RvY3VtZW50OwogICAgIFN0cmluZyBt
X2hyZWY7CiAgICAgU1ZHUHJlc2VydmVBc3BlY3RSYXRpbyBtX3ByZXNlcnZlQXNwZWN0UmF0aW87
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>171478</attachid>
            <date>2012-10-30 10:17:30 -0700</date>
            <delta_ts>2012-10-30 16:47:04 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-99243-20121030131555.patch</filename>
            <type>text/plain</type>
            <size>1383</size>
            <attacher name="Stephen Chenney">schenney</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjkxOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTMwICBTdGVwaGVu
IENoZW5uZXkgIDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRkVJbWFnZTo6bV9k
b2N1bWVudCBpcyBuZXZlciBjbGVhcmVkLiBXaHkgbm90PworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyNDMKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcgYSBjb21tZW50IHRvIGV4cGxhaW4gd2h5
IHRoZSBmYWlsdXJlIHRvIGNsZWFyIG1fZG9jdW1lbnQgaXMgbm90IGEgcHJvYmxlbS4KKworICAg
ICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBubyBjb2RlIGNoYW5nZSBhdCBhbGwuCisKKyAgICAg
ICAgKiBzdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRUltYWdlLmg6CisgICAgICAgIChGRUltYWdl
KTogQWRkIGEgY29tbWVudCBvbiB0aGUgbGlmZXRpbWUgb2YgbV9kb2N1bWVudC4KKwogMjAxMi0x
MC0zMCAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNw
ZWN0b3I6IEFzc29jaWF0ZSBjb25zb2xlIG1lc3NhZ2VzIHdpdGggdGhlIHJlcXVlc3RzIHRoYXQg
Y2F1c2VkIHRoZW0uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9T
VkdGRUltYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL2Zp
bHRlcnMvU1ZHRkVJbWFnZS5oCShyZXZpc2lvbiAxMzI5MTgpCisrKyBTb3VyY2UvV2ViQ29yZS9z
dmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGRUltYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTU0LDYg
KzU0LDggQEAgcHJpdmF0ZToKICAgICBSZW5kZXJPYmplY3QqIHJlZmVyZW5jZWRSZW5kZXJlcigp
IGNvbnN0OwogCiAgICAgUmVmUHRyPEltYWdlPiBtX2ltYWdlOworCisgICAgLy8gbV9kb2N1bWVu
dCB3aWxsIG5ldmVyIGJlIGEgZGFuZ2xpbmcgcmVmZXJlbmNlLiBTZWUgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MjQzCiAgICAgRG9jdW1lbnQqIG1fZG9jdW1lbnQ7
CiAgICAgU3RyaW5nIG1faHJlZjsKICAgICBTVkdQcmVzZXJ2ZUFzcGVjdFJhdGlvIG1fcHJlc2Vy
dmVBc3BlY3RSYXRpbzsK
</data>
<flag name="review"
          id="185411"
          type_id="1"
          status="+"
          setter="krit"
    />
    <flag name="commit-queue"
          id="185412"
          type_id="3"
          status="-"
          setter="krit"
    />
          </attachment>
      

    </bug>

</bugzilla>