99239 2012-10-13 00:17:13 -0700 NamedFlowCollection should be a ContextDestructionObserver 2013-02-07 21:01:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 webkit.review.bot abarth abarth choco mihnea ojan.autocc WebkitBugTracker oldest_to_newest 741437 0 webkit.review.bot 2012-10-13 00:17:13 -0700 NamedFlowCollection should be a ContextDestructionObserver Requested by abarth on #webkit. 827383 1 187076 choco 2013-02-07 05:43:27 -0800 Created attachment 187076 Patch 827436 2 mihnea 2013-02-07 06:36:48 -0800 I think an explanation about why this change is needed would be helpful. 827735 3 187076 abarth 2013-02-07 11:11:35 -0800 Comment on attachment 187076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=187076&action=review > Source/WebCore/dom/NamedFlowCollection.cpp:43 > NamedFlowCollection::NamedFlowCollection(Document* doc) doc -> document > Source/WebCore/dom/NamedFlowCollection.cpp:45 > + , m_document(doc) You don't need the m_document variable anymore. ContextDestructionObserver already keep that information for you. > Source/WebCore/dom/NamedFlowCollection.cpp:107 > -void NamedFlowCollection::documentDestroyed() > +void NamedFlowCollection::contextDestroyed() > { > m_document = 0; > } Once you remove m_document, you can delete this function. 827736 4 abarth 2013-02-07 11:12:10 -0800 > I think an explanation about why this change is needed would be helpful. This class just re-implements ContextDestructionObserver manually. Instead of re-implementing ContextDestructionObserver, we can just subclass it. 827738 5 abarth 2013-02-07 11:13:45 -0800 We're trying to remove as many of the raw Document* member variables as we can from WebCore because those raw pointers often lead to memory corruption. This case doesn't cause memory corruption because NamedFlowCollection clears the pointer when the Document is destroyed. However, it's easier to audit these cases if we let ContextDestructionObserver do that work automatically. 828141 6 choco 2013-02-07 20:32:51 -0800 Your comment is helpful to understand about ContextDestructionContext perfectly. Thanks for reviewing!! I will upload new patch. 828142 7 187226 choco 2013-02-07 20:34:01 -0800 Created attachment 187226 Patch 828144 8 187226 abarth 2013-02-07 20:42:40 -0800 Comment on attachment 187226 Patch looks great 828151 9 187226 webkit.review.bot 2013-02-07 21:01:00 -0800 Comment on attachment 187226 Patch Clearing flags on attachment: 187226 Committed r142223: <http://trac.webkit.org/changeset/142223> 828152 10 webkit.review.bot 2013-02-07 21:01:05 -0800 All reviewed patches have been landed. Closing bug. 187076 2013-02-07 05:43:27 -0800 2013-02-07 20:33:58 -0800 Patch bug-99239-20130207224005.patch text/plain 3247 choco U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWJjODRiZTE2NWI4YjJh NWUyOTdmNjY2Mjk5Zjk3ZDYyMDk0ZWUxNS4uOGE0NjhlZGEzYzE3OTNlMDFjOWE3Y2JjZDBlZGNh NTFjZWFjYzhmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTA3ICBIYW55 ZWUgS2ltICA8Y2hvY29AY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgTmFtZWRGbG93Q29sbGVj dGlvbiBzaG91bGQgYmUgYSBDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyMzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6fkRvY3VtZW50KToKKyAgICAgICAgKiBkb20vTmFt ZWRGbG93Q29sbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOYW1lZEZsb3dDb2xsZWN0 aW9uOjpOYW1lZEZsb3dDb2xsZWN0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Ok5hbWVkRmxvd0Nv bGxlY3Rpb246OmNvbnRleHREZXN0cm95ZWQpOgorICAgICAgICAqIGRvbS9OYW1lZEZsb3dDb2xs ZWN0aW9uLmg6CisgICAgICAgIChOYW1lZEZsb3dDb2xsZWN0aW9uKToKKwogMjAxMy0wMi0wNyAg VG9ueSBHZW50aWxjb3JlICA8dG9ueWdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENhbGwgWFNT QXVkaXRvci5maWx0ZXJUb2tlbigpIGZyb20gdGhyZWFkZWQgSFRNTCBwYXJzZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v RG9jdW1lbnQuY3BwCmluZGV4IDYyMTQ3NTZiYzE0Mzg5MzE2OTk2NGRlYWNmZjcyY2FmYTcyMDM2 YjIuLjhjZTM5OWYxYzIxMGM4ZjA4OTc3NGM4MTViN2QxZDRhY2MzOTFhZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcApAQCAtNjIxLDkgKzYyMSw2IEBAIERvY3VtZW50Ojp+RG9jdW1lbnQoKQog CiAgICAgbV9zdHlsZVNoZWV0Q29sbGVjdGlvbi5jbGVhcigpOwogCi0gICAgaWYgKG1fbmFtZWRG bG93cykKLSAgICAgICAgbV9uYW1lZEZsb3dzLT5kb2N1bWVudERlc3Ryb3llZCgpOwotCiAgICAg aWYgKG1fZWxlbVNoZWV0KQogICAgICAgICBtX2VsZW1TaGVldC0+Y2xlYXJPd25lck5vZGUoKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24uY3Bw IGIvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24uY3BwCmluZGV4IDRjYmVm ZTUxNTgwMDQ5MDY1NGY2YTkyYmQwNGQ0MjdlN2FmYzIzZTcuLmJhZTUyYTQ4ZDg0YjY4ZGFiY2E1 MjRjYWQ2NDQxNjNmMzBjNjZjYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1l ZEZsb3dDb2xsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTmFtZWRGbG93Q29s bGVjdGlvbi5jcHAKQEAgLTQxLDcgKzQxLDggQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogTmFt ZWRGbG93Q29sbGVjdGlvbjo6TmFtZWRGbG93Q29sbGVjdGlvbihEb2N1bWVudCogZG9jKQotICAg IDogbV9kb2N1bWVudChkb2MpCisgICAgOiBDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcihkb2Mp CisgICAgLCBtX2RvY3VtZW50KGRvYykKIHsKIH0KIApAQCAtMTAwLDcgKzEwMSw3IEBAIHZvaWQg TmFtZWRGbG93Q29sbGVjdGlvbjo6ZGlzY2FyZE5hbWVkRmxvdyhXZWJLaXROYW1lZEZsb3cqIG5h bWVkRmxvdykKICAgICBtX25hbWVkRmxvd3MucmVtb3ZlKG5hbWVkRmxvdyk7CiB9CiAKLXZvaWQg TmFtZWRGbG93Q29sbGVjdGlvbjo6ZG9jdW1lbnREZXN0cm95ZWQoKQordm9pZCBOYW1lZEZsb3dD b2xsZWN0aW9uOjpjb250ZXh0RGVzdHJveWVkKCkKIHsKICAgICBtX2RvY3VtZW50ID0gMDsKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZEZsb3dDb2xsZWN0aW9uLmggYi9T b3VyY2UvV2ViQ29yZS9kb20vTmFtZWRGbG93Q29sbGVjdGlvbi5oCmluZGV4IGYyMTRkMGIzZjky ZTE2YmQzNzdiYjY4ODhkY2JiYWQyMzQ2MDhiODkuLjc1ZGYxOTVlNDVjMDBmZDkxOTc0YWFlZjUw YzJlZmJhNWM2Y2M5NGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZEZsb3dD b2xsZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24u aApAQCAtMzAsNiArMzAsNyBAQAogI2lmbmRlZiBOYW1lZEZsb3dDb2xsZWN0aW9uX2gKICNkZWZp bmUgTmFtZWRGbG93Q29sbGVjdGlvbl9oCiAKKyNpbmNsdWRlICJDb250ZXh0RGVzdHJ1Y3Rpb25P YnNlcnZlci5oIgogI2luY2x1ZGUgIldlYktpdE5hbWVkRmxvdy5oIgogI2luY2x1ZGUgPHd0Zi9G b3J3YXJkLmg+CiAjaW5jbHVkZSA8d3RmL0xpc3RIYXNoU2V0Lmg+CkBAIC00Miw3ICs0Myw3IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIERvY3VtZW50OwogY2xhc3MgRE9NTmFtZWRGbG93 Q29sbGVjdGlvbjsKIAotY2xhc3MgTmFtZWRGbG93Q29sbGVjdGlvbiA6IHB1YmxpYyBSZWZDb3Vu dGVkPE5hbWVkRmxvd0NvbGxlY3Rpb24+IHsKK2NsYXNzIE5hbWVkRmxvd0NvbGxlY3Rpb24gOiBw dWJsaWMgUmVmQ291bnRlZDxOYW1lZEZsb3dDb2xsZWN0aW9uPiwgcHVibGljIENvbnRleHREZXN0 cnVjdGlvbk9ic2VydmVyIHsKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxOYW1lZEZs b3dDb2xsZWN0aW9uPiBjcmVhdGUoRG9jdW1lbnQqIGRvYykgeyByZXR1cm4gYWRvcHRSZWYobmV3 IE5hbWVkRmxvd0NvbGxlY3Rpb24oZG9jKSk7IH0KIApAQCAtNjAsNiArNjEsOSBAQCBwdWJsaWM6 CiAKICAgICBQYXNzUmVmUHRyPERPTU5hbWVkRmxvd0NvbGxlY3Rpb24+IGNyZWF0ZUNTU09NU25h cHNob3QoKTsKIAorICAgIC8vIENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyCisgICAgdmlydHVh bCB2b2lkIGNvbnRleHREZXN0cm95ZWQoKTsKKwogcHJpdmF0ZToKICAgICBzdHJ1Y3QgTmFtZWRG bG93SGFzaEZ1bmN0aW9uczsKICAgICBzdHJ1Y3QgTmFtZWRGbG93SGFzaFRyYW5zbGF0b3I7Cg== 187226 2013-02-07 20:34:01 -0800 2013-02-07 21:00:59 -0800 Patch bug-99239-20130208133039.patch text/plain 5073 choco U3VidmVyc2lvbiBSZXZpc2lvbjogMTQyMjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGUxYTA5Mzc3MjI2ZjU0 NmNlYTViOWE1Y2ZiYWFiNTg1OTQ3Nzk0OC4uYjI5ZDkzZmI4ZmYzYmUyMzA2MWY0MzJkZTExNmI5 ODA0MDM3ZDcxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEzLTAyLTA3ICBIYW55 ZWUgS2ltICA8Y2hvY29AY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgTmFtZWRGbG93Q29sbGVj dGlvbiBzaG91bGQgYmUgYSBDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkyMzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUg cmF3IHBvaW50ZXIgb2YgRG9jdW1lbnQgaW4gTmFtZWRGbG93Q29sbGVjdGlvbi4KKyAgICAgICAg SXQgY291bGQgYmUgcmVwbGFjZWQgd2l0aCBDb250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlci4KKyAg ICAgICAgQ29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIgaGFzIHRoZSBwb2ludGVyIGFuZCBjbGVh cnMgdGhlIHBvaW50ZXIKKyAgICAgICAgYXV0b21hdGljYWxseSB3aGVuIHRoZSBkb2N1bWVudCBp cyBkZXN0cm95ZWQuIAorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkRvY3VtZW50Ojp+RG9jdW1lbnQpOgorICAgICAgICAqIGRvbS9OYW1lZEZsb3dDb2xs ZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5hbWVkRmxvd0NvbGxlY3Rpb246Ok5hbWVk Rmxvd0NvbGxlY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6TmFtZWRGbG93Q29sbGVjdGlvbjo6 ZW5zdXJlRmxvd1dpdGhOYW1lKToKKyAgICAgICAgKFdlYkNvcmU6Ok5hbWVkRmxvd0NvbGxlY3Rp b246OmRpc2NhcmROYW1lZEZsb3cpOgorICAgICAgICAoV2ViQ29yZTo6TmFtZWRGbG93Q29sbGVj dGlvbjo6ZG9jdW1lbnQpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogZG9tL05hbWVk Rmxvd0NvbGxlY3Rpb24uaDoKKyAgICAgICAgKE5hbWVkRmxvd0NvbGxlY3Rpb24pOgorCiAyMDEz LTAyLTA3ICBBbGV4ZWkgU3ZpdGtpbmUgIDxhc3ZpdGtpbmVAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIENocm9taXVtOiBIYW5nIHBhcnNpbmcgYmlkaSBjb250cm9sIGNoYXJzIG9uIE1hYyBPUyBY IDEwLjYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDYyMTQ3NTZiYzE0Mzg5MzE2OTk2NGRl YWNmZjcyY2FmYTcyMDM2YjIuLjhjZTM5OWYxYzIxMGM4ZjA4OTc3NGM4MTViN2QxZDRhY2MzOTFh ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNjIxLDkgKzYyMSw2IEBAIERvY3VtZW50 Ojp+RG9jdW1lbnQoKQogCiAgICAgbV9zdHlsZVNoZWV0Q29sbGVjdGlvbi5jbGVhcigpOwogCi0g ICAgaWYgKG1fbmFtZWRGbG93cykKLSAgICAgICAgbV9uYW1lZEZsb3dzLT5kb2N1bWVudERlc3Ry b3llZCgpOwotCiAgICAgaWYgKG1fZWxlbVNoZWV0KQogICAgICAgICBtX2VsZW1TaGVldC0+Y2xl YXJPd25lck5vZGUoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxv d0NvbGxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24u Y3BwCmluZGV4IDRjYmVmZTUxNTgwMDQ5MDY1NGY2YTkyYmQwNGQ0MjdlN2FmYzIzZTcuLjJiYjk0 MGM4OWVlMTVlMzk5ZjM2MTk3ZGE2OTE2OGNkYjZkNTAwZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9OYW1lZEZsb3dDb2xsZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vTmFtZWRGbG93Q29sbGVjdGlvbi5jcHAKQEAgLTQwLDggKzQwLDggQEAKIAogbmFtZXNwYWNl IFdlYkNvcmUgewogCi1OYW1lZEZsb3dDb2xsZWN0aW9uOjpOYW1lZEZsb3dDb2xsZWN0aW9uKERv Y3VtZW50KiBkb2MpCi0gICAgOiBtX2RvY3VtZW50KGRvYykKK05hbWVkRmxvd0NvbGxlY3Rpb246 Ok5hbWVkRmxvd0NvbGxlY3Rpb24oRG9jdW1lbnQqIGRvY3VtZW50KQorICAgIDogQ29udGV4dERl c3RydWN0aW9uT2JzZXJ2ZXIoZG9jdW1lbnQpCiB7CiB9CiAKQEAgLTgxLDcgKzgxLDcgQEAgUGFz c1JlZlB0cjxXZWJLaXROYW1lZEZsb3c+IE5hbWVkRmxvd0NvbGxlY3Rpb246OmVuc3VyZUZsb3dX aXRoTmFtZShjb25zdCBTdHJpbmcKICAgICBSZWZQdHI8V2ViS2l0TmFtZWRGbG93PiBuZXdGbG93 ID0gV2ViS2l0TmFtZWRGbG93OjpjcmVhdGUodGhpcywgZmxvd05hbWUpOwogICAgIG1fbmFtZWRG bG93cy5hZGQobmV3Rmxvdy5nZXQoKSk7CiAKLSAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246 OmRpZENyZWF0ZU5hbWVkRmxvdyhtX2RvY3VtZW50LCBuZXdGbG93LmdldCgpKTsKKyAgICBJbnNw ZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZENyZWF0ZU5hbWVkRmxvdyhkb2N1bWVudCgpLCBuZXdG bG93LmdldCgpKTsKIAogICAgIHJldHVybiBuZXdGbG93LnJlbGVhc2UoKTsKIH0KQEAgLTg5LDIx ICs4OSwyNCBAQCBQYXNzUmVmUHRyPFdlYktpdE5hbWVkRmxvdz4gTmFtZWRGbG93Q29sbGVjdGlv bjo6ZW5zdXJlRmxvd1dpdGhOYW1lKGNvbnN0IFN0cmluZwogdm9pZCBOYW1lZEZsb3dDb2xsZWN0 aW9uOjpkaXNjYXJkTmFtZWRGbG93KFdlYktpdE5hbWVkRmxvdyogbmFtZWRGbG93KQogewogICAg IC8vIFRoZSBkb2N1bWVudCBpcyBub3QgdmFsaWQgYW55bW9yZSBzbyB0aGUgY29sbGVjdGlvbiB3 aWxsIGJlIGRlc3Ryb3llZCBhbnl3YXkuCi0gICAgaWYgKCFtX2RvY3VtZW50KQorICAgIGlmICgh ZG9jdW1lbnQoKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQVNTRVJUKG5hbWVkRmxvdy0+Zmxv d1N0YXRlKCkgPT0gV2ViS2l0TmFtZWRGbG93OjpGbG93U3RhdGVOdWxsKTsKICAgICBBU1NFUlQo bV9uYW1lZEZsb3dzLmNvbnRhaW5zKG5hbWVkRmxvdykpOwogCi0gICAgSW5zcGVjdG9ySW5zdHJ1 bWVudGF0aW9uOjp3aWxsUmVtb3ZlTmFtZWRGbG93KG1fZG9jdW1lbnQsIG5hbWVkRmxvdyk7Cisg ICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjp3aWxsUmVtb3ZlTmFtZWRGbG93KGRvY3VtZW50 KCksIG5hbWVkRmxvdyk7CiAKICAgICBtX25hbWVkRmxvd3MucmVtb3ZlKG5hbWVkRmxvdyk7CiB9 CiAKLXZvaWQgTmFtZWRGbG93Q29sbGVjdGlvbjo6ZG9jdW1lbnREZXN0cm95ZWQoKQorRG9jdW1l bnQqIE5hbWVkRmxvd0NvbGxlY3Rpb246OmRvY3VtZW50KCkgY29uc3QKIHsKLSAgICBtX2RvY3Vt ZW50ID0gMDsKKyAgICBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0ID0gQ29udGV4dERl c3RydWN0aW9uT2JzZXJ2ZXI6OnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKTsKKyAgICBBU1NFUlQo IWNvbnRleHQgfHwgY29udGV4dC0+aXNEb2N1bWVudCgpKTsKKyAgICByZXR1cm4gc3RhdGljX2Nh c3Q8RG9jdW1lbnQqPihjb250ZXh0KTsKIH0KKwogUGFzc1JlZlB0cjxET01OYW1lZEZsb3dDb2xs ZWN0aW9uPiBOYW1lZEZsb3dDb2xsZWN0aW9uOjpjcmVhdGVDU1NPTVNuYXBzaG90KCkKIHsKICAg ICBWZWN0b3I8V2ViS2l0TmFtZWRGbG93Kj4gY3JlYXRlZEZsb3dzOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24uaCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9OYW1lZEZsb3dDb2xsZWN0aW9uLmgKaW5kZXggZjIxNGQwYjNmOTJlMTZiZDM3N2JiNjg4OGRj YmJhZDIzNDYwOGI4OS4uYjAyNDA0Y2NiNGY3ZjUyNjBjODFkMDU0MzlkNzZjMWMwMDgwMGQxYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05hbWVkRmxvd0NvbGxlY3Rpb24uaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vTmFtZWRGbG93Q29sbGVjdGlvbi5oCkBAIC0zMCw2ICszMCw3 IEBACiAjaWZuZGVmIE5hbWVkRmxvd0NvbGxlY3Rpb25faAogI2RlZmluZSBOYW1lZEZsb3dDb2xs ZWN0aW9uX2gKIAorI2luY2x1ZGUgIkNvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyLmgiCiAjaW5j bHVkZSAiV2ViS2l0TmFtZWRGbG93LmgiCiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNs dWRlIDx3dGYvTGlzdEhhc2hTZXQuaD4KQEAgLTQyLDcgKzQzLDcgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogY2xhc3MgRG9jdW1lbnQ7CiBjbGFzcyBET01OYW1lZEZsb3dDb2xsZWN0aW9uOwogCi1j bGFzcyBOYW1lZEZsb3dDb2xsZWN0aW9uIDogcHVibGljIFJlZkNvdW50ZWQ8TmFtZWRGbG93Q29s bGVjdGlvbj4geworY2xhc3MgTmFtZWRGbG93Q29sbGVjdGlvbiA6IHB1YmxpYyBSZWZDb3VudGVk PE5hbWVkRmxvd0NvbGxlY3Rpb24+LCBwdWJsaWMgQ29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIg ewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPE5hbWVkRmxvd0NvbGxlY3Rpb24+IGNy ZWF0ZShEb2N1bWVudCogZG9jKSB7IHJldHVybiBhZG9wdFJlZihuZXcgTmFtZWRGbG93Q29sbGVj dGlvbihkb2MpKTsgfQogCkBAIC01Miw5ICs1Myw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgZGlz Y2FyZE5hbWVkRmxvdyhXZWJLaXROYW1lZEZsb3cqKTsKIAotICAgIHZvaWQgZG9jdW1lbnREZXN0 cm95ZWQoKTsKLQotICAgIERvY3VtZW50KiBkb2N1bWVudCgpIGNvbnN0IHsgcmV0dXJuIG1fZG9j dW1lbnQ7IH0KKyAgICBEb2N1bWVudCogZG9jdW1lbnQoKSBjb25zdDsKIAogICAgIHZpcnR1YWwg fk5hbWVkRmxvd0NvbGxlY3Rpb24oKSB7IH0KIApAQCAtNjgsNyArNjcsNiBAQCBwcml2YXRlOgog CiAgICAgZXhwbGljaXQgTmFtZWRGbG93Q29sbGVjdGlvbihEb2N1bWVudCopOwogCi0gICAgRG9j dW1lbnQqIG1fZG9jdW1lbnQ7CiAgICAgTmFtZWRGbG93U2V0IG1fbmFtZWRGbG93czsKIH07CiAK