99225 2012-10-12 17:56:43 -0700 StringBuilder::append(StringBuilder&) doesn't take into account the bit size of the argument string 2012-10-12 22:33:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin webkit.review.bot oldest_to_newest 741358 0 msaboff 2012-10-12 17:56:43 -0700 StringBuilder::append(StringBuilder& other) always uses other.characters() to access the characters to append. This should be changed to use characters8() or characters16() as appropriate. 741364 1 168523 msaboff 2012-10-12 18:06:50 -0700 Created attachment 168523 Patch 741404 2 168523 buildbot 2012-10-12 21:13:10 -0700 Comment on attachment 168523 Patch Attachment 168523 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14292122 New failing tests: fast/css/transform-inline-style.html editing/execCommand/5458246.html fast/css/remove-shorthand.html fast/dom/HTMLMeterElement/meter-element-with-child-crash.html editing/execCommand/create-list-with-hr.html editing/pasteboard/input-field-1.html editing/inserting/insert-images-in-pre-x-crash.html fast/backgrounds/repeat/parsing-background-repeat.html editing/pasteboard/4806874.html fast/css/transform-inline-style-remove.html editing/pasteboard/paste-line-endings-001.html fast/backgrounds/background-shorthand-with-backgroundSize-style.html fast/css/background-position-serialize.html editing/execCommand/insert-ordered-list.html editing/execCommand/infinite-recursion-computeRectForRepaint.html fast/dom/background-shorthand-csstext.html fast/css/shorthand-mismatched-list-crash.html 741412 3 168541 msaboff 2012-10-12 22:23:54 -0700 Created attachment 168541 Fix for test failures Added missing "else". 741413 4 msaboff 2012-10-12 22:30:05 -0700 Committed r131250: <http://trac.webkit.org/changeset/131250> 741414 5 168541 benjamin 2012-10-12 22:33:50 -0700 Comment on attachment 168541 Fix for test failures Silly me. I checked characters8() and characters16(), and did not pay much attention to the actual code... 168523 2012-10-12 18:06:50 -0700 2012-10-12 21:13:10 -0700 Patch 99225.patch text/plain 1220 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzEyNDMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZ0J1aWxkZXI6OmFwcGVuZChTdHJpbmdC dWlsZGVyJikgZG9lc24ndCB0YWtlIGludG8gYWNjb3VudCB0aGUgYml0IHNpemUgb2YgdGhlIGFy Z3VtZW50IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTkyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRlZCA4IGJpdCBwYXRoLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRl ci5oOgorICAgICAgICAoV1RGOjpTdHJpbmdCdWlsZGVyOjphcHBlbmQpOgorCiAyMDEyLTEwLTEy ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTMxMjI0LgpJbmRleDogU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdCdWlsZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4dC9TdHJp bmdCdWlsZGVyLmgJKHJldmlzaW9uIDEzMTIwMikKKysrIFNvdXJjZS9XVEYvd3RmL3RleHQvU3Ry aW5nQnVpbGRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC04Myw3ICs4Myw5IEBAIHB1YmxpYzoKICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCi0gICAgICAgIGFwcGVuZChvdGhlci5jaGFy YWN0ZXJzKCksIG90aGVyLm1fbGVuZ3RoKTsKKyAgICAgICAgaWYgKG90aGVyLmlzOEJpdCgpKQor ICAgICAgICAgICAgYXBwZW5kKG90aGVyLmNoYXJhY3RlcnM4KCksIG90aGVyLm1fbGVuZ3RoKTsK KyAgICAgICAgYXBwZW5kKG90aGVyLmNoYXJhY3RlcnMxNigpLCBvdGhlci5tX2xlbmd0aCk7CiAg ICAgfQogCiAgICAgdm9pZCBhcHBlbmQoY29uc3QgU3RyaW5nJiBzdHJpbmcsIHVuc2lnbmVkIG9m ZnNldCwgdW5zaWduZWQgbGVuZ3RoKQo= 168541 2012-10-12 22:23:54 -0700 2012-10-12 22:33:50 -0700 Fix for test failures 99225-2.patch text/plain 1239 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzEyNDgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZ0J1aWxkZXI6OmFwcGVuZChTdHJpbmdC dWlsZGVyJikgZG9lc24ndCB0YWtlIGludG8gYWNjb3VudCB0aGUgYml0IHNpemUgb2YgdGhlIGFy Z3VtZW50IHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTkyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRlZCA4IGJpdCBwYXRoLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRl ci5oOgorICAgICAgICAoV1RGOjpTdHJpbmdCdWlsZGVyOjphcHBlbmQpOgorCiAyMDEyLTEwLTEy ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTMxMjI0LgpJbmRleDogU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdCdWlsZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4dC9TdHJp bmdCdWlsZGVyLmgJKHJldmlzaW9uIDEzMTIwMikKKysrIFNvdXJjZS9XVEYvd3RmL3RleHQvU3Ry aW5nQnVpbGRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC04Myw3ICs4MywxMCBAQCBwdWJsaWM6CiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBhcHBlbmQob3RoZXIuY2hh cmFjdGVycygpLCBvdGhlci5tX2xlbmd0aCk7CisgICAgICAgIGlmIChvdGhlci5pczhCaXQoKSkK KyAgICAgICAgICAgIGFwcGVuZChvdGhlci5jaGFyYWN0ZXJzOCgpLCBvdGhlci5tX2xlbmd0aCk7 CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGFwcGVuZChvdGhlci5jaGFyYWN0ZXJzMTYoKSwg b3RoZXIubV9sZW5ndGgpOwogICAgIH0KIAogICAgIHZvaWQgYXBwZW5kKGNvbnN0IFN0cmluZyYg c3RyaW5nLCB1bnNpZ25lZCBvZmZzZXQsIHVuc2lnbmVkIGxlbmd0aCkK