99223 2012-10-12 17:56:36 -0700 AtomicString::HashAndUTF8CharactersTranslator::equal() doesn't optimally handle 8 bit strings 2012-10-17 15:08:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin webkit.review.bot oldest_to_newest 741356 0 msaboff 2012-10-12 17:56:36 -0700 HashAndUTF8CharactersTranslator::equal() uses StringImpl::characters() on subject string to access the characters to compare, possibly up converting an 8 bit string. 741361 1 168520 msaboff 2012-10-12 18:05:57 -0700 Created attachment 168520 Patch 741366 2 168524 msaboff 2012-10-12 18:11:32 -0700 Created attachment 168524 Updated Patch Cleaned up white space error in original patch. 744651 3 168524 ggaren 2012-10-17 14:51:27 -0700 Comment on attachment 168524 Updated Patch r=me 744676 4 168524 webkit.review.bot 2012-10-17 15:08:27 -0700 Comment on attachment 168524 Updated Patch Clearing flags on attachment: 168524 Committed r131652: <http://trac.webkit.org/changeset/131652> 744678 5 webkit.review.bot 2012-10-17 15:08:30 -0700 All reviewed patches have been landed. Closing bug. 168520 2012-10-12 18:05:57 -0700 2012-10-12 18:11:32 -0700 Patch 99223.patch text/plain 2221 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzEyNDIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEF0b21pY1N0cmluZzo6SGFzaEFuZFVURjhDaGFy YWN0ZXJzVHJhbnNsYXRvcjo6ZXF1YWwoKSBkb2Vzbid0IG9wdGltYWxseSBoYW5kbGUgOCBiaXQg c3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTkyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBhbiA4IGJpdCBwYXRoLgorCisgICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmNw cDoKKyAgICAgICAgKFdURjo6SGFzaEFuZFVURjhDaGFyYWN0ZXJzVHJhbnNsYXRvcjo6ZXF1YWwp OgorCiAyMDEyLTEwLTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTMxMjI0LgpJbmRleDogU291 cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAkocmV2aXNpb24gMTMxMjAyKQorKysgU291cmNl L1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODcsMTgg KzE4NywzMyBAQCBzdHJ1Y3QgSGFzaEFuZFVURjhDaGFyYWN0ZXJzVHJhbnNsYXRvciB7CiAgICAg ICAgIGlmIChidWZmZXIudXRmMTZMZW5ndGggIT0gc3RyaW5nLT5sZW5ndGgoKSkKICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKIAotICAgICAgICBjb25zdCBVQ2hhciogc3RyaW5nQ2hhcmFjdGVy cyA9IHN0cmluZy0+Y2hhcmFjdGVycygpOwotCiAgICAgICAgIC8vIElmIGJ1ZmZlciBjb250YWlu cyBvbmx5IEFTQ0lJIGNoYXJhY3RlcnMgVVRGLTggYW5kIFVURjE2IGxlbmd0aCBhcmUgdGhlIHNh bWUuCi0gICAgICAgIGlmIChidWZmZXIudXRmMTZMZW5ndGggIT0gYnVmZmVyLmxlbmd0aCkKKyAg ICAgICAgaWYgKGJ1ZmZlci51dGYxNkxlbmd0aCAhPSBidWZmZXIubGVuZ3RoKSB7CisgICAgICAg ICAgICBjb25zdCBVQ2hhciogc3RyaW5nQ2hhcmFjdGVycyA9IHN0cmluZy0+Y2hhcmFjdGVycygp OworCiAgICAgICAgICAgICByZXR1cm4gZXF1YWxVVEYxNldpdGhVVEY4KHN0cmluZ0NoYXJhY3Rl cnMsIHN0cmluZ0NoYXJhY3RlcnMgKyBzdHJpbmctPmxlbmd0aCgpLCBidWZmZXIuY2hhcmFjdGVy cywgYnVmZmVyLmNoYXJhY3RlcnMgKyBidWZmZXIubGVuZ3RoKTsKKyAgICAgICAgfQorCisgICAg ICAgIGlmIChzdHJpbmctPmlzOEJpdCgpKSB7CisgICAgICAgICAgICBjb25zdCBMQ2hhciogc3Ry aW5nQ2hhcmFjdGVycyA9IHN0cmluZy0+Y2hhcmFjdGVyczgoKTsKKworICAgICAgICAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IGJ1ZmZlci5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAg ICAgIEFTU0VSVChpc0FTQ0lJKGJ1ZmZlci5jaGFyYWN0ZXJzW2ldKSk7CisgICAgICAgICAgICAg ICAgaWYgKHN0cmluZ0NoYXJhY3RlcnNbaV0gIT0gYnVmZmVyLmNoYXJhY3RlcnNbaV0pCisgICAg ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAg ICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKworICAgICAgICBjb25zdCBVQ2hhciogc3RyaW5n Q2hhcmFjdGVycyA9IHN0cmluZy0+Y2hhcmFjdGVyczE2KCk7CiAKICAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IGJ1ZmZlci5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgQVNTRVJU KGlzQVNDSUkoYnVmZmVyLmNoYXJhY3RlcnNbaV0pKTsKICAgICAgICAgICAgIGlmIChzdHJpbmdD aGFyYWN0ZXJzW2ldICE9IGJ1ZmZlci5jaGFyYWN0ZXJzW2ldKQogICAgICAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICAgICAgfQoKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCg== 168524 2012-10-12 18:11:32 -0700 2012-10-17 15:08:27 -0700 Updated Patch 99223-2.patch text/plain 2085 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMzEyNDMpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTEyICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEF0b21pY1N0cmluZzo6SGFzaEFuZFVURjhDaGFy YWN0ZXJzVHJhbnNsYXRvcjo6ZXF1YWwoKSBkb2Vzbid0IG9wdGltYWxseSBoYW5kbGUgOCBiaXQg c3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTkyMjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCBhbiA4IGJpdCBwYXRoLgorCisgICAgICAgICogd3RmL3RleHQvQXRvbWljU3RyaW5nLmNw cDoKKyAgICAgICAgKFdURjo6SGFzaEFuZFVURjhDaGFyYWN0ZXJzVHJhbnNsYXRvcjo6ZXF1YWwp OgorCiAyMDEyLTEwLTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTMxMjI0LgpJbmRleDogU291 cmNlL1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X VEYvd3RmL3RleHQvQXRvbWljU3RyaW5nLmNwcAkocmV2aXNpb24gMTMxMjAyKQorKysgU291cmNl L1dURi93dGYvdGV4dC9BdG9taWNTdHJpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODcsMTEg KzE4NywyNiBAQCBzdHJ1Y3QgSGFzaEFuZFVURjhDaGFyYWN0ZXJzVHJhbnNsYXRvciB7CiAgICAg ICAgIGlmIChidWZmZXIudXRmMTZMZW5ndGggIT0gc3RyaW5nLT5sZW5ndGgoKSkKICAgICAgICAg ICAgIHJldHVybiBmYWxzZTsKIAotICAgICAgICBjb25zdCBVQ2hhciogc3RyaW5nQ2hhcmFjdGVy cyA9IHN0cmluZy0+Y2hhcmFjdGVycygpOwotCiAgICAgICAgIC8vIElmIGJ1ZmZlciBjb250YWlu cyBvbmx5IEFTQ0lJIGNoYXJhY3RlcnMgVVRGLTggYW5kIFVURjE2IGxlbmd0aCBhcmUgdGhlIHNh bWUuCi0gICAgICAgIGlmIChidWZmZXIudXRmMTZMZW5ndGggIT0gYnVmZmVyLmxlbmd0aCkKKyAg ICAgICAgaWYgKGJ1ZmZlci51dGYxNkxlbmd0aCAhPSBidWZmZXIubGVuZ3RoKSB7CisgICAgICAg ICAgICBjb25zdCBVQ2hhciogc3RyaW5nQ2hhcmFjdGVycyA9IHN0cmluZy0+Y2hhcmFjdGVycygp OworCiAgICAgICAgICAgICByZXR1cm4gZXF1YWxVVEYxNldpdGhVVEY4KHN0cmluZ0NoYXJhY3Rl cnMsIHN0cmluZ0NoYXJhY3RlcnMgKyBzdHJpbmctPmxlbmd0aCgpLCBidWZmZXIuY2hhcmFjdGVy cywgYnVmZmVyLmNoYXJhY3RlcnMgKyBidWZmZXIubGVuZ3RoKTsKKyAgICAgICAgfQorCisgICAg ICAgIGlmIChzdHJpbmctPmlzOEJpdCgpKSB7CisgICAgICAgICAgICBjb25zdCBMQ2hhciogc3Ry aW5nQ2hhcmFjdGVycyA9IHN0cmluZy0+Y2hhcmFjdGVyczgoKTsKKworICAgICAgICAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IGJ1ZmZlci5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAg ICAgIEFTU0VSVChpc0FTQ0lJKGJ1ZmZlci5jaGFyYWN0ZXJzW2ldKSk7CisgICAgICAgICAgICAg ICAgaWYgKHN0cmluZ0NoYXJhY3RlcnNbaV0gIT0gYnVmZmVyLmNoYXJhY3RlcnNbaV0pCisgICAg ICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAg ICAgcmV0dXJuIHRydWU7CisgICAgICAgIH0KKworICAgICAgICBjb25zdCBVQ2hhciogc3RyaW5n Q2hhcmFjdGVycyA9IHN0cmluZy0+Y2hhcmFjdGVyczE2KCk7CiAKICAgICAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IGJ1ZmZlci5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgQVNTRVJU KGlzQVNDSUkoYnVmZmVyLmNoYXJhY3RlcnNbaV0pKTsK