99202 2012-10-12 13:33:11 -0700 [Chromium] shift-click fails to spawn new window via window.open 2012-10-24 14:08:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ericu ericu eric fishd pkasting webkit.review.bot oldest_to_newest 741150 0 ericu 2012-10-12 13:33:11 -0700 [Chromium] shift-click fails to spawn new window with target=_blank 741159 1 ericu 2012-10-12 13:37:29 -0700 This is easy to test in GMail; any link in an email will always open in a new tab, even with shift held. The correct behavior would be to spawn a new window if shift is held during the click. 741258 2 168493 ericu 2012-10-12 15:16:03 -0700 Created attachment 168493 First try patch--no tests yet. This code path affects <a target="_blank"...> and <a href="javascript:window.open...>, but apparently not ordinary links. This didn't break any tests, which is a bad sign. Where should I be putting a new test for this? 741267 3 ericu 2012-10-12 15:29:24 -0700 Digging a bit more, I see that this doesn't make e.g. middle-click on a javascript popup go to a background tab--it goes to a tab, but it's backgrounded. E.g. "SEND TO A FRIEND" on http://www.yoshis.com/oakland/jazzclub/artist/show/3030 I haven't chased down why yet. 741272 4 pkasting 2012-10-12 15:40:36 -0700 See also bug 22382, which is normally the cause of this sort of thing for middle-clicks. 743704 5 ericu 2012-10-16 16:55:46 -0700 (In reply to comment #4) > See also bug 22382, which is normally the cause of this sort of thing for middle-clicks. AhhhhhOK, I'm not going to chase middle-click right now, then. I think this patch will just take care of shift-click in the broken case I know about, but I'd feel more comfortable if someone could suggest a test that it should be breaking. 744506 6 ericu 2012-10-17 12:38:14 -0700 OK, it's not target=_blank that does it--that works fine. GMail is actually grabbing the event before that can hit, and using window.open, which is why we're hitting this code path. Up until now, we've been ignoring much of the user gesture's information when we're in the window.open path; this patch changes that to allow shift and ctrl to override the default action more. So now shift-click will work in GMail, but also if you shift-click on a button that spawns a popup, you'll get a new window [i.e. with toolbars, etc.] instead of a popup. That seems like appropriate behavior to me. 744536 7 ericu 2012-10-17 13:10:39 -0700 (In reply to comment #3) > Digging a bit more, I see that this doesn't make e.g. middle-click on a javascript popup go to a background tab--it goes to a tab, but it's backgrounded. > > E.g. "SEND TO A FRIEND" on http://www.yoshis.com/oakland/jazzclub/artist/show/3030 > > I haven't chased down why yet. (In reply to comment #3) > Digging a bit more, I see that this doesn't make e.g. middle-click on a javascript popup go to a background tab--it goes to a tab, but it's backgrounded. > > E.g. "SEND TO A FRIEND" on http://www.yoshis.com/oakland/jazzclub/artist/show/3030 > > I haven't chased down why yet. Correction: that link now does what I expect it to with my change. It's new-background-tab with middle-click and ctrl-click, new-foreground-tab with shift-middle-click. 748113 8 170033 ericu 2012-10-22 17:18:18 -0700 Created attachment 170033 Same code, updated ChangeLog The test for this code will be a Chromium browser_test; see https://codereview.chromium.org/11235048/ for the suite. I've updated the ChangeLog to indicate this; the code is the same as before. This should now be fully baked. 749967 9 170033 abarth 2012-10-24 13:16:21 -0700 Comment on attachment 170033 Same code, updated ChangeLog Ok. 750026 10 170033 webkit.review.bot 2012-10-24 14:08:18 -0700 Comment on attachment 170033 Same code, updated ChangeLog Clearing flags on attachment: 170033 Committed r132399: <http://trac.webkit.org/changeset/132399> 750028 11 webkit.review.bot 2012-10-24 14:08:22 -0700 All reviewed patches have been landed. Closing bug. 168493 2012-10-12 15:16:03 -0700 2012-10-22 17:18:18 -0700 First try patch--no tests yet. new_diff text/plain 3195 ericu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNTMyNDNjYS4uMWE1MzM3OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMC0xMiAgRXJpYyBVaHJo YW5lICA8ZXJpY3VAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05OTIwMgorICAgICAgICBbQ2hyb21pdW1dIHNoaWZ0LWNsaWNr IGZhaWxzIHRvIHNwYXduIG5ldyB3aW5kb3cgd2l0aCB0YXJnZXQ9X2JsYW5rCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKworICAgICAgICBObyBuZXcgdGVzdHMtLXdpbGwg YXNrIGluIHRoZSByZXZpZXcgd2hlcmUgdG8gcHV0IG9uZS4KKworICAgICAgICAqIHNyYy9DaHJv bWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgQ2hhbmdlIGN1cnJlbnRFdmVudFNob3VsZENhdXNl QmFja2dyb3VuZFRhYiB0byB1cGRhdGVQb2xpY3lGb3JFdmVudDsgd2UKKyAgICAgICAgd2VyZSBs b29raW5nIHVwIHRoZSByaWdodCBwb2xpY3ksIHRoZW4gdGhyb3dpbmcgaXQgYXdheSBpZiBpdCB3 YXNuJ3QKKyAgICAgICAgZm9yY2luZyBhIGJhY2tncm91bmQgdGFiLgorICAgICAgICAoV2ViS2l0 OjpDaHJvbWVDbGllbnRJbXBsOjp1cGRhdGVQb2xpY3lGb3JFdmVudCk6CisgICAgICAgIChXZWJL aXQ6OkNocm9tZUNsaWVudEltcGw6OmdldE5hdmlnYXRpb25Qb2xpY3kpOgorCiAyMDEyLTEwLTEy ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBS ZW1vdmUgdXNlZCBmcmFtZUZvckVudGVyZWRDb250ZXh0IEFQSQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAppbmRleCA2NTgxMGI5Li4xNTZiZDk0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNw cApAQCAtMjY1LDE3ICsyNjUsMTMgQEAgUGFnZSogQ2hyb21lQ2xpZW50SW1wbDo6Y3JlYXRlV2lu ZG93KAogICAgIHJldHVybiBuZXdWaWV3LT5wYWdlKCk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgYm9v bCBjdXJyZW50RXZlbnRTaG91bGRDYXVzZUJhY2tncm91bmRUYWIoY29uc3QgV2ViSW5wdXRFdmVu dCogaW5wdXRFdmVudCkKK3N0YXRpYyBpbmxpbmUgdm9pZCB1cGRhdGVQb2xpY3lGb3JFdmVudChj b25zdCBXZWJJbnB1dEV2ZW50KiBpbnB1dEV2ZW50LCBXZWJOYXZpZ2F0aW9uUG9saWN5KiBwb2xp Y3kpCiB7Ci0gICAgaWYgKCFpbnB1dEV2ZW50KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAg ICBpZiAoaW5wdXRFdmVudC0+dHlwZSAhPSBXZWJJbnB1dEV2ZW50OjpNb3VzZVVwKQotICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgaWYgKCFpbnB1dEV2ZW50IHx8IGlucHV0RXZlbnQtPnR5cGUg IT0gV2ViSW5wdXRFdmVudDo6TW91c2VVcCkKKyAgICAgICAgcmV0dXJuOwogCiAgICAgY29uc3Qg V2ViTW91c2VFdmVudCogbW91c2VFdmVudCA9IHN0YXRpY19jYXN0PGNvbnN0IFdlYk1vdXNlRXZl bnQqPihpbnB1dEV2ZW50KTsKIAotICAgIFdlYk5hdmlnYXRpb25Qb2xpY3kgcG9saWN5OwogICAg IHVuc2lnbmVkIHNob3J0IGJ1dHRvbk51bWJlcjsKICAgICBzd2l0Y2ggKG1vdXNlRXZlbnQtPmJ1 dHRvbikgewogICAgIGNhc2UgV2ViTW91c2VFdmVudDo6QnV0dG9uTGVmdDoKQEAgLTI4OCwxNyAr Mjg0LDE0IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBjdXJyZW50RXZlbnRTaG91bGRDYXVzZUJhY2tn cm91bmRUYWIoY29uc3QgV2ViSW5wdXRFdmVudCogaW5wCiAgICAgICAgIGJ1dHRvbk51bWJlciA9 IDI7CiAgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiBmYWxzZTsK KyAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBib29sIGN0cmwgPSBtb3VzZUV2ZW50LT5tb2Rp ZmllcnMgJiBXZWJNb3VzZUV2ZW50OjpDb250cm9sS2V5OwogICAgIGJvb2wgc2hpZnQgPSBtb3Vz ZUV2ZW50LT5tb2RpZmllcnMgJiBXZWJNb3VzZUV2ZW50OjpTaGlmdEtleTsKICAgICBib29sIGFs dCA9IG1vdXNlRXZlbnQtPm1vZGlmaWVycyAmIFdlYk1vdXNlRXZlbnQ6OkFsdEtleTsKICAgICBi b29sIG1ldGEgPSBtb3VzZUV2ZW50LT5tb2RpZmllcnMgJiBXZWJNb3VzZUV2ZW50OjpNZXRhS2V5 OwogCi0gICAgaWYgKCFXZWJWaWV3SW1wbDo6bmF2aWdhdGlvblBvbGljeUZyb21Nb3VzZUV2ZW50 KGJ1dHRvbk51bWJlciwgY3RybCwgc2hpZnQsIGFsdCwgbWV0YSwgJnBvbGljeSkpCi0gICAgICAg IHJldHVybiBmYWxzZTsKLQotICAgIHJldHVybiBwb2xpY3kgPT0gV2ViTmF2aWdhdGlvblBvbGlj eU5ld0JhY2tncm91bmRUYWI7CisgICAgV2ViVmlld0ltcGw6Om5hdmlnYXRpb25Qb2xpY3lGcm9t TW91c2VFdmVudChidXR0b25OdW1iZXIsIGN0cmwsIHNoaWZ0LCBhbHQsIG1ldGEsIHBvbGljeSk7 CiB9CiAKIFdlYk5hdmlnYXRpb25Qb2xpY3kgQ2hyb21lQ2xpZW50SW1wbDo6Z2V0TmF2aWdhdGlv blBvbGljeSgpCkBAIC0zMTUsOCArMzA4LDggQEAgV2ViTmF2aWdhdGlvblBvbGljeSBDaHJvbWVD bGllbnRJbXBsOjpnZXROYXZpZ2F0aW9uUG9saWN5KCkKICAgICBXZWJOYXZpZ2F0aW9uUG9saWN5 IHBvbGljeSA9IFdlYk5hdmlnYXRpb25Qb2xpY3lOZXdGb3JlZ3JvdW5kVGFiOwogICAgIGlmIChh c1BvcHVwKQogICAgICAgICBwb2xpY3kgPSBXZWJOYXZpZ2F0aW9uUG9saWN5TmV3UG9wdXA7Ci0g ICAgaWYgKGN1cnJlbnRFdmVudFNob3VsZENhdXNlQmFja2dyb3VuZFRhYihXZWJWaWV3SW1wbDo6 Y3VycmVudElucHV0RXZlbnQoKSkpCi0gICAgICAgIHBvbGljeSA9IFdlYk5hdmlnYXRpb25Qb2xp Y3lOZXdCYWNrZ3JvdW5kVGFiOworICAgIHVwZGF0ZVBvbGljeUZvckV2ZW50KFdlYlZpZXdJbXBs OjpjdXJyZW50SW5wdXRFdmVudCgpLCAmcG9saWN5KTsKKwogICAgIHJldHVybiBwb2xpY3k7CiB9 CiAK 170033 2012-10-22 17:18:18 -0700 2012-10-24 14:08:18 -0700 Same code, updated ChangeLog shift_click.patch text/plain 3287 ericu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggZTU1MzM0ZS4uY2FiODdhNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0xMC0xMiAgRXJpYyBVaHJo YW5lICA8ZXJpY3VAY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05OTIwMgorICAgICAgICBbQ2hyb21pdW1dIHNoaWZ0LWNsaWNr IGZhaWxzIHRvIHNwYXduIG5ldyB3aW5kb3cgd2l0aCB0YXJnZXQ9X2JsYW5rCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKworICAgICAgICBObyBuZXcgdGVzdHMgaW4gV2Vi S2l0LWxhbmQtLXNlZQorICAgICAgICBodHRwczovL2NvZGVyZXZpZXcuY2hyb21pdW0ub3JnLzEx MjM1MDQ4LyBmb3IgdGVzdHMgdGhhdCBJJ2xsIHN1Ym1pdAorICAgICAgICBvbmNlIHRoaXMgbGFu ZHMuCisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIENoYW5n ZSBjdXJyZW50RXZlbnRTaG91bGRDYXVzZUJhY2tncm91bmRUYWIgdG8gdXBkYXRlUG9saWN5Rm9y RXZlbnQ7IHdlCisgICAgICAgIHdlcmUgbG9va2luZyB1cCB0aGUgcmlnaHQgcG9saWN5LCB0aGVu IHRocm93aW5nIGl0IGF3YXkgaWYgaXQgd2Fzbid0CisgICAgICAgIGZvcmNpbmcgYSBiYWNrZ3Jv dW5kIHRhYi4KKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6dXBkYXRlUG9saWN5 Rm9yRXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpDaHJvbWVDbGllbnRJbXBsOjpnZXROYXZpZ2F0 aW9uUG9saWN5KToKKwogMjAxMi0xMC0xNyAgSm9zaHVhIEJlbGwgIDxqc2JlbGxAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gSW5kZXhlZERCOiBEZWxldGUgb2Jzb2xldGUgcHVi bGljIEFQSSBtZXRob2QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0No cm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xp ZW50SW1wbC5jcHAKaW5kZXggOWQwOTYxYzQuLmY0MDgxOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCkBAIC0yNjUsMTcgKzI2NSwxMyBA QCBQYWdlKiBDaHJvbWVDbGllbnRJbXBsOjpjcmVhdGVXaW5kb3coCiAgICAgcmV0dXJuIG5ld1Zp ZXctPnBhZ2UoKTsKIH0KIAotc3RhdGljIGlubGluZSBib29sIGN1cnJlbnRFdmVudFNob3VsZENh dXNlQmFja2dyb3VuZFRhYihjb25zdCBXZWJJbnB1dEV2ZW50KiBpbnB1dEV2ZW50KQorc3RhdGlj IGlubGluZSB2b2lkIHVwZGF0ZVBvbGljeUZvckV2ZW50KGNvbnN0IFdlYklucHV0RXZlbnQqIGlu cHV0RXZlbnQsIFdlYk5hdmlnYXRpb25Qb2xpY3kqIHBvbGljeSkKIHsKLSAgICBpZiAoIWlucHV0 RXZlbnQpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIGlmIChpbnB1dEV2ZW50LT50eXBl ICE9IFdlYklucHV0RXZlbnQ6Ok1vdXNlVXApCi0gICAgICAgIHJldHVybiBmYWxzZTsKKyAgICBp ZiAoIWlucHV0RXZlbnQgfHwgaW5wdXRFdmVudC0+dHlwZSAhPSBXZWJJbnB1dEV2ZW50OjpNb3Vz ZVVwKQorICAgICAgICByZXR1cm47CiAKICAgICBjb25zdCBXZWJNb3VzZUV2ZW50KiBtb3VzZUV2 ZW50ID0gc3RhdGljX2Nhc3Q8Y29uc3QgV2ViTW91c2VFdmVudCo+KGlucHV0RXZlbnQpOwogCi0g ICAgV2ViTmF2aWdhdGlvblBvbGljeSBwb2xpY3k7CiAgICAgdW5zaWduZWQgc2hvcnQgYnV0dG9u TnVtYmVyOwogICAgIHN3aXRjaCAobW91c2VFdmVudC0+YnV0dG9uKSB7CiAgICAgY2FzZSBXZWJN b3VzZUV2ZW50OjpCdXR0b25MZWZ0OgpAQCAtMjg4LDE3ICsyODQsMTQgQEAgc3RhdGljIGlubGlu ZSBib29sIGN1cnJlbnRFdmVudFNob3VsZENhdXNlQmFja2dyb3VuZFRhYihjb25zdCBXZWJJbnB1 dEV2ZW50KiBpbnAKICAgICAgICAgYnV0dG9uTnVtYmVyID0gMjsKICAgICAgICAgYnJlYWs7CiAg ICAgZGVmYXVsdDoKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICByZXR1cm47CiAgICAg fQogICAgIGJvb2wgY3RybCA9IG1vdXNlRXZlbnQtPm1vZGlmaWVycyAmIFdlYk1vdXNlRXZlbnQ6 OkNvbnRyb2xLZXk7CiAgICAgYm9vbCBzaGlmdCA9IG1vdXNlRXZlbnQtPm1vZGlmaWVycyAmIFdl Yk1vdXNlRXZlbnQ6OlNoaWZ0S2V5OwogICAgIGJvb2wgYWx0ID0gbW91c2VFdmVudC0+bW9kaWZp ZXJzICYgV2ViTW91c2VFdmVudDo6QWx0S2V5OwogICAgIGJvb2wgbWV0YSA9IG1vdXNlRXZlbnQt Pm1vZGlmaWVycyAmIFdlYk1vdXNlRXZlbnQ6Ok1ldGFLZXk7CiAKLSAgICBpZiAoIVdlYlZpZXdJ bXBsOjpuYXZpZ2F0aW9uUG9saWN5RnJvbU1vdXNlRXZlbnQoYnV0dG9uTnVtYmVyLCBjdHJsLCBz aGlmdCwgYWx0LCBtZXRhLCAmcG9saWN5KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAg cmV0dXJuIHBvbGljeSA9PSBXZWJOYXZpZ2F0aW9uUG9saWN5TmV3QmFja2dyb3VuZFRhYjsKKyAg ICBXZWJWaWV3SW1wbDo6bmF2aWdhdGlvblBvbGljeUZyb21Nb3VzZUV2ZW50KGJ1dHRvbk51bWJl ciwgY3RybCwgc2hpZnQsIGFsdCwgbWV0YSwgcG9saWN5KTsKIH0KIAogV2ViTmF2aWdhdGlvblBv bGljeSBDaHJvbWVDbGllbnRJbXBsOjpnZXROYXZpZ2F0aW9uUG9saWN5KCkKQEAgLTMxNSw4ICsz MDgsOCBAQCBXZWJOYXZpZ2F0aW9uUG9saWN5IENocm9tZUNsaWVudEltcGw6OmdldE5hdmlnYXRp b25Qb2xpY3koKQogICAgIFdlYk5hdmlnYXRpb25Qb2xpY3kgcG9saWN5ID0gV2ViTmF2aWdhdGlv blBvbGljeU5ld0ZvcmVncm91bmRUYWI7CiAgICAgaWYgKGFzUG9wdXApCiAgICAgICAgIHBvbGlj eSA9IFdlYk5hdmlnYXRpb25Qb2xpY3lOZXdQb3B1cDsKLSAgICBpZiAoY3VycmVudEV2ZW50U2hv dWxkQ2F1c2VCYWNrZ3JvdW5kVGFiKFdlYlZpZXdJbXBsOjpjdXJyZW50SW5wdXRFdmVudCgpKSkK LSAgICAgICAgcG9saWN5ID0gV2ViTmF2aWdhdGlvblBvbGljeU5ld0JhY2tncm91bmRUYWI7Cisg ICAgdXBkYXRlUG9saWN5Rm9yRXZlbnQoV2ViVmlld0ltcGw6OmN1cnJlbnRJbnB1dEV2ZW50KCks ICZwb2xpY3kpOworCiAgICAgcmV0dXJuIHBvbGljeTsKIH0KIAo=