99197 2012-10-12 12:19:54 -0700 I pity da foo' who's converting numbers to strings 2012-10-13 09:51:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 99191 1 ggaren ggaren abarth barraclough darin eric fpizlo haraken japhet sam webkit.review.bot oldest_to_newest 741108 0 ggaren 2012-10-12 12:19:54 -0700 I pity da foo' who's converting numbers to strings 741109 1 fpizlo 2012-10-12 12:21:47 -0700 So the commit message for this will just be a quickmeme link? 741112 2 168462 ggaren 2012-10-12 12:22:55 -0700 Created attachment 168462 Patch 741115 3 168462 barraclough 2012-10-12 12:29:59 -0700 Comment on attachment 168462 Patch I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion? 741278 4 ggaren 2012-10-12 15:46:12 -0700 > I don't know 'canGetItemsForName', I wonder if we should have a 'canGetItemsForIndex' so we can always avoid the identifier conversion? Darin mentioned this, too. Let's drive this based on how common that scenario is. 741484 5 ggaren 2012-10-13 09:51:22 -0700 (Side note: it's entirely possible that, if we did the research to implement canGetItemsForIndex(), we would discover that it's a no-op that always returns false.) 741485 6 ggaren 2012-10-13 09:51:52 -0700 Committed: <http://trac.webkit.org/changeset/131258>. 168462 2012-10-12 12:22:55 -0700 2012-10-12 12:29:59 -0700 Patch bug-99197-20121012122151.patch text/plain 4202 ggaren SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTIwOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEwLTEyICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgSSBwaXR5IGRhIGZvbycgd2hv J3MgY29udmVydGluZyBudW1iZXJzIHRvIHN0cmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgNDAlIHNwZWVkdXAgb24gUGVyZm9ybWFuY2VUZXN0cy9E cm9tYWVvL2RvbS10cmF2ZXJzZS5odG1sLiBQcm9iYWJseSBzcGVlZHMKKyAgICAgICAgc29tZSBv dGhlciB0aGluZ3MgdXAgdG9vLgorCisgICAgICAgIENyZWRpdCB0byBFcmljIFNlaWRlbCBmb3Ig c3BvdHRpbmcgdGhpcy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckpTLnBtOgorICAgICAgICAoR2VuZXJhdGVJbXBsZW1lbnRhdGlvbik6IGdldE93blByb3BlcnR5 U2xvdEJ5SW5kZXggZG9lc24ndCBuZWVkIHRvIHByZWZlcgorICAgICAgICBzdHJpbmcgbG9va3Vw IGluIHRoZSBzdGF0aWMgdGFibGUgYmVjYXVzZSBvdXIgc3RhdGljIHRhYmxlcyBkb24ndCBjb250 YWluCisgICAgICAgIHByb3BlcnRpZXMgdGhhdCBhcmUgbnVtYmVycy4KKworICAgICAgICBJIGJl bGlldmUgdGhpcyBpcyBqdXN0IGxvdy1oYW5naW5nIGZydWl0IGxlZnQgYmVoaW5kIGJ5IFBoaWwn cworICAgICAgICBnZXRPd25Qcm9wZXJ0eVNsb3RCeUluZGV4IG9wdGltaXphdGlvbiwgYnV0IEkg ZGlkbid0IGNoZWNrIGZvciBzdXJlLgorCiAyMDEyLTEwLTEyICBBbmRyZWFzIEtsaW5nICA8a2xp bmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OOiBSYXBpZCBtZW1vcnkgZ3Jvd3Ro IGNhbGxpbmcgRE9NIEFQSXMgd2l0aCBsYXJnZSBzdHJpbmdzLgpJbmRleDogU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0JKHJldmlzaW9u IDEzMTA5MikKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRv ckpTLnBtCSh3b3JraW5nIGNvcHkpCkBAIC0xNzY4LDEwICsxNzY4LDggQEAgc3ViIEdlbmVyYXRl SW1wbGVtZW50YXRpb24KICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICR7Y2xh c3NOYW1lfSogdGhpc09iamVjdCA9IGpzQ2FzdDwke2NsYXNzTmFtZX0qPihjZWxsKTtcbiIpOwog ICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgQVNTRVJUX0dDX09CSkVDVF9JTkhF UklUUyh0aGlzT2JqZWN0LCAmc19pbmZvKTtcbiIpOwogCi0gICAgICAgICAgICAjIFRoaXMgYXR0 ZW1wdHMgdG8gc2luayB0aGUgc29tZXdoYXQgZXhwZW5zaXZlIGludC10by1zdHJpbmcgY29udmVy c2lvbiB0aGF0IGhhcHBlbnMgd2hlbiB3ZSBjcmVhdGUgUHJvcGVydHlOYW1lCi0gICAgICAgICAg ICAjIHRvIHRoZSBwb2ludCB3aGVyZSB3ZSBhY3R1YWxseSBuZWVkIGl0LiBJbiBwYXJ0aWN1bGFy LCB3aGVuIHdlIGdlbmVyYXRlIHRoaXMgbWV0aG9kIGZvciBjbGFzc2VzIHRoYXQgY2FuCi0gICAg ICAgICAgICAjIGF0dGVtcHQgdGhlaXIgaW5kZXhlZCBnZXR0ZXIgZmlyc3QsIHdlIHRyeSB0byBl bnN1cmUgdGhhdCBpZiB0aGF0IGdldHRlciBzdWNjZWVkcyB0aGVuIHdlIGRvbid0IHBheSBmb3Ig dGhlCi0gICAgICAgICAgICAjIGNyZWF0aW9uIG9mIHRoZSBQcm9wZXJ0eU5hbWUuCisgICAgICAg ICAgICAjIFNpbmsgdGhlIGludC10by1zdHJpbmcgY29udmVyc2lvbiB0aGF0IGhhcHBlbnMgd2hl biB3ZSBjcmVhdGUgYSBQcm9wZXJ0eU5hbWUKKyAgICAgICAgICAgICMgdG8gdGhlIHBvaW50IHdo ZXJlIHdlIGFjdHVhbGx5IG5lZWQgaXQuCiAgICAgICAgICAgICBteSAkZ2VuZXJhdGVkUHJvcGVy dHlOYW1lID0gMDsKICAgICAgICAgICAgIG15ICRwcm9wZXJ0eU5hbWVHZW5lcmF0aW9uID0gc3Vi IHsKICAgICAgICAgICAgICAgICBpZiAoJGdlbmVyYXRlZFByb3BlcnR5TmFtZSkgewpAQCAtMTc4 MSwyMiArMTc3OSw2IEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICAg ICAgJGdlbmVyYXRlZFByb3BlcnR5TmFtZSA9IDE7CiAgICAgICAgICAgICB9OwogICAgICAgICAg ICAgCi0gICAgICAgICAgICBteSAkbWFudWFsTG9va3VwR2V0dGVyR2VuZXJhdGlvbiA9IHN1YiB7 Ci0gICAgICAgICAgICAgICAgbXkgJHJlcXVpcmVzTWFudWFsTG9va3VwID0gJGRhdGFOb2RlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW5kZXhlZEdldHRlciJ9IHx8ICRkYXRhTm9kZS0+ZXh0ZW5k ZWRBdHRyaWJ1dGVzLT57Ik5hbWVkR2V0dGVyIn07Ci0gICAgICAgICAgICAgICAgaWYgKCRyZXF1 aXJlc01hbnVhbExvb2t1cCkgewotICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVu dCwgIiAgICBjb25zdCBIYXNoRW50cnkqIGVudHJ5ID0gJHtjbGFzc05hbWV9VGFibGUuZW50cnko ZXhlYywgcHJvcGVydHlOYW1lKTtcbiIpOwotICAgICAgICAgICAgICAgICAgICBwdXNoKEBpbXBs Q29udGVudCwgIiAgICBpZiAoZW50cnkpIHtcbiIpOwotICAgICAgICAgICAgICAgICAgICBwdXNo KEBpbXBsQ29udGVudCwgIiAgICAgICAgc2xvdC5zZXRDdXN0b20odGhpc09iamVjdCwgZW50cnkt PnByb3BlcnR5R2V0dGVyKCkpO1xuIik7Ci0gICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxD b250ZW50LCAiICAgICAgICByZXR1cm4gdHJ1ZTtcbiIpOwotICAgICAgICAgICAgICAgICAgICBw dXNoKEBpbXBsQ29udGVudCwgIiAgICB9XG4iKTsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAg ICAgICB9OwotICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAoJGRhdGFOb2RlLT5leHRlbmRl ZEF0dHJpYnV0ZXMtPnsiTmFtZWRHZXR0ZXIifSAmJiAhJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJp YnV0ZXMtPnsiQ3VzdG9tTmFtZWRHZXR0ZXIifSkgewotICAgICAgICAgICAgICAgICYkcHJvcGVy dHlOYW1lR2VuZXJhdGlvbigpOwotICAgICAgICAgICAgICAgICYkbWFudWFsTG9va3VwR2V0dGVy R2VuZXJhdGlvbigpOwotICAgICAgICAgICAgfQotCiAgICAgICAgICAgICBpZiAoJGRhdGFOb2Rl LT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW5kZXhlZEdldHRlciJ9IHx8ICRkYXRhTm9kZS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57Ik51bWVyaWNJbmRleGVkR2V0dGVyIn0pIHsKICAgICAgICAgICAg ICAgICBpZiAoSW5kZXhHZXR0ZXJSZXR1cm5zU3RyaW5ncygkaW1wbENsYXNzTmFtZSkpIHsKICAg ICAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgaWYgKGluZGV4IDw9IE1B WF9BUlJBWV9JTkRFWCkge1xuIik7CkBAIC0xODIwLDExICsxODAyLDYgQEAgc3ViIEdlbmVyYXRl SW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICB9 XG4iKTsKICAgICAgICAgICAgICAgICAkaW1wbEluY2x1ZGVzeyJ3dGYvdGV4dC9BdG9taWNTdHJp bmcuaCJ9ID0gMTsKICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgICAKLSAgICAgICAgICAg IGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21OYW1lZEdldHRlciJ9 KSB7Ci0gICAgICAgICAgICAgICAgJiRwcm9wZXJ0eU5hbWVHZW5lcmF0aW9uKCk7Ci0gICAgICAg ICAgICAgICAgJiRtYW51YWxMb29rdXBHZXR0ZXJHZW5lcmF0aW9uKCk7Ci0gICAgICAgICAgICB9 CiAgICAgICAgICAgICAKICAgICAgICAgICAgIGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJKU0N1c3RvbUdldE93blByb3BlcnR5U2xvdEFuZERlc2NyaXB0b3IifSkgewogICAg ICAgICAgICAgICAgICYkcHJvcGVydHlOYW1lR2VuZXJhdGlvbigpOwo=