99190 2012-10-12 11:01:46 -0700 Update method signature for platformCALayerShowRepaintCounter in MediaPlayerPlayerPrivateAVFoundation's LayerClient class. 2012-10-12 12:02:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned eric.carlson feature-media-reviews simon.fraser webkit.review.bot oldest_to_newest 741029 0 roger_fong 2012-10-12 11:01:46 -0700 LayerClient's base class (PlatformCALayerClient) method signature for abstract method platformCALayerShowRepaintCounter was updated in http://trac.webkit.org/changeset/130676 so it needs to be changed in LayerClient as well. 741031 1 168446 roger_fong 2012-10-12 11:02:58 -0700 Created attachment 168446 patch 741033 2 webkit.review.bot 2012-10-12 11:04:51 -0700 Attachment 168446 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 741036 3 simon.fraser 2012-10-12 11:05:16 -0700 Why didn't this break the build? 741044 4 roger_fong 2012-10-12 11:10:15 -0700 AVCF is disabled on OpenSource 741049 5 168450 roger_fong 2012-10-12 11:16:35 -0700 Created attachment 168450 patch 741050 6 168450 simon.fraser 2012-10-12 11:17:44 -0700 Comment on attachment 168450 patch We should really make platformCALayerClient non-pure to avoid all these overrides. 741094 7 roger_fong 2012-10-12 12:02:03 -0700 http://trac.webkit.org/changeset/131206 168446 2012-10-12 11:02:58 -0700 2012-10-12 11:16:35 -0700 patch 99190_patch.txt text/plain 2035 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDgwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTEyICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIG1ldGhvZCBzaWdu YXR1cmUgZm9yIHBsYXRmb3JtQ0FMYXllclNob3dSZXBhaW50Q291bnRlciBpbiBNZWRpYVBsYXll clBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRidzIExheWVyQ2xpZW50IGNsYXNzLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExheWVyQ2xpZW50J3Mg YmFzZSBjbGFzcyAoUGxhdGZvcm1DQUxheWVyQ2xpZW50KSBtZXRob2Qgc2lnbmF0dXJlIGZvciBh YnN0cmFjdCBtZXRob2QgcGxhdGZvcm1DQUxheWVyU2hvd1JlcGFpbnRDb3VudGVyCisgICAgICAg IHdhcyB1cGRhdGVkIGluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMDY3NiBz byBpdCBuZWVkcyB0byBiZSBjaGFuZ2VkIGluIExheWVyQ2xpZW50IGFzIHdlbGwuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uQ0YuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJDbGllbnQ6OnBsYXRm b3JtQ0FMYXllclNob3dSZXBhaW50Q291bnRlcik6CisKIDIwMTItMTAtMDkgIEVucmljYSBDYXN1 Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIGZhc3QvdGV4dC9p bnRlcm5hdGlvbmFsL3RleHQtc3BsaWNlZC1mb250Lmh0bWwgYW5kIGZhc3Qvd3JpdGluZy1tb2Rl L0t1c2EtTWFrdXJhLQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL2NmL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbkNGLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2Yv TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YuY3BwCShyZXZpc2lvbiAxMzA4MDMpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTYsNyAr MTU2LDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIEdyYXBoaWNzTGF5ZXI6OkNvbXBvc2l0aW5n Q29vcmRpbmF0ZXNPcmllbnRhdGlvbiBwbGF0Zm9ybUNBTGF5ZXJDb250ZW50c09yaWVudGF0aW9u KCkgY29uc3QgeyByZXR1cm4gR3JhcGhpY3NMYXllcjo6Q29tcG9zaXRpbmdDb29yZGluYXRlc0Jv dHRvbVVwOyB9CiAgICAgdmlydHVhbCB2b2lkIHBsYXRmb3JtQ0FMYXllclBhaW50Q29udGVudHMo R3JhcGhpY3NDb250ZXh0JiwgY29uc3QgSW50UmVjdCYgaW5DbGlwKSB7IH0KICAgICB2aXJ0dWFs IGJvb2wgcGxhdGZvcm1DQUxheWVyU2hvd0RlYnVnQm9yZGVycygpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9Ci0gICAgdmlydHVhbCBib29sIHBsYXRmb3JtQ0FMYXllclNob3dSZXBhaW50Q291bnRl cigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CisgICAgdmlydHVhbCBib29sIHBsYXRmb3JtQ0FM YXllclNob3dSZXBhaW50Q291bnRlcihQbGF0Zm9ybUNBTGF5ZXIqKSBjb25zdCB7IHJldHVybiBm YWxzZTsgfQogICAgIHZpcnR1YWwgaW50IHBsYXRmb3JtQ0FMYXllckluY3JlbWVudFJlcGFpbnRD b3VudCgpIHsgcmV0dXJuIDA7IH0KIAogICAgIHZpcnR1YWwgYm9vbCBwbGF0Zm9ybUNBTGF5ZXJD b250ZW50c09wYXF1ZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Cg== 168450 2012-10-12 11:16:35 -0700 2012-10-12 11:17:43 -0700 patch 99190_patch.txt text/plain 2035 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDgwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTEyICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIG1ldGhvZCBzaWdu YXR1cmUgZm9yIHBsYXRmb3JtQ0FMYXllclNob3dSZXBhaW50Q291bnRlciBpbiBNZWRpYVBsYXll clBsYXllclByaXZhdGVBVkZvdW5kYXRpb25DRidzIExheWVyQ2xpZW50IGNsYXNzLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExheWVyQ2xpZW50J3Mg YmFzZSBjbGFzcyAoUGxhdGZvcm1DQUxheWVyQ2xpZW50KSBtZXRob2Qgc2lnbmF0dXJlIGZvciBh YnN0cmFjdCBtZXRob2QgcGxhdGZvcm1DQUxheWVyU2hvd1JlcGFpbnRDb3VudGVyCisgICAgICAg IHdhcyB1cGRhdGVkIGluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMDY3NiBz byBpdCBuZWVkcyB0byBiZSBjaGFuZ2VkIGluIExheWVyQ2xpZW50IGFzIHdlbGwuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQbGF5ZXJQcml2YXRl QVZGb3VuZGF0aW9uQ0YuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJDbGllbnQ6OnBsYXRm b3JtQ0FMYXllclNob3dSZXBhaW50Q291bnRlcik6CisKIDIwMTItMTAtMDkgIEVucmljYSBDYXN1 Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIGZhc3QvdGV4dC9p bnRlcm5hdGlvbmFsL3RleHQtc3BsaWNlZC1mb250Lmh0bWwgYW5kIGZhc3Qvd3JpdGluZy1tb2Rl L0t1c2EtTWFrdXJhLQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZm b3VuZGF0aW9uL2NmL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbkNGLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2Yv TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YuY3BwCShyZXZpc2lvbiAxMzA4MDMpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vY2YvTWVkaWFQ bGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTYsNyAr MTU2LDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIEdyYXBoaWNzTGF5ZXI6OkNvbXBvc2l0aW5n Q29vcmRpbmF0ZXNPcmllbnRhdGlvbiBwbGF0Zm9ybUNBTGF5ZXJDb250ZW50c09yaWVudGF0aW9u KCkgY29uc3QgeyByZXR1cm4gR3JhcGhpY3NMYXllcjo6Q29tcG9zaXRpbmdDb29yZGluYXRlc0Jv dHRvbVVwOyB9CiAgICAgdmlydHVhbCB2b2lkIHBsYXRmb3JtQ0FMYXllclBhaW50Q29udGVudHMo R3JhcGhpY3NDb250ZXh0JiwgY29uc3QgSW50UmVjdCYgaW5DbGlwKSB7IH0KICAgICB2aXJ0dWFs IGJvb2wgcGxhdGZvcm1DQUxheWVyU2hvd0RlYnVnQm9yZGVycygpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9Ci0gICAgdmlydHVhbCBib29sIHBsYXRmb3JtQ0FMYXllclNob3dSZXBhaW50Q291bnRl cigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CisgICAgdmlydHVhbCBib29sIHBsYXRmb3JtQ0FM YXllclNob3dSZXBhaW50Q291bnRlcihQbGF0Zm9ybUNBTGF5ZXIqKSBjb25zdCB7IHJldHVybiBm YWxzZTsgfQogICAgIHZpcnR1YWwgaW50IHBsYXRmb3JtQ0FMYXllckluY3JlbWVudFJlcGFpbnRD b3VudCgpIHsgcmV0dXJuIDA7IH0KIAogICAgIHZpcnR1YWwgYm9vbCBwbGF0Zm9ybUNBTGF5ZXJD b250ZW50c09wYXF1ZSgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Cg==