99164 2012-10-12 05:01:14 -0700 Web Inspector: relies on current Function.prototype.bind in the frame 2012-10-12 05:36:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 740819 0 pfeldman 2012-10-12 05:01:14 -0700 InjectedScriptSource should not depend on the bind override. 740821 1 168397 pfeldman 2012-10-12 05:03:31 -0700 Created attachment 168397 Patch 740842 2 168397 vsevik 2012-10-12 05:27:20 -0700 Comment on attachment 168397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168397&action=review > Source/WebCore/inspector/InjectedScriptSource.js:58 > + function bound() Could you please add var_args here? 740843 3 168397 yurys 2012-10-12 05:27:41 -0700 Comment on attachment 168397 Patch Let's use closure instead in the two places where the bind is used. 740850 4 pfeldman 2012-10-12 05:36:06 -0700 Committed r131178: <http://trac.webkit.org/changeset/131178> 168397 2012-10-12 05:03:31 -0700 2012-10-12 05:32:01 -0700 Patch bug-99164-20121012160227.patch text/plain 5660 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmY0NWE4ZWQzMmM5ZTIx MTg3ZjM5NmIxOTcxODU1NGY2ZjNlMmVmNS4uZmE1NmYxNDE3NzFmMDZlOWQ0ZjAyNjBlZDgyOGI3 MTNmY2Y5MmMwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTEwLTEyICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHJlbGllcyBvbiBjdXJyZW50IEZ1bmN0aW9uLnByb3RvdHlwZS5iaW5kIGluIHRoZSBmcmFt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkxNjQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmplY3Rl ZFNjcmlwdFNvdXJjZSBzaG91bGQgbm90IGRlcGVuZCBvbiB0aGUgYmluZCBvdmVycmlkZS4KKwor ICAgICAgICBUZXN0OiBpbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWJpbmQtZmFrZS5odG1sCisK KyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanM6CisgICAgICAgICgu KToKKworMjAxMi0xMC0xMiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4K KwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBuZXZlciBleHBhbmQgZ2xvYmFsIHNjb3BlIGF1dG9t YXRpY2FsbHkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk5MTU5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNj cmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNv dXJjZS5qcwppbmRleCA0NzVjYzhmM2MzZjBiZWRkNGUwZTNlZTE2YzMzYjMzMTBlNTkzMzdjLi4w YTA0M2MzOTY0YmIxYzM5ZmY4ZGNkYTE4OGU1ZjEzZDhhMDllMTg0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzCkBAIC0zNCw2ICszNCwz OCBAQAogKGZ1bmN0aW9uIChJbmplY3RlZFNjcmlwdEhvc3QsIGluc3BlY3RlZFdpbmRvdywgaW5q ZWN0ZWRTY3JpcHRJZCkgewogCiAvKioKKyAqIEBwYXJhbSB7QXJndW1lbnRzfSBhcnJheQorICog QHBhcmFtIHtudW1iZXI9fSBpbmRleAorICogQHJldHVybiB7QXJyYXkuPCo+fQorICovCitmdW5j dGlvbiBzbGljZShhcnJheSwgaW5kZXgpCit7CisgICAgdmFyIHJlc3VsdCA9IFtdOworICAgIGZv ciAodmFyIGkgPSBpbmRleCB8fCAwOyBpIDwgYXJyYXkubGVuZ3RoOyArK2kpCisgICAgICAgIHJl c3VsdC5wdXNoKGFycmF5W2ldKTsKKyAgICByZXR1cm4gcmVzdWx0OworfQorCisvKioKKyAqIEBw YXJhbSB7ZnVuY3Rpb24oKX0gZnVuYworICogQHBhcmFtIHtPYmplY3R9IHRoaXNPYmplY3QKKyAq IEBwYXJhbSB7Li4ubnVtYmVyfSB2YXJfYXJncworICovCitmdW5jdGlvbiBiaW5kKGZ1bmMsIHRo aXNPYmplY3QsIHZhcl9hcmdzKQoreworICAgIHZhciBhcmdzID0gc2xpY2UoYXJndW1lbnRzLCAy KTsKKworICAgIGZ1bmN0aW9uIGJvdW5kKCkKKyAgICB7CisgICAgICAgIHJldHVybiBmdW5jLmFw cGx5KHRoaXNPYmplY3QsIGFyZ3MuY29uY2F0KHNsaWNlKGFyZ3VtZW50cykpKTsKKyAgICB9Cisg ICAgYm91bmQudG9TdHJpbmcgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgcmV0dXJuICJib3VuZDog IiArIGZ1bmM7CisgICAgfTsKKyAgICByZXR1cm4gYm91bmQ7Cit9CisKKy8qKgogICogQGNvbnN0 cnVjdG9yCiAgKi8KIHZhciBJbmplY3RlZFNjcmlwdCA9IGZ1bmN0aW9uKCkKQEAgLTkzNSw3ICs5 NjcsNyBAQCBmdW5jdGlvbiBDb21tYW5kTGluZUFQSShjb21tYW5kTGluZUFQSUltcGwsIGNhbGxG cmFtZSkKICAgICAgICAgaWYgKG1lbWJlciBpbiBpbnNwZWN0ZWRXaW5kb3cgfHwgaW5TY29wZVZh cmlhYmxlcyhtZW1iZXIpKQogICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgdGhpc1tt ZW1iZXJdID0gY29tbWFuZExpbmVBUElJbXBsW21lbWJlcl0uYmluZChjb21tYW5kTGluZUFQSUlt cGwpOworICAgICAgICB0aGlzW21lbWJlcl0gPSBiaW5kKGNvbW1hbmRMaW5lQVBJSW1wbFttZW1i ZXJdLCBjb21tYW5kTGluZUFQSUltcGwpOwogICAgIH0KIAogICAgIGZvciAodmFyIGkgPSAwOyBp IDwgNTsgKytpKSB7CkBAIC05NDMsNyArOTc1LDcgQEAgZnVuY3Rpb24gQ29tbWFuZExpbmVBUEko Y29tbWFuZExpbmVBUElJbXBsLCBjYWxsRnJhbWUpCiAgICAgICAgIGlmIChtZW1iZXIgaW4gaW5z cGVjdGVkV2luZG93IHx8IGluU2NvcGVWYXJpYWJsZXMobWVtYmVyKSkKICAgICAgICAgICAgIGNv bnRpbnVlOwogCi0gICAgICAgIHRoaXMuX19kZWZpbmVHZXR0ZXJfXygiJCIgKyBpLCBjb21tYW5k TGluZUFQSUltcGwuX2luc3BlY3RlZE9iamVjdC5iaW5kKGNvbW1hbmRMaW5lQVBJSW1wbCwgaSkp OworICAgICAgICB0aGlzLl9fZGVmaW5lR2V0dGVyX18oIiQiICsgaSwgYmluZChjb21tYW5kTGlu ZUFQSUltcGwuX2luc3BlY3RlZE9iamVjdCwgY29tbWFuZExpbmVBUElJbXBsLCBpKSk7CiAgICAg fQogCiAgICAgdGhpcy4kXyA9IGluamVjdGVkU2NyaXB0Ll9sYXN0UmVzdWx0OwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGFh NDk5OGQ5NGRmOGRlYmU3YmFiNGQwNjcyODkyYjk5ZmYwNzlhNjMuLjEyMzYwZjA2M2IyMDc0MGFi ZTQzZGVhYTUyNmU2OGUyYTk2ZTE0MzcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0xMC0x MiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiByZWxpZXMgb24gY3VycmVudCBGdW5jdGlvbi5wcm90b3R5cGUuYmluZCBpbiB0 aGUgZnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk5MTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvY29uc29sZS9jb21tYW5kLWxpbmUtYXBpLWV4cGVjdGVkLnR4dDoKKyAgICAg ICAgKiBpbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWJpbmQtZmFrZS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtYmluZC1mYWtlLmh0bWw6 IEFkZGVkLgorCiAyMDEyLTEwLTEyICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEV4dHJhY3QgZG9tYWluIHNwZWNpZmljIGVk aXRpbmcgaGFuZGxpbmcgbG9naWMgZnJvbSBVSVNvdXJjZUNvZGUgZGVzY2VuZGFudHMgKHN0ZXAg MSkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb21tYW5kLWxp bmUtYXBpLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbW1h bmQtbGluZS1hcGktZXhwZWN0ZWQudHh0CmluZGV4IDY1YmMxOTc5MjgwZjIwNjM5YzRhNDMzODdj MTEwZWQ2NGYyODEzMGMuLjIyN2M4ZWQwYzk2ODRkNjUxM2Q0NzU0NWEyN2Y0ZWNjZmNkM2QwOTAg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbW1hbmQtbGluZS1h cGktZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbW1h bmQtbGluZS1hcGktZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEsNCBAQAotQ09OU09MRSBNRVNTQUdF OiBsaW5lIDk4NDogVGhlIGNvbnNvbGUgZnVuY3Rpb24gJCgpIGhhcyBjaGFuZ2VkIGZyb20gJD1n ZXRFbGVtZW50QnlJZChpZCkgdG8gJD1xdWVyeVNlbGVjdG9yKHNlbGVjdG9yKS4gWW91IG1pZ2h0 IHRyeSAkKCIjJXMiKQorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEwMTY6IFRoZSBjb25zb2xlIGZ1 bmN0aW9uICQoKSBoYXMgY2hhbmdlZCBmcm9tICQ9Z2V0RWxlbWVudEJ5SWQoaWQpIHRvICQ9cXVl cnlTZWxlY3RvcihzZWxlY3RvcikuIFlvdSBtaWdodCB0cnkgJCgiIyVzIikKIFRlc3RzIHRoYXQg Y29tbWFuZCBsaW5lIGFwaSB3b3Jrcy4KIAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvY29uc29sZS9jb25zb2xlLWJpbmQtZmFrZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWJpbmQtZmFrZS1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNGIyOWNmYzQ5OWI3ZDZkMzIyMmQ5NGIyNjMwNWJkNzhjNDhiMjIzNAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtYmluZC1mYWtl LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK1Rlc3RzIHRoYXQgb3ZlcnJpZGluZyBGdW5j dGlvbi5wcm90b3R5cGUuYmluZCBkb2VzIG5vdCBicmVhayBpbnNwZWN0b3IuCisKK2ZvbworImZv b1ZhbHVlIgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25z b2xlLWJpbmQtZmFrZS5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29s ZS1iaW5kLWZha2UuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYjNhMDA0NjYyNzdkOWVlMjU1NGQxYjhiMmRk NDQwYzhlNzAxNTVmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nv bnNvbGUvY29uc29sZS1iaW5kLWZha2UuaHRtbApAQCAtMCwwICsxLDI5IEBACis8aHRtbD4KKzxo ZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rvci10 ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rv ci9jb25zb2xlLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK3ZhciBmb28gPSAnZm9vVmFs dWUnOworCitGdW5jdGlvbi5wcm90b3R5cGUuYmluZCA9IGZ1bmN0aW9uICgpIHsgdGhyb3cgIjpQ IjsgfTsKKworZnVuY3Rpb24gdGVzdCgpCit7CisgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUlu Q29uc29sZSgiZm9vIiwgc3RlcDEpOworCisgICAgZnVuY3Rpb24gc3RlcDEoKQorICAgIHsKKyAg ICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wQ29uc29sZU1lc3NhZ2VzKCk7CisgICAgICAgIEluc3Bl Y3RvclRlc3QuY29tcGxldGVUZXN0KCk7CisgICAgfQorfQorPC9zY3JpcHQ+Cis8L2hlYWQ+CisK Kzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPgorVGVzdHMgdGhhdCBvdmVycmlkaW5nIEZ1 bmN0aW9uLnByb3RvdHlwZS5iaW5kIGRvZXMgbm90IGJyZWFrIGluc3BlY3Rvci4KKzwvcD4KKwor PC9ib2R5PgorPC9odG1sPgo=