99157 2012-10-12 02:45:31 -0700 Web Inspector: Add "goto tab 1,2,3" hotkeys 2012-10-12 02:54:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 740759 0 pfeldman 2012-10-12 02:45:31 -0700 Ctrl/Cmd + digit shortcuts should select corresponding tabs 740760 1 168382 pfeldman 2012-10-12 02:48:31 -0700 Created attachment 168382 Patch 740763 2 168382 apavlov 2012-10-12 02:53:01 -0700 Comment on attachment 168382 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168382&action=review > Source/WebCore/inspector/front-end/InspectorView.js:138 > + // Ctrl/Cmd + 1-9 should show corresponding tab. tab -> panel 740765 3 pfeldman 2012-10-12 02:54:49 -0700 Committed r131166: <http://trac.webkit.org/changeset/131166> 168382 2012-10-12 02:48:31 -0700 2012-10-12 02:53:01 -0700 Patch bug-99157-20121012134727.patch text/plain 4548 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q2OTliY2Y1NjYwOGE1 N2E1ZjY1ODEyNTg0ZWQzMzZlMjZiNzI2Yy4uOTFkNzgzYjFiOTY5NzcwZDEyYzM3MGEzNzhjNzNi OTlmYjVlMGNkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTEyICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZCAiZ290byB0YWIgMSwyLDMiIGhvdGtleXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MTU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ3RybC9DbWQgKyBkaWdpdCBzaG9ydGN1dHMgc2hvdWxk IHNlbGVjdCBjb3JyZXNwb25kaW5nIHRhYnMKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvSW5zcGVjdG9yVmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5JbnNwZWN0b3JWaWV3 LnByb3RvdHlwZS5fa2V5RG93bik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuSW5zcGVjdG9yVmll dy5wcm90b3R5cGUuX2tleURvd25JbnRlcm5hbCk6CisKIDIwMTItMTAtMTIgIFNoaW55YSBLYXdh bmFrYSAgPHNoaW55YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE9wdGltemllIFNlbGVjdG9y Q2hlY2tpbmdDb250ZXh0IG1lbW9yeSBsYXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvSW5zcGVjdG9yVmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvSW5zcGVjdG9yVmlldy5qcwppbmRleCAzMTk3OTE3MjQxYzU3ZWU1 NTZkOTNlZGNkN2Y4YjM4YzQ4ZjcyY2E0Li4yMmM1MTk2ZjZjOTc2ZDY0Njg4MDQyNDc4ODcyNjY3 OTY5YmM0ZGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0luc3BlY3RvclZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9JbnNwZWN0b3JWaWV3LmpzCkBAIC0xMzIsMTAgKzEzMiwyMyBAQCBXZWJJbnNwZWN0b3IuSW5z cGVjdG9yVmlldy5wcm90b3R5cGUgPSB7CiAKICAgICBfa2V5RG93bjogZnVuY3Rpb24oZXZlbnQp CiAgICAgeworICAgICAgICBpZiAoIVdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LmV2ZW50 SGFzQ3RybE9yTWV0YShldmVudCkpCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgLy8g Q3RybC9DbWQgKyAxLTkgc2hvdWxkIHNob3cgY29ycmVzcG9uZGluZyB0YWIuCisgICAgICAgIGlm ICghZXZlbnQuc2hpZnRLZXkgJiYgIWV2ZW50LmFsdEtleSAmJiBldmVudC5rZXlDb2RlID4gMHgz MCAmJiBldmVudC5rZXlDb2RlIDwgMHgzQSkgeworICAgICAgICAgICAgdmFyIHBhbmVsTmFtZSA9 IHRoaXMuX3BhbmVsT3JkZXJbZXZlbnQua2V5Q29kZSAtIDB4MzFdOworICAgICAgICAgICAgaWYg KHBhbmVsTmFtZSkgeworICAgICAgICAgICAgICAgIHRoaXMuc2hvd1BhbmVsKHBhbmVsTmFtZSk7 CisgICAgICAgICAgICAgICAgZXZlbnQuY29uc3VtZSh0cnVlKTsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCiAgICAgICAgIC8vIEJVRzg1MzEyOiBPbiBG cmVuY2ggQVpFUlRZIGtleWJvYXJkcywgQWx0R3ItXS9bIGNvbWJpbmF0aW9ucyAoc3lub255bW91 cyB0byBDdHJsLUFsdC1dL1sgb24gV2luZG93cykgYXJlIHVzZWQgdG8gZW50ZXIgXS9bLAogICAg ICAgICAvLyBzbyBmb3IgYSBdL1stcmVsYXRlZCBrZXlkb3duIHdlIGRlbGF5IHRoZSBwYW5lbCBz d2l0Y2ggdXNpbmcgYSB0aW1lciwgdG8gc2VlIGlmIHRoZXJlIGlzIGEga2V5cHJlc3MgZXZlbnQg Zm9sbG93aW5nIHRoaXMgb25lLgogICAgICAgICAvLyBJZiB0aGVyZSBpcywgd2UgY2FuY2VsIHRo ZSB0aW1lciBhbmQgZG8gbm90IGNvbnNpZGVyIHRoaXMgYSBwYW5lbCBzd2l0Y2guCi0gICAgICAg IGlmICghV2ViSW5zcGVjdG9yLmlzV2luKCkgfHwgKCF0aGlzLl9vcGVuQnJhY2tldElkZW50aWZp ZXJzLmhhc093blByb3BlcnR5KGV2ZW50LmtleUlkZW50aWZpZXIpICYmICF0aGlzLl9jbG9zZUJy YWNrZXRJZGVudGlmaWVycy5oYXNPd25Qcm9wZXJ0eShldmVudC5rZXlJZGVudGlmaWVyKSkpIHsK KyAgICAgICAgaWYgKCFXZWJJbnNwZWN0b3IuaXNXaW4oKSB8fCAoIXRoaXMuX29wZW5CcmFja2V0 SWRlbnRpZmllcnNbZXZlbnQua2V5SWRlbnRpZmllcl0gJiYgIXRoaXMuX2Nsb3NlQnJhY2tldElk ZW50aWZpZXJzW2V2ZW50LmtleUlkZW50aWZpZXJdKSkgewogICAgICAgICAgICAgdGhpcy5fa2V5 RG93bkludGVybmFsKGV2ZW50KTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQpAQCAt MTQ1LDggKzE1OCw4IEBAIFdlYkluc3BlY3Rvci5JbnNwZWN0b3JWaWV3LnByb3RvdHlwZSA9IHsK IAogICAgIF9rZXlEb3duSW50ZXJuYWw6IGZ1bmN0aW9uKGV2ZW50KQogICAgIHsKLSAgICAgICAg aWYgKHRoaXMuX29wZW5CcmFja2V0SWRlbnRpZmllcnMuaGFzT3duUHJvcGVydHkoZXZlbnQua2V5 SWRlbnRpZmllcikpIHsKLSAgICAgICAgICAgIHZhciBpc1JvdGF0ZUxlZnQgPSBXZWJJbnNwZWN0 b3IuS2V5Ym9hcmRTaG9ydGN1dC5ldmVudEhhc0N0cmxPck1ldGEoZXZlbnQpICYmICFldmVudC5z aGlmdEtleSAmJiAhZXZlbnQuYWx0S2V5OworICAgICAgICBpZiAodGhpcy5fb3BlbkJyYWNrZXRJ ZGVudGlmaWVyc1tldmVudC5rZXlJZGVudGlmaWVyXSkgeworICAgICAgICAgICAgdmFyIGlzUm90 YXRlTGVmdCA9ICFldmVudC5zaGlmdEtleSAmJiAhZXZlbnQuYWx0S2V5OwogICAgICAgICAgICAg aWYgKGlzUm90YXRlTGVmdCkgewogICAgICAgICAgICAgICAgIHZhciBpbmRleCA9IHRoaXMuX3Bh bmVsT3JkZXIuaW5kZXhPZih0aGlzLmN1cnJlbnRQYW5lbCgpLm5hbWUpOwogICAgICAgICAgICAg ICAgIGluZGV4ID0gKGluZGV4ID09PSAwKSA/IHRoaXMuX3BhbmVsT3JkZXIubGVuZ3RoIC0gMSA6 IGluZGV4IC0gMTsKQEAgLTE1NSw3ICsxNjgsNyBAQCBXZWJJbnNwZWN0b3IuSW5zcGVjdG9yVmll dy5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQog Ci0gICAgICAgICAgICB2YXIgaXNHb0JhY2sgPSBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dC5ldmVudEhhc0N0cmxPck1ldGEoZXZlbnQpICYmIGV2ZW50LmFsdEtleTsKKyAgICAgICAgICAg IHZhciBpc0dvQmFjayA9IGV2ZW50LmFsdEtleTsKICAgICAgICAgICAgIGlmIChpc0dvQmFjayAm JiB0aGlzLl9jYW5Hb0JhY2tJbkhpc3RvcnkoKSkgewogICAgICAgICAgICAgICAgIHRoaXMuX2dv QmFja0luSGlzdG9yeSgpOwogICAgICAgICAgICAgICAgIGV2ZW50LmNvbnN1bWUodHJ1ZSk7CkBA IC0xNjMsOCArMTc2LDggQEAgV2ViSW5zcGVjdG9yLkluc3BlY3RvclZpZXcucHJvdG90eXBlID0g ewogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKHRoaXMuX2Ns b3NlQnJhY2tldElkZW50aWZpZXJzLmhhc093blByb3BlcnR5KGV2ZW50LmtleUlkZW50aWZpZXIp KSB7Ci0gICAgICAgICAgICB2YXIgaXNSb3RhdGVSaWdodCA9IFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0LmV2ZW50SGFzQ3RybE9yTWV0YShldmVudCkgJiYgIWV2ZW50LnNoaWZ0S2V5ICYm ICFldmVudC5hbHRLZXk7CisgICAgICAgIGlmICh0aGlzLl9jbG9zZUJyYWNrZXRJZGVudGlmaWVy c1tldmVudC5rZXlJZGVudGlmaWVyXSkgeworICAgICAgICAgICAgdmFyIGlzUm90YXRlUmlnaHQg PSAhZXZlbnQuc2hpZnRLZXkgJiYgIWV2ZW50LmFsdEtleTsKICAgICAgICAgICAgIGlmIChpc1Jv dGF0ZVJpZ2h0KSB7CiAgICAgICAgICAgICAgICAgdmFyIGluZGV4ID0gdGhpcy5fcGFuZWxPcmRl ci5pbmRleE9mKHRoaXMuY3VycmVudFBhbmVsKCkubmFtZSk7CiAgICAgICAgICAgICAgICAgaW5k ZXggPSAoaW5kZXggKyAxKSAlIHRoaXMuX3BhbmVsT3JkZXIubGVuZ3RoOwpAQCAtMTczLDcgKzE4 Niw3IEBAIFdlYkluc3BlY3Rvci5JbnNwZWN0b3JWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAKLSAgICAgICAgICAgIHZhciBpc0dvRm9y d2FyZCA9IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LmV2ZW50SGFzQ3RybE9yTWV0YShl dmVudCkgJiYgZXZlbnQuYWx0S2V5OworICAgICAgICAgICAgdmFyIGlzR29Gb3J3YXJkID0gZXZl bnQuYWx0S2V5OwogICAgICAgICAgICAgaWYgKGlzR29Gb3J3YXJkICYmIHRoaXMuX2NhbkdvRm9y d2FyZEluSGlzdG9yeSgpKSB7CiAgICAgICAgICAgICAgICAgdGhpcy5fZ29Gb3J3YXJkSW5IaXN0 b3J5KCk7CiAgICAgICAgICAgICAgICAgZXZlbnQuY29uc3VtZSh0cnVlKTsK