99136 2012-10-11 21:52:58 -0700 Check parameter's safety first 2012-10-12 10:33:34 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 ljaehun.lim webkit-unassigned crogers eric.carlson feature-media-reviews jer.noble webkit.review.bot oldest_to_newest 740614 0 ljaehun.lim 2012-10-11 21:52:58 -0700 Pointer parameter was used before NULL checking. This patch moves safety checking statements to the head of the function. 740615 1 168356 ljaehun.lim 2012-10-11 21:54:32 -0700 Created attachment 168356 Patch 740976 2 jer.noble 2012-10-12 09:39:28 -0700 Good catch. LGTM. 741014 3 168356 webkit.review.bot 2012-10-12 10:33:31 -0700 Comment on attachment 168356 Patch Clearing flags on attachment: 168356 Committed r131198: <http://trac.webkit.org/changeset/131198> 741015 4 webkit.review.bot 2012-10-12 10:33:34 -0700 All reviewed patches have been landed. Closing bug. 168356 2012-10-11 21:54:32 -0700 2012-10-12 10:33:31 -0700 Patch patch.diff text/plain 3463 ljaehun.lim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZDU3MTI5Li44MGQ4NzViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTAtMTEgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBDaGVjayBwYXJhbWV0ZXIncyBzYWZldHkgZmlyc3QKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MTM2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUG9pbnRlciBwYXJhbWV0ZXIgd2FzIHVzZWQg YmVmb3JlIE5VTEwgY2hlY2tpbmcuCisgICAgICAgIFRoaXMgcGF0Y2ggbW92ZXMgc2FmZXR5IGNo ZWNraW5nIHN0YXRlbWVudHMgdG8gdGhlIGhlYWQgb2YgdGhlIGZ1bmN0aW9uLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gTm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0v YXVkaW8vQXVkaW9DaGFubmVsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvQ2hhbm5lbDo6 Y29weUZyb21SYW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0NoYW5uZWw6OnN1bUZyb20p OgorICAgICAgICAqIHBsYXRmb3JtL2F1ZGlvL0VxdWFsUG93ZXJQYW5uZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RXF1YWxQb3dlclBhbm5lcjo6cGFuKToKKwogMjAxMi0xMC0xMSAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEF0dGVtcHQgdG8gZml4 IGJ1aWxkIGJyb2tlbiBieSByMTMxMTI1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vQXVkaW9DaGFubmVsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL0F1ZGlvQ2hhbm5lbC5jcHAKaW5kZXggMjMyMTM0OS4uYjFjYWUwMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vQXVkaW9DaGFubmVsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9BdWRpb0NoYW5uZWwuY3BwCkBAIC02NSwxNSArNjUs MTUgQEAgdm9pZCBBdWRpb0NoYW5uZWw6OmNvcHlGcm9tKGNvbnN0IEF1ZGlvQ2hhbm5lbCogc291 cmNlQ2hhbm5lbCkKIAogdm9pZCBBdWRpb0NoYW5uZWw6OmNvcHlGcm9tUmFuZ2UoY29uc3QgQXVk aW9DaGFubmVsKiBzb3VyY2VDaGFubmVsLCB1bnNpZ25lZCBzdGFydEZyYW1lLCB1bnNpZ25lZCBl bmRGcmFtZSkKIHsKLSAgICBpZiAoc291cmNlQ2hhbm5lbC0+aXNTaWxlbnQoKSAmJiBpc1NpbGVu dCgpKQotICAgICAgICByZXR1cm47Ci0KICAgICAvLyBDaGVjayB0aGF0IHJhbmdlIGlzIHNhZmUg Zm9yIHJlYWRpbmcgZnJvbSBzb3VyY2VDaGFubmVsLgogICAgIGJvb2wgaXNSYW5nZVNhZmUgPSBz b3VyY2VDaGFubmVsICYmIHN0YXJ0RnJhbWUgPCBlbmRGcmFtZSAmJiBlbmRGcmFtZSA8PSBzb3Vy Y2VDaGFubmVsLT5sZW5ndGgoKTsKICAgICBBU1NFUlQoaXNSYW5nZVNhZmUpOwogICAgIGlmICgh aXNSYW5nZVNhZmUpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmIChzb3VyY2VDaGFubmVsLT5p c1NpbGVudCgpICYmIGlzU2lsZW50KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIENoZWNr IHRoYXQgdGhpcyBjaGFubmVsIGhhcyBlbm91Z2ggc3BhY2UuCiAgICAgc2l6ZV90IHJhbmdlTGVu Z3RoID0gZW5kRnJhbWUgLSBzdGFydEZyYW1lOwogICAgIGJvb2wgaXNSYW5nZUxlbmd0aFNhZmUg PSByYW5nZUxlbmd0aCA8PSBsZW5ndGgoKTsKQEAgLTk1LDE0ICs5NSwxNCBAQCB2b2lkIEF1ZGlv Q2hhbm5lbDo6Y29weUZyb21SYW5nZShjb25zdCBBdWRpb0NoYW5uZWwqIHNvdXJjZUNoYW5uZWws IHVuc2lnbmVkIHN0YQogCiB2b2lkIEF1ZGlvQ2hhbm5lbDo6c3VtRnJvbShjb25zdCBBdWRpb0No YW5uZWwqIHNvdXJjZUNoYW5uZWwpCiB7Ci0gICAgaWYgKHNvdXJjZUNoYW5uZWwtPmlzU2lsZW50 KCkpCi0gICAgICAgIHJldHVybjsKLQogICAgIGJvb2wgaXNTYWZlID0gc291cmNlQ2hhbm5lbCAm JiBzb3VyY2VDaGFubmVsLT5sZW5ndGgoKSA+PSBsZW5ndGgoKTsKICAgICBBU1NFUlQoaXNTYWZl KTsKICAgICBpZiAoIWlzU2FmZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKHNvdXJjZUNo YW5uZWwtPmlzU2lsZW50KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIGlmIChpc1NpbGVudCgp KQogICAgICAgICBjb3B5RnJvbShzb3VyY2VDaGFubmVsKTsKICAgICBlbHNlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9FcXVhbFBvd2VyUGFubmVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL0VxdWFsUG93ZXJQYW5uZXIuY3BwCmluZGV4IDkw MzUzNjcuLjZiMjI5ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L0VxdWFsUG93ZXJQYW5uZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlv L0VxdWFsUG93ZXJQYW5uZXIuY3BwCkBAIC01MSwxMiArNTEsMTMgQEAgRXF1YWxQb3dlclBhbm5l cjo6RXF1YWxQb3dlclBhbm5lcihmbG9hdCBzYW1wbGVSYXRlKQogCiB2b2lkIEVxdWFsUG93ZXJQ YW5uZXI6OnBhbihkb3VibGUgYXppbXV0aCwgZG91YmxlIC8qZWxldmF0aW9uKi8sIGNvbnN0IEF1 ZGlvQnVzKiBpbnB1dEJ1cywgQXVkaW9CdXMqIG91dHB1dEJ1cywgc2l6ZV90IGZyYW1lc1RvUHJv Y2VzcykKIHsKLSAgICB1bnNpZ25lZCBudW1iZXJPZklucHV0Q2hhbm5lbHMgPSBpbnB1dEJ1cy0+ bnVtYmVyT2ZDaGFubmVscygpOwotICAgIGJvb2wgaXNJbnB1dFNhZmUgPSBpbnB1dEJ1cyAmJiAo bnVtYmVyT2ZJbnB1dENoYW5uZWxzID09IDEgfHwgbnVtYmVyT2ZJbnB1dENoYW5uZWxzID09IDIp ICYmIGZyYW1lc1RvUHJvY2VzcyA8PSBpbnB1dEJ1cy0+bGVuZ3RoKCk7CisgICAgYm9vbCBpc0lu cHV0U2FmZSA9IGlucHV0QnVzICYmIChpbnB1dEJ1cy0+bnVtYmVyT2ZDaGFubmVscygpID09IDEg fHwgaW5wdXRCdXMtPm51bWJlck9mQ2hhbm5lbHMoKSA9PSAyKSAmJiBmcmFtZXNUb1Byb2Nlc3Mg PD0gaW5wdXRCdXMtPmxlbmd0aCgpOwogICAgIEFTU0VSVChpc0lucHV0U2FmZSk7CiAgICAgaWYg KCFpc0lucHV0U2FmZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgdW5zaWduZWQgbnVtYmVyT2ZJ bnB1dENoYW5uZWxzID0gaW5wdXRCdXMtPm51bWJlck9mQ2hhbm5lbHMoKTsKKwogICAgIGJvb2wg aXNPdXRwdXRTYWZlID0gb3V0cHV0QnVzICYmIG91dHB1dEJ1cy0+bnVtYmVyT2ZDaGFubmVscygp ID09IDIgJiYgZnJhbWVzVG9Qcm9jZXNzIDw9IG91dHB1dEJ1cy0+bGVuZ3RoKCk7CiAgICAgQVNT RVJUKGlzT3V0cHV0U2FmZSk7CiAgICAgaWYgKCFpc091dHB1dFNhZmUpCg==