99135 2012-10-11 21:51:59 -0700 Change creation of layer when blendmode is set 2012-10-12 13:04:01 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 99119 1 cabanier cabanier eric simon.fraser webkit.review.bot oldest_to_newest 740610 0 cabanier 2012-10-11 21:51:59 -0700 The current code always creates a layer when it sees a blend mode. This is not always necessary since Core Graphics supports this idiom. This patch will change the code so it no longer creates a layer. Subsequent patches are needed for cases that layers are needed such as when there is video, nested blending or filters. 740620 1 168358 cabanier 2012-10-11 22:12:30 -0700 Created attachment 168358 Patch 740994 2 168358 simon.fraser 2012-10-12 09:58:01 -0700 Comment on attachment 168358 Patch You need to change RenderLayerCompositor::requiresCompositingForIndirectReason() to make a compositing layer when blending is on, when children are composited. You need a test that has a blended div with a 3d-transformed descendant to test this. 741103 3 cabanier 2012-10-12 12:14:08 -0700 (In reply to comment #2) > (From update of attachment 168358 [details]) > You need to change RenderLayerCompositor::requiresCompositingForIndirectReason() to make a compositing layer when blending is on, when children are composited. > > You need a test that has a blended div with a 3d-transformed descendant to test this. I know that this is not a complete patch. As we discussed, I want to land the CG code first but the tests won't work since the layer negates the effect of blending. 168358 2012-10-11 22:12:30 -0700 2012-10-12 09:58:01 -0700 Patch bug-99135-20121011221157.patch text/plain 7054 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTE0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEwLTExICBSaWsgQ2Fi YW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CisKKyAgICAgICAgQ2hhbmdlIGNyZWF0aW9uIG9m IGxheWVyIHdoZW4gYmxlbmRtb2RlIGlzIHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkxMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIGxvZ2ljIHNvIHRoYXQgYmxlbmRpbmcgZG9lcyBu b3QgYWx3YXlzIGNyZWF0ZSBhIGxheWVyLgorCisgICAgICAgIFRlc3Q6IGNzczMvY29tcG9zaXRp bmcvc2hvdWxkLW5vdC1oYXZlLWNvbXBvc2l0aW5nLWxheWVyLmh0bWwKKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nTGF5ZXIpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nRm9yQmxl bmRpbmcpOgorCiAyMDEyLTEwLTExICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg3MDAKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0 b3IuY3BwCShyZXZpc2lvbiAxMzExMTIpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ2Niw2ICsxNDY2LDcg QEAgYm9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcAogICAgICAgICB8fCBj bGlwc0NvbXBvc2l0aW5nRGVzY2VuZGFudHMobGF5ZXIpCiAgICAgICAgIHx8IHJlcXVpcmVzQ29t cG9zaXRpbmdGb3JBbmltYXRpb24ocmVuZGVyZXIpCiAgICAgICAgIHx8IHJlcXVpcmVzQ29tcG9z aXRpbmdGb3JGaWx0ZXJzKHJlbmRlcmVyKQorICAgICAgICB8fCByZXF1aXJlc0NvbXBvc2l0aW5n Rm9yQmxlbmRpbmcocmVuZGVyZXIpCiAgICAgICAgIHx8IHJlcXVpcmVzQ29tcG9zaXRpbmdGb3JQ b3NpdGlvbihyZW5kZXJlciwgbGF5ZXIpCiAgICAgICAgIHx8IHJlcXVpcmVzQ29tcG9zaXRpbmdG b3JPdmVyZmxvd1Njcm9sbGluZyhsYXllcikKICAgICAgICAgfHwgcmVxdWlyZXNDb21wb3NpdGlu Z0ZvckJsZW5kaW5nKHJlbmRlcmVyKTsKQEAgLTE4MzQsMTQgKzE4MzUsOSBAQCBib29sIFJlbmRl ckxheWVyQ29tcG9zaXRvcjo6cmVxdWlyZXNDb21wCiAjZW5kaWYKIH0KIAotYm9vbCBSZW5kZXJM YXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRpbmdGb3JCbGVuZGluZyhSZW5kZXJPYmpl Y3QqIHJlbmRlcmVyKSBjb25zdAorYm9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVz Q29tcG9zaXRpbmdGb3JCbGVuZGluZyhSZW5kZXJPYmplY3QqKSBjb25zdAogewotI2lmIEVOQUJM RShDU1NfQ09NUE9TSVRJTkcpCi0gICAgcmV0dXJuIHJlbmRlcmVyLT5oYXNCbGVuZE1vZGUoKTsK LSNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKHJlbmRlcmVyKTsKICAgICByZXR1cm4gZmFsc2U7Ci0j ZW5kaWYKIH0KIAogYm9vbCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OnJlcXVpcmVzQ29tcG9zaXRp bmdGb3JQb3NpdGlvbihSZW5kZXJPYmplY3QqIHJlbmRlcmVyLCBjb25zdCBSZW5kZXJMYXllciog bGF5ZXIpIGNvbnN0CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzExNDIpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMC0xMSAgUmlr IENhYmFuaWVyICA8Y2FiYW5pZXJAYWRvYmUuY29tPgorCisgICAgICAgIENoYW5nZSBjcmVhdGlv biBvZiBsYXllciB3aGVuIGJsZW5kbW9kZSBpcyBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCBsb2dpYyBzbyB0aGF0IGJsZW5kaW5nIGRv ZXMgbm90IGFsd2F5cyBjcmVhdGUgYSBsYXllci4KKworICAgICAgICAqIGNzczMvY29tcG9zaXRp bmcvc2hvdWxkLWhhdmUtY29tcG9zaXRpbmctbGF5ZXItZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgor ICAgICAgICAqIGNzczMvY29tcG9zaXRpbmcvc2hvdWxkLWhhdmUtY29tcG9zaXRpbmctbGF5ZXIu aHRtbDogUmVtb3ZlZC4KKyAgICAgICAgKiBjc3MzL2NvbXBvc2l0aW5nL3Nob3VsZC1ub3QtaGF2 ZS1jb21wb3NpdGluZy1sYXllci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGNzczMv Y29tcG9zaXRpbmcvc2hvdWxkLW5vdC1oYXZlLWNvbXBvc2l0aW5nLWxheWVyLmh0bWw6IEFkZGVk LgorCiAyMDEyLTEwLTExICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4g CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmlld2VkIGdhcmRlbmluZywgVGVzdEV4cGVjdGF0 aW9uIHVwZGF0ZWQuCkluZGV4OiBMYXlvdXRUZXN0cy9jc3MzL2NvbXBvc2l0aW5nL3Nob3VsZC1o YXZlLWNvbXBvc2l0aW5nLWxheWVyLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9jc3MzL2NvbXBvc2l0aW5nL3Nob3VsZC1oYXZlLWNvbXBvc2l0aW5nLWxheWVyLWV4cGVj dGVkLnR4dAkocmV2aXNpb24gMTMxMTEyKQorKysgTGF5b3V0VGVzdHMvY3NzMy9jb21wb3NpdGlu Zy9zaG91bGQtaGF2ZS1jb21wb3NpdGluZy1sYXllci1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTEsMjIgKzAsMCBAQAotVGVzdCB0byBtYWtlIHN1cmUgYSBibGVuZCBtb2RlIGNyZWF0 ZXMgYSBjb21wb3NpdGluZyBsYXllci4gVGVzdCBpcyBzdWNjZXNzZnVsIG9mIHJlbmRlciB0cmVl IHNob3dzIGNvbXBvc2l0aW5nCi0KLU9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBv ZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KLQotCi1QQVNT IGNvbnRlbnQgaGFzIGNvbXBvc2l0aW5nIGxheWVycwotCi0oR3JhcGhpY3NMYXllcgotICAoYm91 bmRzIDgwMC4wMCA2MDAuMDApCi0gIChjaGlsZHJlbiAxCi0gICAgKEdyYXBoaWNzTGF5ZXIKLSAg ICAgIChib3VuZHMgODAwLjAwIDYwMC4wMCkKLSAgICAgIChjaGlsZHJlbiAxCi0gICAgICAgIChH cmFwaGljc0xheWVyCi0gICAgICAgICAgKHBvc2l0aW9uIDguMDAgNzYuMDApCi0gICAgICAgICAg KGJvdW5kcyAxNjAuMDAgOTAuMDApCi0gICAgICAgICkKLSAgICAgICkKLSAgICApCi0gICkKLSkK LQpJbmRleDogTGF5b3V0VGVzdHMvY3NzMy9jb21wb3NpdGluZy9zaG91bGQtaGF2ZS1jb21wb3Np dGluZy1sYXllci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2NzczMvY29tcG9zaXRp bmcvc2hvdWxkLWhhdmUtY29tcG9zaXRpbmctbGF5ZXIuaHRtbAkocmV2aXNpb24gMTMxMTEyKQor KysgTGF5b3V0VGVzdHMvY3NzMy9jb21wb3NpdGluZy9zaG91bGQtaGF2ZS1jb21wb3NpdGluZy1s YXllci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMwICswLDAgQEAKLTwhRE9DVFlQRSBIVE1M IFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KLTxodG1sPgotPGhlYWQ+Ci08c2NyaXB0 IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgot PC9oZWFkPgotPHNjcmlwdD4KLSAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKLSAgICAgICAg dGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Ci0gICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9u ZSgpOwotICAgIH0KLQotICAgIGZ1bmN0aW9uIGRvVGVzdCgpCi0gICAgewotICAgICAgICBkZXNj cmlwdGlvbigiVGVzdCB0byBtYWtlIHN1cmUgYSBibGVuZCBtb2RlIGNyZWF0ZXMgYSBjb21wb3Np dGluZyBsYXllci4gVGVzdCBpcyBzdWNjZXNzZnVsIG9mIHJlbmRlciB0cmVlIHNob3dzIGNvbXBv c2l0aW5nIik7Ci0gICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewotICAgICAgICAgICAg dmFyIGxheWVycyA9IHdpbmRvdy5pbnRlcm5hbHMubGF5ZXJUcmVlQXNUZXh0KGRvY3VtZW50KTsK LSAgICAgICAgICAgIGlmIChsYXllcnMgPT0gIiIpCi0gICAgICAgICAgICAgICAgdGVzdEZhaWxl ZCgibm8gY29tcG9zaXRpbmcgbGF5ZXJzIik7Ci0gICAgICAgICAgICBlbHNlCi0gICAgICAgICAg ICAgICAgdGVzdFBhc3NlZCgiY29udGVudCBoYXMgY29tcG9zaXRpbmcgbGF5ZXJzIik7Ci0gICAg ICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibGF5ZXJ0cmVlIikuaW5uZXJUZXh0ID0g bGF5ZXJzOwotICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Ci0gICAgICAgIH0K LSAgICB9Ci0gICAgCi0gICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBkb1Rlc3Qs IGZhbHNlKTsKLQotPC9zY3JpcHQ+Ci08aW1nIHN0eWxlPSItd2Via2l0LWJsZW5kLW1vZGU6IG11 bHRpcGx5OyIgc3JjPSJyZXNvdXJjZXMvcmVmZXJlbmNlLnBuZyI+Ci08cHJlIGlkPSJsYXllcnRy ZWUiPjwvcHJlPgpJbmRleDogTGF5b3V0VGVzdHMvY3NzMy9jb21wb3NpdGluZy9zaG91bGQtbm90 LWhhdmUtY29tcG9zaXRpbmctbGF5ZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2NzczMvY29tcG9zaXRpbmcvc2hvdWxkLW5vdC1oYXZlLWNvbXBvc2l0aW5nLWxheWVy LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2NzczMvY29tcG9zaXRp bmcvc2hvdWxkLW5vdC1oYXZlLWNvbXBvc2l0aW5nLWxheWVyLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw4IEBACitUZXN0IHRvIG1ha2Ugc3VyZSBhIGJsZW5kIG1vZGUgY3Jl YXRlcyBhIGNvbXBvc2l0aW5nIGxheWVyLiBUZXN0IGlzIHN1Y2Nlc3NmdWwgb2YgcmVuZGVyIHRy ZWUgc2hvd3MgY29tcG9zaXRpbmcKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BB U1Mgbm8gY29tcG9zaXRpbmcgbGF5ZXJzCisKKwpJbmRleDogTGF5b3V0VGVzdHMvY3NzMy9jb21w b3NpdGluZy9zaG91bGQtbm90LWhhdmUtY29tcG9zaXRpbmctbGF5ZXIuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9jc3MzL2NvbXBvc2l0aW5nL3Nob3VsZC1ub3QtaGF2ZS1jb21wb3Np dGluZy1sYXllci5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvY3NzMy9jb21wb3Np dGluZy9zaG91bGQtbm90LWhhdmUtY29tcG9zaXRpbmctbGF5ZXIuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwzMCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRN TC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8c2NyaXB0PgorICAgIGlm ICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsK KyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgZnVuY3Rp b24gZG9UZXN0KCkKKyAgICB7CisgICAgICAgIGRlc2NyaXB0aW9uKCJUZXN0IHRvIG1ha2Ugc3Vy ZSBhIGJsZW5kIG1vZGUgY3JlYXRlcyBhIGNvbXBvc2l0aW5nIGxheWVyLiBUZXN0IGlzIHN1Y2Nl c3NmdWwgb2YgcmVuZGVyIHRyZWUgc2hvd3MgY29tcG9zaXRpbmciKTsKKyAgICAgICAgaWYgKHdp bmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICB2YXIgbGF5ZXJzID0gd2luZG93LmludGVy bmFscy5sYXllclRyZWVBc1RleHQoZG9jdW1lbnQpOworICAgICAgICAgICAgaWYgKGxheWVycyA9 PSAiIikKKyAgICAgICAgICAgICAgICB0ZXN0UGFzc2VkKCJubyBjb21wb3NpdGluZyBsYXllcnMi KTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICB0ZXN0RmFpbGVkKCJjb250ZW50 IGhhcyBjb21wb3NpdGluZyBsYXllcnMiKTsKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJsYXllcnRyZWUiKS5pbm5lclRleHQgPSBsYXllcnM7CisgICAgICAgICAgICB0ZXN0 UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgfQorICAgIH0KKyAgICAKKyAgICB3aW5kb3cu YWRkRXZlbnRMaXN0ZW5lcignbG9hZCcsIGRvVGVzdCwgZmFsc2UpOworCis8L3NjcmlwdD4KKzxp bWcgc3R5bGU9Ii13ZWJraXQtYmxlbmQtbW9kZTogbXVsdGlwbHk7IiBzcmM9InJlc291cmNlcy9y ZWZlcmVuY2UucG5nIj4KKzxwcmUgaWQ9ImxheWVydHJlZSI+PC9wcmU+Cg==