99122 2012-10-11 17:40:16 -0700 LocalCurrentGraphicsContext will never restore the current context to null 2012-10-11 18:29:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca simon.fraser oldest_to_newest 740470 0 thorton 2012-10-11 17:40:16 -0700 In a WebKit2 world, at rest, we are in a state where NSGraphicsContext is null (because we have no NSWindow, NSViews, etc.) LocalCurrentGraphicsContext is supposed to make temporary changes to the current Cocoa graphics context. However! It will not restore the current context to null, so you can end up with an unexpected context as the "at rest" context. 740493 1 168327 thorton 2012-10-11 18:21:44 -0700 Created attachment 168327 patch 740494 2 168327 simon.fraser 2012-10-11 18:22:59 -0700 Comment on attachment 168327 patch View in context: https://bugs.webkit.org/attachment.cgi?id=168327&action=review > Source/WebCore/ChangeLog:12 > + LocalCurrentGraphicsContext is meant to cause temporary changes to > + NSGraphicsContext's currentContext. However, if it is entered when > + currentContext is null, it will not restore to null, as a null > + m_savedNSGraphicsContext was being used to indicate that the current and > + passed-in graphics contexts were equal (and thus no save/restore was required). You should also mentiong flipping the order of the restores. 740497 3 thorton 2012-10-11 18:29:48 -0700 http://trac.webkit.org/changeset/131120 168327 2012-10-11 18:21:44 -0700 2012-10-11 18:22:59 -0700 patch gc.diff text/plain 3359 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZjA0ZGEyLi4zNGVhMzQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMTAtMTEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgTG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0IHdpbGwgbmV2ZXIgcmVzdG9yZSB0 aGUgY3VycmVudCBjb250ZXh0IHRvIG51bGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk5MTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0IGlzIG1lYW50IHRv IGNhdXNlIHRlbXBvcmFyeSBjaGFuZ2VzIHRvCisgICAgICAgIE5TR3JhcGhpY3NDb250ZXh0J3Mg Y3VycmVudENvbnRleHQuIEhvd2V2ZXIsIGlmIGl0IGlzIGVudGVyZWQgd2hlbgorICAgICAgICBj dXJyZW50Q29udGV4dCBpcyBudWxsLCBpdCB3aWxsIG5vdCByZXN0b3JlIHRvIG51bGwsIGFzIGEg bnVsbAorICAgICAgICBtX3NhdmVkTlNHcmFwaGljc0NvbnRleHQgd2FzIGJlaW5nIHVzZWQgdG8g aW5kaWNhdGUgdGhhdCB0aGUgY3VycmVudCBhbmQKKyAgICAgICAgcGFzc2VkLWluIGdyYXBoaWNz IGNvbnRleHRzIHdlcmUgZXF1YWwgKGFuZCB0aHVzIG5vIHNhdmUvcmVzdG9yZSB3YXMgcmVxdWly ZWQpLgorCisgICAgICAgIEFkZCBhIHNlcGFyYXRlIGZsYWcgZm9yIHdoZXRoZXIgb3Igbm90IHdl IG5lZWQgdG8gcmVzdG9yZSB0aGUgY29udGV4dC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9M b2NhbEN1cnJlbnRHcmFwaGljc0NvbnRleHQuaDoKKyAgICAgICAgKExvY2FsQ3VycmVudEdyYXBo aWNzQ29udGV4dCk6CisgICAgICAgICogcGxhdGZvcm0vbWFjL0xvY2FsQ3VycmVudEdyYXBoaWNz Q29udGV4dC5tbToKKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4 dDo6TG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OkxvY2Fs Q3VycmVudEdyYXBoaWNzQ29udGV4dDo6fkxvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dCk6CisK IDIwMTItMTAtMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtTb3VwXSBDbGVhbiB1cCBSZXNvdXJjZUVycm9yIGNyZWF0aW9uCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0 LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTG9jYWxDdXJyZW50R3JhcGhpY3NDb250 ZXh0LmgKaW5kZXggZDRkZjdlNi4uODI0ZjJmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL0xvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dC5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9Mb2NhbEN1cnJlbnRHcmFwaGljc0NvbnRleHQuaApAQCAtMzks NiArMzksNyBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIEdyYXBoaWNzQ29udGV4dCogbV9zYXZl ZEdyYXBoaWNzQ29udGV4dDsKICAgICBOU0dyYXBoaWNzQ29udGV4dCogbV9zYXZlZE5TR3JhcGhp Y3NDb250ZXh0OworICAgIGJvb2wgbV9kaWRTZXRHcmFwaGljc0NvbnRleHQ7CiAjaWYgVVNFKFNL SUEpCiAgICAgZ2Z4OjpTa2lhQml0TG9ja2VyIG1fc2tpYUJpdExvY2tlcjsKICNlbmRpZgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0xvY2FsQ3VycmVudEdyYXBoaWNz Q29udGV4dC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9Mb2NhbEN1cnJlbnRHcmFw aGljc0NvbnRleHQubW0KaW5kZXggNWYxZDA3Yy4uZjAzM2RmMyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL0xvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dC5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0 Lm1tCkBAIC0zMCw4ICszMCw5IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIExvY2FsQ3VycmVu dEdyYXBoaWNzQ29udGV4dDo6TG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0KEdyYXBoaWNzQ29u dGV4dCogZ3JhcGhpY3NDb250ZXh0KQorICAgIDogbV9kaWRTZXRHcmFwaGljc0NvbnRleHQoZmFs c2UpCiAjaWYgVVNFKFNLSUEpCi0gICAgOiBtX3NraWFCaXRMb2NrZXIoZ3JhcGhpY3NDb250ZXh0 LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y2FudmFzKCkpCisgICAgLCBtX3NraWFCaXRMb2NrZXIoZ3Jh cGhpY3NDb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y2FudmFzKCkpCiAjZW5kaWYKIHsKICAg ICBtX3NhdmVkR3JhcGhpY3NDb250ZXh0ID0gZ3JhcGhpY3NDb250ZXh0OwpAQCAtNDIsMjAgKzQz LDIxIEBAIExvY2FsQ3VycmVudEdyYXBoaWNzQ29udGV4dDo6TG9jYWxDdXJyZW50R3JhcGhpY3ND b250ZXh0KEdyYXBoaWNzQ29udGV4dCogZ3JhcGhpCiAgICAgICAgIG1fc2F2ZWROU0dyYXBoaWNz Q29udGV4dCA9IDA7CiAgICAgICAgIHJldHVybjsKICAgICB9Ci0gICAgCisKICAgICBtX3NhdmVk TlNHcmFwaGljc0NvbnRleHQgPSBbW05TR3JhcGhpY3NDb250ZXh0IGN1cnJlbnRDb250ZXh0XSBy ZXRhaW5dOwogICAgIE5TR3JhcGhpY3NDb250ZXh0KiBuZXdDb250ZXh0ID0gW05TR3JhcGhpY3ND b250ZXh0IGdyYXBoaWNzQ29udGV4dFdpdGhHcmFwaGljc1BvcnQ6Y2dDb250ZXh0IGZsaXBwZWQ6 WUVTXTsKICAgICBbTlNHcmFwaGljc0NvbnRleHQgc2V0Q3VycmVudENvbnRleHQ6bmV3Q29udGV4 dF07CisgICAgbV9kaWRTZXRHcmFwaGljc0NvbnRleHQgPSB0cnVlOwogfQogCiBMb2NhbEN1cnJl bnRHcmFwaGljc0NvbnRleHQ6On5Mb2NhbEN1cnJlbnRHcmFwaGljc0NvbnRleHQoKQogewotICAg IG1fc2F2ZWRHcmFwaGljc0NvbnRleHQtPnJlc3RvcmUoKTsKLQotICAgIGlmIChtX3NhdmVkTlNH cmFwaGljc0NvbnRleHQpIHsKKyAgICBpZiAobV9kaWRTZXRHcmFwaGljc0NvbnRleHQpIHsKICAg ICAgICAgW05TR3JhcGhpY3NDb250ZXh0IHNldEN1cnJlbnRDb250ZXh0Om1fc2F2ZWROU0dyYXBo aWNzQ29udGV4dF07CiAgICAgICAgIFttX3NhdmVkTlNHcmFwaGljc0NvbnRleHQgcmVsZWFzZV07 CiAgICAgfQorCisgICAgbV9zYXZlZEdyYXBoaWNzQ29udGV4dC0+cmVzdG9yZSgpOwogfQogCiBD R0NvbnRleHRSZWYgTG9jYWxDdXJyZW50R3JhcGhpY3NDb250ZXh0OjpjZ0NvbnRleHQoKQo=