99117 2012-10-11 16:44:21 -0700 Move TransformState code into its own member function, and remove a test that was prematurely added 2012-10-12 18:18:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 740416 0 simon.fraser 2012-10-11 16:44:21 -0700 Move TransformState code into its own member function, and remove a test that was prematurely added 740419 1 168315 simon.fraser 2012-10-11 16:45:45 -0700 Created attachment 168315 Patch 740429 2 168315 thorton 2012-10-11 16:49:30 -0700 Comment on attachment 168315 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168315&action=review > Source/WebCore/ChangeLog:8 > + The code that manipulates the TransormState and computes the visible rect is going to get typo Transform > Source/WebCore/ChangeLog:11 > + Remove a test that wasn't supposed to be added yet. Unclear why these are in the same patch. (what would happen if someone wanted to roll out the TransformState change?) > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:950 > + // Save the state before sending down to kids and restore it after Punctuation. 741369 3 simon.fraser 2012-10-12 18:18:06 -0700 http://trac.webkit.org/changeset/131247 168315 2012-10-11 16:45:45 -0700 2012-10-11 16:49:30 -0700 Patch bug-99117-20121011164444.patch text/plain 7338 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMDg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZlY2EzNWM1OTViNzhh YWE4ZjhkMzNlNzZmZTJjNDJjMTZiMTk0Mi4uY2YwZjhhYzRmYTQzM2RlN2ZiYzdkNGMxN2FkMmEx OTFlN2NkZTZhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTEwLTExICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIE1vdmUgVHJhbnNm b3JtU3RhdGUgY29kZSBpbnRvIGl0cyBvd24gbWVtYmVyIGZ1bmN0aW9uLCBhbmQgcmVtb3ZlIGEg dGVzdCB0aGF0IHdhcyBwcmVtYXR1cmVseSBhZGRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkxMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29kZSB0aGF0IG1hbmlwdWxhdGVzIHRoZSBUcmFu c29ybVN0YXRlIGFuZCBjb21wdXRlcyB0aGUgdmlzaWJsZSByZWN0IGlzIGdvaW5nIHRvIGdldAor ICAgICAgICBtb3JlIGNvbXBsZXgsIHNvIG1vdmUgaXQgaW50byBhIG5ldyBtZW1iZXIgZnVuY3Rp b24uCisKKyAgICAgICAgUmVtb3ZlIGEgdGVzdCB0aGF0IHdhc24ndCBzdXBwb3NlZCB0byBiZSBh ZGRlZCB5ZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVy Q0EuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNBOjpjb21wdXRlVmlzaWJs ZVJlY3QpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllckNBOjpyZWN1cnNpdmVDb21t aXRDaGFuZ2VzKToKKworMjAxMi0xMC0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KKwogICAgICAgICBBZGQgc29tZSBpbml0aWFsIHZpc2libGUgcmVjdCB0ZXN0cyBh bmQgdHdlYWsgdGhlIHZpc2libGUgd2FzaCBsYXllcgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkwOTUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKaW5kZXggNzQwZGIz M2M3YWZlNmM2NjBiNjViYmYyYmY1YmU3M2JjNTdhZjczYy4uMjUwMThlNmQyNjQxNzkwYWRmOTNi ZTE0MTZhMDBhNWNhZDA1ZWUyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwCkBAIC05MTQsMTMgKzkxNCwxMCBA QCBUaWxlZEJhY2tpbmcqIEdyYXBoaWNzTGF5ZXJDQTo6dGlsZWRCYWNraW5nKCkKICAgICByZXR1 cm4gbV9sYXllci0+dGlsZWRCYWNraW5nKCk7CiB9CiAKLXZvaWQgR3JhcGhpY3NMYXllckNBOjpy ZWN1cnNpdmVDb21taXRDaGFuZ2VzKGNvbnN0IFRyYW5zZm9ybVN0YXRlJiBzdGF0ZSwgZmxvYXQg cGFnZVNjYWxlRmFjdG9yLCBjb25zdCBGbG9hdFBvaW50JiBwb3NpdGlvblJlbGF0aXZlVG9CYXNl LCBib29sIGFmZmVjdGVkQnlQYWdlU2NhbGUpCit2b2lkIEdyYXBoaWNzTGF5ZXJDQTo6Y29tcHV0 ZVZpc2libGVSZWN0KFRyYW5zZm9ybVN0YXRlJiBzdGF0ZSkKIHsKLSAgICAvLyBTYXZlIHRoZSBz dGF0ZSBiZWZvcmUgc2VuZGluZyBkb3duIHRvIGtpZHMgYW5kIHJlc3RvcmUgaXQgYWZ0ZXIKLSAg ICBUcmFuc2Zvcm1TdGF0ZSBsb2NhbFN0YXRlID0gc3RhdGU7Ci0gICAgCiAgICAgVHJhbnNmb3Jt U3RhdGU6OlRyYW5zZm9ybUFjY3VtdWxhdGlvbiBhY2N1bXVsYXRpb24gPSBwcmVzZXJ2ZXMzRCgp ID8gVHJhbnNmb3JtU3RhdGU6OkFjY3VtdWxhdGVUcmFuc2Zvcm0gOiBUcmFuc2Zvcm1TdGF0ZTo6 RmxhdHRlblRyYW5zZm9ybTsKLSAgICBsb2NhbFN0YXRlLm1vdmUobV9wb3NpdGlvbi54KCksIG1f cG9zaXRpb24ueSgpLCBhY2N1bXVsYXRpb24pOworICAgIHN0YXRlLm1vdmUobV9wb3NpdGlvbi54 KCksIG1fcG9zaXRpb24ueSgpLCBhY2N1bXVsYXRpb24pOwogICAgIAogICAgIGlmICghdHJhbnNm b3JtKCkuaXNJZGVudGl0eSgpKSB7CiAgICAgICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IHRyYW5z Zm9ybVdpdGhBbmNob3JQb2ludDsKQEAgLTkyOSwyMSArOTI2LDMxIEBAIHZvaWQgR3JhcGhpY3NM YXllckNBOjpyZWN1cnNpdmVDb21taXRDaGFuZ2VzKGNvbnN0IFRyYW5zZm9ybVN0YXRlJiBzdGF0 ZSwgZmxvYXQKICAgICAgICAgdHJhbnNmb3JtV2l0aEFuY2hvclBvaW50LnRyYW5zbGF0ZTNkKGFi c29sdXRlQW5jaG9yUG9pbnQueCgpLCBhYnNvbHV0ZUFuY2hvclBvaW50LnkoKSwgYWJzb2x1dGVB bmNob3JQb2ludC56KCkpOwogICAgICAgICB0cmFuc2Zvcm1XaXRoQW5jaG9yUG9pbnQubXVsdGlw bHkodHJhbnNmb3JtKCkpOwogICAgICAgICB0cmFuc2Zvcm1XaXRoQW5jaG9yUG9pbnQudHJhbnNs YXRlM2QoLWFic29sdXRlQW5jaG9yUG9pbnQueCgpLCAtYWJzb2x1dGVBbmNob3JQb2ludC55KCks IC1hYnNvbHV0ZUFuY2hvclBvaW50LnooKSk7Ci0gICAgICAgIGxvY2FsU3RhdGUuYXBwbHlUcmFu c2Zvcm0odHJhbnNmb3JtV2l0aEFuY2hvclBvaW50LCBhY2N1bXVsYXRpb24pOworICAgICAgICBz dGF0ZS5hcHBseVRyYW5zZm9ybSh0cmFuc2Zvcm1XaXRoQW5jaG9yUG9pbnQsIGFjY3VtdWxhdGlv bik7CiAgICAgfQogICAgIAotICAgIEZsb2F0UmVjdCBjbGlwUmVjdEZvckNoaWxkcmVuID0gbG9j YWxTdGF0ZS5sYXN0UGxhbmFyUXVhZCgpLmJvdW5kaW5nQm94KCk7CisgICAgRmxvYXRSZWN0IGNs aXBSZWN0Rm9yQ2hpbGRyZW4gPSBzdGF0ZS5sYXN0UGxhbmFyUXVhZCgpLmJvdW5kaW5nQm94KCk7 CiAgICAgRmxvYXRSZWN0IGNsaXBSZWN0Rm9yU2VsZigwLCAwLCBtX3NpemUud2lkdGgoKSwgbV9z aXplLmhlaWdodCgpKTsKICAgICBjbGlwUmVjdEZvclNlbGYuaW50ZXJzZWN0KGNsaXBSZWN0Rm9y Q2hpbGRyZW4pOwogICAgIAogICAgIGlmIChtYXNrc1RvQm91bmRzKCkpIHsKICAgICAgICAgQVNT RVJUKGFjY3VtdWxhdGlvbiA9PSBUcmFuc2Zvcm1TdGF0ZTo6RmxhdHRlblRyYW5zZm9ybSk7CiAg ICAgICAgIC8vIFJlcGxhY2UgdGhlIHF1YWQgaW4gdGhlIFRyYW5zZm9ybVN0YXRlIHdpdGggb25l IHRoYXQgaXMgY2xpcHBlZCB0byB0aGlzIGxheWVyJ3MgYm91bmRzCi0gICAgICAgIGxvY2FsU3Rh dGUuc2V0UXVhZChjbGlwUmVjdEZvclNlbGYpOworICAgICAgICBzdGF0ZS5zZXRRdWFkKGNsaXBS ZWN0Rm9yU2VsZik7CiAgICAgfQogCiAgICAgbV92aXNpYmxlUmVjdCA9IGNsaXBSZWN0Rm9yU2Vs ZjsKLSAgICAKKworICAgIGlmICghY2hpbGRyZW5UcmFuc2Zvcm0oKS5pc0lkZW50aXR5KCkpICAg IAorICAgICAgICBzdGF0ZS5hcHBseVRyYW5zZm9ybShjaGlsZHJlblRyYW5zZm9ybSgpLCBhY2N1 bXVsYXRpb24pOworfQorCit2b2lkIEdyYXBoaWNzTGF5ZXJDQTo6cmVjdXJzaXZlQ29tbWl0Q2hh bmdlcyhjb25zdCBUcmFuc2Zvcm1TdGF0ZSYgc3RhdGUsIGZsb2F0IHBhZ2VTY2FsZUZhY3Rvciwg Y29uc3QgRmxvYXRQb2ludCYgcG9zaXRpb25SZWxhdGl2ZVRvQmFzZSwgYm9vbCBhZmZlY3RlZEJ5 UGFnZVNjYWxlKQoreworICAgIC8vIFNhdmUgdGhlIHN0YXRlIGJlZm9yZSBzZW5kaW5nIGRvd24g dG8ga2lkcyBhbmQgcmVzdG9yZSBpdCBhZnRlcgorICAgIFRyYW5zZm9ybVN0YXRlIGxvY2FsU3Rh dGUgPSBzdGF0ZTsKKyAgICBjb21wdXRlVmlzaWJsZVJlY3QobG9jYWxTdGF0ZSk7CisKICNpZmRl ZiBWSVNJQkxFX1RJTEVfV0FTSAogICAgIC8vIFVzZSBoYXZpbmcgYSB0cmFuc2Zvcm0gYXMgYSBr ZXkgdG8gbWFraW5nIHRoZSB0aWxlIHdhc2ggbGF5ZXIuIElmIGV2ZXJ5IGxheWVyIGdldHMgYSB3 YXNoLAogICAgIC8vIHRoZXkgc3RhcnQgdG8gb2JzY3VyZSB1c2VmdWwgaW5mb3JtYXRpb24uCkBA IC05NjIsNyArOTY5LDcgQEAgdm9pZCBHcmFwaGljc0xheWVyQ0E6OnJlY3Vyc2l2ZUNvbW1pdENo YW5nZXMoY29uc3QgVHJhbnNmb3JtU3RhdGUmIHN0YXRlLCBmbG9hdAogICAgIH0KIAogICAgIGlm IChtX3Zpc2libGVUaWxlV2FzaExheWVyKQotICAgICAgICBtX3Zpc2libGVUaWxlV2FzaExheWVy LT5zZXRGcmFtZShjbGlwUmVjdEZvclNlbGYpOworICAgICAgICBtX3Zpc2libGVUaWxlV2FzaExh eWVyLT5zZXRGcmFtZShtX3Zpc2libGVSZWN0KTsKICNlbmRpZgogCiAgICAgYm9vbCBoYWRDaGFu Z2VzID0gbV91bmNvbW1pdHRlZENoYW5nZXM7CkBAIC05ODUsOSArOTkyLDYgQEAgdm9pZCBHcmFw aGljc0xheWVyQ0E6OnJlY3Vyc2l2ZUNvbW1pdENoYW5nZXMoY29uc3QgVHJhbnNmb3JtU3RhdGUm IHN0YXRlLCBmbG9hdAogICAgIGNvbnN0IFZlY3RvcjxHcmFwaGljc0xheWVyKj4mIGNoaWxkTGF5 ZXJzID0gY2hpbGRyZW4oKTsKICAgICBzaXplX3QgbnVtQ2hpbGRyZW4gPSBjaGlsZExheWVycy5z aXplKCk7CiAgICAgCi0gICAgaWYgKCFjaGlsZHJlblRyYW5zZm9ybSgpLmlzSWRlbnRpdHkoKSkg ICAgCi0gICAgICAgIGxvY2FsU3RhdGUuYXBwbHlUcmFuc2Zvcm0oY2hpbGRyZW5UcmFuc2Zvcm0o KSwgYWNjdW11bGF0aW9uKTsKLSAgICAKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG51bUNo aWxkcmVuOyArK2kpIHsKICAgICAgICAgR3JhcGhpY3NMYXllckNBKiBjdXJDaGlsZCA9IHN0YXRp Y19jYXN0PEdyYXBoaWNzTGF5ZXJDQSo+KGNoaWxkTGF5ZXJzW2ldKTsKICAgICAgICAgY3VyQ2hp bGQtPnJlY3Vyc2l2ZUNvbW1pdENoYW5nZXMobG9jYWxTdGF0ZSwgcGFnZVNjYWxlRmFjdG9yLCBi YXNlUmVsYXRpdmVQb3NpdGlvbiwgYWZmZWN0ZWRCeVBhZ2VTY2FsZSk7CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWQ0MzUz ZTA1ZmQ3OTFiZTAxNjczOTczYTYyMzE4ZTYxMzkxOGI5YS4uNzM5NzQwM2UwNjc3ZGQ3OGM5ZTc3 ZmQyZTM5MDU0NjQ1NTRmZmZlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisr KyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDEyLTEwLTExICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIE1vdmUgVHJh bnNmb3JtU3RhdGUgY29kZSBpbnRvIGl0cyBvd24gbWVtYmVyIGZ1bmN0aW9uLCBhbmQgcmVtb3Zl IGEgdGVzdCB0aGF0IHdhcyBwcmVtYXR1cmVseSBhZGRlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkxMTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgYSB0ZXN0IHRoYXQgd2Fzbid0IHN1cHBv c2VkIHRvIGJlIGFkZGVkIHlldC4KKworICAgICAgICAqIGNvbXBvc2l0aW5nL3Zpc2libGUtcmVj dC8zZC10cmFuc2Zvcm1lZC5odG1sOiBSZW1vdmVkLgorCisyMDEyLTEwLTExICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBzb21lIGluaXRpYWwg dmlzaWJsZSByZWN0IHRlc3RzIGFuZCB0d2VhayB0aGUgdmlzaWJsZSB3YXNoIGxheWVyCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTA5NQogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy92aXNpYmxlLXJlY3QvM2QtdHJhbnNmb3Jt ZWQuaHRtbCBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3Zpc2libGUtcmVjdC8zZC10cmFuc2Zv cm1lZC5odG1sCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAxZjYxZDA5MjIwZmFiOGMx MjkyMjhmNTY2NGNkZTQxYWMyMjI2NzJhLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3Zpc2libGUtcmVjdC8zZC10 cmFuc2Zvcm1lZC5odG1sCisrKyAvZGV2L251bGwKQEAgLTEsNDcgKzAsMCBAQAotPCFET0NUWVBF IGh0bWw+Ci0KLTxodG1sPgotPGhlYWQ+Ci0gICAgPHN0eWxlPgotICAgICAgICAuY29udGFpbmVy IHsKLSAgICAgICAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKLSAgICAgICAgICAgIGhlaWdodDog MjAwcHg7Ci0gICAgICAgICAgICB3aWR0aDogMjAwcHg7Ci0gICAgICAgICAgICBib3JkZXI6IDFw eCBzb2xpZCBibGFjazsKLSAgICAgICAgICAgIG92ZXJmbG93OiBoaWRkZW47Ci0gICAgICAgICAg ICB6LWluZGV4OiAwOwotICAgICAgICAgICAgbWFyZ2luOiAxMHB4OwotICAgICAgICB9Ci0gICAg ICAgIAotICAgICAgICAuYm94IHsKLSAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKLSAg ICAgICAgICAgIHdpZHRoOiA1MDBweDsKLSAgICAgICAgICAgIGhlaWdodDogNTAwcHg7Ci0gICAg ICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwotICAgICAgICB9Ci0gICAgPC9zdHlsZT4K LSAgICA8c2NyaXB0PgotICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgICAgICAg ICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKLQotICAgICAgICBmdW5jdGlvbiBkdW1wTGF5ZXJz KCkKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCi0gICAgICAg ICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xheWVycycpLmlubmVyVGV4dCA9IGlu dGVybmFscy5sYXllclRyZWVBc1RleHQoZG9jdW1lbnQsIGludGVybmFscy5MQVlFUl9UUkVFX0lO Q0xVREVTX1ZJU0lCTEVfUkVDVFMpCi0gICAgICAgIH0KLSAgICAgICAgd2luZG93LmFkZEV2ZW50 TGlzdGVuZXIoJ2xvYWQnLCBkdW1wTGF5ZXJzLCBmYWxzZSk7Ci0gICAgPC9zY3JpcHQ+Ci08L2hl YWQ+Ci08Ym9keT4KLQotICAgIDxkaXYgY2xhc3M9ImNvbnRhaW5lciI+Ci0gICAgICAgIDxkaXYg Y2xhc3M9ImJveCIgc3R5bGU9Ii13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGVYKDQ1ZGVnKTsiPjwv ZGl2PgotICAgIDwvZGl2PgotCi0gICAgPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KLSAgICAgICAg PGRpdiBjbGFzcz0iYm94IiBzdHlsZT0iLXdlYmtpdC10cmFuc2Zvcm06IHJvdGF0ZVkoNDVkZWcp Ij48L2Rpdj4KLSAgICA8L2Rpdj4KLQotPHByZSBpZD0ibGF5ZXJzIj5MYXllciB0cmVlIGdvZXMg aGVyZSB3aGVuIHRlc3Rpbmc8L3ByZT4KLTwvYm9keT4KLTwvaHRtbD4K