99111 2012-10-11 16:18:44 -0700 ScrollingStateNode should keep its Vector of children in an OwnPtr 2012-10-11 16:51:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin andersca bdakin jamesr sam simon.fraser tonikitoo webkit.review.bot oldest_to_newest 740385 0 bdakin 2012-10-11 16:18:44 -0700 ScrollingStateNode should keep its Vector of children in an OwnPtr. Patch forthcoming. 740392 1 168310 bdakin 2012-10-11 16:24:10 -0700 Created attachment 168310 Patch 740433 2 bdakin 2012-10-11 16:51:53 -0700 Thanks Ada! http://trac.webkit.org/changeset/131112 168310 2012-10-11 16:24:10 -0700 2012-10-11 16:37:54 -0700 Patch own-ptr.txt text/plain 2845 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMTEwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTExICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTkxMTEKKyAgICAgICAgU2Nyb2xsaW5nU3RhdGVOb2RlIHNob3Vs ZCBrZWVwIGl0cyBWZWN0b3Igb2YgY2hpbGRyZW4gaW4gYW4gT3duUHRyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVmVjdG9yPE93blB0cjxTY3JvbGxp bmdTdGF0ZU5vZGU+ID4qIG1fY2hpbGRyZW47IGlzIG5vdzoKKyAgICAgICAgIE93blB0cjxWZWN0 b3I8T3duUHRyPFNjcm9sbGluZ1N0YXRlTm9kZT4gPiA+IG1fY2hpbGRyZW47CisgICAgICAgICog cGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVOb2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbGluZ1N0YXRlTm9kZTo6U2Nyb2xsaW5nU3RhdGVOb2RlKToKKyAgICAgICAgKFdlYkNv cmU6OlNjcm9sbGluZ1N0YXRlTm9kZTo6flNjcm9sbGluZ1N0YXRlTm9kZSk6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxpbmdTdGF0ZU5vZGU6OmFwcGVuZENoaWxkKToKKyAgICAgICAgKiBwYWdl L3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaDoKKyAgICAgICAgKFNjcm9sbGluZ1N0YXRl Tm9kZSk6CisKIDIwMTItMTAtMTEgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5j b20+CiAKICAgICAgICAgQVg6IGxhYmVsRm9yRWxlbWVudCBpcyBzbG93IHdoZW4gdGhlcmUgYXJl IGEgbG90IG9mIERPTSBlbGVtZW50cwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvU2Nyb2xsaW5nU3RhdGVOb2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuY3BwCShyZXZpc2lvbiAxMzEwODMpCisr KyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIFNjcm9s bGluZ1N0YXRlTm9kZTo6U2Nyb2xsaW5nU3RhdGVOb2RlKFNjcm9sbGluZ1N0YXRlVHJlZSogc2Ny b2xsaW5nU3RhdGVUcmVlKQogICAgIDogbV9zY3JvbGxpbmdTdGF0ZVRyZWUoc2Nyb2xsaW5nU3Rh dGVUcmVlKQogICAgICwgbV9wYXJlbnQoMCkKLSAgICAsIG1fY2hpbGRyZW4oMCkKICAgICAsIG1f c2Nyb2xsTGF5ZXJEaWRDaGFuZ2UoZmFsc2UpCiB7CiB9CkBAIC00Niw3ICs0NSw2IEBAIFNjcm9s bGluZ1N0YXRlTm9kZTo6U2Nyb2xsaW5nU3RhdGVOb2RlKFMKIFNjcm9sbGluZ1N0YXRlTm9kZTo6 U2Nyb2xsaW5nU3RhdGVOb2RlKFNjcm9sbGluZ1N0YXRlTm9kZSogc3RhdGVOb2RlKQogICAgIDog bV9zY3JvbGxpbmdTdGF0ZVRyZWUoMCkKICAgICAsIG1fcGFyZW50KDApCi0gICAgLCBtX2NoaWxk cmVuKDApCiAgICAgLCBtX3Njcm9sbExheWVyRGlkQ2hhbmdlKHN0YXRlTm9kZS0+c2Nyb2xsTGF5 ZXJEaWRDaGFuZ2UoKSkKIHsKICAgICBzZXRTY3JvbGxMYXllcihzdGF0ZU5vZGUtPnBsYXRmb3Jt U2Nyb2xsTGF5ZXIoKSk7CkBAIC01NCw3ICs1Miw2IEBAIFNjcm9sbGluZ1N0YXRlTm9kZTo6U2Ny b2xsaW5nU3RhdGVOb2RlKFMKIAogU2Nyb2xsaW5nU3RhdGVOb2RlOjp+U2Nyb2xsaW5nU3RhdGVO b2RlKCkKIHsKLSAgICBkZWxldGUgbV9jaGlsZHJlbjsKIH0KIAogdm9pZCBTY3JvbGxpbmdTdGF0 ZU5vZGU6OmNsb25lQW5kUmVzZXRDaGlsZE5vZGVzKFNjcm9sbGluZ1N0YXRlTm9kZSogY2xvbmUp CkBAIC03Miw3ICs2OSw3IEBAIHZvaWQgU2Nyb2xsaW5nU3RhdGVOb2RlOjphcHBlbmRDaGlsZChQ YXMKICAgICBjaGlsZE5vZGUtPnNldFBhcmVudCh0aGlzKTsKIAogICAgIGlmICghbV9jaGlsZHJl bikKLSAgICAgICAgbV9jaGlsZHJlbiA9IG5ldyBWZWN0b3I8T3duUHRyPFNjcm9sbGluZ1N0YXRl Tm9kZT4gPjsKKyAgICAgICAgbV9jaGlsZHJlbiA9IGFkb3B0UHRyKG5ldyBWZWN0b3I8T3duUHRy PFNjcm9sbGluZ1N0YXRlTm9kZT4gPik7CiAKICAgICBtX2NoaWxkcmVuLT5hcHBlbmQoY2hpbGRO b2RlKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0 YXRlTm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1N0YXRlTm9kZS5oCShyZXZpc2lvbiAxMzEwODMpCisrKyBTb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtODMs NyArODMsNyBAQCBwcm90ZWN0ZWQ6CiBwcml2YXRlOgogICAgIFNjcm9sbGluZ1N0YXRlTm9kZSog bV9wYXJlbnQ7CiAKLSAgICBWZWN0b3I8T3duUHRyPFNjcm9sbGluZ1N0YXRlTm9kZT4gPiogbV9j aGlsZHJlbjsKKyAgICBPd25QdHI8VmVjdG9yPE93blB0cjxTY3JvbGxpbmdTdGF0ZU5vZGU+ID4g PiBtX2NoaWxkcmVuOwogCiAgICAgYm9vbCBtX3Njcm9sbExheWVyRGlkQ2hhbmdlOwogCg==