99109 2012-10-11 16:01:59 -0700 webview not redrawn as needed when accelerated compositing is enabled. 2012-10-29 11:01:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier d-r mrobinson webkit.review.bot oldest_to_newest 740357 0 a.renevier 2012-10-11 16:01:59 -0700 Hi, when accelerated compositing is enabled, the web view is sometimes not correctly updated. This may happen when the content of a page changes, or when I reload a page. The view is redrawn either when draw method is called directly by gtk (for example due to a Expose event), or when gtk_widget_queue_draw is called in AcceleratedCompositingContext::flushAndRenderLayers. But it is only called if (m_redrawPendingTime && currentTime() - m_redrawPendingTime > gScheduleDelay) is true, which depends mostly on luck. It's my understanding that webview should also be redrawn on XDamageNotify event, but this event is never sent. I tried switch from catalyst to mesa drivers. I tried to switch from a non composited window manager to a composited one. I also tried to revert bug #97472, but none of this worked: XDamageNotify never occurs. I don't known what to do to investigate more now. 740363 1 168302 a.renevier 2012-10-11 16:06:05 -0700 Created attachment 168302 testcase testcase: display the page, and do not do anything (like moving the mouse). After 2 seconds, the text should change from hello to goodbye. When I display the page on GtkLauncher with accelerated compositing enabled, the text is not updated until I click inside the page (or switch to it with the keyboard). 740364 2 168303 a.renevier 2012-10-11 16:07:03 -0700 Created attachment 168303 testcase (hopefully correct this time) 740377 3 a.renevier 2012-10-11 16:12:03 -0700 For some reason, when runned from webkit.org, the testcase works correctly. But if I reload, it fails. Anyway, I can see by putting printf in filterXDamageEvent that XDamageNotify even does not occur. 752148 4 a.renevier 2012-10-26 09:57:01 -0700 What happens is display from GLContext::shaderX11Display has not been wrapped in a GdkDisplay, and therefore, events for that display are not captured in the gtk event handler. 752149 5 170949 a.renevier 2012-10-26 09:58:50 -0700 Created attachment 170949 Patch patch proposal: use gdk default display for GL shared display 752180 6 mrobinson 2012-10-26 10:52:33 -0700 What use of GLContext::sharedX11Display is causing the issue. The one in platform/graphics/glx/GLContextGLX.cpp or the one in platform/gtk/RedirectedXCompositeWindow.cpp? 752195 7 a.renevier 2012-10-26 11:03:04 -0700 (In reply to comment #6) > What use of GLContext::sharedX11Display is causing the issue. The one in platform/graphics/glx/GLContextGLX.cpp or the one in platform/gtk/RedirectedXCompositeWindow.cpp? RedirectedXCompositeWindow we call gdk_window_add_filter(0, reinterpret_cast<GdkFilterFunc>(filterXDamageEvent), 0); Currently, we get some events in filterXDamageEvent but they are not related to GL shared display. 752204 8 mrobinson 2012-10-26 11:12:07 -0700 Can you fix the problem by simply using the default GDK display everywhere in RedirectedXCompositeWindow? 752246 9 a.renevier 2012-10-26 11:57:00 -0700 (In reply to comment #8) > Can you fix the problem by simply using the default GDK display everywhere in RedirectedXCompositeWindow? This works. But then, redirected window and gl context will be related to different displays. There is a comment near GLContext::sharedX11Display stating: // We do not want to call glXMakeContextCurrent using different Display pointers, // because it might lead to crashes in some drivers (fglrx). Even though my testcase does not crash with fglrx, do you known if we might trigger this bug by using the default display in redirected comp window, and another one in glContext ? 752687 10 mrobinson 2012-10-26 22:38:12 -0700 (In reply to comment #9) > (In reply to comment #8) > Even though my testcase does not crash with fglrx, do you known if we might trigger this bug by using the default display in redirected comp window, and another one in glContext ? I believe the issue is only with calling glXMakeCurrent. 753524 11 171265 a.renevier 2012-10-29 09:43:04 -0700 Created attachment 171265 Patch updated patch: use default gdk display everywhere in RedirectedXCompositeWindow 753616 12 171265 webkit.review.bot 2012-10-29 11:01:35 -0700 Comment on attachment 171265 Patch Clearing flags on attachment: 171265 Committed r132823: <http://trac.webkit.org/changeset/132823> 753617 13 webkit.review.bot 2012-10-29 11:01:40 -0700 All reviewed patches have been landed. Closing bug. 168302 2012-10-11 16:06:05 -0700 2012-10-11 16:07:03 -0700 testcase url.txt text/plain 42 a.renevier aHR0cDovL3JlbmV2aWVyLm5ldC9taXNjL3dlYmtpdF85OTEwOS5odG1s 168303 2012-10-11 16:07:03 -0700 2012-10-11 16:07:03 -0700 testcase (hopefully correct this time) index.html text/html 656 a.renevier PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHRpdGxlPnBlcnNwZWN0aXZlIHRl c3Q8L3RpdGxlPgogICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0 ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiPgoKICAgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+Cgog ICAgYm9keSwgaHRtbCB7CiAgICAgICAgbWFyZ2luOiAwOyBwYWRkaW5nOiAwOwogICAgfQogICAg Ym9keSB7CiAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKICAgIH0KCiAgICAgICNyaW5n IHsKICAgICAgICAtd2Via2l0LXBlcnNwZWN0aXZlOiA4MDBweDsKICAgICAgICBiYWNrZ3JvdW5k LWNvbG9yOiAjOTk1QzdGOwogICAgICAgIC13ZWJraXQtdHJhbnNmb3JtOiByb3RhdGVZKDQ1ZGVn KTs7CiAgICAgIH0KCiAgICA8L3N0eWxlPgoKICA8L2hlYWQ+CgogIDxzY3JpcHQ+CiAgd2luZG93 LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdy aW5nJykudGV4dENvbnRlbnQgPSAnZ29vZGJ5ZSc7CiAgfSwgMjAwMCk7CiAgPC9zY3JpcHQ+CiAg CiAgPGJvZHk+CgogICAgICAgIDxkaXYgaWQ9InJpbmciPgogICAgICAgIGhlbGxvCiAgICAgICAg PC9kaXY+CgogIDwvYm9keT4KICAKPC9odG1sPgo= 170949 2012-10-26 09:58:50 -0700 2012-10-29 09:43:01 -0700 Patch bug-99109-20121026095722.patch text/plain 2251 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDViNTE5NmRhYTRlMmRh NzhiOWVjMTE1Zjg0OTE2ZDExOGJjMDc3OS4uZjAzZDYxNjU2M2JiNjM5ZWQ1YjFiZDVlYmVmMTQ0 NTg4MjU4YTAzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTI2ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgd2Vi dmlldyBub3QgcmVkcmF3biBhcyBuZWVkZWQgd2hlbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBp cyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTkxMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBHTCBzaGFyZWQgZGlzcGxheSBpcyBub3QgaW4gdGhlIGd0ayBsb29wIGFuZCB0aGVyZWZvcmUs IGl0cyBldmVudHMgYXJlCisgICAgICAgIG5vdCBjYXB0dXJlZCBieSBndGsuIFRoaXMgaXMgbmVl ZGVkIGJ5IGd0ayByZWRpcmVjdGVkIGNvbXBvc2l0ZQorICAgICAgICB3aW5kb3cuIFNvLCB0aGlz IHBhdGNoIHVzZXMgZ2RrIGRlZmF1bHQgZGlzcGxheSBmb3Igc2hhcmVkIGRpc3BsYXkuIAorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dMQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHTENvbnRleHQ6OnNoYXJlZFgxMURpc3BsYXkpOgorICAgICAgICAoV2ViQ29yZTo6R0xD b250ZXh0OjpjbGVhbnVwU2hhcmVkWDExRGlzcGxheSk6CisKIDIwMTItMTAtMjQgIEFybmF1ZCBS ZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNvbT4KIAogICAgICAgICBkbyBub3Qg bXVsdGlwbHkvZGVtdWx0aXBseSBjb2xvcnMgd2hlbiBhbHBoYSBpcyAyNTUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dMQ29udGV4dC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HTENvbnRleHQuY3BwCmluZGV4 IDJjYjBhYjNjYzkwMWQxMjNlYWVjZGNlYjE1NTAzODc5MzBhNTQ3NDMuLjY5YTY0NDFmMmMyZGVj ZmY4Njg1OWY5N2UxZGRhZjFiYjA2N2QzZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dMQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR0xDb250ZXh0LmNwcApAQCAtMjcsNiArMjcsOSBAQAog CiAjaWYgUExBVEZPUk0oWDExKQogI2luY2x1ZGUgPFgxMS9YbGliLmg+CisjaWYgUExBVEZPUk0o R1RLKQorI2luY2x1ZGUgPGdkay9nZGt4Lmg+CisjZW5kaWYKICNlbmRpZgogCiBuYW1lc3BhY2Ug V2ViQ29yZSB7CkBAIC00NSw4ICs0OCwxNSBAQCBHTENvbnRleHQqIEdMQ29udGV4dDo6c2hhcmlu Z0NvbnRleHQoKQogc3RhdGljIERpc3BsYXkqIGdTaGFyZWRYMTFEaXNwbGF5ID0gMDsKIERpc3Bs YXkqIEdMQ29udGV4dDo6c2hhcmVkWDExRGlzcGxheSgpCiB7Ci0gICAgaWYgKCFnU2hhcmVkWDEx RGlzcGxheSkKKyAgICBpZiAoIWdTaGFyZWRYMTFEaXNwbGF5KSB7CisjaWYgUExBVEZPUk0oR1RL KQorICAgICAgICBHZGtEaXNwbGF5KiBkaXNwbGF5ID0gZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQo KTsKKyAgICAgICAgQVNTRVJUKGRpc3BsYXkpOworICAgICAgICBnU2hhcmVkWDExRGlzcGxheSAg PSBHREtfRElTUExBWV9YRElTUExBWShkaXNwbGF5KTsKKyNlbHNlCiAgICAgICAgIGdTaGFyZWRY MTFEaXNwbGF5ID0gWE9wZW5EaXNwbGF5KDApOworI2VuZGlmCisgICAgfQogICAgIHJldHVybiBn U2hhcmVkWDExRGlzcGxheTsKIH0KIApAQCAtNTQsNyArNjQsOSBAQCB2b2lkIEdMQ29udGV4dDo6 Y2xlYW51cFNoYXJlZFgxMURpc3BsYXkoKQogewogICAgIGlmICghZ1NoYXJlZFgxMURpc3BsYXkp CiAgICAgICAgIHJldHVybjsKKyNpZiAhUExBVEZPUk0oR1RLKQogICAgIFhDbG9zZURpc3BsYXko Z1NoYXJlZFgxMURpc3BsYXkpOworI2VuZGlmIAogICAgIGdTaGFyZWRYMTFEaXNwbGF5ID0gMDsK IH0KICNlbmRpZiAvLyBQTEFURk9STShYMTEpCg== 171265 2012-10-29 09:43:04 -0700 2012-10-29 11:01:34 -0700 Patch bug-99109-20121029094130.patch text/plain 2743 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyMTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzVmNmJmNjg2OTI4NjI0 OWM1NThmZDhkZGU0YTQ3ZjJjNjViODJhNi4uNzJlODYyMjQ2NmVkZmQzYjFhOWRkZmIyOTIyYzM0 YmI3OTRiYzQ2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTI5ICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKKyAgICAgICAgd2Vi dmlldyBub3QgcmVkcmF3biBhcyBuZWVkZWQgd2hlbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBp cyBlbmFibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTkxMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBHTCBzaGFyZWQgZGlzcGxheSBpcyBub3QgaW4gdGhlIGd0ayBsb29wIGFuZCB0aGVyZWZvcmUs IGl0cyBldmVudHMgYXJlCisgICAgICAgIG5vdCBjYXB0dXJlZCBieSBndGsuIFNvLCB3ZSB1c2Ug Z2RrIGRlZmF1bHQgaW5zdGVhZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGNvdmVyZWQgYnkg ZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21w b3NpdGVXaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVkaXJlY3RlZFhDb21wb3NpdGVX aW5kb3c6OlJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93KToKKyAgICAgICAgKFdlYkNvcmU6OlJl ZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93Ojp+UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cpOgor ICAgICAgICAoV2ViQ29yZTo6UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3c6OnJlc2l6ZSk6CisK IDIwMTItMTAtMjYgIEFybmF1ZCBSZW5ldmllciAgPGEucmVuZXZpZXJAc2lzYS5zYW1zdW5nLmNv bT4KIAogICAgICAgICBpbmNvbnNpc3RlbmN5IGluIGRyYXdJbWFnZSB3aXRoIHRhcmdldCByZWN0 IG5lZ2F0aXZlIGRpbWVuc2lvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1JlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93LmNwcAppbmRleCBlOTExOGM3N2Uz ZWQyNjRkZjFlMzA1NjIyODNkNTRmNzljMDlkMGY2Li45MTEwNTgxMjg2OGU2ZjhjMTdlOWZiY2Ux MzNjOWE4MmU2MzM4MWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9SZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdy5jcHAKQEAgLTEwOCw3ICsxMDgsNyBA QCBSZWRpcmVjdGVkWENvbXBvc2l0ZVdpbmRvdzo6UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3co Y29uc3QgSW50U2l6ZSYgc2l6ZSkKICAgICAsIG1fZGFtYWdlTm90aWZ5Q2FsbGJhY2soMCkKICAg ICAsIG1fZGFtYWdlTm90aWZ5RGF0YSgwKQogewotICAgIERpc3BsYXkqIGRpc3BsYXkgPSBHTENv bnRleHQ6OnNoYXJlZFgxMURpc3BsYXkoKTsKKyAgICBEaXNwbGF5KiBkaXNwbGF5ID0gR0RLX0RJ U1BMQVlfWERJU1BMQVkoZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSk7CiAgICAgU2NyZWVuKiBz Y3JlZW4gPSBEZWZhdWx0U2NyZWVuT2ZEaXNwbGF5KGRpc3BsYXkpOwogCiAgICAgLy8gVGhpcyBp cyBiYXNlZCBvbiBjb2RlIGZyb20gQ2hyb21pdW06IHNyYy9jb250ZW50L2NvbW1vbi9ncHUvaW1h Z2VfdHJhbnNwb3J0X3N1cmZhY2VfbGludXguY2MKQEAgLTE2Myw3ICsxNjMsNyBAQCBSZWRpcmVj dGVkWENvbXBvc2l0ZVdpbmRvdzo6flJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93KCkKICAgICBp ZiAoZ2V0V2luZG93SGFzaE1hcCgpLmlzRW1wdHkoKSkKICAgICAgICAgZ2RrX3dpbmRvd19yZW1v dmVfZmlsdGVyKDAsIHJlaW50ZXJwcmV0X2Nhc3Q8R2RrRmlsdGVyRnVuYz4oZmlsdGVyWERhbWFn ZUV2ZW50KSwgMCk7CiAKLSAgICBEaXNwbGF5KiBkaXNwbGF5ID0gR0xDb250ZXh0OjpzaGFyZWRY MTFEaXNwbGF5KCk7CisgICAgRGlzcGxheSogZGlzcGxheSA9IEdES19ESVNQTEFZX1hESVNQTEFZ KGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCkpOwogICAgIFhEYW1hZ2VEZXN0cm95KGRpc3BsYXks IG1fZGFtYWdlKTsKICAgICBYRGVzdHJveVdpbmRvdyhkaXNwbGF5LCBtX3dpbmRvdyk7CiAgICAg WERlc3Ryb3lXaW5kb3coZGlzcGxheSwgbV9wYXJlbnRXaW5kb3cpOwpAQCAtMTcyLDcgKzE3Miw3 IEBAIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93Ojp+UmVkaXJlY3RlZFhDb21wb3NpdGVXaW5k b3coKQogCiB2b2lkIFJlZGlyZWN0ZWRYQ29tcG9zaXRlV2luZG93OjpyZXNpemUoY29uc3QgSW50 U2l6ZSYgc2l6ZSkKIHsKLSAgICBEaXNwbGF5KiBkaXNwbGF5ID0gR0xDb250ZXh0OjpzaGFyZWRY MTFEaXNwbGF5KCk7CisgICAgRGlzcGxheSogZGlzcGxheSA9IEdES19ESVNQTEFZX1hESVNQTEFZ KGdka19kaXNwbGF5X2dldF9kZWZhdWx0KCkpOwogICAgIFhSZXNpemVXaW5kb3coZGlzcGxheSwg bV93aW5kb3csIHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSk7CiAKICAgICBYRmx1c2goZGlz cGxheSk7Cg==