99092 2012-10-11 13:16:51 -0700 [Chromium] Improve the comment describing mainWorldScriptContext 2012-10-11 14:13:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth dglazkov fishd gbillock jamesr tkent+wkapi webkit.review.bot oldest_to_newest 740197 0 abarth 2012-10-11 13:16:51 -0700 [Chromium] Improve the comment describing mainWorldScriptContext 740199 1 168265 abarth 2012-10-11 13:17:25 -0700 Created attachment 168265 Patch 740203 2 jamesr 2012-10-11 13:20:47 -0700 Most of the callers seem a bit off - they're either injecting V8 extensions directly into this context or assuming that it's the only context that matters. 740205 3 webkit.review.bot 2012-10-11 13:21:35 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 740259 4 168265 webkit.review.bot 2012-10-11 14:13:08 -0700 Comment on attachment 168265 Patch Clearing flags on attachment: 168265 Committed r131095: <http://trac.webkit.org/changeset/131095> 740260 5 webkit.review.bot 2012-10-11 14:13:12 -0700 All reviewed patches have been landed. Closing bug. 168265 2012-10-11 13:17:25 -0700 2012-10-11 14:13:08 -0700 Patch bug-99092-20121011131622.patch text/plain 1642 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzEwOTApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEwLTExICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBJbXByb3ZlIHRoZSBjb21tZW50IGRlc2NyaWJpbmcgbWFpbldvcmxkU2Ny aXB0Q29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTkwOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHB1YmxpYy9XZWJGcmFtZS5oOgorICAgICAgICAoV2ViRnJhbWUpOgorICAgICAgICAgICAg LSBBZGQgc29tZSBtb3JlIHRleHQgYWJvdXQgd2hhdCB0aGlzIEFQSSBkb2VzIHNvIHRoYXQgZm9s a3Mgd2hvCisgICAgICAgICAgICAgIGNhbGwgaXQga25vdyB3aGF0IHRoZXkgbmVlZCB0byB3b3Jy eSBhYm91dC4KKwogMjAxMi0xMC0xMSAgTWloYWkgQmFsYW4gIDxtaWJhbGFuQGFkb2JlLmNvbT4K IAogICAgICAgICBBbHdheXMgZW5hYmxlIHRoZSBleHBlcmltZW50cyB0YWIgZm9yIFdlYktpdCBu aWdodGx5CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgJKHJl dmlzaW9uIDEzMTA4NikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1l LmgJKHdvcmtpbmcgY29weSkKQEAgLTI5NCw4ICsyOTQsMTEgQEAgcHVibGljOgogICAgICAgICBp bnQgYXJnYywKICAgICAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFyZ3ZbXSkgPSAwOwogCi0g ICAgLy8gUmV0dXJucyB0aGUgVjggY29udGV4dCBmb3IgdGhpcyBmcmFtZSwgb3IgYW4gZW1wdHkg aGFuZGxlIGlmIHRoZXJlCi0gICAgLy8gaXMgbm9uZS4KKyAgICAvLyBSZXR1cm5zIHRoZSBWOCBj b250ZXh0IGZvciBhc3NvY2lhdGVkIHdpdGggdGhlIG1haW4gd29ybGQgYW5kIHRoaXMKKyAgICAv LyBmcmFtZS4gVGhlcmUgY2FuIGJlIG1hbnkgVjggY29udGV4dHMgYXNzb2NpYXRlZCB3aXRoIHRo aXMgZnJhbWUsIG9uZSBmb3IKKyAgICAvLyBlYWNoIGlzb2xhdGVkIHdvcmxkIGFuZCBvbmUgZm9y IHRoZSBtYWluIHdvcmxkLiBJZiB5b3UgZG9uJ3Qga25vdyB3aGF0CisgICAgLy8gdGhlICJtYWlu IHdvcmxkIiBvciBhbiAiaXNvbGF0ZWQgd29ybGQiIGlzLCB0aGVuIHlvdSBwcm9iYWJseSBzaG91 bGRuJ3QKKyAgICAvLyBiZSBjYWxsaW5nIHRoaXMgQVBJLgogICAgIHZpcnR1YWwgdjg6OkxvY2Fs PHY4OjpDb250ZXh0PiBtYWluV29ybGRTY3JpcHRDb250ZXh0KCkgY29uc3QgPSAwOwogCiAgICAg Ly8gQ3JlYXRlcyBhbiBpbnN0YW5jZSBvZiBmaWxlIHN5c3RlbSBvYmplY3QuCg==