99079 2012-10-11 08:46:53 -0700 Regression(r131058): Broke EFL build 2012-10-11 09:37:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98247 1 cdumez cdumez d-r gyuyoung.kim kenneth naginenis ryuan.choi webkit.review.bot oldest_to_newest 740010 0 cdumez 2012-10-11 08:46:53 -0700 r131058 broke the EFL build: /home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp: In member function ‘bool WebCore::SimpleFontData::canRenderCombiningCharacterSequence(const UChar*, size_t) const’: /home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:184:36: error: ‘WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, bool>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, bool> >, WTF::StringHash, WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>, WTF::HashTraits<bool> >, WTF::HashTraits<WTF::String> >::ValueType’ has no member named ‘second’ /home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:198:29: error: ‘WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, bool>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, bool> >, WTF::StringHash, WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>, WTF::HashTraits<bool> >, WTF::HashTraits<WTF::String> >::ValueType’ has no member named ‘second’ /home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:201:32: error: ‘WTF::HashTableIterator<WTF::String, WTF::KeyValuePair<WTF::String, bool>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::String, bool> >, WTF::StringHash, WTF::HashMapValueTraits<WTF::HashTraits<WTF::String>, WTF::HashTraits<bool> >, WTF::HashTraits<WTF::String> >::ValueType’ has no member named ‘second’ /home/chris/unencrypted/WebKit/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:202:1: warning: control reaches end of non-void function [-Wreturn-type] make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/platform/graphics/freetype/SimpleFontDataFreeType.cpp.o] Error 1 740013 1 168236 cdumez 2012-10-11 08:51:05 -0700 Created attachment 168236 Patch Could someone please cq+? 740061 2 168236 webkit.review.bot 2012-10-11 09:37:55 -0700 Comment on attachment 168236 Patch Clearing flags on attachment: 168236 Committed r131073: <http://trac.webkit.org/changeset/131073> 740062 3 webkit.review.bot 2012-10-11 09:37:59 -0700 All reviewed patches have been landed. Closing bug. 168236 2012-10-11 08:51:05 -0700 2012-10-11 09:37:55 -0700 Patch 99079_build_fix.patch text/plain 1954 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYzVhN2Y0Li5iZWVlZjEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTAtMTEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMzEwNTgpOiBCcm9rZSBFRkwgYnVpbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MDc5CisKKyAg ICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgVXNlIGl0ZXJhdG9yOjp2YWx1 ZSBpbnN0ZWFkIG9mIGl0ZXJhdG9yOjpzZWNvbmQgdG8gZml4CisgICAgICAgIGJ1aWxkIGJyZWFr IGFmdGVyIHIxMzEwNTguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9T aW1wbGVGb250RGF0YUZyZWVUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUZvbnRE YXRhOjpjYW5SZW5kZXJDb21iaW5pbmdDaGFyYWN0ZXJTZXF1ZW5jZSk6CisKIDIwMTItMTAtMTEg IEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWJJREw6IG92 ZXJsb2FkZWQgbWV0aG9kcyBwcmV2ZW50IG51bWJlciAtPiBzdHJpbmcgY29udmVyc2lvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvU2ltcGxl Rm9udERhdGFGcmVlVHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9m cmVldHlwZS9TaW1wbGVGb250RGF0YUZyZWVUeXBlLmNwcAppbmRleCAyMGY0ZjM3Li4zMGQ4ODlm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9T aW1wbGVGb250RGF0YUZyZWVUeXBlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9mcmVldHlwZS9TaW1wbGVGb250RGF0YUZyZWVUeXBlLmNwcApAQCAtMTgxLDcgKzE4 MSw3IEBAIGJvb2wgU2ltcGxlRm9udERhdGE6OmNhblJlbmRlckNvbWJpbmluZ0NoYXJhY3RlclNl cXVlbmNlKGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzCiAKICAgICBXVEY6Okhhc2hNYXA8U3RyaW5n LCBib29sPjo6QWRkUmVzdWx0IGFkZFJlc3VsdCA9IG1fY29tYmluaW5nQ2hhcmFjdGVyU2VxdWVu Y2VTdXBwb3J0LT5hZGQoU3RyaW5nKGNoYXJhY3RlcnMsIGxlbmd0aCksIGZhbHNlKTsKICAgICBp ZiAoIWFkZFJlc3VsdC5pc05ld0VudHJ5KQotICAgICAgICByZXR1cm4gYWRkUmVzdWx0Lml0ZXJh dG9yLT5zZWNvbmQ7CisgICAgICAgIHJldHVybiBhZGRSZXN1bHQuaXRlcmF0b3ItPnZhbHVlOwog CiAgICAgVUVycm9yQ29kZSBlcnJvciA9IFVfWkVST19FUlJPUjsKICAgICBWZWN0b3I8VUNoYXIs IDQ+IG5vcm1hbGl6ZWRDaGFyYWN0ZXJzKGxlbmd0aCk7CkBAIC0xOTUsMTAgKzE5NSwxMCBAQCBi b29sIFNpbXBsZUZvbnREYXRhOjpjYW5SZW5kZXJDb21iaW5pbmdDaGFyYWN0ZXJTZXF1ZW5jZShj b25zdCBVQ2hhciogY2hhcmFjdGVycwogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAo RmNGcmVlVHlwZUNoYXJJbmRleChmYWNlLCBub3JtYWxpemVkQ2hhcmFjdGVyc1swXSkpCi0gICAg ICAgIGFkZFJlc3VsdC5pdGVyYXRvci0+c2Vjb25kID0gdHJ1ZTsKKyAgICAgICAgYWRkUmVzdWx0 Lml0ZXJhdG9yLT52YWx1ZSA9IHRydWU7CiAKICAgICBjYWlyb19mdF9zY2FsZWRfZm9udF91bmxv Y2tfZmFjZShtX3BsYXRmb3JtRGF0YS5zY2FsZWRGb250KCkpOwotICAgIHJldHVybiBhZGRSZXN1 bHQuaXRlcmF0b3ItPnNlY29uZDsKKyAgICByZXR1cm4gYWRkUmVzdWx0Lml0ZXJhdG9yLT52YWx1 ZTsKIH0KICNlbmRpZgogCg==