99076 2012-10-11 08:31:36 -0700 [Qt][WK2] GraphicsSurfaceGLX should keep track of previous GL context. 2012-10-12 02:37:03 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno noam oldest_to_newest 739996 0 zeno 2012-10-11 08:31:36 -0700 In GraphicsSurfaceGLX / GraphicsSurfacePrivate constructor we create a new GL context for resolving GL functions. The QOpenGLContext implementation for GLX makes this context current by default. Therefore we have to keep track of the previous context and make that one current again after the creation. 740005 1 168233 zeno 2012-10-11 08:40:53 -0700 Created attachment 168233 patch for review. 740753 2 168233 zeno 2012-10-12 02:36:58 -0700 Comment on attachment 168233 patch for review. Clearing flags on attachment: 168233 Committed r131164: <http://trac.webkit.org/changeset/131164> 740754 3 zeno 2012-10-12 02:37:03 -0700 All reviewed patches have been landed. Closing bug. 168233 2012-10-11 08:40:53 -0700 2012-10-12 02:36:58 -0700 patch for review. 99076_20121011-173835.patch text/plain 2031 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNjhjZWJmLi4zMzdlMmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMTEgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtXSzJdIEdyYXBoaWNzU3VyZmFjZUdMWCBzaG91bGQga2VlcCB0cmFjayBvZiBwcmV2 aW91cyBHTCBjb250ZXh0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTkwNzYKKworICAgICAgICBJbiBHcmFwaGljc1N1cmZhY2VHTFgvR3JhcGhpY3NT dXJmYWNlUHJpdmF0ZSB3ZSBjcmVhdGUgYSBuZXcKKyAgICAgICAgUU9wZW5HTENvbnRleHQgZm9y IHJlc29sdmluZyBHTCBtZXRob2RzLgorICAgICAgICBUaGlzIGNvbnRleHQgaXMgaW1wbGljaXRs eSBtYWRlIGN1cnJlbnQgb24gY3JlYXRpb24uCisgICAgICAgIFRoZXJlZm9yZSB3ZSBuZWVkIHRv IGtlZXAgdHJhY2sgb2YgdGhlIHByZXZpb3VzbHkgYm91bmQgY29udGV4dAorICAgICAgICBhbmQg bWFrZSB0aGF0IG9uZSBjdXJyZW50IGFnYWluIGFmdGVyIGNhbGxpbmcgY3JlYXRlLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkdyYXBoaWNzU3VyZmFjZVByaXZhdGU6OkdyYXBoaWNzU3VyZmFjZVByaXZhdGUpOgorCiAy MDEyLTEwLTEwICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAg IFJFR1JFU1NJT04gKHIxMjk3MzgpOiBDYWxlbmRhciBwaWNrZXIgaXMgdG9vIHdpZGUgd2hlbiB0 aGUgaW5wdXQgaXMgcnRsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9zdXJmYWNlcy9xdC9HcmFwaGljc1N1cmZhY2VHTFguY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvcXQvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcAppbmRl eCAxYmJlYjczLi5lMDI2OTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9zdXJmYWNlcy9xdC9HcmFwaGljc1N1cmZhY2VHTFguY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL3F0L0dyYXBoaWNzU3VyZmFjZUdMWC5j cHAKQEAgLTEwNyw4ICsxMDcsMTggQEAgc3RydWN0IEdyYXBoaWNzU3VyZmFjZVByaXZhdGUgewog ICAgICAgICAsIG1fdGV4dHVyZUlzWUludmVydGVkKGZhbHNlKQogICAgICAgICAsIG1faGFzQWxw aGEoZmFsc2UpCiAgICAgeworICAgICAgICBRU3VyZmFjZSogY3VycmVudFN1cmZhY2UgPSAwOwor ICAgICAgICBRT3BlbkdMQ29udGV4dCogY3VycmVudENvbnRleHQgPSBRT3BlbkdMQ29udGV4dDo6 Y3VycmVudENvbnRleHQoKTsKKyAgICAgICAgaWYgKGN1cnJlbnRDb250ZXh0KQorICAgICAgICAg ICAgY3VycmVudFN1cmZhY2UgPSBjdXJyZW50Q29udGV4dC0+c3VyZmFjZSgpOworCiAgICAgICAg IG1fZGlzcGxheSA9IFhPcGVuRGlzcGxheSgwKTsKICAgICAgICAgbV9nbENvbnRleHQtPmNyZWF0 ZSgpOworCisgICAgICAgIC8vIFRoZSBHTFggaW1wbGVtZW50YXRpb24gb2YgUU9wZW5HTENvbnRl eHQgd2lsbCByZXNldCB0aGUgY3VycmVudCBjb250ZXh0IHdoZW4gY3JlYXRlIGlzIGJlaW5nIGNh bGxlZC4KKyAgICAgICAgLy8gVGhlcmVmb3JlIHdlIGhhdmUgdG8gbWFrZSB0aGUgcHJldmlvdXMg Y29udGV4dCBjdXJyZW50IGFnYWluLgorICAgICAgICBpZiAoY3VycmVudENvbnRleHQpCisgICAg ICAgICAgICBjdXJyZW50Q29udGV4dC0+bWFrZUN1cnJlbnQoY3VycmVudFN1cmZhY2UpOwogICAg IH0KIAogICAgIH5HcmFwaGljc1N1cmZhY2VQcml2YXRlKCkK