9907 2006-07-14 03:10:43 -0700 REGRESSION (r15418): editing/pasteboard/paste-table-001 fails in pixel mode 2006-07-14 06:12:40 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned oldest_to_newest 49747 0 mitz 2006-07-14 03:10:43 -0700 The patch for bug 9670 regressed editing/pasteboard/paste-table-001. I think I got the caret rect calculation wrong :-( 49755 1 9443 mitz 2006-07-14 04:26:09 -0700 Created attachment 9443 Fix the calculation of min/max allowable caret position Fixes the regression and doesn't introduce new failures in run-webkit-tests --pixel editing fast. 49763 2 9443 darin 2006-07-14 05:32:30 -0700 Comment on attachment 9443 Fix the calculation of min/max allowable caret position r=me 49773 3 ddkilzer 2006-07-14 06:12:40 -0700 Committed revision 15427. 9443 2006-07-14 04:26:09 -0700 2006-07-14 05:32:30 -0700 Fix the calculation of min/max allowable caret position 9907_r1.patch text/plain 1902 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTQyMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDYtMDctMTQgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD05OTA3CisgICAgICAgICAgUkVHUkVTU0lPTiAocjE1NDE4KTogZWRpdGluZy9wYXN0ZWJv YXJkL3Bhc3RlLXRhYmxlLTAwMSBmYWlscyBpbiBwaXhlbCAgbW9kZQorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlclRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dDo6Y2Fy ZXRSZWN0KTogRml4ZWQgdGhlIGNhbGN1bGF0aW9uIG9mIHRoZSBtYXgvbWluIGFsbG93ZWQgY2Fy ZXQKKyAgICAgICAgcG9zaXRpb24uCisKIDIwMDYtMDctMTQgIEdlb2ZmcmV5IEdhcmVuICA8Z2dh cmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZS4KSW5kZXg6IFdlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRleHQuY3BwCShyZXZpc2lvbiAxNTQyMykKKysrIFdlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDQsMTAgKzQwNCwxMSBAQCBJbnRS ZWN0IFJlbmRlclRleHQ6OmNhcmV0UmVjdChpbnQgb2Zmc2V0CiAKICAgICBpbnQgbGVmdCA9IGJv eC0+cG9zaXRpb25Gb3JPZmZzZXQob2Zmc2V0KTsKIAorICAgIGludCByb290TGVmdCA9IGJveC0+ cm9vdCgpLT54UG9zKCk7CiAgICAgLy8gRklYTUU6IHNob3VsZCB3ZSB1c2UgdGhlIHdpZHRoIG9m IHRoZSByb290IGlubGluZSBib3ggb3IgdGhlCiAgICAgLy8gd2lkdGggb2YgdGhlIGNvbnRhaW5p bmcgYmxvY2sgZm9yIHRoaXM/CiAgICAgaWYgKGV4dHJhV2lkdGhUb0VuZE9mTGluZSkKLSAgICAg ICAgKmV4dHJhV2lkdGhUb0VuZE9mTGluZSA9IChib3gtPnJvb3QoKS0+d2lkdGgoKSArIGJveC0+ cm9vdCgpLT54UG9zKCkpIC0gKGxlZnQgKyAxKTsKKyAgICAgICAgKmV4dHJhV2lkdGhUb0VuZE9m TGluZSA9IChib3gtPnJvb3QoKS0+d2lkdGgoKSArIHJvb3RMZWZ0KSAtIChsZWZ0ICsgMSk7CiAK ICAgICBpbnQgYWJzeCwgYWJzeTsKICAgICBhYnNvbHV0ZVBvc2l0aW9uRm9yQ29udGVudChhYnN4 LCBhYnN5KTsKQEAgLTQxOCw5ICs0MTksOSBAQCBJbnRSZWN0IFJlbmRlclRleHQ6OmNhcmV0UmVj dChpbnQgb2Zmc2V0CiAgICAgaWYgKHN0eWxlKCktPmF1dG9XcmFwKCkpIHsKICAgICAgICAgaW50 IGF2YWlsYWJsZVdpZHRoID0gY2ItPmxpbmVXaWR0aCh0b3ApOwogICAgICAgICBpZiAoIWJveC0+ bV9yZXZlcnNlZCkKLSAgICAgICAgICAgIGxlZnQgPSBtaW4obGVmdCwgYWJzeCArIGF2YWlsYWJs ZVdpZHRoIC0gMSk7CisgICAgICAgICAgICBsZWZ0ID0gbWluKGxlZnQsIGFic3ggKyByb290TGVm dCArIGF2YWlsYWJsZVdpZHRoIC0gMSk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIGxlZnQg PSBtYXgobGVmdCwgYWJzeCArIGJveC0+bV94KTsKKyAgICAgICAgICAgIGxlZnQgPSBtYXgobGVm dCwgYWJzeCArIHJvb3RMZWZ0KTsKICAgICB9CiAgICAgIAogICAgIHJldHVybiBJbnRSZWN0KGxl ZnQsIHRvcCwgMSwgaGVpZ2h0KTsK