9903 2006-07-13 20:29:17 -0700 Simplify logic in JSHTMLOptionsCollection::setLength() by using no-arg getNumber() 2007-06-24 12:04:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer darin ggaren mrowe oldest_to_newest 49702 0 ddkilzer 2006-07-13 20:29:17 -0700 This is a follow-up to Bug 9742.  See Bug 9742 Comment #15 for Geoffrey's comments about why this should be fixed. Adding NeedsRadar keyword since it's a follow-up to bug 9742, which also had NeedsRadar. 49706 1 9438 ddkilzer 2006-07-13 21:21:34 -0700 Created attachment 9438 Patch v1 Proposed patch.  (I hope I interpreted your comment correctly, Geoff!) 49708 2 9438 ddkilzer 2006-07-13 21:58:34 -0700 Comment on attachment 9438 Patch v1 Oops. I need to include the bug information in the ChangeLog! 49711 3 9439 ddkilzer 2006-07-13 22:33:31 -0700 Created attachment 9439 Patch v2 Now with Bugzilla bug information in the ChangeLog! 49712 4 ddkilzer 2006-07-13 22:45:51 -0700 Note that the tests added in Bug 9742 still pass with Patch v2. 49718 5 9439 ggaren 2006-07-14 01:27:09 -0700 Comment on attachment 9439 Patch v2 That's right. This patch enables landing the getNumber part of my JavaScriptCore patch: { if (JSImmediate::isImmediate(this)) { v = JSImmediate::toDouble(this); - return true; + return JSImmediate::isNumber(this); } return downcast()->getNumber(v); 49759 6 ddkilzer 2006-07-14 05:00:19 -0700 Committed revision 15424. 6466 7 ddkilzer 2007-06-24 12:04:43 -0700 Mass removal of NeedsRadar keyword from my bugs that have already been RESOLVED. 9438 2006-07-13 21:21:34 -0700 2006-07-13 22:33:31 -0700 Patch v1 bug-9903-v1.diff text/plain 1572 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTQxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDYtMDctMTMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHpl ci5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Tm8gdGVzdCBjYXNlcyBzaW5jZSB0aGVyZSBpcyBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0eS4K KworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTE9wdGlvbnNDb2xsZWN0aW9uQ3VzdG9tLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkpTSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpzZXRMZW5ndGgp OiAgU2ltcGxpZmllZCBsb2dpYyBieSB1c2luZyB0aGUKKyAgICAgICAgbm8tYXJndW1lbnQgZ2V0 TnVtYmVyKCkgbWV0aG9kLgorCiAyMDA2LTA3LTEzICBEYXZpZCBIYXJyaXNvbiAgPGhhcnJpc29u QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZlIEh5YXR0LgpJbmRleDogV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0hUTUxPcHRpb25zQ29sbGVjdGlvbkN1c3RvbS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxPcHRpb25zQ29sbGVjdGlvbkN1c3Rv bS5jcHAJKHJldmlzaW9uIDE1NDE2KQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxPcHRp b25zQ29sbGVjdGlvbkN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDExICs0NCw5IEBA IHZvaWQgSlNIVE1MT3B0aW9uc0NvbGxlY3Rpb246OnNldExlbmd0aCgKICAgICBIVE1MT3B0aW9u c0NvbGxlY3Rpb24qIGltcCA9IHN0YXRpY19jYXN0PEhUTUxPcHRpb25zQ29sbGVjdGlvbio+KGlt cGwoKSk7CiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAgdW5zaWduZWQgbmV3TGVuZ3Ro ID0gMDsKLSAgICBkb3VibGUgbGVuZ3RoVmFsdWU7Ci0gICAgaWYgKCF2YWx1ZS0+aXNVbmRlZmlu ZWRPck51bGwoKSAmJiB2YWx1ZS0+Z2V0TnVtYmVyKGxlbmd0aFZhbHVlKSkgewotICAgICAgICBp ZiAoaXNOYU4obGVuZ3RoVmFsdWUpIHx8IGlzSW5mKGxlbmd0aFZhbHVlKSkKLSAgICAgICAgICAg IG5ld0xlbmd0aCA9IDA7Ci0gICAgICAgIGVsc2UgaWYgKGxlbmd0aFZhbHVlIDwgMC4wKQorICAg IGRvdWJsZSBsZW5ndGhWYWx1ZSA9IHZhbHVlLT5nZXROdW1iZXIoKTsKKyAgICBpZiAoIWlzTmFO KGxlbmd0aFZhbHVlKSAmJiAhaXNJbmYobGVuZ3RoVmFsdWUpKSB7CisgICAgICAgIGlmIChsZW5n dGhWYWx1ZSA8IDAuMCkKICAgICAgICAgICAgIGVjID0gSU5ERVhfU0laRV9FUlI7CiAgICAgICAg IGVsc2UgaWYgKGxlbmd0aFZhbHVlID4gc3RhdGljX2Nhc3Q8ZG91YmxlPihVSU5UX01BWCkpCiAg ICAgICAgICAgICBuZXdMZW5ndGggPSBVSU5UX01BWDsK 9439 2006-07-13 22:33:31 -0700 2006-07-14 01:27:09 -0700 Patch v2 bug-9903-v2.diff text/plain 1738 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTQxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDYtMDctMTMgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHpl ci5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg LSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05OTAz CisgICAgICAgICAgU2ltcGxpZnkgbG9naWMgaW4gSlNIVE1MT3B0aW9uc0NvbGxlY3Rpb246OnNl dExlbmd0aCgpIGJ5IHVzaW5nIG5vLWFyZyBnZXROdW1iZXIoKQorCisgICAgICAgIE5vIHRlc3Qg Y2FzZXMgc2luY2UgdGhlcmUgaXMgbm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0hUTUxPcHRpb25zQ29sbGVjdGlvbkN1c3RvbS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpKU0hUTUxPcHRpb25zQ29sbGVjdGlvbjo6c2V0TGVuZ3RoKTogIFNpbXBs aWZpZWQgbG9naWMgYnkgdXNpbmcgdGhlCisgICAgICAgIG5vLWFyZ3VtZW50IGdldE51bWJlcigp IG1ldGhvZC4KKwogMjAwNi0wNy0xMyAgTWl0eiBQZXR0ZWwgIDxvcGVuZGFyd2luLm9yZ0BtaXR6 cGV0dGVsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBIeWF0dC4KSW5kZXg6IFdlYkNvcmUv YmluZGluZ3MvanMvSlNIVE1MT3B0aW9uc0NvbGxlY3Rpb25DdXN0b20uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MT3B0aW9uc0NvbGxlY3Rpb25DdXN0b20uY3Bw CShyZXZpc2lvbiAxNTQxNikKKysrIFdlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MT3B0aW9uc0Nv bGxlY3Rpb25DdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NCwxMSArNDQsOSBAQCB2b2lk IEpTSFRNTE9wdGlvbnNDb2xsZWN0aW9uOjpzZXRMZW5ndGgoCiAgICAgSFRNTE9wdGlvbnNDb2xs ZWN0aW9uKiBpbXAgPSBzdGF0aWNfY2FzdDxIVE1MT3B0aW9uc0NvbGxlY3Rpb24qPihpbXBsKCkp OwogICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwogICAgIHVuc2lnbmVkIG5ld0xlbmd0aCA9IDA7 Ci0gICAgZG91YmxlIGxlbmd0aFZhbHVlOwotICAgIGlmICghdmFsdWUtPmlzVW5kZWZpbmVkT3JO dWxsKCkgJiYgdmFsdWUtPmdldE51bWJlcihsZW5ndGhWYWx1ZSkpIHsKLSAgICAgICAgaWYgKGlz TmFOKGxlbmd0aFZhbHVlKSB8fCBpc0luZihsZW5ndGhWYWx1ZSkpCi0gICAgICAgICAgICBuZXdM ZW5ndGggPSAwOwotICAgICAgICBlbHNlIGlmIChsZW5ndGhWYWx1ZSA8IDAuMCkKKyAgICBkb3Vi bGUgbGVuZ3RoVmFsdWUgPSB2YWx1ZS0+Z2V0TnVtYmVyKCk7CisgICAgaWYgKCFpc05hTihsZW5n dGhWYWx1ZSkgJiYgIWlzSW5mKGxlbmd0aFZhbHVlKSkgeworICAgICAgICBpZiAobGVuZ3RoVmFs dWUgPCAwLjApCiAgICAgICAgICAgICBlYyA9IElOREVYX1NJWkVfRVJSOwogICAgICAgICBlbHNl IGlmIChsZW5ndGhWYWx1ZSA+IHN0YXRpY19jYXN0PGRvdWJsZT4oVUlOVF9NQVgpKQogICAgICAg ICAgICAgbmV3TGVuZ3RoID0gVUlOVF9NQVg7Cg==