99019 2012-10-11 04:00:32 -0700 [GTK] REGRESSION(r131033): Favicons don't work in MiniBrowser 2012-10-11 09:37:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia mario mario webkit.review.bot oldest_to_newest 739790 0 cgarcia 2012-10-11 04:00:32 -0700 Since r131033, the favicon database is not initialized by default, so we need call webkit_web_context_set_favicon_database_directory() in MiniBrowser to enable favicons again. 739988 1 168228 mario 2012-10-11 08:16:30 -0700 Created attachment 168228 Patch proposal Oneliner ready 740007 2 168228 cgarcia 2012-10-11 08:43:58 -0700 Comment on attachment 168228 Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=168228&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:524 > + // Enable the favicon database, by specifying the default directory. > + webkit_web_context_set_favicon_database_directory(webkit_web_view_get_context(window->webView), NULL); > + We don't want to do this for every window, since we are sharing the web process, if would be better to do it only once in main.c before browser windows are created. 740015 3 168237 mario 2012-10-11 08:53:30 -0700 Created attachment 168237 Path proposal New patch addressing Carlos's comment 740059 4 168237 webkit.review.bot 2012-10-11 09:37:04 -0700 Comment on attachment 168237 Path proposal Clearing flags on attachment: 168237 Committed r131072: <http://trac.webkit.org/changeset/131072> 740060 5 webkit.review.bot 2012-10-11 09:37:06 -0700 All reviewed patches have been landed. Closing bug. 168228 2012-10-11 08:16:30 -0700 2012-10-11 08:53:24 -0700 Patch proposal 0001-2012-10-11-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2507 mario RnJvbSA4ZDA3NGVlYWQ1ZTM2N2MxY2FkM2JlYTc0NzBiNzEyN2EzZmNhYmM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDExIE9jdCAyMDEyIDE3OjE0OjE1ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0xMC0xMSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIFJFR1JFU1NJT04ocjEzMTAzMyk6IEZhdmljb25zIGRvbid0IHdvcmsg aW4gTWluaUJyb3dzZXIKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTkwMTkKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAg IEVuYWJsZSB0aGUgZmF2aWNvbnMgZGF0YWJhc2UgYnkgc3BlY2lmeWluZyB0aGUgZGVmYXVsdCBw YXRoIGZvcgogICAgICAgIHRoZSBkaXJlY3Rvcnkgd2hlcmUgdGhlIGFjdHVhbCBkYXRhIHdpbGwg YmUgc3RvcmVkLgoKICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CiAg ICAgICAgKGJyb3dzZXJXaW5kb3dDb25zdHJ1Y3RlZCk6IFNldCB0aGUgZGVmYXVsdCBkaXJlY3Rv cnkgZm9yIHRoZSBkYXRhYmFzZQogICAgICAgIGNhbGxpbmcgIHdlYmtpdF93ZWJfY29udGV4dF9z ZXRfZmF2aWNvbl9kYXRhYmFzZV9kaXJlY3RvcnkoKQotLS0KIFRvb2xzL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysrKysrKwogVG9vbHMvTWluaUJyb3dzZXIv Z3RrL0Jyb3dzZXJXaW5kb3cuYyB8ICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRp b25zKCspCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDA5N2U0MWUuLjlmMGUwNGYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMC0xMSAgTWFyaW8gU2FuY2hl eiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gUkVHUkVTU0lP TihyMTMxMDMzKTogRmF2aWNvbnMgZG9uJ3Qgd29yayBpbiBNaW5pQnJvd3NlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTkwMTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgdGhlIGZhdmljb25z IGRhdGFiYXNlIGJ5IHNwZWNpZnlpbmcgdGhlIGRlZmF1bHQgcGF0aCBmb3IKKyAgICAgICAgdGhl IGRpcmVjdG9yeSB3aGVyZSB0aGUgYWN0dWFsIGRhdGEgd2lsbCBiZSBzdG9yZWQuCisKKyAgICAg ICAgKiBNaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jOgorICAgICAgICAoYnJvd3Nlcldp bmRvd0NvbnN0cnVjdGVkKTogU2V0IHRoZSBkZWZhdWx0IGRpcmVjdG9yeSBmb3IgdGhlIGRhdGFi YXNlCisgICAgICAgIGNhbGxpbmcgIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfZmF2aWNvbl9kYXRh YmFzZV9kaXJlY3RvcnkoKQorCiAyMDEyLTEwLTExICBKaW53b28gU29uZyAgPGppbndvbzcuc29u Z0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFJldmlzaXQgc2V0dGluZyBBUEkg bmFtZXMgYW5kIGRvY3VtZW50YXRpb24KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyV2luZG93LmMgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5j CmluZGV4IDg2YjA0NDYuLmVlYjliNWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0 ay9Ccm93c2VyV2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5k b3cuYwpAQCAtNTE5LDYgKzUxOSw5IEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJXaW5kb3dDb25zdHJ1 Y3RlZChHT2JqZWN0ICpnT2JqZWN0KQogICAgIFdlYktpdEJhY2tGb3J3YXJkTGlzdCAqYmFja0Zv cndhZGxpc3QgPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2JhY2tfZm9yd2FyZF9saXN0KHdpbmRvdy0+ d2ViVmlldyk7CiAgICAgZ19zaWduYWxfY29ubmVjdChiYWNrRm9yd2FkbGlzdCwgImNoYW5nZWQi LCBHX0NBTExCQUNLKGJhY2tGb3J3YWRsaXN0Q2hhbmdlZCksIHdpbmRvdyk7CiAKKyAgICAvLyBF bmFibGUgdGhlIGZhdmljb24gZGF0YWJhc2UsIGJ5IHNwZWNpZnlpbmcgdGhlIGRlZmF1bHQgZGly ZWN0b3J5LgorICAgIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfZmF2aWNvbl9kYXRhYmFzZV9kaXJl Y3Rvcnkod2Via2l0X3dlYl92aWV3X2dldF9jb250ZXh0KHdpbmRvdy0+d2ViVmlldyksIE5VTEwp OworCiAjaWYgR1RLX0NIRUNLX1ZFUlNJT04oMywgMiwgMCkKICAgICBHdGtXaWRnZXQgKm92ZXJs YXkgPSBndGtfb3ZlcmxheV9uZXcoKTsKICAgICBndGtfYm94X3BhY2tfc3RhcnQoR1RLX0JPWCh3 aW5kb3ctPm1haW5Cb3gpLCBvdmVybGF5LCBUUlVFLCBUUlVFLCAwKTsKLS0gCjEuNy4xMS40Cgo= 168237 2012-10-11 08:53:30 -0700 2012-10-11 09:37:03 -0700 Path proposal bug-99019-20121011175228.patch text/plain 1514 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMDM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDk3ZTQxZTQxMjlhYzM4ZWVlZjU5OGVmZTNiODJmNTli MjFkZTQ1NC4uY2JhNDY0ZmZiYzU0ODNhMmRjMjhmYzM5NTlhMTI5ZDAyYmJlZjdiMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEwLTExICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBSRUdSRVNTSU9OKHIxMzEwMzMpOiBGYXZpY29ucyBkb24ndCB3 b3JrIGluIE1pbmlCcm93c2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05OTAxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEVuYWJsZSB0aGUgZmF2aWNvbnMgZGF0YWJhc2UgYnkgc3BlY2lmeWluZyB0aGUg ZGVmYXVsdCBwYXRoIGZvcgorICAgICAgICB0aGUgZGlyZWN0b3J5IHdoZXJlIHRoZSBhY3R1YWwg ZGF0YSB3aWxsIGJlIHN0b3JlZC4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9tYWluLmM6 CisgICAgICAgIChtYWluKTogU2V0IHRoZSBkZWZhdWx0IGRpcmVjdG9yeSBmb3IgdGhlIGZhdmlj b24gZGF0YWJhc2UgY2FsbGluZworICAgICAgICB3ZWJraXRfd2ViX2NvbnRleHRfc2V0X2Zhdmlj b25fZGF0YWJhc2VfZGlyZWN0b3J5KCkuCisKIDIwMTItMTAtMTEgIEppbndvbyBTb25nICA8amlu d29vNy5zb25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW1dLMl0gUmV2aXNpdCBzZXR0 aW5nIEFQSSBuYW1lcyBhbmQgZG9jdW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJy b3dzZXIvZ3RrL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWluLmMKaW5kZXggNGE5 ZDhhNWZjMzNjMTQ3MmYzMTEwMGFiNjFmNmIyOWVmNmFmODY2ZS4uYzczNjdkZjljMTNlODU4NTU3 ZDAwNmE2NmI2NWRmOWRkZTIyYWJiZSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3Rr L21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCkBAIC0yMjcsNiArMjI3 LDkgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKICAgICBnX3NldGVudigiV0VC S0lUX0lOU1BFQ1RPUl9QQVRIIiwgV0VCS0lUX0VYRUNfUEFUSCAicmVzb3VyY2VzL2luc3BlY3Rv ciIsIEZBTFNFKTsKICNlbmRpZiAvKiBXRUJLSVRfRVhFQ19QQVRIICovCiAKKyAgICAvLyBFbmFi bGUgdGhlIGZhdmljb24gZGF0YWJhc2UsIGJ5IHNwZWNpZnlpbmcgdGhlIGRlZmF1bHQgZGlyZWN0 b3J5LgorICAgIHdlYmtpdF93ZWJfY29udGV4dF9zZXRfZmF2aWNvbl9kYXRhYmFzZV9kaXJlY3Rv cnkod2Via2l0X3dlYl9jb250ZXh0X2dldF9kZWZhdWx0KCksIE5VTEwpOworCiAgICAgaWYgKHVy aUFyZ3VtZW50cykgewogICAgICAgICBpbnQgaTsKIAo=