99004 2012-10-11 00:58:47 -0700 Fix committers.py for the names of contributors to appear on webkit.org/team.html 2012-10-11 13:24:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vivekgalatage vivekgalatage abarth ap dpranke ojan webkit.review.bot oldest_to_newest 739678 0 vivekgalatage 2012-10-11 00:58:47 -0700 Fix committers.py for the names of contributors to appear on webkit.org/team.html 739695 1 168163 vivekgalatage 2012-10-11 01:15:25 -0700 Created attachment 168163 Patch 739709 2 168163 yutak 2012-10-11 01:29:21 -0700 Comment on attachment 168163 Patch I feel what should be fixed is the parser (where is it?) in this case, but there's no reason to leave this style inconsistencies. 739718 3 168163 webkit.review.bot 2012-10-11 01:52:42 -0700 Comment on attachment 168163 Patch Clearing flags on attachment: 168163 Committed r131029: <http://trac.webkit.org/changeset/131029> 739719 4 webkit.review.bot 2012-10-11 01:52:45 -0700 All reviewed patches have been landed. Closing bug. 739744 5 vivekgalatage 2012-10-11 02:28:43 -0700 (In reply to comment #2) > (From update of attachment 168163 [details]) > I feel what should be fixed is the parser (where is it?) in this case, but there's no reason to leave > this style inconsistencies. The JSON specification specifies about using the strings only with ("). Also its stated here http://stackoverflow.com/questions/2275359/jquery-single-quote-in-json-response?answertab=votes#tab-top Some of the implementations(as stated in above link: java) might allow the (') strings. I verified with all leading browsers(FF, Opera) (fiddle link: http://jsfiddle.net/4bwrC/ ) and all of them don't support this. The errors are reported from here: JSC: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/LiteralParser.cpp#L274 V8: Source/WebKit/chromium/v8/src/messages.js Line: 145 740206 6 ap 2012-10-11 13:24:44 -0700 I'm confused. When did names from committers.py become published on webkit.org/team.html? Have these persons given their permission for that? 168163 2012-10-11 01:15:25 -0700 2012-10-11 01:52:42 -0700 Patch bug-99004-20121011134449.patch text/plain 4362 vivekgalatage U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwNzQ4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2U3Y2Y5NjA0OGI2MmNhZDlhZDZiNmVjNWNjZDI3OGMy NDg5M2QzYS4uZmFiMDVjNmVjYWNjNzI0MzA1NzEyZDYwNTNjMzdkNzc3NTIyZWU3NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTEwLTExIFZpdmVrIEdhbGF0YWdlIDx2aXZla2dhbGF0YWdlQGdtYWlsLmNvbT4K KworICAgICAgICBGaXggY29tbWl0dGVycy5weSBmb3IgdGhlIG5hbWVzIG9mIGNvbnRyaWJ1dG9y cyB0byBhcHBlYXIgb24gd2Via2l0Lm9yZy90ZWFtLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MDA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkKKworICAgICAgICBTb21lIG9mIHRoZSBuaWNrbmFtZXMgaW4gdGhlIGNv bW1pdHRlcnMucHkgZmlsZSBhcmUgdXNpbmcgdGhlIHNpbmdsZSBxdW90ZXMgKCcpCisgICAgICAg IGJ1dCB3aGlsZSBwYXJzaW5nIHRoZXNlLCBKU09OIHRocm93cyBhbiBlcnJvcjogU2luZ2xlIHF1 b3RlcyAoJykgYXJlIG5vdCBhbGxvd2VkIGluIEpTT04KKyAgICAgICAgSGVuY2UgY292ZXJ0aW5n IHRoZXNlIHNpbmdsZSBxdW90ZXMgdG8gKCIpIHNvIGFzIHRoZSBjb250cmlidXRvciBuYW1lcyBh cHBlYXIgcHJvcGVybHkKKyAgICAgICAgb24gaHR0cDovL3d3dy53ZWJraXQub3JnL3RlYW0uaHRt bAorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL2NvbW1pdHRlcnMu cHk6CisKIDIwMTItMTAtMDkgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkIEdUSyBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvY29tbWl0dGVycy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9jb21taXR0ZXJzLnB5CmluZGV4IDhiODJlOTEzM2Q5 MWUwY2E4MDM1NjQ5YjU5YzFhZjBiZDMyYzMwMmIuLjM4ZjRmZTNjYjljYjg0OTQ4YWRjMDJjODJi MTVkNTVkOWFjNzA1NWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L2NvbmZpZy9jb21taXR0ZXJzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L2NvbmZpZy9jb21taXR0ZXJzLnB5CkBAIC0xMDgsMTQgKzEwOCwxNCBAQCB3YXRjaGVyc193aG9f YXJlX25vdF9jb250cmlidXRvcnMgPSBbCiAKIGNvbnRyaWJ1dG9yc193aG9fYXJlX25vdF9jb21t aXR0ZXJzID0gWwogICAgIENvbnRyaWJ1dG9yKCJBaGFyb24gTGFuaW4iLCAiYWhhcm9uQGdvb2ds ZS5jb20iKSwKLSAgICBDb250cmlidXRvcigiQWxhbiBTdGVhcm5zIiwgInN0ZWFybnNAYWRvYmUu Y29tIiwgJ2FzdGVhcm5zJyksCisgICAgQ29udHJpYnV0b3IoIkFsYW4gU3RlYXJucyIsICJzdGVh cm5zQGFkb2JlLmNvbSIsICJhc3RlYXJucyIpLAogICAgIENvbnRyaWJ1dG9yKCJBbGV4ZXkgTWFy aW5pY2hldiIsIFsiYW1hcmluaWNoZXZAY2hyb21pdW0ub3JnIiwgImFtYXJpbmljaGV2QGdvb2ds ZS5jb20iXSwgImFtYXJpbmljaGV2IiksCiAgICAgQ29udHJpYnV0b3IoIkFuZHJhcyBQaXJvc2th IiwgInBhbmRyYXNAaW5mLnUtc3plZ2VkLmh1IiwgImFuZHJpczg4IiksCiAgICAgQ29udHJpYnV0 b3IoIkFuZHJlaSBCdWN1ciIsICJhYnVjdXJAYWRvYmUuY29tIiwgImFidWN1ciIpLAogICAgIENv bnRyaWJ1dG9yKCJBbm5lIHZhbiBLZXN0ZXJlbiIsICJhbm5ldmFua2VzdGVyZW4rd2Via2l0QGdt YWlsLmNvbSIsICJhbm5ldmsiKSwKICAgICBDb250cmlidXRvcigiQW5uaWUgU3VsbGl2YW4iLCAi c3VsbGl2YW5AY2hyb21pdW0ub3JnIiwgImFubmllIiksCiAgICAgQ29udHJpYnV0b3IoIkFyeWVo IEdyZWdvciIsICJheWdAYXJ5ZWgubmFtZSIsICJBcnllaEdyZWdvciIpLAotICAgIENvbnRyaWJ1 dG9yKCJCYWxhenMgQW5rZXMiLCAiYmFua0BpbmYudS1zemVnZWQuaHUiLCAnYWJhbGF6cycpLAor ICAgIENvbnRyaWJ1dG9yKCJCYWxhenMgQW5rZXMiLCAiYmFua0BpbmYudS1zemVnZWQuaHUiLCAi YWJhbGF6cyIpLAogICAgIENvbnRyaWJ1dG9yKCJCcmlhbiBTYWxvbW9uIiwgImJzYWxvbW9uQGdv b2dsZS5jb20iKSwKICAgICBDb250cmlidXRvcigiQ29tbWl0IFF1ZXVlIiwgImNvbW1pdC1xdWV1 ZUB3ZWJraXQub3JnIiksCiAgICAgQ29udHJpYnV0b3IoIkRhbmllbCBTaWV2ZXJzIiwgInNpZXZl cnNAY2hyb21pdW0ub3JnIiksCkBAIC0xMzUsOCArMTM1LDggQEAgY29udHJpYnV0b3JzX3dob19h cmVfbm90X2NvbW1pdHRlcnMgPSBbCiAgICAgQ29udHJpYnV0b3IoIkdyZWdnIFRhdmFyZXMiLCBb ImdtYW5AZ29vZ2xlLmNvbSIsICJnbWFuQGNocm9taXVtLm9yZyJdLCAiZ21hbiIpLAogICAgIENv bnRyaWJ1dG9yKCJIYW8gWmhlbmciLCAiemhlbmdoYW9AY2hyb21pdW0ub3JnIiksCiAgICAgQ29u dHJpYnV0b3IoIklhbiBIaWNrc29uIiwgImlhbkBoaXhpZS5jaCIsICJoaXhpZSIpLAotICAgIENv bnRyaWJ1dG9yKCJKYW5vcyBCYWRpY3MiLCAiamJhZGljc0BpbmYudS1zemVnZWQuaHUiLCAnZGlj c2thJyksCi0gICAgQ29udHJpYnV0b3IoIkpvbmF0aGFuIEJhY2tlciIsICJiYWNrZXJAY2hyb21p dW0ub3JnIiwgJ2JhY2tlcicpLAorICAgIENvbnRyaWJ1dG9yKCJKYW5vcyBCYWRpY3MiLCAiamJh ZGljc0BpbmYudS1zemVnZWQuaHUiLCAiZGljc2thIiksCisgICAgQ29udHJpYnV0b3IoIkpvbmF0 aGFuIEJhY2tlciIsICJiYWNrZXJAY2hyb21pdW0ub3JnIiwgImJhY2tlciIpLAogICAgIENvbnRy aWJ1dG9yKCJKZWZmIFRpbWFudXMiLCBbInR3aXpAY2hyb21pdW0ub3JnIiwgInR3aXpAZ29vZ2xl LmNvbSJdLCAidHdpeiIpLAogICAgIENvbnRyaWJ1dG9yKCJKaW5nIFpoYW8iLCAiamluZ3poYW9A Y2hyb21pdW0ub3JnIiksCiAgICAgQ29udHJpYnV0b3IoIkpvaG4gQmF0ZXMiLCBbImpiYXRlc0Bn b29nbGUuY29tIiwgImpiYXRlc0BjaHJvbWl1bS5vcmciXSwgImpiYXRlcyIpLApAQCAtMTUwLDcg KzE1MCw3IEBAIGNvbnRyaWJ1dG9yc193aG9fYXJlX25vdF9jb21taXR0ZXJzID0gWwogICAgIENv bnRyaWJ1dG9yKCJPbGl2ZXIgVmFyZ2EiLCBbInZvbGl2ZXJAaW5mLnUtc3plZ2VkLmh1IiwgIlZh cmdhLk9saXZlckBzdHVkLnUtc3plZ2VkLmh1Il0sICJUd2lzdE8iKSwKICAgICBDb250cmlidXRv cigiUGV0ZXIgR2FsIiwgImdhbHBldGVyQGluZi51LXN6ZWdlZC5odSIsICJlbGVjcm8iKSwKICAg ICBDb250cmlidXRvcigiUGV0ZXIgTGluc3MiLCAicGV0ZXIubGluc3NAaHAuY29tIiwgInBsaW5z cyIpLAotICAgIENvbnRyaWJ1dG9yKCJQcmF2aW4gRCIsICJwcmF2aW5kLjJrNEBnbWFpbC5jb20i LCAncHJhdmluZCcpLAorICAgIENvbnRyaWJ1dG9yKCJQcmF2aW4gRCIsICJwcmF2aW5kLjJrNEBn bWFpbC5jb20iLCAicHJhdmluZCIpLAogICAgIENvbnRyaWJ1dG9yKCJSYWRhciBXZWJLaXQgQnVn IEltcG9ydGVyIiwgIndlYmtpdC1idWctaW1wb3J0ZXJAZ3JvdXAuYXBwbGUuY29tIiksCiAgICAg Q29udHJpYnV0b3IoIlJhdWwgSHVkZWEiLCAicmh1ZGVhQGFkb2JlLmNvbSIsICJyaHVkZWEiKSwK ICAgICBDb250cmlidXRvcigiUm9sYW5kIFRha2FjcyIsICJydGFrYWNzQGluZi51LXN6ZWdlZC5o dSIsICJydGFrYWNzIiksCkBAIC0xNzgsNyArMTc4LDcgQEAgY29udHJpYnV0b3JzX3dob19hcmVf bm90X2NvbW1pdHRlcnMgPSBbCiBjb21taXR0ZXJzX3VuYWJsZV90b19yZXZpZXcgPSBbCiAgICAg Q29tbWl0dGVyKCJBYXJvbiBCb29kbWFuIiwgImFhQGNocm9taXVtLm9yZyIsICJhYm9vZG1hbiIp LAogICAgIENvbW1pdHRlcigiQWRhbSBCZXJna3Zpc3QiLCAiYWRhbS5iZXJna3Zpc3RAZXJpY3Nz b24uY29tIiwgImFkYW1iZSIpLAotICAgIENvbW1pdHRlcigiQWRhbSBLYWxsYWkiLCAia2FkYW1A aW5mLnUtc3plZ2VkLmh1IiwgJ2thZGFtJyksCisgICAgQ29tbWl0dGVyKCJBZGFtIEthbGxhaSIs ICJrYWRhbUBpbmYudS1zemVnZWQuaHUiLCAia2FkYW0iKSwKICAgICBDb21taXR0ZXIoIkFkYW0g S2xlaW4iLCAiYWRhbWtAY2hyb21pdW0ub3JnIiwgImFrbGVpbiIpLAogICAgIENvbW1pdHRlcigi QWRhbSBMYW5nbGV5IiwgImFnbEBjaHJvbWl1bS5vcmciLCAiYWdsIiksCiAgICAgQ29tbWl0dGVy KCJBZGVtYXIgZGUgU291emEgUmVpcyBKciIsIFsiYWRlbWFyLnJlaXNAZ21haWwuY29tIiwgImFk ZW1hckB3ZWJraXQub3JnIl0sICJhZGVtYXIiKSwK