98998 2012-10-10 23:56:48 -0700 [WK2] Change the scope of locking in CoreIPC::Connection class. 2012-10-31 03:53:46 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98580 1 bw80.lee bw80.lee andersca laszlo.gombos lucas.de.marchi webkit.review.bot oldest_to_newest 739649 0 bw80.lee 2012-10-10 23:56:48 -0700 locking range in the Connection::enqueueIncomingMessage() function need to be changed to protect lockup. 740556 1 168340 bw80.lee 2012-10-11 20:02:40 -0700 Created attachment 168340 Patch 741807 2 bw80.lee 2012-10-15 00:27:49 -0700 I tested layout test and unit test on EFL, and there was no regressions. 748282 3 laszlo.gombos 2012-10-22 22:37:43 -0700 This looks good to me. It make sense to release the lock immediately after the resource that is protected is no longer modified. Anders, can you take a look ? 748875 4 andersca 2012-10-23 12:58:26 -0700 I think the patch looks OK, but there seems to be a fundamental problem with EFL if you can get a deadlock in this case. 748903 5 laszlo.gombos 2012-10-23 13:25:16 -0700 (In reply to comment #4) > I think the patch looks OK, but there seems to be a fundamental problem with EFL if you can get a deadlock in this case. Thanks. There is indeed a problem with the EFL port. After the enablers in the common code (e.g. like this patch) are landed, the issue with the EFL port will be addressed. 749209 6 andersca 2012-10-23 18:39:11 -0700 > Thanks. > > There is indeed a problem with the EFL port. After the enablers in the common code (e.g. like this patch) are landed, the issue with the EFL port will be addressed. Wouldn't it be better to address the issue first? 749227 7 laszlo.gombos 2012-10-23 19:04:04 -0700 (In reply to comment #6) > > Thanks. > > > > There is indeed a problem with the EFL port. After the enablers in the common code (e.g. like this patch) are landed, the issue with the EFL port will be addressed. > > Wouldn't it be better to address the issue first? It looks to me that the fix for EFL has a dependency on this patch in the shared code. The EFL specific fixes are part of bug 98580. This bug + bug 98580 + bug 98978 resolves the issue for EFL. I figured that this patch is a good place to start the discussion for these serious of patches. 754946 8 171578 bw80.lee 2012-10-30 21:43:54 -0700 Created attachment 171578 Patch 754948 9 bw80.lee 2012-10-30 21:49:35 -0700 (In reply to comment #8) > Created an attachment (id=171578) [details] > Patch Rebased the patch and Modified the change log more clearly. 754955 10 171578 laszlo.gombos 2012-10-30 21:57:16 -0700 Comment on attachment 171578 Patch Last patch looks good to me with the revised ChangeLog. Thanks, r=me. 754956 11 171578 bw80.lee 2012-10-30 22:01:20 -0700 Comment on attachment 171578 Patch Thank you for the review :) 755066 12 171578 webkit.review.bot 2012-10-31 02:10:58 -0700 Comment on attachment 171578 Patch Clearing flags on attachment: 171578 Committed r133001: <http://trac.webkit.org/changeset/133001> 755067 13 webkit.review.bot 2012-10-31 02:11:02 -0700 All reviewed patches have been landed. Closing bug. 168340 2012-10-11 20:02:40 -0700 2012-10-30 21:43:48 -0700 Patch bug-98998-20121012120136.patch text/plain 2834 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYWMyYjM4Y2M0NDhjNmRm N2VlMWVlMzNhOGM3MTM2ZDI5MWY4MTMxZi4uZTBmNDk2NWZkYjhhN2VjZjI0NzliMWJlOWMxMjUx ODQ1NTZkNTI3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEwLTExICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBDaGFuZ2Ug dGhlIHJhbmdlIG9mIGxvY2tpbmcgaW4gQ29yZUlQQzo6Q29ubmVjdGlvbiBjbGFzcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4OTk4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVG8gcHJldmVudCBkZWFk LWxvY2sgcHJvYmxlbSBvbiBFRkwsIHRoZSBzY29wZSBvZiBzb21lIG11dGV4IGxvY2tlcnMgYXJl CisgICAgICAgIGNoYW5nZWQgb25seSB0byBhY2Nlc3MgdGhlIG1lc3NhZ2UgcXVldWUuCisKKyAg ICAgICAgQ3VycmVudGx5LCBUaGUgbXV0ZXggbV9pbmNvbW1pbmdNZXNzYWdlc0xvY2sgYW5kIG1f b3V0Z29pbmdNZXNzYWdlc0xvY2sKKyAgICAgICAgYXJlIHVzZWQgbm90IG9ubHkgZm9yIHRoZSBt ZXNzYWdlIHF1ZXVlcyBidXQgYWxzbyBmb3IgV29ya1F1ZXVlOjpkaXNwYXRjaCgpCisgICAgICAg IG9yIFJ1bkxvb3A6OmRpc3BhdGNoKCkgZnVuY3Rpb24uCisKKyAgICAgICAgT24gRUZMIHBvcnQs IHRob3NlIGRpc3BhdGNoIGZ1bmN0aW9ucyBoYXZlIGNvZGVzIHRvIHdyaXRlIHBpcGUuCisgICAg ICAgIFdoZW4gcGlwZSBidWZmZXIgaXMgZnVsbCwgdXNpbmcgdGhlIG11dGV4IGxvY2tlciBmb3Ig dGhlIGRpc3BhdGNoIGZ1bmN0aW9ucworICAgICAgICBjYW4gbWFrZSBkZWFkLWxvY2sgcHJvYmxl bSBvbiBFRkwuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwOgor ICAgICAgICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6c2VuZE1lc3NhZ2UpOgorICAgICAgICAoQ29y ZUlQQzo6Q29ubmVjdGlvbjo6ZW5xdWV1ZUluY29taW5nTWVzc2FnZSk6CisKIDIwMTItMTAtMTEg IFJlZ2luYSBDaHVuZyAgPGhlZWppbi5yLmNodW5nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtF RkxdW1dLMl0gV2ViUHJvY2VzcyBrZWVwcyBvbiB3YWl0aW5nIGZvciBVSVByb2Nlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCmluZGV4IDAyNjM0 ODc0Y2U2YzJmYjY1ZjdhZWE2NTk4MTc4YTkwNmQyMjJhMGYuLjgzYTViNzk3ZDA0N2U1ZThmMDM0 MDI1OGFkOGU4YTg5NmZhZjFmNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt L0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29y ZUlQQy9Db25uZWN0aW9uLmNwcApAQCAtMzA0LDkgKzMwNCwxMSBAQCBib29sIENvbm5lY3Rpb246 OnNlbmRNZXNzYWdlKE1lc3NhZ2VJRCBtZXNzYWdlSUQsIFBhc3NPd25QdHI8QXJndW1lbnRFbmNv ZGVyPiBhcgogICAgICAgICAgICAgfHwgbV9pbkRpc3BhdGNoTWVzc2FnZU1hcmtlZERpc3BhdGNo V2hlbldhaXRpbmdGb3JTeW5jUmVwbHlDb3VudCkpCiAgICAgICAgIG1lc3NhZ2VJRCA9IG1lc3Nh Z2VJRC5tZXNzYWdlSURXaXRoQWRkZWRGbGFncyhNZXNzYWdlSUQ6OkRpc3BhdGNoTWVzc2FnZVdo ZW5XYWl0aW5nRm9yU3luY1JlcGx5KTsKIAotICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX291dGdv aW5nTWVzc2FnZXNMb2NrKTsKLSAgICBtX291dGdvaW5nTWVzc2FnZXMuYXBwZW5kKE91dGdvaW5n TWVzc2FnZShtZXNzYWdlSUQsIGFyZ3VtZW50cykpOwotICAgIAorICAgIHsKKyAgICAgICAgTXV0 ZXhMb2NrZXIgbG9ja2VyKG1fb3V0Z29pbmdNZXNzYWdlc0xvY2spOworICAgICAgICBtX291dGdv aW5nTWVzc2FnZXMuYXBwZW5kKE91dGdvaW5nTWVzc2FnZShtZXNzYWdlSUQsIGFyZ3VtZW50cykp OworICAgIH0KKwogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgYWRkIGEgYm9vbGVhbiBmbGFnIHNv IHdlIGRvbid0IGNhbGwgdGhpcyB3aGVuIHdvcmsgaGFzIGFscmVhZHkgYmVlbiBzY2hlZHVsZWQu CiAgICAgbV9jb25uZWN0aW9uUXVldWUuZGlzcGF0Y2goV1RGOjpiaW5kKCZDb25uZWN0aW9uOjpz ZW5kT3V0Z29pbmdNZXNzYWdlcywgdGhpcykpOwogICAgIHJldHVybiB0cnVlOwpAQCAtNjQ3LDgg KzY0OSwxMCBAQCB2b2lkIENvbm5lY3Rpb246OmRpZEZhaWxUb1NlbmRTeW5jTWVzc2FnZSgpCiAK IHZvaWQgQ29ubmVjdGlvbjo6ZW5xdWV1ZUluY29taW5nTWVzc2FnZShJbmNvbWluZ01lc3NhZ2Um IGluY29taW5nTWVzc2FnZSkKIHsKLSAgICBNdXRleExvY2tlciBsb2NrZXIobV9pbmNvbWluZ01l c3NhZ2VzTG9jayk7Ci0gICAgbV9pbmNvbWluZ01lc3NhZ2VzLmFwcGVuZChpbmNvbWluZ01lc3Nh Z2UpOworICAgIHsKKyAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1faW5jb21pbmdNZXNzYWdl c0xvY2spOworICAgICAgICBtX2luY29taW5nTWVzc2FnZXMuYXBwZW5kKGluY29taW5nTWVzc2Fn ZSk7CisgICAgfQogCiAgICAgbV9jbGllbnRSdW5Mb29wLT5kaXNwYXRjaChXVEY6OmJpbmQoJkNv bm5lY3Rpb246OmRpc3BhdGNoT25lTWVzc2FnZSwgdGhpcykpOwogfQo= 171578 2012-10-30 21:43:54 -0700 2012-10-31 02:10:58 -0700 Patch bug-98998-20121031134218.patch text/plain 2584 bw80.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyOTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmZhOWUzODQ4N2E3NDFi NTg0ZjVmYzFjY2NlY2JmOTgzODRmMDEyMS4uMGVmMDE5MzVmZDRlZWJlNTE3YmYxNDIwMThlMDk4 NjUwYWM0MTgzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEwLTMwICBCeXVu Z3dvbyBMZWUgIDxidzgwLmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbV0syXSBDaGFuZ2Ug dGhlIHNjb3BlIG9mIGxvY2tpbmcgaW4gQ29yZUlQQzo6Q29ubmVjdGlvbiBjbGFzcy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4OTk4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVsZWFzZSB0aGUgbV9p bmNvbWluZ01lc3NhZ2VzTG9jayBhbmQgbV9vdXRnb2luZ01lc3NhZ2VzTG9jayBtdXRleGVzCisg ICAgICAgIGltbWVkaWF0ZWx5IGFmdGVyIHRoZSBwcm90ZWN0ZWQgcmVzb3VyY2UgaXMgbm8gbG9u Z2VyIG1vZGlmaWVkIHRvCisgICAgICAgIHByZXZlbnQgYSBwb3NzaWJsZSBzb3VyY2Ugb2YgYSBk ZWFkbG9jay4KKworICAgICAgICBUaGUgY2hhbmdlIGFsbG93cyB0aGUgRUZMIHBvcnQgdG8gcHJl dmVudCBhbiBhY3R1YWwgZGVhZC1sb2NrCisgICAgICAgIHNpdHVhdGlvbiB3aXRoIHNvbWUgdXBj b21pbmcgY2hhbmdlcy4KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5j cHA6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjpzZW5kTWVzc2FnZSk6CisgICAgICAg IChDb3JlSVBDOjpDb25uZWN0aW9uOjplbnF1ZXVlSW5jb21pbmdNZXNzYWdlKToKKwogMjAxMi0x MC0zMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtN YWNdIE1ha2UgV2ViS2l0MiBCdWlsZCB3aXRoIE5FVFdPUktfUFJPQ0VTUyBkaXNhYmxlZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKaW5kZXggOTM0 NTgzNDE3ODQxMmRiNjRiY2QyYzk4NTRiM2Q0MDJlNGZmNzc0MC4uNzUxMWM5NDQ5MDljNWZmZmM2 MTA2YWE0ZWFmNzBlOWQwM2YyZGI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZv cm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9D b3JlSVBDL0Nvbm5lY3Rpb24uY3BwCkBAIC0zMDQsOCArMzA0LDEwIEBAIGJvb2wgQ29ubmVjdGlv bjo6c2VuZE1lc3NhZ2UoTWVzc2FnZUlEIG1lc3NhZ2VJRCwgUGFzc093blB0cjxNZXNzYWdlRW5j b2Rlcj4gZW5jCiAgICAgICAgICAgICB8fCBtX2luRGlzcGF0Y2hNZXNzYWdlTWFya2VkRGlzcGF0 Y2hXaGVuV2FpdGluZ0ZvclN5bmNSZXBseUNvdW50KSkKICAgICAgICAgbWVzc2FnZUlEID0gbWVz c2FnZUlELm1lc3NhZ2VJRFdpdGhBZGRlZEZsYWdzKE1lc3NhZ2VJRDo6RGlzcGF0Y2hNZXNzYWdl V2hlbldhaXRpbmdGb3JTeW5jUmVwbHkpOwogCi0gICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fb3V0 Z29pbmdNZXNzYWdlc0xvY2spOwotICAgIG1fb3V0Z29pbmdNZXNzYWdlcy5hcHBlbmQoT3V0Z29p bmdNZXNzYWdlKG1lc3NhZ2VJRCwgZW5jb2RlcikpOworICAgIHsKKyAgICAgICAgTXV0ZXhMb2Nr ZXIgbG9ja2VyKG1fb3V0Z29pbmdNZXNzYWdlc0xvY2spOworICAgICAgICBtX291dGdvaW5nTWVz c2FnZXMuYXBwZW5kKE91dGdvaW5nTWVzc2FnZShtZXNzYWdlSUQsIGVuY29kZXIpKTsKKyAgICB9 CiAgICAgCiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBhZGQgYSBib29sZWFuIGZsYWcgc28gd2Ug ZG9uJ3QgY2FsbCB0aGlzIHdoZW4gd29yayBoYXMgYWxyZWFkeSBiZWVuIHNjaGVkdWxlZC4KICAg ICBtX2Nvbm5lY3Rpb25RdWV1ZS5kaXNwYXRjaChXVEY6OmJpbmQoJkNvbm5lY3Rpb246OnNlbmRP dXRnb2luZ01lc3NhZ2VzLCB0aGlzKSk7CkBAIC02NDgsOCArNjUwLDEwIEBAIHZvaWQgQ29ubmVj dGlvbjo6ZGlkRmFpbFRvU2VuZFN5bmNNZXNzYWdlKCkKIAogdm9pZCBDb25uZWN0aW9uOjplbnF1 ZXVlSW5jb21pbmdNZXNzYWdlKEluY29taW5nTWVzc2FnZSYgaW5jb21pbmdNZXNzYWdlKQogewot ICAgIE11dGV4TG9ja2VyIGxvY2tlcihtX2luY29taW5nTWVzc2FnZXNMb2NrKTsKLSAgICBtX2lu Y29taW5nTWVzc2FnZXMuYXBwZW5kKGluY29taW5nTWVzc2FnZSk7CisgICAgeworICAgICAgICBN dXRleExvY2tlciBsb2NrZXIobV9pbmNvbWluZ01lc3NhZ2VzTG9jayk7CisgICAgICAgIG1faW5j b21pbmdNZXNzYWdlcy5hcHBlbmQoaW5jb21pbmdNZXNzYWdlKTsKKyAgICB9CiAKICAgICBtX2Ns aWVudFJ1bkxvb3AtPmRpc3BhdGNoKFdURjo6YmluZCgmQ29ubmVjdGlvbjo6ZGlzcGF0Y2hPbmVN ZXNzYWdlLCB0aGlzKSk7CiB9Cg==