98993 2012-10-10 22:19:55 -0700 WebCore::RenderBlock::determineStartPosition crash 2012-11-25 23:46:29 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikelawther webkit-unassigned cabanier eric mitz tasak webkit.review.bot oldest_to_newest 739618 0 mikelawther 2012-10-10 22:19:55 -0700 As reported in http://crbug.com/123440. Repro: ----- <body style="position:absolute;"> <foo style="white-space:pre-wrap;"> <ul style="zoom:1866;"></ul> <sup> <foo id="root"> a<foo style="position:fixed;"></foo><foo><label id="node"> a</label> </foo> </foo></sup></foo> </body> <script type="text/javascript"> document.body.offsetTop; root.appendChild(node); </script> ----- Crashes with NULL deref at: 0012ec24 030380b5 chrome_1c30000!WebCore::RenderBlock::determineStartPosition(class WebCore::LineLayoutState * layoutState = 0x0012ed88, class WebCore::BidiResolver<WebCore::InlineIterator,WebCore::BidiRun> * resolver = 0x0012ec68)+0x18b [c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\rendering\renderblocklinelayout.cpp @ 1632] 0012ed6c 0303869c chrome_1c30000!WebCore::RenderBlock::layoutRunsAndFloats(class WebCore::LineLayoutState * layoutState = 0x0012ed88, bool hasInlineChild = true)+0x35 [c:\b\build\slave\win\build\src\third_party\webkit\source\webcore\rendering\renderblocklinelayout.cpp @ 1162] [....] 740212 1 ap 2012-10-11 13:28:47 -0700 Affects Safari 6.0.1 and ToT. 742985 2 168896 tasak 2012-10-16 02:15:02 -0700 Created attachment 168896 Patch 743152 3 168896 mitz 2012-10-16 08:10:29 -0700 Comment on attachment 168896 Patch Shouldn't removing the line break object in the scenario you're describing dirty the line? Can you simplify the test? It is not clear which style properties are significant to the bug and whether the node has to be moved or merely removed. 743823 4 169080 tasak 2012-10-16 20:27:29 -0700 Created attachment 169080 Patch 743826 5 tasak 2012-10-16 20:57:02 -0700 (In reply to comment #3) Thank you for reviewing. I updated the condition, because the comment says: // The previous line didn't break cleanly or broke at a newline // that has been deleted, so treat it as dirty too. I think, this would match the case:"The previous line broke at a newline that has been deleted." > (From update of attachment 168896 [details]) > Shouldn't removing the line break object in the scenario you're describing dirty the line? Removing the line break object is caused by Node::detach(). So, I think, it is a little difficult to avoid removing, because render objects related to the line break might be destroyed. #0 WebCore::RootInlineBox::childRemoved (this=0x7fffeaa96a98, box=0x7fffea924b58) #1 0x0000000001ea359c in WebCore::InlineFlowBox::removeChild (this=0x7fffea924a38, child=0x7fffea924b58) #2 0x0000000001ea0b73 in WebCore::InlineBox::remove (this=0x7fffea924b58) #3 0x0000000001f8c85d in WebCore::RenderInline::willBeDestroyed (this=0x7fffea8fdeb8) #4 0x0000000001ffce75 in WebCore::RenderObject::destroy (this=0x7fffea8fdeb8) #5 0x0000000001ffcd7d in WebCore::RenderObject::destroyAndCleanupAnonymousWrappers (this=0x7fffea8fdeb8) #6 0x00000000010acaa2 in WebCore::Node::detach (this=0x7fffeaa05200) > Can you simplify the test? It is not clear which style properties are significant to the bug and whether the node has to be moved or merely removed. I see. I updated the test. Best regards, Takashi Sakamoto 775183 6 169080 bfulgham 2012-11-25 23:38:12 -0800 Comment on attachment 169080 Patch Looks good. R=me. 775189 7 169080 webkit.review.bot 2012-11-25 23:46:25 -0800 Comment on attachment 169080 Patch Clearing flags on attachment: 169080 Committed r135684: <http://trac.webkit.org/changeset/135684> 775190 8 webkit.review.bot 2012-11-25 23:46:29 -0800 All reviewed patches have been landed. Closing bug. 168896 2012-10-16 02:15:02 -0700 2012-10-16 20:27:24 -0700 Patch bug-98993-20121016181351.patch text/plain 4810 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxMzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQ0MTNmNjAzMDI5NjVj NDNhNTUwNjRiMmYwYmEwMmE5ZjU4YzRhYi4uZTIzYWJhYzI1YjBjODVkOWViODk5NjVmMjFkYWRk MjViMjhlMjQ2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTEwLTE2ICBUYWth c2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpSZW5k ZXJCbG9jazo6ZGV0ZXJtaW5lU3RhcnRQb3NpdGlvbiBjcmFzaAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg5OTMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB3ZSBtb3ZlIHNvbWUgbm9kZSBhbmQgdGhl IG5vZGUgaGFzIHNvbWUgdGV4dCwKKyAgICAgICAgSW5saW5lRmxvd0JveDo6cmVtb3ZlQ2hpbGQo KSBpcyBpbnZva2VkLiBUaGUgbWV0aG9kIGludm9rZXMKKyAgICAgICAgUm9vdElubGluZUJveDo6 Y2hpbGRSZW1vdmVkKCkuIGNoaWxkUmVtb3ZlZCgpIGNoZWNrcyB3aGV0aGVyIHRoZQorICAgICAg ICByZW1vdmVkIGlubGluZWJveCBoYXMgdGhlIHJlbmRlcmVyIG9mIGl0cyBwYXJlbnQncyBsaW5l IGJyZWFrIG9iamVjdC4KKyAgICAgICAgSWYgc28sIHVzZSBzZXRMaW5lQnJlYWtJbmZvIHRvIG1h a2UgdGhlIHBhcmVudCdzIGxpbmUgYnJlYWsgaW5mbyB0bworICAgICAgICBiZSAwLiBIb3dldmVy IGluIFJlbmRlckJsb2NrOjpkZXRlcm1pbmVTdGFydFBvc2l0aW9uKCksIHRoZSBjb2RlCisgICAg ICAgIGFzc3VtZSB0aGF0IGFsbCBsaW5lIGJyZWFrIGluZm8gaXMgc29sdmVkLCBpLmUuCisgICAg ICAgIHByZXZSb290Qm94LT5saW5lQnJlYWtPYmooKS0+aXNUZXh0KCkuIFNpbmNlIGxpbmVCcmVh a09iaigpIHJldHVybnMgMAorICAgICAgICBiZWNhdXNlIG9mIHJlbW92ZUNoaWxkKCksIGRldGVy bWluZVN0YXJ0UG9zaXRpb24gY3Jhc2ggb2NjdXJzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvaW5s aW5lL2lubGluZS1ib3gtYXBwZW5kLWNoaWxkLWNyYXNoLmh0bWwKKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy QmxvY2s6OmRldGVybWluZVN0YXJ0UG9zaXRpb24pOgorICAgICAgICBDaGVja3Mgd2hldGhlciBs aW5lQnJlYWtPYmooKSBpcyAwIG9yIG5vdCBiZWZvcmUgdXNpbmcgbGluZUJyZWFrT2JqKCkuCisK IDIwMTItMTAtMTUgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtXZWJTb2NrZXRdIFdlYlNvY2tldEluZmxhdGVyIHNob3VsZCBoYW5kbGUgQkZJTkFM ID0gMSBibG9ja3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9ja0xpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr TGluZUxheW91dC5jcHAKaW5kZXggMjFmZDU1MmY3ODBjM2IyNDI2ZWMwNDIwNmE5ZWVjOWExMTJj YzAwZC4uNzdiMWRlM2ExMmM5OTVkNGE3YjhiNWQ0NjhmMDZlMWE0YjkyNjZlMyAxMDA3NTUKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAg LTE4MTgsNyArMTgxOCw3IEBAIFJvb3RJbmxpbmVCb3gqIFJlbmRlckJsb2NrOjpkZXRlcm1pbmVT dGFydFBvc2l0aW9uKExpbmVMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhdGUsCiAgICAgICAgICAgICAv LyBXZSBoYXZlIGEgZGlydHkgbGluZS4KICAgICAgICAgICAgIGlmIChSb290SW5saW5lQm94KiBw cmV2Um9vdEJveCA9IGN1cnItPnByZXZSb290Qm94KCkpIHsKICAgICAgICAgICAgICAgICAvLyBX ZSBoYXZlIGEgcHJldmlvdXMgbGluZS4KLSAgICAgICAgICAgICAgICBpZiAoIWRpcnRpZWRCeUZs b2F0ICYmICghcHJldlJvb3RCb3gtPmVuZHNXaXRoQnJlYWsoKSB8fCAocHJldlJvb3RCb3gtPmxp bmVCcmVha09iaigpLT5pc1RleHQoKSAmJiBwcmV2Um9vdEJveC0+bGluZUJyZWFrUG9zKCkgPj0g dG9SZW5kZXJUZXh0KHByZXZSb290Qm94LT5saW5lQnJlYWtPYmooKSktPnRleHRMZW5ndGgoKSkp KQorICAgICAgICAgICAgICAgIGlmICghZGlydGllZEJ5RmxvYXQgJiYgKCFwcmV2Um9vdEJveC0+ ZW5kc1dpdGhCcmVhaygpIHx8IChwcmV2Um9vdEJveC0+bGluZUJyZWFrT2JqKCkgJiYgcHJldlJv b3RCb3gtPmxpbmVCcmVha09iaigpLT5pc1RleHQoKSAmJiBwcmV2Um9vdEJveC0+bGluZUJyZWFr UG9zKCkgPj0gdG9SZW5kZXJUZXh0KHByZXZSb290Qm94LT5saW5lQnJlYWtPYmooKSktPnRleHRM ZW5ndGgoKSkpKQogICAgICAgICAgICAgICAgICAgICAvLyBUaGUgcHJldmlvdXMgbGluZSBkaWRu J3QgYnJlYWsgY2xlYW5seSBvciBicm9rZSBhdCBhIG5ld2xpbmUKICAgICAgICAgICAgICAgICAg ICAgLy8gdGhhdCBoYXMgYmVlbiBkZWxldGVkLCBzbyB0cmVhdCBpdCBhcyBkaXJ0eSB0b28uCiAg ICAgICAgICAgICAgICAgICAgIGN1cnIgPSBwcmV2Um9vdEJveDsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYzU4MGUzZjY1 MzkxZjUzMTY0NWE3ZGQ3ODEyNDk2MWRlYTYxNzZkLi5lMWE1MjQ4MGJiZTIxNmJkYjMxZGQzYTRi YmNmMGNkYjYwNzBiMzE2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTAtMTYgIFRha2Fz aGkgU2FrYW1vdG8gIDx0YXNha0Bnb29nbGUuY29tPgorCisgICAgICAgIFdlYkNvcmU6OlJlbmRl ckJsb2NrOjpkZXRlcm1pbmVTdGFydFBvc2l0aW9uIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODk5MworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9pbmxpbmUvaW5saW5lLWJveC1hcHBl bmQtY2hpbGQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2lubGlu ZS9pbmxpbmUtYm94LWFwcGVuZC1jaGlsZC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMi0xMC0x NSAgS2VuaWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1dl YlNvY2tldF0gV2ViU29ja2V0SW5mbGF0ZXIgc2hvdWxkIGhhbmRsZSBCRklOQUwgPSAxIGJsb2Nr cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5lLWJveC1hcHBlbmQt Y2hpbGQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5l LWJveC1hcHBlbmQtY2hpbGQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdlZjIyZTlh NDMxYWQwMjcyNzEzYjcxZmRjODc5NDAxNmM4ZWYxMmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtYm94LWFwcGVuZC1jaGlsZC1jcmFzaC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9p bmxpbmUvaW5saW5lLWJveC1hcHBlbmQtY2hpbGQtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zh c3QvaW5saW5lL2lubGluZS1ib3gtYXBwZW5kLWNoaWxkLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u N2NlNDM2MDc0ODVlNmU5MDMzMGJiZDUyMmJkZWE2NTJmMGE3MmFhMwotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lubGluZS1ib3gtYXBwZW5kLWNoaWxkLWNyYXNo Lmh0bWwKQEAgLTAsMCArMSwyNCBAQAorPGh0bWw+Cis8Ym9keSBzdHlsZT0icG9zaXRpb246YWJz b2x1dGU7Ij4KKyAgPCEtLSBbYnVnIDkzOTkzXSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTg5OTMgLS0+CisgIDwhLS0gV2ViQ29yZTo6UmVuZGVyQmxvY2s6OmRldGVy bWluZVN0YXJ0UG9zaXRpb24gY3Jhc2ggLS0+CisgIDwhLS0gSWYgdGhpcyB0ZXN0IHBhc3Nlcywg bm8gY3Jhc2guIFdlIGNhbiBzZWUgIlBBU1MiLiAtLT4KKyAgPGZvbyBzdHlsZT0id2hpdGUtc3Bh Y2U6cHJlLXdyYXA7Ij4KKyAgICA8dWwgc3R5bGU9Inpvb206MTg2NjsiPjwvdWw+CisgICAgPHN1 cD4KKyAgICAgIDxmb28gaWQ9InJvb3QiPgorCWE8Zm9vIHN0eWxlPSJwb3NpdGlvbjpmaXhlZDsi PjwvZm9vPjxmb28+PGxhYmVsIGlkPSJub2RlIj4KKwkgICAgYTwvbGFiZWw+CisJPC9mb28+Cisg IDwvZm9vPjwvc3VwPjwvZm9vPgorPC9ib2R5PgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgp OworZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7Cityb290LmFwcGVuZENoaWxkKG5vZGUpOworZG9j dW1lbnQuYm9keS5vZmZzZXRUb3A7Citkb2N1bWVudC5ib2R5LmlubmVySFRNTCA9ICdQQVNTJzsK Kzwvc2NyaXB0PgorPC9odG1sPgorCg== 169080 2012-10-16 20:27:29 -0700 2012-11-25 23:46:25 -0800 Patch bug-98993-20121017122617.patch text/plain 4780 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTMxNTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE3ZDEwY2Y1MDk5YzM1 NzIwYmUwYzQwMzI5MzhmODU2NDQ0ZmNiYS4uMDI5YmI0ZDMzYzBhZGIxNjlhNTA4OGNjZGQyOTM2 ZTc1ZjhmMDYwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTEwLTE2ICBUYWth c2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpSZW5k ZXJCbG9jazo6ZGV0ZXJtaW5lU3RhcnRQb3NpdGlvbiBjcmFzaAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg5OTMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB3ZSBtb3ZlIHNvbWUgbm9kZSBhbmQgdGhl IG5vZGUgaGFzIHNvbWUgdGV4dCwKKyAgICAgICAgSW5saW5lRmxvd0JveDo6cmVtb3ZlQ2hpbGQo KSBpcyBpbnZva2VkLiBUaGUgbWV0aG9kIGludm9rZXMKKyAgICAgICAgUm9vdElubGluZUJveDo6 Y2hpbGRSZW1vdmVkKCkuIGNoaWxkUmVtb3ZlZCgpIGNoZWNrcyB3aGV0aGVyIHRoZQorICAgICAg ICByZW1vdmVkIGlubGluZWJveCBoYXMgdGhlIHJlbmRlcmVyIG9mIGl0cyBwYXJlbnQncyBsaW5l IGJyZWFrIG9iamVjdC4KKyAgICAgICAgSWYgc28sIHVzZSBzZXRMaW5lQnJlYWtJbmZvIHRvIG1h a2UgdGhlIHBhcmVudCdzIGxpbmUgYnJlYWsgaW5mbyB0bworICAgICAgICBiZSAwLiBIb3dldmVy IGluIFJlbmRlckJsb2NrOjpkZXRlcm1pbmVTdGFydFBvc2l0aW9uKCksIHRoZSBjb2RlCisgICAg ICAgIGFzc3VtZSB0aGF0IGFsbCBsaW5lIGJyZWFrIGluZm8gaXMgc29sdmVkLCBpLmUuCisgICAg ICAgIHByZXZSb290Qm94LT5saW5lQnJlYWtPYmooKS0+aXNUZXh0KCkuIFNpbmNlIGxpbmVCcmVh a09iaigpIHJldHVybnMgMAorICAgICAgICBiZWNhdXNlIG9mIHJlbW92ZUNoaWxkKCksIGRldGVy bWluZVN0YXJ0UG9zaXRpb24gY3Jhc2ggb2NjdXJzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvaW5s aW5lL2lubGluZS1ib3gtYXBwZW5kLWNoaWxkLWNyYXNoLmh0bWwKKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy QmxvY2s6OmRldGVybWluZVN0YXJ0UG9zaXRpb24pOgorICAgICAgICBDaGVja3Mgd2hldGhlciBs aW5lQnJlYWtPYmooKSBpcyAwIG9yIG5vdCBiZWZvcmUgdXNpbmcgbGluZUJyZWFrT2JqKCkuCisK IDIwMTItMTAtMTYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAg ICAgICBIVE1MU2VsZWN0RWxlbWVudDo6b3B0aW9uU2VsZWN0ZWRCeVVzZXIgY29uZnVzZXMgbGlz dEluZGV4IGFuZCBvcHRpb25JbmRleApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcAppbmRleCAyMWZkNTUyZjc4MGMzYjI0MjZlYzA0MjA2 YTllZWM5YTExMmNjMDBkLi5kOWIyMjI2NWNhZDI5ZDlkNTI4NzE2NTQxOWMxNjBmMDE4ZDdhZmRl IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5 b3V0LmNwcApAQCAtMTgxOCw3ICsxODE4LDcgQEAgUm9vdElubGluZUJveCogUmVuZGVyQmxvY2s6 OmRldGVybWluZVN0YXJ0UG9zaXRpb24oTGluZUxheW91dFN0YXRlJiBsYXlvdXRTdGF0ZSwKICAg ICAgICAgICAgIC8vIFdlIGhhdmUgYSBkaXJ0eSBsaW5lLgogICAgICAgICAgICAgaWYgKFJvb3RJ bmxpbmVCb3gqIHByZXZSb290Qm94ID0gY3Vyci0+cHJldlJvb3RCb3goKSkgewogICAgICAgICAg ICAgICAgIC8vIFdlIGhhdmUgYSBwcmV2aW91cyBsaW5lLgotICAgICAgICAgICAgICAgIGlmICgh ZGlydGllZEJ5RmxvYXQgJiYgKCFwcmV2Um9vdEJveC0+ZW5kc1dpdGhCcmVhaygpIHx8IChwcmV2 Um9vdEJveC0+bGluZUJyZWFrT2JqKCktPmlzVGV4dCgpICYmIHByZXZSb290Qm94LT5saW5lQnJl YWtQb3MoKSA+PSB0b1JlbmRlclRleHQocHJldlJvb3RCb3gtPmxpbmVCcmVha09iaigpKS0+dGV4 dExlbmd0aCgpKSkpCisgICAgICAgICAgICAgICAgaWYgKCFkaXJ0aWVkQnlGbG9hdCAmJiAoIXBy ZXZSb290Qm94LT5lbmRzV2l0aEJyZWFrKCkgfHwgIXByZXZSb290Qm94LT5saW5lQnJlYWtPYmoo KSB8fCAocHJldlJvb3RCb3gtPmxpbmVCcmVha09iaigpLT5pc1RleHQoKSAmJiBwcmV2Um9vdEJv eC0+bGluZUJyZWFrUG9zKCkgPj0gdG9SZW5kZXJUZXh0KHByZXZSb290Qm94LT5saW5lQnJlYWtP YmooKSktPnRleHRMZW5ndGgoKSkpKQogICAgICAgICAgICAgICAgICAgICAvLyBUaGUgcHJldmlv dXMgbGluZSBkaWRuJ3QgYnJlYWsgY2xlYW5seSBvciBicm9rZSBhdCBhIG5ld2xpbmUKICAgICAg ICAgICAgICAgICAgICAgLy8gdGhhdCBoYXMgYmVlbiBkZWxldGVkLCBzbyB0cmVhdCBpdCBhcyBk aXJ0eSB0b28uCiAgICAgICAgICAgICAgICAgICAgIGN1cnIgPSBwcmV2Um9vdEJveDsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA1MDA3NWFmNDg3NzIxYTczNmYzNWI4ZjRjNDY1ZDQ2NmY1ZmY0NmRmLi43MzhjYzZmZjY1Mzhm ZTc5YzkxYjEyNjdhZDk0ZDY2ZGM2MWI1MzBlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTIt MTAtMTYgIFRha2FzaGkgU2FrYW1vdG8gIDx0YXNha0Bnb29nbGUuY29tPgorCisgICAgICAgIFdl YkNvcmU6OlJlbmRlckJsb2NrOjpkZXRlcm1pbmVTdGFydFBvc2l0aW9uIGNyYXNoCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODk5MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9pbmxpbmUvaW5s aW5lLWJveC1hcHBlbmQtY2hpbGQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2lubGluZS9pbmxpbmUtYm94LWFwcGVuZC1jaGlsZC1jcmFzaC5odG1sOiBBZGRlZC4K KwogMjAxMi0xMC0xNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAg ICAgICAgIEhUTUxTZWxlY3RFbGVtZW50OjpvcHRpb25TZWxlY3RlZEJ5VXNlciBjb25mdXNlcyBs aXN0SW5kZXggYW5kIG9wdGlvbkluZGV4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2lu bGluZS9pbmxpbmUtYm94LWFwcGVuZC1jaGlsZC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtYm94LWFwcGVuZC1jaGlsZC1jcmFzaC1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uN2VmMjJlOWE0MzFhZDAyNzI3MTNiNzFmZGM4Nzk0MDE2YzhlZjEyZgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lubGluZS1ib3gtYXBw ZW5kLWNoaWxkLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtYm94LWFwcGVuZC1jaGlsZC1jcmFz aC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5lLWJveC1hcHBlbmQtY2hpbGQt Y3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hMzE2YjM2NzBkYWVjZWI5OTk0Y2M4OTY3ZGE4MmI4YmQ1 MWU0NmNlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5l LWJveC1hcHBlbmQtY2hpbGQtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI1IEBACis8aHRtbD4KKzxi b2R5PgorICA8IS0tIFtidWcgOTM5OTNdIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05ODk5MyAtLT4KKyAgPCEtLSBXZWJDb3JlOjpSZW5kZXJCbG9jazo6ZGV0ZXJtaW5l U3RhcnRQb3NpdGlvbiBjcmFzaCAtLT4KKyAgPCEtLSBJZiB0aGlzIHRlc3QgcGFzc2VzLCBubyBj cmFzaC4gV2UgY2FuIHNlZSAiUEFTUyIuIC0tPgorICA8Zm9vIHN0eWxlPSJ3aGl0ZS1zcGFjZTpw cmUtd3JhcDsiPgorICAgIDxzdXA+CisgICAgICA8Zm9vIGlkPSJyb290Ij4KKwlhPGZvbyBzdHls ZT0icG9zaXRpb246Zml4ZWQ7Ij48L2Zvbz48Zm9vPjxsYWJlbCBpZD0ibm9kZSI+CisJICAgIGE8 L2xhYmVsPgorCTwvZm9vPgorICA8L2Zvbz4KKyAgPC9zdXA+CisgIDwvZm9vPgorPC9ib2R5Pgor PHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQor ICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7City b290LmFwcGVuZENoaWxkKG5vZGUpOworZG9jdW1lbnQuYm9keS5vZmZzZXRUb3A7Citkb2N1bWVu dC5ib2R5LmlubmVySFRNTCA9ICdQQVNTJzsKKzwvc2NyaXB0PgorPC9odG1sPgorCg==