98983 2012-10-10 20:28:18 -0700 [Chromium] Calendar picker: should use consistent Localizer object 2012-10-10 21:44:52 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent haraken morrita webkit.review.bot oldest_to_newest 739552 0 tkent 2012-10-10 20:28:18 -0700 Calendar picker: should use consistent Localizer object In WebKit/chromium/src/DateTimeChooserImpl.cpp, we use two Localizer objects, one if m_localizer and another is 'localizer' local object in writeDocument. We should use single Localizer object. 739554 1 168133 tkent 2012-10-10 20:33:11 -0700 Created attachment 168133 Patch 739560 2 168133 haraken 2012-10-10 20:37:50 -0700 Comment on attachment 168133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168133&action=review Looks reasonable > Source/WebKit/chromium/ChangeLog:15 > + environment; e.g. Month labels in a calendar picker were numeric. This > + patch fixes it, and this is covered by > + fast/forms/date/calendar-picker-appearance.html. No change in the test result? Or you might want to add a new test that covers this change. 739565 3 168133 tkent 2012-10-10 20:41:15 -0700 Comment on attachment 168133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168133&action=review >> Source/WebKit/chromium/ChangeLog:15 >> + fast/forms/date/calendar-picker-appearance.html. > > No change in the test result? Or you might want to add a new test that covers this change. The test is already marked as failure in TestExpectations. I won't add image results to this patch because I don't have handy Linux (ICU) environment. 739567 4 168133 haraken 2012-10-10 20:41:47 -0700 Comment on attachment 168133 Patch Makes sense. 739568 5 tkent 2012-10-10 20:42:20 -0700 FYI. See Linux results: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=calendar-picker-appearance.html 739598 6 168133 webkit.review.bot 2012-10-10 21:44:48 -0700 Comment on attachment 168133 Patch Clearing flags on attachment: 168133 Committed r131011: <http://trac.webkit.org/changeset/131011> 739599 7 webkit.review.bot 2012-10-10 21:44:52 -0700 All reviewed patches have been landed. Closing bug. 168133 2012-10-10 20:33:11 -0700 2012-10-10 21:44:48 -0700 Patch bug-98983-20121011123209.patch text/plain 3383 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwOTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDMyZWEwNjgyOWI4NmQ4NjFmN2MzM2JkODI5MTAyMjUzODUxMzRiNTUuLjE5NDFhYWQ5YTgzMzM4 NGEwOGQ1MDg5M2EyYzhlMDliNjZhNDUxYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTItMTAtMTAgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gQ2FsZW5kYXIgcGlja2VyOiBzaG91bGQgdXNlIGNv bnNpc3RlbnQgTG9jYWxpemVyIG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTg5ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9EYXRlVGltZUNo b29zZXJJbXBsLmNwcCwgd2UgdXNlZCB0d28KKyAgICAgICAgTG9jYWxpemVyIG9iamVjdHMsIG9u ZSB3YXMgbV9sb2NhbGl6ZXIgYW5kIGFub3RoZXIgd2FzICdsb2NhbGl6ZXInIGxvY2FsCisgICAg ICAgIG9iamVjdCBpbiB3cml0ZURvY3VtZW50LiBXZSBzaG91bGQgdXNlIHNpbmdsZSBMb2NhbGl6 ZXIgb2JqZWN0LgorCisgICAgICAgIEFsc28sIExvY2FsaXplcjo6Y3JlYXRlKG51bGxBdG9tKSBo YWQgdW5leHBlY3RlZCBiZWhhdmlvcnMgaW4gSUNVCisgICAgICAgIGVudmlyb25tZW50OyBlLmcu IE1vbnRoIGxhYmVscyBpbiBhIGNhbGVuZGFyIHBpY2tlciB3ZXJlIG51bWVyaWMuIFRoaXMKKyAg ICAgICAgcGF0Y2ggZml4ZXMgaXQsIGFuZCB0aGlzIGlzIGNvdmVyZWQgYnkKKyAgICAgICAgZmFz dC9mb3Jtcy9kYXRlL2NhbGVuZGFyLXBpY2tlci1hcHBlYXJhbmNlLmh0bWwuCisKKyAgICAgICAg KiBzcmMvRGF0ZVRpbWVDaG9vc2VySW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRhdGVUaW1l Q2hvb3NlckltcGw6OndyaXRlRG9jdW1lbnQpOgorICAgICAgICBVc2UgbV9sb2NhbGl6ZXIuCisK IDIwMTItMTAtMTAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQuICBSb2xsZWQgREVQUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0RhdGVUaW1lQ2hvb3NlckltcGwuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvRGF0ZVRpbWVDaG9vc2VySW1wbC5jcHAKaW5kZXggMWE1YjdhMjlhNWQ0 NTA1NmIyNzVmYmQ1ZTM2YzMwZTQwMGNlYjVjZS4uZTY5MTYwZDY4NTAxNTA1OTQ0OWMzNTIwYjg1 NGIzMjViZDFlNjA4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRGF0 ZVRpbWVDaG9vc2VySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRGF0 ZVRpbWVDaG9vc2VySW1wbC5jcHAKQEAgLTkwLDcgKzkwLDYgQEAgdm9pZCBEYXRlVGltZUNob29z ZXJJbXBsOjp3cml0ZURvY3VtZW50KFdlYkNvcmU6OkRvY3VtZW50V3JpdGVyJiB3cml0ZXIpCiAg ICAgU3RyaW5nIG1heFN0cmluZyA9IGRhdGUudG9TdHJpbmcoKTsKICAgICBTdHJpbmcgc3RlcFN0 cmluZyA9IFN0cmluZzo6bnVtYmVyKG1fcGFyYW1ldGVycy5zdGVwKTsKICAgICBTdHJpbmcgc3Rl cEJhc2VTdHJpbmcgPSBTdHJpbmc6Om51bWJlcihtX3BhcmFtZXRlcnMuc3RlcEJhc2UsIDExLCBX VEY6OlRydW5jYXRlVHJhaWxpbmdaZXJvcyk7Ci0gICAgT3duUHRyPExvY2FsaXplcj4gbG9jYWxp emVyID0gTG9jYWxpemVyOjpjcmVhdGUobnVsbEF0b20pOwogICAgIEludFJlY3QgYW5jaG9yUmVj dEluU2NyZWVuID0gbV9jaHJvbWVDbGllbnQtPnJvb3RWaWV3VG9TY3JlZW4obV9wYXJhbWV0ZXJz LmFuY2hvclJlY3RJblJvb3RWaWV3KTsKICAgICBGcmFtZVZpZXcqIHZpZXcgPSBzdGF0aWNfY2Fz dDxXZWJWaWV3SW1wbCo+KG1fY2hyb21lQ2xpZW50LT53ZWJWaWV3KCkpLT5wYWdlKCktPm1haW5G cmFtZSgpLT52aWV3KCk7CiAgICAgSW50UmVjdCByb290Vmlld1Zpc2libGVDb250ZW50UmVjdCA9 IHZpZXctPnZpc2libGVDb250ZW50UmVjdCh0cnVlIC8qIGluY2x1ZGUgc2Nyb2xsYmFycyAqLyk7 CkBAIC0xMjEsMTAgKzEyMCwxMCBAQCB2b2lkIERhdGVUaW1lQ2hvb3NlckltcGw6OndyaXRlRG9j dW1lbnQoV2ViQ29yZTo6RG9jdW1lbnRXcml0ZXImIHdyaXRlcikKICAgICBhZGRQcm9wZXJ0eSgi bG9jYWxlIiwgV2ViQ29yZTo6ZGVmYXVsdExhbmd1YWdlKCksIHdyaXRlcik7CiAgICAgYWRkUHJv cGVydHkoInRvZGF5TGFiZWwiLCBQbGF0Zm9ybTo6Y3VycmVudCgpLT5xdWVyeUxvY2FsaXplZFN0 cmluZyhXZWJMb2NhbGl6ZWRTdHJpbmc6OkNhbGVuZGFyVG9kYXkpLCB3cml0ZXIpOwogICAgIGFk ZFByb3BlcnR5KCJjbGVhckxhYmVsIiwgUGxhdGZvcm06OmN1cnJlbnQoKS0+cXVlcnlMb2NhbGl6 ZWRTdHJpbmcoV2ViTG9jYWxpemVkU3RyaW5nOjpDYWxlbmRhckNsZWFyKSwgd3JpdGVyKTsKLSAg ICBhZGRQcm9wZXJ0eSgid2Vla1N0YXJ0RGF5IiwgbG9jYWxpemVyLT5maXJzdERheU9mV2Vlaygp LCB3cml0ZXIpOwotICAgIGFkZFByb3BlcnR5KCJtb250aExhYmVscyIsIGxvY2FsaXplci0+bW9u dGhMYWJlbHMoKSwgd3JpdGVyKTsKLSAgICBhZGRQcm9wZXJ0eSgiZGF5TGFiZWxzIiwgbG9jYWxp emVyLT53ZWVrRGF5U2hvcnRMYWJlbHMoKSwgd3JpdGVyKTsKLSAgICBEaXJlY3Rpb24gZGlyID0g ZGlyZWN0aW9uKGxvY2FsaXplci0+bW9udGhMYWJlbHMoKVswXVswXSk7CisgICAgYWRkUHJvcGVy dHkoIndlZWtTdGFydERheSIsIG1fbG9jYWxpemVyLT5maXJzdERheU9mV2VlaygpLCB3cml0ZXIp OworICAgIGFkZFByb3BlcnR5KCJtb250aExhYmVscyIsIG1fbG9jYWxpemVyLT5tb250aExhYmVs cygpLCB3cml0ZXIpOworICAgIGFkZFByb3BlcnR5KCJkYXlMYWJlbHMiLCBtX2xvY2FsaXplci0+ d2Vla0RheVNob3J0TGFiZWxzKCksIHdyaXRlcik7CisgICAgRGlyZWN0aW9uIGRpciA9IGRpcmVj dGlvbihtX2xvY2FsaXplci0+bW9udGhMYWJlbHMoKVswXVswXSk7CiAgICAgYWRkUHJvcGVydHko ImlzQ2FsZW5kYXJSVEwiLCBkaXIgPT0gUmlnaHRUb0xlZnQgfHwgZGlyID09IFJpZ2h0VG9MZWZ0 QXJhYmljLCB3cml0ZXIpOwogICAgIGFkZFByb3BlcnR5KCJpc1JUTCIsIG1fcGFyYW1ldGVycy5p c0FuY2hvckVsZW1lbnRSVEwsIHdyaXRlcik7CiAgICAgaWYgKG1fcGFyYW1ldGVycy5zdWdnZXN0 aW9uVmFsdWVzLnNpemUoKSkgewo=