98969 2012-10-10 16:53:38 -0700 [texmap] logic error in BitmapTextureGL::updateContents 2012-10-11 10:28:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 a.renevier a.renevier jturcotte noam webkit.review.bot oldest_to_newest 739403 0 a.renevier 2012-10-10 16:53:38 -0700 Hi, in bug #91897, if (bytesPerLine == targetRect.width() * bytesPerPixel has been replaced by if (bytesPerLine == targetRect.width() / 4 (multiplication => division) So, the "fast path" is never used anymore 739408 1 168098 a.renevier 2012-10-10 17:00:01 -0700 Created attachment 168098 Patch patch proposal 739409 2 webkit.review.bot 2012-10-10 17:02:03 -0700 Attachment 168098 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 739415 3 168101 a.renevier 2012-10-10 17:04:29 -0700 Created attachment 168101 Patch amended patch 739610 4 168101 webkit.review.bot 2012-10-10 21:57:56 -0700 Comment on attachment 168101 Patch Rejecting attachment 168101 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e-webkit line 164. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14257387 740073 5 a.renevier 2012-10-11 09:55:46 -0700 (In reply to comment #4) > (From update of attachment 168101 [details]) > Rejecting attachment 168101 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > e-webkit line 164. > > Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 9 > BlackBerry] Fix assertion in NetworkJob::notifyChallengeResult. > > When you have resolved this problem run "git rebase --continue". > If you would prefer to skip this patch, instead run "git rebase --skip". > To restore the original branch and stop rebasing run "git rebase --abort". > > rebase refs/remotes/origin/master: command returned error: 1 > > Died at Tools/Scripts/update-webkit line 164. > > Full output: http://queues.webkit.org/results/14257387 I don't really understand why the patch could not be applied 740102 6 168101 jturcotte 2012-10-11 10:23:19 -0700 Comment on attachment 168101 Patch Not sure either, the error seems unrelated. Trying again. 740107 7 168101 webkit.review.bot 2012-10-11 10:28:01 -0700 Comment on attachment 168101 Patch Clearing flags on attachment: 168101 Committed r131078: <http://trac.webkit.org/changeset/131078> 740108 8 webkit.review.bot 2012-10-11 10:28:04 -0700 All reviewed patches have been landed. Closing bug. 168098 2012-10-10 17:00:01 -0700 2012-10-10 17:04:26 -0700 Patch bug-98969-20121010165857.patch text/plain 2061 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIwZWRkM2UwYjNlNjQ0 Yzc0ZmYzNTc0NTIxZDM1NzhiNGM4NGZhNi4uMmMxNWY4NDJlYTg5YzgwZGVhMjE0NWZhNWFlYmE2 NWNmMjJmYjg2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTEwLTEwICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW3Rl eG1hcF0gbG9naWMgZXJyb3IgaW4gQml0bWFwVGV4dHVyZUdMOjp1cGRhdGVDb250ZW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg5NjkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNvcnJlY3QgdGVz dCAoYnl0ZXNQZXJMaW5lID09IHRhcmdldFJlY3Qud2lkdGgoKSAvIDQpIG5ldmVyCisJCWV2YWx1 YXRlcyB0byB0cnVlLiBDaGFuZ2UgaXQgdG8gY29ycmVjdCB0ZXN0IAorICAgICAgICAoYnl0ZXNQ ZXJMaW5lID09IHRhcmdldFJlY3Qud2lkdGgoKSAqIDQpCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz IGJlY2F1c2Ugbm8gZnVuY3Rpb25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJpdG1h cFRleHR1cmVHTDo6dXBkYXRlQ29udGVudHMpOgorCisyMDEyLTEwLTEwICBBcm5hdWQgUmVuZXZp ZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAgICAgYWNjZWxlcmF0ZWQg Y29tcG9zaXRpbmcgZG9lcyBub3Qgd29yayB3aXRoIGF0aSBkcml2ZXIKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDcyCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJH TC5jcHAKaW5kZXggOTE2OWJmYjA5YjM2YWUyOGI0ODcxNjVmMTM3MGI4M2M5MjIwYTAzYi4uZTUy ODk0NzNiNWY1MWE2MzAwYmM1MTZhNjM1ZTU5NGY0OGEzOTcwNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJH TC5jcHAKQEAgLTY1MCw3ICs2NTAsNyBAQCB2b2lkIEJpdG1hcFRleHR1cmVHTDo6dXBkYXRlQ29u dGVudHMoY29uc3Qgdm9pZCogZGF0YSwgY29uc3QgSW50UmVjdCYgdGFyZ2V0UmVjdAogICAgIGVs c2UKICAgICAgICAgc3dpenpsZUJHUkFUb1JHQkEocmVpbnRlcnByZXRfY2FzdDx1aW50MzJfdCo+ KGNvbnN0X2Nhc3Q8dm9pZCo+KGRhdGEpKSwgSW50UmVjdChzb3VyY2VPZmZzZXQsIHRhcmdldFJl Y3Quc2l6ZSgpKSwgYnl0ZXNQZXJMaW5lIC8gYnl0ZXNQZXJQaXhlbCk7CiAKLSAgICBpZiAoYnl0 ZXNQZXJMaW5lID09IHRhcmdldFJlY3Qud2lkdGgoKSAvIDQgJiYgc291cmNlT2Zmc2V0ID09IElu dFBvaW50Ojp6ZXJvKCkpIHsKKyAgICBpZiAoYnl0ZXNQZXJMaW5lID09IHRhcmdldFJlY3Qud2lk dGgoKSAqIGJ5dGVzUGVyUGl4ZWwgJiYgc291cmNlT2Zmc2V0ID09IEludFBvaW50Ojp6ZXJvKCkp IHsKICAgICAgICAgbV9jb250ZXh0M0QtPnRleFN1YkltYWdlMkQoR3JhcGhpY3NDb250ZXh0M0Q6 OlRFWFRVUkVfMkQsIDAsIHRhcmdldFJlY3QueCgpLCB0YXJnZXRSZWN0LnkoKSwgdGFyZ2V0UmVj dC53aWR0aCgpLCB0YXJnZXRSZWN0LmhlaWdodCgpLCBnbEZvcm1hdCwgREVGQVVMVF9URVhUVVJF X1BJWEVMX1RSQU5TRkVSX1RZUEUsIChjb25zdCBjaGFyKilkYXRhKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0K 168101 2012-10-10 17:04:29 -0700 2012-10-11 10:28:01 -0700 Patch bug-98969-20121010170325.patch text/plain 2067 a.renevier U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIwZWRkM2UwYjNlNjQ0 Yzc0ZmYzNTc0NTIxZDM1NzhiNGM4NGZhNi4uMGFjM2E2YTQxM2FhMTBkYmE1ZjRlOTY4MmIzMTA2 MjY5YjhiNzQzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTEwLTEwICBBcm5h dWQgUmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CiAKKyAgICAgICAgW3Rl eG1hcF0gbG9naWMgZXJyb3IgaW4gQml0bWFwVGV4dHVyZUdMOjp1cGRhdGVDb250ZW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg5NjkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNvcnJlY3QgdGVz dCAoYnl0ZXNQZXJMaW5lID09IHRhcmdldFJlY3Qud2lkdGgoKSAvIDQpIG5ldmVyCisgICAgICAg IGV2YWx1YXRlcyB0byB0cnVlLiBDaGFuZ2UgaXQgdG8gY29ycmVjdCB0ZXN0IAorICAgICAgICAo Ynl0ZXNQZXJMaW5lID09IHRhcmdldFJlY3Qud2lkdGgoKSAqIDQpCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzIGJlY2F1c2Ugbm8gZnVuY3Rpb25hbCBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkJpdG1hcFRleHR1cmVHTDo6dXBkYXRlQ29udGVudHMpOgorCisyMDEyLTEwLTEwICBBcm5hdWQg UmVuZXZpZXIgIDxhLnJlbmV2aWVyQHNpc2Euc2Ftc3VuZy5jb20+CisKICAgICAgICAgYWNjZWxl cmF0ZWQgY29tcG9zaXRpbmcgZG9lcyBub3Qgd29yayB3aXRoIGF0aSBkcml2ZXIKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk3NDcyCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy R0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJHTC5jcHAKaW5kZXggOTE2OWJmYjA5YjM2YWUyOGI0ODcxNjVmMTM3MGI4M2M5MjIwYTAz Yi4uZTUyODk0NzNiNWY1MWE2MzAwYmM1MTZhNjM1ZTU5NGY0OGEzOTcwNyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN YXBwZXJHTC5jcHAKQEAgLTY1MCw3ICs2NTAsNyBAQCB2b2lkIEJpdG1hcFRleHR1cmVHTDo6dXBk YXRlQ29udGVudHMoY29uc3Qgdm9pZCogZGF0YSwgY29uc3QgSW50UmVjdCYgdGFyZ2V0UmVjdAog ICAgIGVsc2UKICAgICAgICAgc3dpenpsZUJHUkFUb1JHQkEocmVpbnRlcnByZXRfY2FzdDx1aW50 MzJfdCo+KGNvbnN0X2Nhc3Q8dm9pZCo+KGRhdGEpKSwgSW50UmVjdChzb3VyY2VPZmZzZXQsIHRh cmdldFJlY3Quc2l6ZSgpKSwgYnl0ZXNQZXJMaW5lIC8gYnl0ZXNQZXJQaXhlbCk7CiAKLSAgICBp ZiAoYnl0ZXNQZXJMaW5lID09IHRhcmdldFJlY3Qud2lkdGgoKSAvIDQgJiYgc291cmNlT2Zmc2V0 ID09IEludFBvaW50Ojp6ZXJvKCkpIHsKKyAgICBpZiAoYnl0ZXNQZXJMaW5lID09IHRhcmdldFJl Y3Qud2lkdGgoKSAqIGJ5dGVzUGVyUGl4ZWwgJiYgc291cmNlT2Zmc2V0ID09IEludFBvaW50Ojp6 ZXJvKCkpIHsKICAgICAgICAgbV9jb250ZXh0M0QtPnRleFN1YkltYWdlMkQoR3JhcGhpY3NDb250 ZXh0M0Q6OlRFWFRVUkVfMkQsIDAsIHRhcmdldFJlY3QueCgpLCB0YXJnZXRSZWN0LnkoKSwgdGFy Z2V0UmVjdC53aWR0aCgpLCB0YXJnZXRSZWN0LmhlaWdodCgpLCBnbEZvcm1hdCwgREVGQVVMVF9U RVhUVVJFX1BJWEVMX1RSQU5TRkVSX1RZUEUsIChjb25zdCBjaGFyKilkYXRhKTsKICAgICAgICAg cmV0dXJuOwogICAgIH0K