98968 2012-10-10 16:40:54 -0700 REGRESSION: Unable to scroll with trackpad on some websites after r130783 2012-10-10 18:25:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 bdakin bdakin andersca bdakin jamesr simon.fraser thorton tonikitoo webkit.review.bot oldest_to_newest 739392 0 bdakin 2012-10-10 16:40:54 -0700 http://trac.webkit.org/changeset/130783 broke scrolling on some internal Apple websites. The bug also affects bugs.webkit.org for me sometimes. Unfortunately, I do not have a reduced test case because the bug fails to reproduce when you save sites locally. <rdar://problem/12471825> Patch forthcoming. 739402 1 168095 bdakin 2012-10-10 16:53:14 -0700 Created attachment 168095 Patch 739451 2 168095 simon.fraser 2012-10-10 18:00:27 -0700 Comment on attachment 168095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168095&action=review > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:85 > + m_changedProperties = ViewportRect | ContentsSize | NonFastScrollableRegion | WheelEventHandlerCount > + | ShouldUpdateScrollLayerPositionOnMainThread | HorizontalScrollElasticity | VerticalScrollElasticity > + | HasEnabledHorizontalScrollbar | HasEnabledVerticalScrollbar | HorizontalScrollbarMode > + | VerticalScrollbarMode | ScrollOrigin | RequestedScrollPosition; Would be nicer if the enum had an 'All' value that was 0xFF or the OR of all the values. 739467 3 bdakin 2012-10-10 18:25:11 -0700 Thanks Simon! I added an All value. http://trac.webkit.org/changeset/130989 168095 2012-10-10 16:53:14 -0700 2012-10-10 18:00:27 -0700 Patch mypage-fix.txt text/plain 6633 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDk3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBACisyMDEyLTEwLTEwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTg5NjgKKyAgICAgICAgUkVHUkVTU0lPTjogVW5hYmxlIHRvIHNj cm9sbCB3aXRoIHRyYWNrcGFkIG9uIHNvbWUgd2Vic2l0ZXMgYWZ0ZXIgCisgICAgICAgIHIxMzA3 ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IGJ1ZyBzZWVtcyB0byByZXByb2R1Y2UgbW9zdGx5IG9uIHdlYiBwYWdlcyB0aGF0IHJlcXVpcmUg bG9naW4uIAorICAgICAgICBUaGUgcmUtcm91dGluZyBjYXVzZXMgZXh0cmEgY2h1cm4gb2YgdGhl IFJlbmRlckxheWVyQmFja2luZywgYW5kIHdlIAorICAgICAgICBlbmQgdXAgZGVzdHJveWluZyBh bmQgcmUtY3JlYXRpbmcgdGhlIGJhY2tpbmcgYW5kIHRoZXJlZm9yZSB0aGUgCisgICAgICAgIFNj cm9sbGluZ1N0YXRlTm9kZXMsIGFuZCB3aGVuIHRoZSB0aW1pbmcgaXMganVzdCB3cm9uZyB3ZSBn ZXQgaW50byBhIAorICAgICAgICBzdGF0ZSB3aGVyZSB0aGUgU2Nyb2xsaW5nVHJlZSBoYXMgYSBz ZXQgb2YgaW5jb3JyZWN0IGluZm9ybWF0aW9uLiAKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0 aGUgYnVnIGJ5IG1ha2luZyBzdXJlIHRoZSBTY3JvbGxpbmdTdGF0ZU5vZGVzIGtlZXAgCisgICAg ICAgIHRoZSBTY3JvbGxpbmdUcmVlIGluIHN5bmNoIHdpdGggdGhlaXIgcmUtc2V0IGRhdGEuCisK KyAgICAgICAgVGVsbCB0aGUgU2Nyb2xsaW5nU3RhdGVUcmVlIHRoYXQgdGhlIHJvb3QgbGF5ZXIg aGFzIGNoYW5nZWQuCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0 b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmll d1Jvb3RMYXllckRpZENoYW5nZSk6CisKKyAgICAgICAgTmV3IHZpcnR1YWwgZnVuY3Rpb24gd2ls bCBzZXQgZXZlcnkgcHJvcGVydHkgYXMgaGF2aW5nIGNoYW5nZWQuCisgICAgICAgICogcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVOb2RlLmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxp bmdTdGF0ZU5vZGU6OnNldEhhc0NoYW5nZWRQcm9wZXJ0aWVzKToKKyAgICAgICAgKiBwYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdTdGF0ZVNjcm9sbGluZ05vZGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6U2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlOjpzZXRIYXNDaGFuZ2VkUHJvcGVydGllcyk6 CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdT dGF0ZVNjcm9sbGluZ05vZGUuaDoKKworICAgICAgICBXaGVuIHRoZSByb290IGxheWVyIGNoYW5n ZXMsIG1ha2Ugc3VyZSB3ZSB1cGRhdGUgdGhlIFNjcm9sbGluZ1RyZWUgCisgICAgICAgIGFwcHJv cHJpYXRlbHkgYnkgaW5kaWNhdGluZyB0aGF0IGV2ZXJ5IHByb3BlcnR5IGNvdWxkIGhhdmUgY2hh bmdlZC4KKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nU3RhdGVUcmVlOjpyb290TGF5ZXJEaWRDaGFuZ2Up OgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n U3RhdGVUcmVlLmg6CisgICAgICAgIChTY3JvbGxpbmdTdGF0ZVRyZWUpOgorCiAyMDEyLTEwLTEw ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBBY3RpdmF0ZSBw bHVnaW5zIHdoZW4gdXNlciBjbGlja3Mgb24gc25hcHNob3QKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAJKHJl dmlzaW9uIDEzMDc4MykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjUxLDYgKzI1MSw3IEBAIHZvaWQg U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OmZyYW1lVmlld1Jvb3QKICAgICAvLyBJZiB0aGUgcm9vdCBs YXllciBkb2VzIG5vdCBoYXZlIGEgU2Nyb2xsaW5nU3RhdGVOb2RlLCB0aGVuIHdlIHNob3VsZCBj cmVhdGUgb25lLgogICAgIGVuc3VyZVJvb3RTdGF0ZU5vZGVGb3JGcmFtZVZpZXcoZnJhbWVWaWV3 KTsKICAgICBBU1NFUlQobV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnJvb3RTdGF0ZU5vZGUoKSk7Cisg ICAgbV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnJvb3RMYXllckRpZENoYW5nZSgpOwogI2VuZGlmCiAK ICAgICBmcmFtZVZpZXdMYXlvdXRVcGRhdGVkKGZyYW1lVmlldyk7CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaAkocmV2aXNp b24gMTMwNzgzKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3Rh dGVOb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTU2LDYgKzU2LDcgQEAgcHVibGljOgogICAgIHZp cnR1YWwgYm9vbCBoYXNDaGFuZ2VkUHJvcGVydGllcygpIGNvbnN0ID0gMDsKICAgICB2aXJ0dWFs IHVuc2lnbmVkIGNoYW5nZWRQcm9wZXJ0aWVzKCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgdm9p ZCByZXNldENoYW5nZWRQcm9wZXJ0aWVzKCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzZXRIYXND aGFuZ2VkUHJvcGVydGllcygpIHsgc2V0U2Nyb2xsTGF5ZXJEaWRDaGFuZ2UodHJ1ZSk7IH0KIAog ICAgIFBsYXRmb3JtTGF5ZXIqIHBsYXRmb3JtU2Nyb2xsTGF5ZXIoKSBjb25zdDsKICAgICB2b2lk IHNldFNjcm9sbExheWVyKGNvbnN0IEdyYXBoaWNzTGF5ZXIqKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVTY3Jv bGxpbmdOb2RlLmNwcAkocmV2aXNpb24gMTMwNzc3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzcsNiArNzcsMTUgQEAgU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlOjp+U2Nyb2xsaW5n UwogewogfQogCit2b2lkIFNjcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZTo6c2V0SGFzQ2hhbmdl ZFByb3BlcnRpZXMoKQoreworICAgIG1fY2hhbmdlZFByb3BlcnRpZXMgPSBWaWV3cG9ydFJlY3Qg fCBDb250ZW50c1NpemUgfCBOb25GYXN0U2Nyb2xsYWJsZVJlZ2lvbiB8IFdoZWVsRXZlbnRIYW5k bGVyQ291bnQKKyAgICAgICAgfCBTaG91bGRVcGRhdGVTY3JvbGxMYXllclBvc2l0aW9uT25NYWlu VGhyZWFkIHwgSG9yaXpvbnRhbFNjcm9sbEVsYXN0aWNpdHkgfCBWZXJ0aWNhbFNjcm9sbEVsYXN0 aWNpdHkKKyAgICAgICAgfCBIYXNFbmFibGVkSG9yaXpvbnRhbFNjcm9sbGJhciB8IEhhc0VuYWJs ZWRWZXJ0aWNhbFNjcm9sbGJhciB8IEhvcml6b250YWxTY3JvbGxiYXJNb2RlCisgICAgICAgIHwg VmVydGljYWxTY3JvbGxiYXJNb2RlIHwgU2Nyb2xsT3JpZ2luIHwgUmVxdWVzdGVkU2Nyb2xsUG9z aXRpb247CisgICAgU2Nyb2xsaW5nU3RhdGVOb2RlOjpzZXRIYXNDaGFuZ2VkUHJvcGVydGllcygp OworfQorCiBQYXNzT3duUHRyPFNjcm9sbGluZ1N0YXRlTm9kZT4gU2Nyb2xsaW5nU3RhdGVTY3Jv bGxpbmdOb2RlOjpjbG9uZUFuZFJlc2V0Tm9kZSgpCiB7CiAgICAgT3duUHRyPFNjcm9sbGluZ1N0 YXRlU2Nyb2xsaW5nTm9kZT4gY2xvbmUgPSBhZG9wdFB0cihuZXcgU2Nyb2xsaW5nU3RhdGVTY3Jv bGxpbmdOb2RlKHRoaXMpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZS5oCShyZXZpc2lvbiAx MzA3ODMpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVNj cm9sbGluZ05vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNjUsNiArNjUsNyBAQCBwdWJsaWM6CiAg ICAgdmlydHVhbCBib29sIGhhc0NoYW5nZWRQcm9wZXJ0aWVzKCkgY29uc3QgT1ZFUlJJREUgeyBy ZXR1cm4gbV9jaGFuZ2VkUHJvcGVydGllczsgfQogICAgIHZpcnR1YWwgdW5zaWduZWQgY2hhbmdl ZFByb3BlcnRpZXMoKSBjb25zdCBPVkVSUklERSB7IHJldHVybiBtX2NoYW5nZWRQcm9wZXJ0aWVz OyB9CiAgICAgdmlydHVhbCB2b2lkIHJlc2V0Q2hhbmdlZFByb3BlcnRpZXMoKSBPVkVSUklERSB7 IG1fY2hhbmdlZFByb3BlcnRpZXMgPSAwOyB9CisgICAgdmlydHVhbCB2b2lkIHNldEhhc0NoYW5n ZWRQcm9wZXJ0aWVzKCk7CiAKICAgICBjb25zdCBJbnRSZWN0JiB2aWV3cG9ydFJlY3QoKSBjb25z dCB7IHJldHVybiBtX3ZpZXdwb3J0UmVjdDsgfQogICAgIHZvaWQgc2V0Vmlld3BvcnRSZWN0KGNv bnN0IEludFJlY3QmKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9s bGluZ1N0YXRlVHJlZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9zY3Jv bGxpbmcvU2Nyb2xsaW5nU3RhdGVUcmVlLmNwcAkocmV2aXNpb24gMTMwNzgzKQorKysgU291cmNl L1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVUcmVlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjgsNiArNjgsMTYgQEAgdm9pZCBTY3JvbGxpbmdTdGF0ZVRyZWU6OnJlbW92ZU5v ZGUoU2NybwogICAgIG1fcm9vdFN0YXRlTm9kZS0+cmVtb3ZlQ2hpbGQobm9kZSk7CiB9CiAKK3Zv aWQgU2Nyb2xsaW5nU3RhdGVUcmVlOjpyb290TGF5ZXJEaWRDaGFuZ2UoKQoreworICAgIC8vIElm IHRoZSByb290IGxheWVyIGhhcyBjaGFuZ2VkLCB0aGVuIGRlc3Ryb3llZCBhbmQgcmUtY3JlYXRl ZCB0aGUgcm9vdCBzdGF0ZSBub2RlLiBUaGF0IG1lYW5zIHRoYXQgdGhlCisgICAgLy8gY2FjaGVk IHByb3BlcnRpZXMgaW4gU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlIGFyZSBubyBsb25nZXIg cmVmbGVjdGl2ZSBvZiB0aGUgcHJvcGVydGllcyB3ZSBoYXZlCisgICAgLy8gY2FjaGVkIG92ZXIg aW4gdGhlIFNjcm9sbGluZ1RyZWUuIFRvIHJlc29sdmUgdGhpcywgd2Ugd2lsbCBtYXJrIGFsbCBv ZiB0aGUgcHJvcGVydGllcyBhcyBoYXZpbmcgY2hhbmdlZAorICAgIC8vIHNvIHRoYXQgdGhlIFNj cm9sbGluZ1RyZWUgd2lsbCBiZSBpbiBzeW5jaCB3aXRoIHRoZSBzdGF0ZSB0cmVlLgorICAgIHNl dEhhc0NoYW5nZWRQcm9wZXJ0aWVzKHRydWUpOworICAgIHJvb3RTdGF0ZU5vZGUoKS0+c2V0SGFz Q2hhbmdlZFByb3BlcnRpZXMoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5k aWYgLy8gRU5BQkxFKFRIUkVBREVEX1NDUk9MTElORykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlVHJlZS5oCShyZXZpc2lvbiAxMzA3 ODMpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZVRyZWUu aAkod29ya2luZyBjb3B5KQpAQCAtNjIsNiArNjIsOCBAQCBwdWJsaWM6CiAKICAgICB2b2lkIHJl bW92ZU5vZGUoU2Nyb2xsaW5nU3RhdGVOb2RlKik7CiAKKyAgICB2b2lkIHJvb3RMYXllckRpZENo YW5nZSgpOworCiAgICAgdm9pZCBzZXRIYXNDaGFuZ2VkUHJvcGVydGllcyhib29sIGNoYW5nZWRQ cm9wZXJ0aWVzKSB7IG1faGFzQ2hhbmdlZFByb3BlcnRpZXMgPSBjaGFuZ2VkUHJvcGVydGllczsg fQogICAgIGJvb2wgaGFzQ2hhbmdlZFByb3BlcnRpZXMoKSBjb25zdCB7IHJldHVybiBtX2hhc0No YW5nZWRQcm9wZXJ0aWVzOyB9CiAK