98961 2012-10-10 15:47:55 -0700 text-combine doesn’t use third- and quarter-width variants when used with @font-face 2012-10-10 20:21:06 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz cmarcelo eric macpherson menard webkit.review.bot oldest_to_newest 739354 0 mitz 2012-10-10 15:47:55 -0700 <rdar://problem/12472460> When used with a @font-face font, text-combine fails to measure text using the third- and quarter-width variants, and renders with a different font altogether. Patch forthcoming. 739371 1 168085 mitz 2012-10-10 16:13:20 -0700 Created attachment 168085 Patch 739374 2 webkit.review.bot 2012-10-10 16:18:00 -0700 Attachment 168085 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/platform/graphics/FontWidthVariant.h:41: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 739512 3 168085 thorton 2012-10-10 19:09:03 -0700 Comment on attachment 168085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=168085&action=review > LayoutTests/fast/text/text-combine-with-font-face.html:4 > + src: local(HiraMinProN-W3); Is this one of the fonts we ship in the repo? 739516 4 mitz 2012-10-10 19:20:50 -0700 (In reply to comment #3) > (From update of attachment 168085 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168085&action=review > > > LayoutTests/fast/text/text-combine-with-font-face.html:4 > > + src: local(HiraMinProN-W3); > > Is this one of the fonts we ship in the repo? No. local() means that a locally-installed font with that name should be used. OS X comes with that font. Thanks for the review! 739550 5 mitz 2012-10-10 20:21:06 -0700 Fixed in <http://trac.webkit.org/r131005>. 168085 2012-10-10 16:13:20 -0700 2012-10-10 19:09:02 -0700 Patch bug-98961-20121010161219.patch text/plain 6879 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDk3NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEwLTEwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyNDcy NDYwPiB0ZXh0LWNvbWJpbmUgZG9lc27igJl0IHVzZSB0aGlyZC0gYW5kIHF1YXJ0ZXItd2lkdGgg dmFyaWFudHMgd2hlbiB1c2VkIHdpdGggQGZvbnQtZmFjZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvdGV4dC1jb21iaW5lLXdp dGgtZm9udC1mYWNlLmh0bWwKKworICAgICAgICAqIGNzcy9DU1NTZWdtZW50ZWRGb250RmFjZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NTZWdtZW50ZWRGb250RmFjZTo6Z2V0Rm9udERhdGEp OiBBZGRlZCB0aGUgd2lkdGggdmFyaWFudCB0byB0aGUKKyAgICAgICAga2V5IHVzZWQgZm9yIGVu dHJpZXMgaW4gdGhlIGZvbnQgZGF0YSB0YWJsZSwgc28gdGhhdCB3ZSBjYW4gcmV0dXJuIGRpZmZl cmVudAorICAgICAgICBmb250IGRhdGEgZm9yIGRpZmZlcmVudCB3aWR0aCB2YXJpYW50cy4KKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250V2lkdGhWYXJpYW50Lmg6IERlZmluZWQgRm9u dFdpZHRoVmFyaWFudFdpZHRoIGZvcgorICAgICAgICB1c2UgaW4gdGhlIGNvbXB1dGF0aW9uIG9m IHRoZSBhYm92ZSBrZXkuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckNvbWJpbmVUZXh0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckNvbWJpbmVUZXh0Ojpjb21iaW5lVGV4dCk6IEFk ZGVkIGEgbG9jYWwgdmFyaWFibGUgdG8gc3RvcmUKKyAgICAgICAgdGhlIGZvbnQgc2VsZWN0b3Ig YmVmb3JlIGNoYW5naW5nIHRoZSBmb250IGRlc2NyaXB0aW9uLiBQcmV2aW91c2x5LCBieSB0aGUg dGltZQorICAgICAgICB3ZSB0cmllZCB0byBnZXQgdGhlIGZvbnQgc2VsZWN0b3IgZnJvbSB0aGUg Zm9udCwgaXQgaGFkIGFscmVhZHkgYmVlbiBjbGVhcmVkLAorICAgICAgICBzbyB3ZSBjYWxsZWQg Rm9udDo6dXBkYXRlKCkgd2l0aCBhIDAgZm9udCBzZWxlY3RvciwgbWVhbmluZyBAZm9udC1mYWNl IGZvbnRzCisgICAgICAgIGNvdWxkIG5vdCBiZSBzZWxlY3RlZC4KKwogMjAxMi0xMC0xMCAgS2Vu aWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRm9udFZlcnRp Y2FsRGF0YUNhY2hlIHNob3VsZCBhbGxvdyB6ZXJvIGFzIGEga2V5IHZhbHVlCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU2VnbWVudGVkRm9udEZhY2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWdtZW50ZWRGb250RmFjZS5jcHAJKHJldmlzaW9uIDEzMDky MykKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTZWdtZW50ZWRGb250RmFjZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEwNSw3ICsxMDUsMTAgQEAgUGFzc1JlZlB0cjxGb250RGF0YT4gQ1NTU2Vn bWVudGVkRm9udEZhYwogICAgICAgICByZXR1cm4gMDsKIAogICAgIEZvbnRUcmFpdHNNYXNrIGRl c2lyZWRUcmFpdHNNYXNrID0gZm9udERlc2NyaXB0aW9uLnRyYWl0c01hc2soKTsKLSAgICB1bnNp Z25lZCBoYXNoS2V5ID0gKChmb250RGVzY3JpcHRpb24uY29tcHV0ZWRQaXhlbFNpemUoKSArIDEp IDw8IChGb250VHJhaXRzTWFza1dpZHRoICsgMSkpIHwgKChmb250RGVzY3JpcHRpb24ub3JpZW50 YXRpb24oKSA9PSBWZXJ0aWNhbCA/IDEgOiAwKSA8PCBGb250VHJhaXRzTWFza1dpZHRoKSB8IGRl c2lyZWRUcmFpdHNNYXNrOworICAgIHVuc2lnbmVkIGhhc2hLZXkgPSAoKGZvbnREZXNjcmlwdGlv bi5jb21wdXRlZFBpeGVsU2l6ZSgpICsgMSkgPDwgKEZvbnRUcmFpdHNNYXNrV2lkdGggKyBGb250 V2lkdGhWYXJpYW50V2lkdGggKyAxKSkKKyAgICAgICAgfCAoKGZvbnREZXNjcmlwdGlvbi5vcmll bnRhdGlvbigpID09IFZlcnRpY2FsID8gMSA6IDApIDw8IChGb250VHJhaXRzTWFza1dpZHRoICsg Rm9udFdpZHRoVmFyaWFudFdpZHRoKSkKKyAgICAgICAgfCBmb250RGVzY3JpcHRpb24ud2lkdGhW YXJpYW50KCkgPDwgRm9udFRyYWl0c01hc2tXaWR0aAorICAgICAgICB8IGRlc2lyZWRUcmFpdHNN YXNrOwogCiAgICAgUmVmUHRyPFNlZ21lbnRlZEZvbnREYXRhPiYgZm9udERhdGEgPSBtX2ZvbnRE YXRhVGFibGUuYWRkKGhhc2hLZXksIDApLml0ZXJhdG9yLT52YWx1ZTsKICAgICBpZiAoZm9udERh dGEgJiYgZm9udERhdGEtPm51bVJhbmdlcygpKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvRm9udFdpZHRoVmFyaWFudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRXaWR0aFZhcmlhbnQuaAkocmV2aXNpb24gMTMwOTIz KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFdpZHRoVmFyaWFudC5o CSh3b3JraW5nIGNvcHkpCkBAIC0yOCw3ICsyOCwxNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKLWVudW0gRm9udFdpZHRoVmFyaWFudCB7IFJlZ3VsYXJXaWR0aCwgSGFsZldpZHRoLCBUaGly ZFdpZHRoLCBRdWFydGVyV2lkdGggfTsKK2VudW0gRm9udFdpZHRoVmFyaWFudCB7CisgICAgUmVn dWxhcldpZHRoLAorICAgIEhhbGZXaWR0aCwKKyAgICBUaGlyZFdpZHRoLAorICAgIFF1YXJ0ZXJX aWR0aCwKKyAgICBMYXN0Rm9udFdpZHRoVmFyaWFudCA9IFF1YXJ0ZXJXaWR0aAorfTsKKworY29u c3QgdW5zaWduZWQgRm9udFdpZHRoVmFyaWFudFdpZHRoID0gMjsKKworQ09NUElMRV9BU1NFUlQo TGFzdEZvbnRXaWR0aFZhcmlhbnQgPj4gRm9udFdpZHRoVmFyaWFudFdpZHRoID09IDAsIEZvbnRX aWR0aFZhcmlhbnRXaWR0aF9pc19jb3JyZWN0KTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQog CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQ29tYmluZVRleHQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJDb21iaW5lVGV4dC5j cHAJKHJldmlzaW9uIDEzMDkyMykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJD b21iaW5lVGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw2ICsxMDMsOCBAQCB2b2lkIFJl bmRlckNvbWJpbmVUZXh0Ojpjb21iaW5lVGV4dCgpCiAgICAgbV9jb21iaW5lZFRleHRXaWR0aCA9 IG9yaWdpbmFsRm9udCgpLndpZHRoKHJ1bik7CiAgICAgbV9pc0NvbWJpbmVkID0gbV9jb21iaW5l ZFRleHRXaWR0aCA8PSBlbVdpZHRoOwogCisgICAgRm9udFNlbGVjdG9yKiBmb250U2VsZWN0b3Ig PSBzdHlsZSgpLT5mb250KCkuZm9udFNlbGVjdG9yKCk7CisKICAgICBpZiAobV9pc0NvbWJpbmVk KQogICAgICAgICBzaG91bGRVcGRhdGVGb250ID0gc3R5bGUoKS0+c2V0Rm9udERlc2NyaXB0aW9u KGRlc2NyaXB0aW9uKTsgLy8gTmVlZCB0byBjaGFuZ2UgZm9udCBvcmllbnRhdGlvbiB0byBob3Jp em9udGFsLgogICAgIGVsc2UgewpAQCAtMTExLDcgKzExMyw3IEBAIHZvaWQgUmVuZGVyQ29tYmlu ZVRleHQ6OmNvbWJpbmVUZXh0KCkKICAgICAgICAgZm9yIChzaXplX3QgaSA9IDAgOyBpIDwgV1RG X0FSUkFZX0xFTkdUSCh3aWR0aFZhcmlhbnRzKSA7ICsraSkgewogICAgICAgICAgICAgZGVzY3Jp cHRpb24uc2V0V2lkdGhWYXJpYW50KHdpZHRoVmFyaWFudHNbaV0pOwogICAgICAgICAgICAgRm9u dCBjb21wcmVzc2VkRm9udCA9IEZvbnQoZGVzY3JpcHRpb24sIHN0eWxlKCktPmZvbnQoKS5sZXR0 ZXJTcGFjaW5nKCksIHN0eWxlKCktPmZvbnQoKS53b3JkU3BhY2luZygpKTsKLSAgICAgICAgICAg IGNvbXByZXNzZWRGb250LnVwZGF0ZShzdHlsZSgpLT5mb250KCkuZm9udFNlbGVjdG9yKCkpOwor ICAgICAgICAgICAgY29tcHJlc3NlZEZvbnQudXBkYXRlKGZvbnRTZWxlY3Rvcik7CiAgICAgICAg ICAgICBmbG9hdCBydW5XaWR0aCA9IGNvbXByZXNzZWRGb250LndpZHRoKHJ1bik7CiAgICAgICAg ICAgICBpZiAocnVuV2lkdGggPD0gZW1XaWR0aCkgewogICAgICAgICAgICAgICAgIG1fY29tYmlu ZWRUZXh0V2lkdGggPSBydW5XaWR0aDsKQEAgLTEyOCw3ICsxMzAsNyBAQCB2b2lkIFJlbmRlckNv bWJpbmVUZXh0Ojpjb21iaW5lVGV4dCgpCiAgICAgICAgIHNob3VsZFVwZGF0ZUZvbnQgPSBzdHls ZSgpLT5zZXRGb250RGVzY3JpcHRpb24ob3JpZ2luYWxGb250KCkuZm9udERlc2NyaXB0aW9uKCkp OwogCiAgICAgaWYgKHNob3VsZFVwZGF0ZUZvbnQpCi0gICAgICAgIHN0eWxlKCktPmZvbnQoKS51 cGRhdGUoc3R5bGUoKS0+Zm9udCgpLmZvbnRTZWxlY3RvcigpKTsKKyAgICAgICAgc3R5bGUoKS0+ Zm9udCgpLnVwZGF0ZShmb250U2VsZWN0b3IpOwogCiAgICAgaWYgKG1faXNDb21iaW5lZCkgewog ICAgICAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgb2JqZWN0UmVwbGFjZW1lbnRDaGFy YWN0ZXJTdHJpbmcsICgmb2JqZWN0UmVwbGFjZW1lbnRDaGFyYWN0ZXIsIDEpKTsKSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDEzMDk3NSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTEwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyNDcyNDYwPiB0ZXh0LWNvbWJpbmUg ZG9lc27igJl0IHVzZSB0aGlyZC0gYW5kIHF1YXJ0ZXItd2lkdGggdmFyaWFudHMgd2hlbiB1c2Vk IHdpdGggQGZvbnQtZmFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTg5NjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGZhc3QvdGV4dC90ZXh0LWNvbWJpbmUtd2l0aC1mb250LWZhY2UtZXhwZWN0ZWQu aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC90ZXh0L3RleHQtY29tYmluZS13aXRoLWZvbnQt ZmFjZS5odG1sOiBBZGRlZC4KKwogMjAxMi0xMC0xMCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBwZXJmIHRlc3RzIHRoYXQgaGF2ZW4ndCBmYWlsZWQg aW4gdGhlIHBhc3QgNTAwIHJ1bnMuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvdGV4dC1j b21iaW5lLXdpdGgtZm9udC1mYWNlLWV4cGVjdGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvZmFzdC90ZXh0L3RleHQtY29tYmluZS13aXRoLWZvbnQtZmFjZS1leHBlY3RlZC5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3RleHQtY29tYmluZS13aXRo LWZvbnQtZmFjZS1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACis8 c3R5bGU+CisgICAgZGl2IHsKKyAgICAgICAgLXdlYmtpdC13cml0aW5nLW1vZGU6IHZlcnRpY2Fs LXJsOworICAgICAgICBmb250LXNpemU6IDM2cHg7CisgICAgICAgIGZvbnQtZmFtaWx5OiBIaXJh TWluUHJvTi1XMzsKKyAgICB9CisgICAgc3BhbiB7CisgICAgICAgIC13ZWJraXQtdGV4dC1jb21i aW5lOiBob3Jpem9udGFsOworICAgIH0KKzwvc3R5bGU+Cis8ZGl2PgorICAgIDxzcGFuPjE8L3Nw YW4+PHNwYW4+MjM8L3NwYW4+PHNwYW4+NDU2PC9zcGFuPjxzcGFuPjc4OTA8L3NwYW4+Cis8L2Rp dj4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC90ZXh0LWNvbWJpbmUtd2l0aC1mb250LWZh Y2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RleHQvdGV4dC1jb21iaW5l LXdpdGgtZm9udC1mYWNlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3Rl eHQvdGV4dC1jb21iaW5lLXdpdGgtZm9udC1mYWNlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTggQEAKKzxzdHlsZT4KKyAgICBAZm9udC1mYWNlIHsKKyAgICAgICAgZm9udC1mYW1pbHk6 IHRlc3Q7CisgICAgICAgIHNyYzogbG9jYWwoSGlyYU1pblByb04tVzMpOworICAgIH0KKworICAg IGRpdiB7CisgICAgICAgIC13ZWJraXQtd3JpdGluZy1tb2RlOiB2ZXJ0aWNhbC1ybDsKKyAgICAg ICAgZm9udC1zaXplOiAzNnB4OworICAgICAgICBmb250LWZhbWlseTogdGVzdDsKKyAgICB9Cisg ICAgc3BhbiB7CisgICAgICAgIC13ZWJraXQtdGV4dC1jb21iaW5lOiBob3Jpem9udGFsOworICAg IH0KKzwvc3R5bGU+Cis8ZGl2PgorICAgIDxzcGFuPjE8L3NwYW4+PHNwYW4+MjM8L3NwYW4+PHNw YW4+NDU2PC9zcGFuPjxzcGFuPjc4OTA8L3NwYW4+Cis8L2Rpdj4K