98947 2012-10-10 12:36:42 -0700 [Chromium] Update selection on long press to match normal delimiters. 2012-10-10 18:45:42 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leandrogracia leandrogracia abarth webkit.review.bot oldest_to_newest 739220 0 leandrogracia 2012-10-10 12:36:42 -0700 Make the required changes to make the selection on long press behaviour consistent. 739234 1 168057 leandrogracia 2012-10-10 12:55:04 -0700 Created attachment 168057 Patch 739235 2 168057 abarth 2012-10-10 12:56:57 -0700 Comment on attachment 168057 Patch Ok. Thanks. 739486 3 168057 webkit.review.bot 2012-10-10 18:45:39 -0700 Comment on attachment 168057 Patch Clearing flags on attachment: 168057 Committed r130992: <http://trac.webkit.org/changeset/130992> 739487 4 webkit.review.bot 2012-10-10 18:45:42 -0700 All reviewed patches have been landed. Closing bug. 168057 2012-10-10 12:55:04 -0700 2012-10-10 18:45:39 -0700 Patch bug-98947-20121010205403.patch text/plain 6146 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwOTI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhlNjJjNjMwOTlmMTNjMWM5MDlmYzg1NjYwNDY4OGYxYWYyMDdkNGQuLmZmNzZmMDBlYzcxMWU3 MWNiMDdiN2Y3N2E0MmNiYjljMDg2Y2FiYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTAtMTAgIExlYW5kcm8gR3JhY2lhIEdpbCAgPGxlYW5kcm9n cmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gVXBkYXRlIHNlbGVjdGlv biBvbiBsb25nIHByZXNzIHRvIG1hdGNoIG5vcm1hbCBkZWxpbWl0ZXJzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg5NDcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSBsb25nIHByZXNzIHNl bGVjdGlvbiBiZWhhdmlvdXIgY29uc2lzdGVudC4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1w bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpoYW5kbGVHZXN0dXJlRXZlbnQp OgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6ZGV0ZWN0Q29udGVudE9uVG91Y2gpOgor ICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5oOgorICAgICAgICAoV2ViVmlld0ltcGwpOgorICAg ICAgICAqIHRlc3RzL1dlYlZpZXdUZXN0LmNwcDoKKwogMjAxMi0xMC0xMCAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBTdG9yZSBhIHZpc2libGUgcmVj dCBpbiBHcmFwaGljc0xheWVycywgYW5kIG9wdGlvbmFsbHkgZHVtcCBpdCBpbiBsYXllclRyZWVB c1RleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAppbmRleCBh NTgyZWY2MWQwYTRlYWEyNDMxZDlmY2YxZTZiODg1NDBiMWNiZTFiLi5hZWYxYWJiOTFjODMwZGQ5 OTBmMjc4Nzg4NjIwODUwMzAyYTI5N2EyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViVmlld0ltcGwuY3BwCkBAIC03MDcsNyArNzA3LDcgQEAgYm9vbCBXZWJWaWV3SW1wbDo6aGFu ZGxlR2VzdHVyZUV2ZW50KGNvbnN0IFdlYkdlc3R1cmVFdmVudCYgZXZlbnQpCiAgICAgICAgIGJy ZWFrOwogICAgIGNhc2UgV2ViSW5wdXRFdmVudDo6R2VzdHVyZVRhcDogewogICAgICAgICBtX2Ns aWVudC0+Y2FuY2VsU2NoZWR1bGVkQ29udGVudEludGVudHMoKTsKLSAgICAgICAgaWYgKGRldGVj dENvbnRlbnRPblRvdWNoKFdlYlBvaW50KGV2ZW50LngsIGV2ZW50LnkpLCBldmVudC50eXBlKSkg eworICAgICAgICBpZiAoZGV0ZWN0Q29udGVudE9uVG91Y2goV2ViUG9pbnQoZXZlbnQueCwgZXZl bnQueSkpKSB7CiAgICAgICAgICAgICBldmVudFN3YWxsb3dlZCA9IHRydWU7CiAgICAgICAgICAg ICBicmVhazsKICAgICAgICAgfQpAQCAtNzU5LDExICs3NTksNiBAQCBib29sIFdlYlZpZXdJbXBs OjpoYW5kbGVHZXN0dXJlRXZlbnQoY29uc3QgV2ViR2VzdHVyZUV2ZW50JiBldmVudCkKICAgICAg ICAgICAgIGJyZWFrOwogCiAgICAgICAgIG1fY2xpZW50LT5jYW5jZWxTY2hlZHVsZWRDb250ZW50 SW50ZW50cygpOwotICAgICAgICBpZiAoZGV0ZWN0Q29udGVudE9uVG91Y2goV2ViUG9pbnQoZXZl bnQueCwgZXZlbnQueSksIGV2ZW50LnR5cGUpKSB7Ci0gICAgICAgICAgICBldmVudFN3YWxsb3dl ZCA9IHRydWU7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotCiAgICAgICAgIG1fcGFn ZS0+Y29udGV4dE1lbnVDb250cm9sbGVyKCktPmNsZWFyQ29udGV4dE1lbnUoKTsKICAgICAgICAg bV9jb250ZXh0TWVudUFsbG93ZWQgPSB0cnVlOwogICAgICAgICBQbGF0Zm9ybUdlc3R1cmVFdmVu dEJ1aWxkZXIgcGxhdGZvcm1FdmVudChtYWluRnJhbWVJbXBsKCktPmZyYW1lVmlldygpLCBldmVu dCk7CkBAIC00MTM5LDEyICs0MTM0LDggQEAgdm9pZCBXZWJWaWV3SW1wbDo6c2VsZWN0QXV0b2Zp bGxTdWdnZXN0aW9uQXRJbmRleCh1bnNpZ25lZCBsaXN0SW5kZXgpCiAgICAgICAgIG1fYXV0b2Zp bGxQb3B1cENsaWVudC0+dmFsdWVDaGFuZ2VkKGxpc3RJbmRleCk7CiB9CiAKLWJvb2wgV2ViVmll d0ltcGw6OmRldGVjdENvbnRlbnRPblRvdWNoKGNvbnN0IFdlYlBvaW50JiBwb3NpdGlvbiwgV2Vi SW5wdXRFdmVudDo6VHlwZSB0b3VjaFR5cGUpCitib29sIFdlYlZpZXdJbXBsOjpkZXRlY3RDb250 ZW50T25Ub3VjaChjb25zdCBXZWJQb2ludCYgcG9zaXRpb24pCiB7Ci0gICAgQVNTRVJUKHRvdWNo VHlwZSA9PSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlVGFwCi0gICAgICAgICAgIHx8IHRvdWNoVHlw ZSA9PSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlVHdvRmluZ2VyVGFwCi0gICAgICAgICAgIHx8IHRv dWNoVHlwZSA9PSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlTG9uZ1ByZXNzKTsKLQogICAgIEhpdFRl c3RSZXN1bHQgdG91Y2hIaXQgPSBoaXRUZXN0UmVzdWx0Rm9yV2luZG93UG9zKHBvc2l0aW9uKTsK IAogICAgIGlmICh0b3VjaEhpdC5pc0NvbnRlbnRFZGl0YWJsZSgpKQpAQCAtNDE1NywyMiArNDE0 OCwxNCBAQCBib29sIFdlYlZpZXdJbXBsOjpkZXRlY3RDb250ZW50T25Ub3VjaChjb25zdCBXZWJQ b2ludCYgcG9zaXRpb24sIFdlYklucHV0RXZlbnQ6OgogICAgIC8vIElnbm9yZSB3aGVuIHRhcHBp bmcgb24gbGlua3Mgb3Igbm9kZXMgbGlzdGVuaW5nIHRvIGNsaWNrIGV2ZW50cywgdW5sZXNzIHRo ZSBjbGljayBldmVudCBpcyBvbiB0aGUKICAgICAvLyBib2R5IGVsZW1lbnQsIGluIHdoaWNoIGNh c2UgaXQncyB1bmxpa2VseSB0aGF0IHRoZSBvcmlnaW5hbCBub2RlIGl0c2VsZiB3YXMgaW50ZW5k ZWQgdG8gYmUgY2xpY2thYmxlLgogICAgIGZvciAoOyBub2RlICYmICFub2RlLT5oYXNUYWdOYW1l KEhUTUxOYW1lczo6Ym9keVRhZyk7IG5vZGUgPSBub2RlLT5wYXJlbnROb2RlKCkpIHsKLSAgICAg ICAgaWYgKG5vZGUtPmlzTGluaygpIHx8ICh0b3VjaFR5cGUgPT0gV2ViSW5wdXRFdmVudDo6R2Vz dHVyZVRhcAotICAgICAgICAgICAgICAgICYmIChub2RlLT53aWxsUmVzcG9uZFRvVG91Y2hFdmVu dHMoKSB8fCBub2RlLT53aWxsUmVzcG9uZFRvTW91c2VDbGlja0V2ZW50cygpKSkpIHsKKyAgICAg ICAgaWYgKG5vZGUtPmlzTGluaygpIHx8IG5vZGUtPndpbGxSZXNwb25kVG9Ub3VjaEV2ZW50cygp IHx8IG5vZGUtPndpbGxSZXNwb25kVG9Nb3VzZUNsaWNrRXZlbnRzKCkpCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7Ci0gICAgICAgIH0KICAgICB9CiAKICAgICBXZWJDb250ZW50RGV0ZWN0aW9u UmVzdWx0IGNvbnRlbnQgPSBtX2NsaWVudC0+ZGV0ZWN0Q29udGVudEFyb3VuZCh0b3VjaEhpdCk7 CiAgICAgaWYgKCFjb250ZW50LmlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0g ICAgaWYgKHRvdWNoVHlwZSAhPSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlVGFwKSB7Ci0gICAgICAg IC8vIFNlbGVjdCB0aGUgZGV0ZWN0ZWQgY29udGVudCBhcyBhIGJsb2NrLgotICAgICAgICBmb2N1 c2VkRnJhbWUoKS0+c2VsZWN0UmFuZ2UoY29udGVudC5yYW5nZSgpKTsKLSAgICAgICAgcmV0dXJu IHRydWU7Ci0gICAgfQotCiAgICAgbV9jbGllbnQtPnNjaGVkdWxlQ29udGVudEludGVudChjb250 ZW50LmludGVudCgpKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IGZmMzRjYzI3MGUxNjliZjVmMWM3MGE5ZDU5NmMxOTE5 MWRiM2MwYzEuLjQ3OTA3ZjEyNDE3ZTNmMjIwYWM4YjAwZjkzNjBhZWZhYWEwZGFmNDIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuaApAQCAtMzkyLDcgKzM5Miw3IEBA IHB1YmxpYzoKICAgICB2b2lkIG1vdXNlQ29udGV4dE1lbnUoY29uc3QgV2ViTW91c2VFdmVudCYp OwogICAgIHZvaWQgbW91c2VEb3VibGVDbGljayhjb25zdCBXZWJNb3VzZUV2ZW50Jik7CiAKLSAg ICBib29sIGRldGVjdENvbnRlbnRPblRvdWNoKGNvbnN0IFdlYlBvaW50JiwgV2ViSW5wdXRFdmVu dDo6VHlwZSk7CisgICAgYm9vbCBkZXRlY3RDb250ZW50T25Ub3VjaChjb25zdCBXZWJQb2ludCYp OwogICAgIHZvaWQgc3RhcnRQYWdlU2NhbGVBbmltYXRpb24oY29uc3QgV2ViQ29yZTo6SW50UG9p bnQmIHRhcmdldFBvc2l0aW9uLCBib29sIHVzZUFuY2hvciwgZmxvYXQgbmV3U2NhbGUsIGRvdWJs ZSBkdXJhdGlvbkluU2Vjb25kcyk7CiAKICAgICB2b2lkIG51bWJlck9mV2hlZWxFdmVudEhhbmRs ZXJzQ2hhbmdlZCh1bnNpZ25lZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Rlc3RzL1dlYlZpZXdUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2Vi Vmlld1Rlc3QuY3BwCmluZGV4IGM4NTUxZGYxNzZlOTg3NjA1Mzg3MTBkMmVkYmYxMzYwNDRmOTMw YTEuLjE5MjljMWJhNjMwODMyNWZkYmRkMmZhOGM1MjIzY2UwMGY2ZmY5NmQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViVmlld1Rlc3QuY3BwCkBAIC01ODUsMjQgKzU4NSw2 IEBAIFRFU1RfRihXZWJWaWV3VGVzdCwgRGV0ZWN0Q29udGVudEFyb3VuZFBvc2l0aW9uKQogICAg IEVYUEVDVF9GQUxTRShjbGllbnQuY29udGVudERldGVjdGlvblJlcXVlc3RlZCgpKTsKICAgICBj bGllbnQucmVzZXQoKTsKIAotICAgIC8vIENvbnRlbnQgZGV0ZWN0aW9uIHNob3VsZCBzdGlsbCB3 b3JrIG9uIGNsaWNrLCBtb3VzZSBhbmQgdG91Y2ggZXZlbnQgbGlzdGVuZXJzIGZvciBsb25nIHRh cHMKLSAgICAvLyBhcyBsb25nIGFzIHdlJ3JlIG5vdCB0YXBwaW5nIG9uIGxpbmtzLgotICAgIEVY UEVDVF9UUlVFKHRhcEVsZW1lbnRCeUlkKHdlYlZpZXcsIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVM b25nUHJlc3MsIGNsaWNrTGlzdGVuZXIpKTsKLSAgICBFWFBFQ1RfVFJVRShjbGllbnQuY29udGVu dERldGVjdGlvblJlcXVlc3RlZCgpKTsKLSAgICBjbGllbnQucmVzZXQoKTsKLQotICAgIEVYUEVD VF9UUlVFKHRhcEVsZW1lbnRCeUlkKHdlYlZpZXcsIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVMb25n UHJlc3MsIHRvdWNoc3RhcnRMaXN0ZW5lcikpOwotICAgIEVYUEVDVF9UUlVFKGNsaWVudC5jb250 ZW50RGV0ZWN0aW9uUmVxdWVzdGVkKCkpOwotICAgIGNsaWVudC5yZXNldCgpOwotCi0gICAgRVhQ RUNUX1RSVUUodGFwRWxlbWVudEJ5SWQod2ViVmlldywgV2ViSW5wdXRFdmVudDo6R2VzdHVyZUxv bmdQcmVzcywgbW91c2Vkb3duTGlzdGVuZXIpKTsKLSAgICBFWFBFQ1RfVFJVRShjbGllbnQuY29u dGVudERldGVjdGlvblJlcXVlc3RlZCgpKTsKLSAgICBjbGllbnQucmVzZXQoKTsKLQotICAgIEVY UEVDVF9UUlVFKHRhcEVsZW1lbnRCeUlkKHdlYlZpZXcsIFdlYklucHV0RXZlbnQ6Okdlc3R1cmVM b25nUHJlc3MsIGxpbmspKTsKLSAgICBFWFBFQ1RfRkFMU0UoY2xpZW50LmNvbnRlbnREZXRlY3Rp b25SZXF1ZXN0ZWQoKSk7Ci0gICAgY2xpZW50LnJlc2V0KCk7Ci0KICAgICAvLyBDb250ZW50IGRl dGVjdGlvbiBzaG91bGQgd29yayBub3JtYWxseSB3aXRob3V0IHRoZXNlIGV2ZW50IGxpc3RlbmVy cy4KICAgICAvLyBUaGUgY2xpY2sgbGlzdGVuZXIgaW4gdGhlIGJvZHkgc2hvdWxkIGJlIGlnbm9y ZWQgYXMgYSBzcGVjaWFsIGNhc2UuCiAgICAgRVhQRUNUX1RSVUUodGFwRWxlbWVudEJ5SWQod2Vi VmlldywgV2ViSW5wdXRFdmVudDo6R2VzdHVyZVRhcCwgbm9MaXN0ZW5lcikpOwo=