98923 2012-10-10 10:09:49 -0700 Web Inspector: Enabling experiments tab in WebKit nightly. 2012-10-11 09:29:52 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED AdobeTracked P2 Normal --- 0 mibalan mibalan apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy WebkitBugTracker webkit.review.bot yurys oldest_to_newest 739053 0 mibalan 2012-10-10 10:09:49 -0700 As per the discussion at http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html all experimental features will be enabled in Safari's Web Inspector. 739058 1 mibalan 2012-10-10 10:13:59 -0700 (In reply to comment #0) > As per the discussion at http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html all experimental features will be enabled in Safari's Web Inspector. The initial wording is actually wrong. This patch is about enabling the experimental tab in WebKit nightly (not having it depend on a runtime flag - as is the case in Chromium) 739948 2 168224 mibalan 2012-10-11 07:24:31 -0700 Created attachment 168224 Patch for always enabling the experiments tab. 739955 3 168224 apavlov 2012-10-11 07:27:30 -0700 Comment on attachment 168224 Patch for always enabling the experiments tab. View in context: https://bugs.webkit.org/attachment.cgi?id=168224&action=review So, what about non-nightlies? Do all parties agree that we should enable experiments in all possible cases? > Source/WebCore/inspector/front-end/Settings.js:220 > + // to enable it at runtime Lost closing parenthesis :) 739958 4 mibalan 2012-10-11 07:32:54 -0700 (In reply to comment #3) > (From update of attachment 168224 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=168224&action=review > > So, what about non-nightlies? Do all parties agree that we should enable experiments in all possible cases? > This is my understanding from the discussion on webkit-dev [1] and the one on IRC today. [1] http://lists.webkit.org/pipermail/webkit-dev/2012-September/022339.html 740014 5 168224 pfeldman 2012-10-11 08:51:48 -0700 Comment on attachment 168224 Patch for always enabling the experiments tab. This will also enable experiments in Chrome. You should instead add Preferences.experimentsEnabled and make it "true" in WebCore/inspector/front-end/Settings.js and "false" in WebKit/chromium/src/js/DevTools.js. This check will become Preferences.experimentsEnabled || "experiments" in WebInspector.queryParamsObject. I think it is fine to enable experiments on stable versions given that Safari ships its proprietary front-end now. 740026 6 168238 mibalan 2012-10-11 09:07:43 -0700 Created attachment 168238 Patch for enabling the experiments tab in WebKit nightly 740044 7 168238 webkit.review.bot 2012-10-11 09:29:49 -0700 Comment on attachment 168238 Patch for enabling the experiments tab in WebKit nightly Clearing flags on attachment: 168238 Committed r131071: <http://trac.webkit.org/changeset/131071> 740045 8 webkit.review.bot 2012-10-11 09:29:52 -0700 All reviewed patches have been landed. Closing bug. 168224 2012-10-11 07:24:31 -0700 2012-10-11 09:07:43 -0700 Patch for always enabling the experiments tab. b98923.patch text/plain 1442 mibalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZGRjZjNlLi4xYWRmYmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMTAtMTEgIE1paGFpIEJhbGFuICA8bWliYWxhbkBhZG9iZS5jb20+CisKKyAgICAg ICAgQWx3YXlzIGVuYWJsZSB0aGUgZXhwZXJpbWVudHMgdGFiIGZvciBXZWJLaXQgbmlnaHRseQor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVuYWJsaW5nIGV4cGVyaW1lbnRzIHRhYiBpbiBXZWJL aXQgbmlnaHRseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4OTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2hhbmdlZCB0aGUgZXhwZXJpbWVudHNFbmFibGVkIGdldHRlciB0byBhbHdheXMgcmV0dXJu IHRydWUgaW4gb3JkZXIgdG8gaGF2ZSB0aGUgRXhwZXJpbWVudHMKKyAgICAgICAgdGFiIGFsd2F5 cyBlbmFibGVkIGluIFdlYktpdCdzIFdlYkluc3BlY3Rvci4KKworICAgICAgICAqIGluc3BlY3Rv ci9mcm9udC1lbmQvU2V0dGluZ3MuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRXhwZXJpbWVu dHNTZXR0aW5ncy5wcm90b3R5cGUuZ2V0IGV4cGVyaW1lbnRzRW5hYmxlZCk6CisKIDIwMTItMTAt MTAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAg ICAgICBTUUxSZXN1bHRTZXQucm93c0FmZmVjdGVkIG5vdCBjbGVhcmVkCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwppbmRleCA0ZmRlNTdiLi5jNTQ4 OGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRp bmdzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3Mu anMKQEAgLTIxNiw3ICsyMTYsOSBAQCBXZWJJbnNwZWN0b3IuRXhwZXJpbWVudHNTZXR0aW5ncy5w cm90b3R5cGUgPSB7CiAgICAgICovCiAgICAgZ2V0IGV4cGVyaW1lbnRzRW5hYmxlZCgpCiAgICAg ewotICAgICAgICByZXR1cm4gImV4cGVyaW1lbnRzIiBpbiBXZWJJbnNwZWN0b3IucXVlcnlQYXJh bXNPYmplY3Q7CisgICAgICAgIC8vIFdlIHdhbnQgdGhlIGV4cGVyaW1lbnRzIHRhYiBhbHdheXMg ZW5hYmxlZCBvbiBXZWJLaXQgbmlnaHRseSAoYmVjYXVzZSB0aGVyZSdzIG5vIHdheQorICAgICAg ICAvLyB0byBlbmFibGUgaXQgYXQgcnVudGltZQorICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9 LAogICAgIAogICAgIC8qKgo= 168238 2012-10-11 09:07:43 -0700 2012-10-11 09:29:49 -0700 Patch for enabling the experiments tab in WebKit nightly b98923.patch text/plain 3187 mibalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzZGRjZjNlLi4xMTc5MTA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMTAtMTEgIE1paGFpIEJhbGFuICA8bWliYWxhbkBhZG9iZS5jb20+CisKKyAgICAg ICAgQWx3YXlzIGVuYWJsZSB0aGUgZXhwZXJpbWVudHMgdGFiIGZvciBXZWJLaXQgbmlnaHRseQor CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVuYWJsaW5nIGV4cGVyaW1lbnRzIHRhYiBpbiBXZWJL aXQgbmlnaHRseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk4OTIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRW5hYmxpbmcgV2ViIEluc3BlY3RvciBleHBlcmltZW50cyB0YWIgaW4gV2ViS2l0IG5pZ2h0 bHkuIFRoaXMgaXMgZG9uZSBieSBhZGRpbmcgYSBuZXcKKyAgICAgICAgUHJlZmVyZW5jZSBrZXks IFByZWZlcmVuY2VzLmV4cGVyaW1lbnRzRW5hYmxlZC4gRGVmYXVsdCB2YWx1ZXMgYXJlIHRydWUg Zm9yIFdlYktpdCBhbmQgZmFsc2UKKyAgICAgICAgZm9yIENocm9taXVtLiBUaGV5IGNhbiBhbHNv IGJlIG92ZXJyaWRkZW4gYXMgYmVmb3JlIChpbiBDaHJvbWl1bSkKKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRXhwZXJp bWVudHNTZXR0aW5ncy5wcm90b3R5cGUuZ2V0IGV4cGVyaW1lbnRzRW5hYmxlZCk6CisKIDIwMTIt MTAtMTAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAog ICAgICAgICBTUUxSZXN1bHRTZXQucm93c0FmZmVjdGVkIG5vdCBjbGVhcmVkCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwppbmRleCA0ZmRlNTdiLi5h MGJhY2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Nl dHRpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGlu Z3MuanMKQEAgLTQzLDcgKzQzLDggQEAgdmFyIFByZWZlcmVuY2VzID0gewogICAgIGV4cG9zZURp c2FibGVDYWNoZTogZmFsc2UsCiAgICAgYXBwbGljYXRpb25UaXRsZTogIldlYiBJbnNwZWN0b3Ig LSAlcyIsCiAgICAgc2hvd0RvY2tUb1JpZ2h0OiBmYWxzZSwKLSAgICBleHBvc2VGaWxlU3lzdGVt SW5zcGVjdGlvbjogZmFsc2UKKyAgICBleHBvc2VGaWxlU3lzdGVtSW5zcGVjdGlvbjogZmFsc2Us CisgICAgZXhwZXJpbWVudHNFbmFibGVkOiB0cnVlCiB9CiAKIHZhciBDYXBhYmlsaXRpZXMgPSB7 CkBAIC0yMTYsNyArMjE3LDcgQEAgV2ViSW5zcGVjdG9yLkV4cGVyaW1lbnRzU2V0dGluZ3MucHJv dG90eXBlID0gewogICAgICAqLwogICAgIGdldCBleHBlcmltZW50c0VuYWJsZWQoKQogICAgIHsK LSAgICAgICAgcmV0dXJuICJleHBlcmltZW50cyIgaW4gV2ViSW5zcGVjdG9yLnF1ZXJ5UGFyYW1z T2JqZWN0OworICAgICAgICByZXR1cm4gUHJlZmVyZW5jZXMuZXhwZXJpbWVudHNFbmFibGVkIHx8 ICgiZXhwZXJpbWVudHMiIGluIFdlYkluc3BlY3Rvci5xdWVyeVBhcmFtc09iamVjdCk7CiAgICAg fSwKICAgICAKICAgICAvKioKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNTA0OWI0YS4u OWIzYTgzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAx Mi0xMC0xMSAgTWloYWkgQmFsYW4gIDxtaWJhbGFuQGFkb2JlLmNvbT4KKworICAgICAgICBBbHdh eXMgZW5hYmxlIHRoZSBleHBlcmltZW50cyB0YWIgZm9yIFdlYktpdCBuaWdodGx5CisKKyAgICAg ICAgV2ViIEluc3BlY3RvcjogRW5hYmxpbmcgZXhwZXJpbWVudHMgdGFiIGluIFdlYktpdCBuaWdo dGx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg5 MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFi bGluZyBXZWIgSW5zcGVjdG9yIGV4cGVyaW1lbnRzIHRhYiBpbiBXZWJLaXQgbmlnaHRseS4gVGhp cyBpcyBkb25lIGJ5IGFkZGluZyBhIG5ldworICAgICAgICBQcmVmZXJlbmNlIGtleSwgUHJlZmVy ZW5jZXMuZXhwZXJpbWVudHNFbmFibGVkLiBEZWZhdWx0IHZhbHVlcyBhcmUgdHJ1ZSBmb3IgV2Vi S2l0IGFuZCBmYWxzZQorICAgICAgICBmb3IgQ2hyb21pdW0uIFRoZXkgY2FuIGFsc28gYmUgb3Zl cnJpZGRlbiBhcyBiZWZvcmUgKGluIENocm9taXVtKQorCisgICAgICAgICogc3JjL2pzL0RldlRv b2xzLmpzOgorCiAyMDEyLTEwLTA4ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4K IAogICAgICAgICBbQ2hyb21pdW1dIEFkZCBXZWJFbGVtZW50OjpoYXNIVE1MVGFnTmFtZSwgYW5k IGRlcHJlY2F0ZSBoYXNUYWdOYW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9qcy9EZXZUb29scy5qcyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRv b2xzLmpzCmluZGV4IGY1NTU0MTkuLmJiZGJkOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL2pzL0RldlRvb2xzLmpzCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL2pzL0RldlRvb2xzLmpzCkBAIC00MSw2ICs0MSw3IEBACiAgICAgUHJlZmVyZW5jZXMuZXhw b3NlRGlzYWJsZUNhY2hlID0gdHJ1ZTsKICAgICBQcmVmZXJlbmNlcy5zaG93RG9ja1RvUmlnaHQg PSB0cnVlOwogICAgIFByZWZlcmVuY2VzLmV4cG9zZUZpbGVTeXN0ZW1JbnNwZWN0aW9uID0gdHJ1 ZTsKKyAgICBQcmVmZXJlbmNlcy5leHBlcmltZW50c0VuYWJsZWQgPSBmYWxzZTsKIH0pKCk7fQog CiBmdW5jdGlvbiBidWlsZFBsYXRmb3JtRXh0ZW5zaW9uQVBJKGV4dGVuc2lvbkluZm8pCg==