98893 2012-10-10 06:12:12 -0700 Replace (typeof(x) != <>) with !(typeof(x) == <>) 2022-02-27 23:26:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 valery.ignatyev webkit-unassigned barraclough bfulgham fpizlo oldest_to_newest 738887 0 valery.ignatyev 2012-10-10 06:12:12 -0700 Replace (typeof(x) != <"object", "undefined", ...>) with !(typeof(x) == {"object",..}). Later is_object, is_<...> bytecode operation will be used. This eliminates expensive typeof implementation and allows to use DFG optimizations, which doesn't support 'typeof'. 738888 1 167986 valery.ignatyev 2012-10-10 06:15:09 -0700 Created attachment 167986 patch with fix 739137 2 ap 2012-10-10 11:07:34 -0700 Is this patch ready for review? If so, please mark is as "review?", so that it doesn't get overlooked. 739320 3 167986 buildbot 2012-10-10 15:05:35 -0700 Comment on attachment 167986 patch with fix Attachment 167986 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14244735 New failing tests: sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.1/15.1.1.1_NaN/S15.1.1.1_A2_T2.html platform/mac/plugins/bindings-test-objc.html fast/workers/worker-close.html sputnik/Conformance/09_Type_Conversion/9.8_ToString/S9.8_A4_T2.html fast/js/webcore-string-comparison.html 739321 4 167986 fpizlo 2012-10-10 15:07:11 -0700 Comment on attachment 167986 patch with fix It seems like you're making tests fail. 739849 5 168201 valery.ignatyev 2012-10-11 05:44:04 -0700 Created attachment 168201 patch second attempt 740039 6 168201 fpizlo 2012-10-11 09:25:25 -0700 Comment on attachment 168201 patch second attempt View in context: https://bugs.webkit.org/attachment.cgi?id=168201&action=review > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1060 > + if (opcodeID == op_nstricteq) This should be "else if"? 740056 7 168242 valery.ignatyev 2012-10-11 09:36:28 -0700 Created attachment 168242 fixed patch Thank you very much for a feedback. Is it codestyle violation? I didn't understand why 'else if' is necessary. 740063 8 fpizlo 2012-10-11 09:39:08 -0700 (In reply to comment #7) > Created an attachment (id=168242) [details] > fixed patch > > Thank you very much for a feedback. > Is it codestyle violation? > I didn't understand why 'else if' is necessary. 1) Style. At first, since there wasn't an "else", it seemed like both 'if' statements could be taken, which is not the case. It makes the code less clear on first glance. 2) Performance. We care about it. So even in code that isn't known to be hot (though all of the bytecode generator is hot and is subject to continuous interest from the standpoint of optimization), we aim to write the code in a way that will be naturally performant especially if it's super easy to do so - like making sure that the second branch isn't taken if the first one is (by using "else"). 757123 9 valery.ignatyev 2012-11-02 05:27:15 -0700 ping 765815 10 bfulgham 2012-11-13 10:58:09 -0800 This patch looks good to me. Filip, is there anything else you want to see before this is approved? 766667 11 168242 webkit.review.bot 2012-11-14 02:31:07 -0800 Comment on attachment 168242 fixed patch Rejecting attachment 168242 from commit-queue. valery.ignatyev@ispras.ru does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 767098 12 bfulgham 2012-11-14 11:26:35 -0800 Committed r134634: <http://trac.webkit.org/changeset/134634> 767100 13 bfulgham 2012-11-14 11:27:24 -0800 I have committed the change; please watch the build bots for any test failures created by this change. 767101 14 bfulgham 2012-11-14 11:28:20 -0800 Out of curiosity, did you run any profiling to see what benefit this provided? It would be nice to document them in this bug. 767903 15 valery.ignatyev 2012-11-15 03:28:54 -0800 Generally, this patch is only the first part of 'typeof' support in DFG, which I'am trying to implement in the bug https://bugs.webkit.org/show_bug.cgi?id=98898 , but still have no final success. I have separated this part not only by sense, but to familiarize with your patch contributing procedures. We are working on performance improvement of customer's set of tests and this patch allows to use DFG on several functions. It gives 40% speedup on that tests. I can provide only reduced examples if it's necessary. 167986 2012-10-10 06:15:09 -0700 2012-10-11 05:44:04 -0700 patch with fix typeof_p1.patch text/plain 1958 valery.ignatyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGYxMjJjN2UuLjg3OGViOTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTEwICBWYWxlcnkgSWduYXR5 ZXYgIDx2YWxlcnkuaWduYXR5ZXZAaXNwcmFzLnJ1PgorCisgICAgICAgIFJlcGxhY2UgKHR5cGVv Zih4KSAhPSA8Im9iamVjdCIsICJ1bmRlZmluZWQiLCAuLi4+KSB3aXRoCisgICAgICAgICEodHlw ZW9mKHgpID09IDwib2JqZWN0IiwuLj4pLiBMYXRlciBpc19vYmplY3QsIGlzXzwuLi4+ICBieXRl Y29kZSBvcGVyYXRpb24KKyAgICAgICAgd2lsbCBiZSB1c2VkLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODg5MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZWxpbWluYXRlcyBleHBlbnNpdmUg IHR5cGVvZiBpbXBsZW1lbnRhdGlvbiBhbmQKKyAgICAgICAgYWxsb3dzIHRvIHVzZSBERkcgb3B0 aW1pemF0aW9ucywgd2hpY2ggZG9lc24ndCBzdXBwb3J0ICd0eXBlb2YnLgorCisgICAgICAgICog Ynl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6OkJpbmFyeU9wTm9k ZTo6ZW1pdEJ5dGVjb2RlKToKKwogMjAxMi0xMC0xMCAgUGV0ZXIgR2FsICA8Z2FscGV0ZXJAaW5m LnUtc3plZ2VkLmh1PgogCiAgICAgICAgIEFkZCBtb3ZlRG91YmxlVG9JbnRzIGFuZCBtb3ZlSW50 c1RvRG91YmxlIHRvIE1hY3JvQXNzZW1ibGVyQVJNCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAKaW5kZXggMGFjNDE0OS4uNjY3ZDc4 MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0Nv ZGVnZW4uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXND b2RlZ2VuLmNwcApAQCAtMTA1Myw2ICsxMDUzLDExIEBAIFJlZ2lzdGVySUQqIEJpbmFyeU9wTm9k ZTo6ZW1pdEJ5dGVjb2RlKEJ5dGVjb2RlR2VuZXJhdG9yJiBnZW5lcmF0b3IsIFJlZ2lzdGVySUQq CiAKICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gc3JjMSA9IGdlbmVyYXRvci5lbWl0Tm9kZUZvckxl ZnRIYW5kU2lkZShtX2V4cHIxLCBtX3JpZ2h0SGFzQXNzaWdubWVudHMsIG1fZXhwcjItPmlzUHVy ZShnZW5lcmF0b3IpKTsKICAgICBSZWdpc3RlcklEKiBzcmMyID0gZ2VuZXJhdG9yLmVtaXROb2Rl KG1fZXhwcjIpOworICAgIGlmIChnZW5lcmF0b3IubV9sYXN0T3Bjb2RlSUQgPT0gb3BfdHlwZW9m KSB7CisgICAgICAgIFJlZlB0cjxSZWdpc3RlcklEPiB0bXAgPSBnZW5lcmF0b3IudGVtcERlc3Rp bmF0aW9uKGRzdCk7CisgICAgICAgIGdlbmVyYXRvci5lbWl0RXF1YWxpdHlPcChvcF9lcSwgZ2Vu ZXJhdG9yLmZpbmFsRGVzdGluYXRpb24odG1wLmdldCgpLCBzcmMxLmdldCgpKSwgc3JjMS5nZXQo KSwgc3JjMik7CisgICAgICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdFVuYXJ5T3Aob3Bfbm90LCBn ZW5lcmF0b3IuZmluYWxEZXN0aW5hdGlvbihkc3QsIHRtcC5nZXQoKSksIHRtcC5nZXQoKSk7Cisg ICAgfQogICAgIHJldHVybiBnZW5lcmF0b3IuZW1pdEJpbmFyeU9wKG9wY29kZUlELCBnZW5lcmF0 b3IuZmluYWxEZXN0aW5hdGlvbihkc3QsIHNyYzEuZ2V0KCkpLCBzcmMxLmdldCgpLCBzcmMyLCBP cGVyYW5kVHlwZXMobV9leHByMS0+cmVzdWx0RGVzY3JpcHRvcigpLCBtX2V4cHIyLT5yZXN1bHRE ZXNjcmlwdG9yKCkpKTsKIH0KIAo= 168201 2012-10-11 05:44:04 -0700 2012-10-11 09:36:28 -0700 patch second attempt typeof_p1.patch text/plain 2185 valery.ignatyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNlNmVmNjYuLjIxZDNjMzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTExICBWYWxlcnkgSWduYXR5 ZXYgIDx2YWxlcnkuaWduYXR5ZXZAaXNwcmFzLnJ1PgorCisgICAgICAgIFJlcGxhY2UgKHR5cGVv Zih4KSAhPSA8Im9iamVjdCIsICJ1bmRlZmluZWQiLCAuLi4+KSB3aXRoCisgICAgICAgICEodHlw ZW9mKHgpID09IDwib2JqZWN0IiwuLj4pLiBMYXRlciBpc19vYmplY3QsIGlzXzwuLi4+ICBieXRl Y29kZSBvcGVyYXRpb24KKyAgICAgICAgd2lsbCBiZSB1c2VkLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODg5MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZWxpbWluYXRlcyBleHBlbnNpdmUg IHR5cGVvZiBpbXBsZW1lbnRhdGlvbiBhbmQKKyAgICAgICAgYWxsb3dzIHRvIHVzZSBERkcgb3B0 aW1pemF0aW9ucywgd2hpY2ggZG9lc24ndCBzdXBwb3J0ICd0eXBlb2YnLgorCisgICAgICAgICog Ynl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6OkJpbmFyeU9wTm9k ZTo6ZW1pdEJ5dGVjb2RlKToKKwogMjAxMi0xMC0xMCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBQYWdlbG9hZCB0ZXN0cyBzaG91bGQgbWVhc3VyZSBtZW1v cnkgdXNhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIv Tm9kZXNDb2RlZ2VuLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9k ZXNDb2RlZ2VuLmNwcAppbmRleCAwYWM0MTQ5Li4yMDM0ZDI5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCkBAIC0xMDUzLDYg KzEwNTMsMTQgQEAgUmVnaXN0ZXJJRCogQmluYXJ5T3BOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNv ZGVHZW5lcmF0b3ImIGdlbmVyYXRvciwgUmVnaXN0ZXJJRCoKIAogICAgIFJlZlB0cjxSZWdpc3Rl cklEPiBzcmMxID0gZ2VuZXJhdG9yLmVtaXROb2RlRm9yTGVmdEhhbmRTaWRlKG1fZXhwcjEsIG1f cmlnaHRIYXNBc3NpZ25tZW50cywgbV9leHByMi0+aXNQdXJlKGdlbmVyYXRvcikpOwogICAgIFJl Z2lzdGVySUQqIHNyYzIgPSBnZW5lcmF0b3IuZW1pdE5vZGUobV9leHByMik7CisgICAgaWYgKGdl bmVyYXRvci5tX2xhc3RPcGNvZGVJRCA9PSBvcF90eXBlb2YgJiYgKG9wY29kZUlEID09IG9wX25l cSB8fCBvcGNvZGVJRCA9PSBvcF9uc3RyaWN0ZXEpKSB7CisgICAgICAgIFJlZlB0cjxSZWdpc3Rl cklEPiB0bXAgPSBnZW5lcmF0b3IudGVtcERlc3RpbmF0aW9uKGRzdCk7CisgICAgICAgIGlmIChv cGNvZGVJRCA9PSBvcF9uZXEpCisgICAgICAgICAgICBnZW5lcmF0b3IuZW1pdEVxdWFsaXR5T3Ao b3BfZXEsIGdlbmVyYXRvci5maW5hbERlc3RpbmF0aW9uKHRtcC5nZXQoKSwgc3JjMS5nZXQoKSks IHNyYzEuZ2V0KCksIHNyYzIpOworICAgICAgICBpZiAob3Bjb2RlSUQgPT0gb3BfbnN0cmljdGVx KQorICAgICAgICAgICAgZ2VuZXJhdG9yLmVtaXRFcXVhbGl0eU9wKG9wX3N0cmljdGVxLCBnZW5l cmF0b3IuZmluYWxEZXN0aW5hdGlvbih0bXAuZ2V0KCksIHNyYzEuZ2V0KCkpLCBzcmMxLmdldCgp LCBzcmMyKTsKKyAgICAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0VW5hcnlPcChvcF9ub3QsIGdl bmVyYXRvci5maW5hbERlc3RpbmF0aW9uKGRzdCwgdG1wLmdldCgpKSwgdG1wLmdldCgpKTsKKyAg ICB9CiAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0QmluYXJ5T3Aob3Bjb2RlSUQsIGdlbmVyYXRv ci5maW5hbERlc3RpbmF0aW9uKGRzdCwgc3JjMS5nZXQoKSksIHNyYzEuZ2V0KCksIHNyYzIsIE9w ZXJhbmRUeXBlcyhtX2V4cHIxLT5yZXN1bHREZXNjcmlwdG9yKCksIG1fZXhwcjItPnJlc3VsdERl c2NyaXB0b3IoKSkpOwogfQogCg== 168242 2012-10-11 09:36:28 -0700 2022-02-27 23:26:35 -0800 fixed patch typeof_p1.patch text/plain 2239 valery.ignatyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGNlNmVmNjYuLjIxZDNjMzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTExICBWYWxlcnkgSWduYXR5 ZXYgIDx2YWxlcnkuaWduYXR5ZXZAaXNwcmFzLnJ1PgorCisgICAgICAgIFJlcGxhY2UgKHR5cGVv Zih4KSAhPSA8Im9iamVjdCIsICJ1bmRlZmluZWQiLCAuLi4+KSB3aXRoCisgICAgICAgICEodHlw ZW9mKHgpID09IDwib2JqZWN0IiwuLj4pLiBMYXRlciBpc19vYmplY3QsIGlzXzwuLi4+ICBieXRl Y29kZSBvcGVyYXRpb24KKyAgICAgICAgd2lsbCBiZSB1c2VkLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05ODg5MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZWxpbWluYXRlcyBleHBlbnNpdmUg IHR5cGVvZiBpbXBsZW1lbnRhdGlvbiBhbmQKKyAgICAgICAgYWxsb3dzIHRvIHVzZSBERkcgb3B0 aW1pemF0aW9ucywgd2hpY2ggZG9lc24ndCBzdXBwb3J0ICd0eXBlb2YnLgorCisgICAgICAgICog Ynl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6OkJpbmFyeU9wTm9k ZTo6ZW1pdEJ5dGVjb2RlKToKKwogMjAxMi0xMC0xMCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBQYWdlbG9hZCB0ZXN0cyBzaG91bGQgbWVhc3VyZSBtZW1v cnkgdXNhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIv Tm9kZXNDb2RlZ2VuLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9k ZXNDb2RlZ2VuLmNwcAppbmRleCAwYWM0MTQ5Li4yMDM0ZDI5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCkBAIC0xMDUzLDYg KzEwNTMsMTYgQEAgUmVnaXN0ZXJJRCogQmluYXJ5T3BOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNv ZGVHZW5lcmF0b3ImIGdlbmVyYXRvciwgUmVnaXN0ZXJJRCoKIAogICAgIFJlZlB0cjxSZWdpc3Rl cklEPiBzcmMxID0gZ2VuZXJhdG9yLmVtaXROb2RlRm9yTGVmdEhhbmRTaWRlKG1fZXhwcjEsIG1f cmlnaHRIYXNBc3NpZ25tZW50cywgbV9leHByMi0+aXNQdXJlKGdlbmVyYXRvcikpOwogICAgIFJl Z2lzdGVySUQqIHNyYzIgPSBnZW5lcmF0b3IuZW1pdE5vZGUobV9leHByMik7CisgICAgaWYgKGdl bmVyYXRvci5tX2xhc3RPcGNvZGVJRCA9PSBvcF90eXBlb2YgJiYgKG9wY29kZUlEID09IG9wX25l cSB8fCBvcGNvZGVJRCA9PSBvcF9uc3RyaWN0ZXEpKSB7CisgICAgICAgIFJlZlB0cjxSZWdpc3Rl cklEPiB0bXAgPSBnZW5lcmF0b3IudGVtcERlc3RpbmF0aW9uKGRzdCk7CisgICAgICAgIGlmIChv cGNvZGVJRCA9PSBvcF9uZXEpCisgICAgICAgICAgICBnZW5lcmF0b3IuZW1pdEVxdWFsaXR5T3Ao b3BfZXEsIGdlbmVyYXRvci5maW5hbERlc3RpbmF0aW9uKHRtcC5nZXQoKSwgc3JjMS5nZXQoKSks IHNyYzEuZ2V0KCksIHNyYzIpOworICAgICAgICBlbHNlIGlmIChvcGNvZGVJRCA9PSBvcF9uc3Ry aWN0ZXEpCisgICAgICAgICAgICBnZW5lcmF0b3IuZW1pdEVxdWFsaXR5T3Aob3Bfc3RyaWN0ZXEs IGdlbmVyYXRvci5maW5hbERlc3RpbmF0aW9uKHRtcC5nZXQoKSwgc3JjMS5nZXQoKSksIHNyYzEu Z2V0KCksIHNyYzIpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNI RUQoKTsKKyAgICAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0VW5hcnlPcChvcF9ub3QsIGdlbmVy YXRvci5maW5hbERlc3RpbmF0aW9uKGRzdCwgdG1wLmdldCgpKSwgdG1wLmdldCgpKTsKKyAgICB9 CiAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0QmluYXJ5T3Aob3Bjb2RlSUQsIGdlbmVyYXRvci5m aW5hbERlc3RpbmF0aW9uKGRzdCwgc3JjMS5nZXQoKSksIHNyYzEuZ2V0KCksIHNyYzIsIE9wZXJh bmRUeXBlcyhtX2V4cHIxLT5yZXN1bHREZXNjcmlwdG9yKCksIG1fZXhwcjItPnJlc3VsdERlc2Ny aXB0b3IoKSkpOwogfQogCg==