98890 2012-10-10 05:45:34 -0700 EventHandler::handleGestureLongPress breaks compilation if CONTEXT_MENUS isn't set 2012-10-10 11:08:56 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 luciano.wolf luciano.wolf cmarcelo dglazkov peter+ews webkit.review.bot oldest_to_newest 738872 0 luciano.wolf 2012-10-10 05:45:34 -0700 If CONTEXT_MENU isn't enabled there will be a call to "sendContextMenuEventForGesture(gestureEvent);" that is wrapped with "#if ENABLE(CONTEXT_MENU)" and the code won't compile. 738875 1 167984 luciano.wolf 2012-10-10 05:53:46 -0700 Created attachment 167984 Proposed patch Enable EventHandler::handleGestureLongPress only if CONTEXT_MENU is set 738877 2 167984 buildbot 2012-10-10 05:58:30 -0700 Comment on attachment 167984 Proposed patch Attachment 167984 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14238708 738878 3 167984 webkit.review.bot 2012-10-10 05:59:31 -0700 Comment on attachment 167984 Proposed patch Attachment 167984 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14248495 738879 4 167984 webkit-ews 2012-10-10 06:00:42 -0700 Comment on attachment 167984 Proposed patch Attachment 167984 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14245514 738880 5 167984 webkit-ews 2012-10-10 06:00:52 -0700 Comment on attachment 167984 Proposed patch Attachment 167984 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14252183 738883 6 167984 peter+ews 2012-10-10 06:06:14 -0700 Comment on attachment 167984 Proposed patch Attachment 167984 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14245517 738902 7 167984 cmarcelo 2012-10-10 06:31:59 -0700 Comment on attachment 167984 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=167984&action=review > Source/WebCore/page/EventHandler.cpp:2573 > +#if ENABLE(CONTEXT_MENU) This ifdef is in the wrong place. Shouldn't it be protecting the sendContextMenuEventForGesture() call? 738948 8 167997 luciano.wolf 2012-10-10 07:46:54 -0700 Created attachment 167997 Another proposed patch 738979 9 luciano.wolf 2012-10-10 08:37:11 -0700 (In reply to comment #7) > (From update of attachment 167984 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=167984&action=review > > > Source/WebCore/page/EventHandler.cpp:2573 > > +#if ENABLE(CONTEXT_MENU) > > This ifdef is in the wrong place. Shouldn't it be protecting the sendContextMenuEventForGesture() call? But in this case we've to return something. If you're not ANDROID the only line remaining is this sendContextMenuEventForGesture(). Should we just return "false" (after moving ENABLE(CONTEXT_MENUS) to the proper place)? 738989 10 167984 cmarcelo 2012-10-10 08:48:22 -0700 Comment on attachment 167984 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=167984&action=review >>> Source/WebCore/page/EventHandler.cpp:2573 >>> +#if ENABLE(CONTEXT_MENU) >> >> This ifdef is in the wrong place. Shouldn't it be protecting the sendContextMenuEventForGesture() call? > > But in this case we've to return something. If you're not ANDROID the only line remaining is this sendContextMenuEventForGesture(). Should we just return "false" (after moving ENABLE(CONTEXT_MENUS) to the proper place)? Yes. But sendContextMenuEventForGesture() is only declared if we have CONTEXT_MENUS (see EventHandler.h), so you need to guard it. My understanding from the event handling is that if it's not defined you can simply return false here. So add an else case for the #if ENABLE(CONTEXT_MENUS) returning false should be enough. 739005 11 168010 luciano.wolf 2012-10-10 09:11:50 -0700 Created attachment 168010 Another proposed patch 739038 12 168010 cmarcelo 2012-10-10 09:48:17 -0700 Comment on attachment 168010 Another proposed patch Let's wait the EWS just in case :-) 739043 13 168020 luciano.wolf 2012-10-10 09:54:22 -0700 Created attachment 168020 Patch for landing 739047 14 168022 luciano.wolf 2012-10-10 10:03:48 -0700 Created attachment 168022 Patch for landing 739111 15 168022 webkit.review.bot 2012-10-10 10:50:01 -0700 Comment on attachment 168022 Patch for landing Rejecting attachment 168022 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: it2/ChangeLog Auto-merging Source/WebKit2/win/WebKit2.def Failed to merge in the changes. Patch failed at 0001 Needs internal API to return distributed nodes for InsertionPoint When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14260093 739142 16 cmarcelo 2012-10-10 11:08:56 -0700 Committed r130930: <http://trac.webkit.org/changeset/130930> 167984 2012-10-10 05:53:46 -0700 2012-10-10 08:48:22 -0700 Proposed patch bug-98890-20121010095245.patch text/plain 1619 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzY4Y2ViZjMwZjVkMWMy MWQwZDg2M2E4MDhjMTE3MGE0OTEzNmI3MS4uNzFlY2JlYzgwYjNkZmI0OTBhZjQxZDZjMjEyMGRj YTg5Yzk1YjA2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTEwICBMdWNp YW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBFdmVudEhh bmRsZXI6OmhhbmRsZUdlc3R1cmVMb25nUHJlc3MgYnJlYWtzIGNvbXBpbGF0aW9uIGlmIENPTlRF WFRfTUVOVSBpc24ndCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk4ODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRW5hYmxlIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUxvbmdQcmVzcyBvbmx5 IGlmIENPTlRFWFRfTUVOVSBpcyBzZXQuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0xMC0xMCAgS2Vpc2hpIEhhdHRvcmkgIDxr ZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTI5NzM4KTogQ2FsZW5k YXIgcGlja2VyIGlzIHRvbyB3aWRlIHdoZW4gdGhlIGlucHV0IGlzIHJ0bApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDJkY2Q0MmMxZDU3YzFhNTU1MTNlZjI3ZGUxYTc5MWMx NDQzYTQ1ODMuLjY1NjNlNzk4MmZkMmQ4NThiODNiZWIwM2YyYjI4YjdhOThiOTUyNmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTI1NzAsNiArMjU3MCw3IEBAIGJvb2wg RXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlVGFwKGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50 JiBnZXN0dXJlRXZlbnQpCiAgICAgcmV0dXJuIGRlZmF1bHRQcmV2ZW50ZWQ7CiB9CiAKKyNpZiBF TkFCTEUoQ09OVEVYVF9NRU5VKQogYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVMb25n UHJlc3MoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmVudCkKIHsKICNpZiBP UyhBTkRST0lEKQpAQCAtMjU4NCw2ICsyNTg1LDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRs ZUdlc3R1cmVMb25nUHJlc3MoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmUK ICNlbmRpZgogICAgIHJldHVybiBzZW5kQ29udGV4dE1lbnVFdmVudEZvckdlc3R1cmUoZ2VzdHVy ZUV2ZW50KTsKIH0KKyNlbmRpZiAvLyBFTkFCTEUoQ09OVEVYVF9NRU5VKQogCiBib29sIEV2ZW50 SGFuZGxlcjo6aGFuZGxlR2VzdHVyZVNjcm9sbFVwZGF0ZShjb25zdCBQbGF0Zm9ybUdlc3R1cmVF dmVudCYgZ2VzdHVyZUV2ZW50KQogewo= 167997 2012-10-10 07:46:54 -0700 2012-10-10 07:53:57 -0700 Another proposed patch bug-98890-20121010114553.patch text/plain 2750 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzY4Y2ViZjMwZjVkMWMy MWQwZDg2M2E4MDhjMTE3MGE0OTEzNmI3MS4uZDY2MGNmOWE1ZTM4OWE5YTI2ZWMwNDEzNjg4N2E2 M2M2MmM5MThhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEwLTEwICBMdWNp YW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBFdmVudEhh bmRsZXI6OmhhbmRsZUdlc3R1cmVMb25nUHJlc3MgYnJlYWtzIGNvbXBpbGF0aW9uIGlmIENPTlRF WFRfTUVOVSBpc24ndCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk4ODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVu dEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVFdmVudCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAg ICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorICAgICAgICAoRXZlbnRIYW5kbGVyKToKKwogMjAx Mi0xMC0xMCAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBS RUdSRVNTSU9OIChyMTI5NzM4KTogQ2FsZW5kYXIgcGlja2VyIGlzIHRvbyB3aWRlIHdoZW4gdGhl IGlucHV0IGlzIHJ0bApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDJkY2Q0 MmMxZDU3YzFhNTU1MTNlZjI3ZGUxYTc5MWMxNDQzYTQ1ODMuLjdmNDAyZjdmMDQ2OGUzNTYxNjgz MDA4ZjA0YmFjNWI2ZTRmMTZlOTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAK QEAgLTI1MjEsOCArMjUyMSwxMCBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUV2 ZW50KGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50JiBnZXN0dXJlRXZlbnQpCiAgICAgICAgIHJl dHVybiBoYW5kbGVHZXN0dXJlVGFwKGdlc3R1cmVFdmVudCk7CiAgICAgY2FzZSBQbGF0Zm9ybUV2 ZW50OjpHZXN0dXJlVGFwRG93bjoKICAgICAgICAgcmV0dXJuIGhhbmRsZUdlc3R1cmVUYXBEb3du KCk7CisjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpH ZXN0dXJlTG9uZ1ByZXNzOgogICAgICAgICByZXR1cm4gaGFuZGxlR2VzdHVyZUxvbmdQcmVzcyhn ZXN0dXJlRXZlbnQpOworI2VuZGlmCiAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlRG91 YmxlVGFwOgogICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6R2VzdHVyZVBpbmNoQmVnaW46CiAgICAg Y2FzZSBQbGF0Zm9ybUV2ZW50OjpHZXN0dXJlUGluY2hFbmQ6CkBAIC0yNTcwLDYgKzI1NzIsNyBA QCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZVRhcChjb25zdCBQbGF0Zm9ybUdlc3R1 cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogICAgIHJldHVybiBkZWZhdWx0UHJldmVudGVkOwogfQog CisjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCiBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2Vz dHVyZUxvbmdQcmVzcyhjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQog ewogI2lmIE9TKEFORFJPSUQpCkBAIC0yNTg0LDYgKzI1ODcsNyBAQCBib29sIEV2ZW50SGFuZGxl cjo6aGFuZGxlR2VzdHVyZUxvbmdQcmVzcyhjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2Vz dHVyZUV2ZQogI2VuZGlmCiAgICAgcmV0dXJuIHNlbmRDb250ZXh0TWVudUV2ZW50Rm9yR2VzdHVy ZShnZXN0dXJlRXZlbnQpOwogfQorI2VuZGlmIC8vIEVOQUJMRShDT05URVhUX01FTlVTKQogCiBi b29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZVNjcm9sbFVwZGF0ZShjb25zdCBQbGF0Zm9y bUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9FdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy LmgKaW5kZXggYTYwNGRhMmM4NDBlMzIxYjZkN2QxYzg1MTAyMjU5NzJkYThiMTg4YS4uN2M5YzA5 MTUwYWJlZTU3OTg5YzQ3YmM5ZDNmNTA5MzgyNTUyNjg1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5oCkBAIC0xNjcsNyArMTY3LDkgQEAgcHVibGljOgogI2lmIEVOQUJMRShHRVNUVVJF X0VWRU5UUykKICAgICBib29sIGhhbmRsZUdlc3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1 cmVFdmVudCYpOwogICAgIGJvb2wgaGFuZGxlR2VzdHVyZVRhcChjb25zdCBQbGF0Zm9ybUdlc3R1 cmVFdmVudCYpOworI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQogICAgIGJvb2wgaGFuZGxlR2Vz dHVyZUxvbmdQcmVzcyhjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYpOworI2VuZGlmCiAgICAg Ym9vbCBoYW5kbGVHZXN0dXJlU2Nyb2xsVXBkYXRlKGNvbnN0IFBsYXRmb3JtR2VzdHVyZUV2ZW50 Jik7CiAjZW5kaWYKIAo= 168010 2012-10-10 09:11:50 -0700 2012-10-10 09:54:17 -0700 Another proposed patch bug-98890-20121010131049.patch text/plain 1348 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYzY2M4NTQ0YzMyMzNi NTIwZmZmYzc1NmQxNmI2YjMyYzIyMzEyOC4uODkzOTJhNzhlYzVlMGI1ZWQ3NzQwNGQ5NjRhZWJi MjcyMGM1NWZkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTEwICBMdWNp YW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBFdmVudEhh bmRsZXI6OmhhbmRsZUdlc3R1cmVMb25nUHJlc3MgYnJlYWtzIGNvbXBpbGF0aW9uIGlmIENPTlRF WFRfTUVOVSBpc24ndCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk4ODkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVu dEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVMb25nUHJlc3MpOgorCiAyMDEyLTEwLTEwICBNaWtlIFdl c3QgIDxta3dzdEBnb29nbGUuY29tPgogCiAgICAgICAgIEVkaXRvckNvbW1hbmQgY2FsbHMgc2V0 UHJvcGVydHkgd2l0aCB0aGUgd3JvbmcgcGFyYW1ldGVycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRI YW5kbGVyLmNwcAppbmRleCAyZGNkNDJjMWQ1N2MxYTU1NTEzZWYyN2RlMWE3OTFjMTQ0M2E0NTgz Li45OWQ5OWRmNzY0NGIwOWE5NTNiZTAwYWZiZjBjZDJiZWU3NmZkODgzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuY3BwCkBAIC0yNTgyLDcgKzI1ODIsMTEgQEAgYm9vbCBFdmVudEhh bmRsZXI6OmhhbmRsZUdlc3R1cmVMb25nUHJlc3MoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQm IGdlc3R1cmVFdmUKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KICNlbmRpZgorI2lm IEVOQUJMRShDT05URVhUX01FTlVTKQogICAgIHJldHVybiBzZW5kQ29udGV4dE1lbnVFdmVudEZv ckdlc3R1cmUoZ2VzdHVyZUV2ZW50KTsKKyNlbHNlCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlm CiB9CiAKIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlU2Nyb2xsVXBkYXRlKGNvbnN0 IFBsYXRmb3JtR2VzdHVyZUV2ZW50JiBnZXN0dXJlRXZlbnQpCg== 168020 2012-10-10 09:54:22 -0700 2012-10-10 10:03:43 -0700 Patch for landing bug-98890-20121010135321.patch text/plain 1364 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYzY2M4NTQ0YzMyMzNi NTIwZmZmYzc1NmQxNmI2YjMyYzIyMzEyOC4uNDIwMmUyNGMzNTEyN2E3OWM3MWJkMTNkZWI0YTJj NGNlNzIwZGQzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTEwICBMdWNp YW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBFdmVudEhh bmRsZXI6OmhhbmRsZUdlc3R1cmVMb25nUHJlc3MgYnJlYWtzIGNvbXBpbGF0aW9uIGlmIENPTlRF WFRfTUVOVVMgaXNuJ3Qgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05ODg5MAorCisgICAgICAgIFJldmlld2VkIGJ5IENhaW8gTWFyY2VsbyBkZSBP bGl2ZWlyYSBGaWxobworCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlTG9uZ1ByZXNzKToKKwogMjAx Mi0xMC0xMCAgTWlrZSBXZXN0ICA8bWt3c3RAZ29vZ2xlLmNvbT4KIAogICAgICAgICBFZGl0b3JD b21tYW5kIGNhbGxzIHNldFByb3BlcnR5IHdpdGggdGhlIHdyb25nIHBhcmFtZXRlcnMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggMmRjZDQyYzFkNTdjMWE1NTUxM2VmMjdk ZTFhNzkxYzE0NDNhNDU4My4uOTlkOTlkZjc2NDRiMDlhOTUzYmUwMGFmYmYwY2QyYmVlNzZmZDg4 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMjU4Miw3ICsyNTgyLDEx IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVHZXN0dXJlTG9uZ1ByZXNzKGNvbnN0IFBsYXRm b3JtR2VzdHVyZUV2ZW50JiBnZXN0dXJlRXZlCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICB9CiAjZW5kaWYKKyNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKICAgICByZXR1cm4gc2VuZENv bnRleHRNZW51RXZlbnRGb3JHZXN0dXJlKGdlc3R1cmVFdmVudCk7CisjZWxzZQorICAgIHJldHVy biBmYWxzZTsKKyNlbmRpZgogfQogCiBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZVNj cm9sbFVwZGF0ZShjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZW50KQo= 168022 2012-10-10 10:03:48 -0700 2012-10-10 10:50:01 -0700 Patch for landing bug-98890-20121010140247.patch text/plain 1365 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYzY2M4NTQ0YzMyMzNi NTIwZmZmYzc1NmQxNmI2YjMyYzIyMzEyOC4uMzIxYWRiYjgzNjA3YWMyNWFmY2U1MWY0MGVmZDAy NWMwNjNjYmEyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEwLTEwICBMdWNp YW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBFdmVudEhh bmRsZXI6OmhhbmRsZUdlc3R1cmVMb25nUHJlc3MgYnJlYWtzIGNvbXBpbGF0aW9uIGlmIENPTlRF WFRfTUVOVVMgaXNuJ3Qgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05ODg5MAorCisgICAgICAgIFJldmlld2VkIGJ5IENhaW8gTWFyY2VsbyBkZSBP bGl2ZWlyYSBGaWxoby4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUxvbmdQcmVzcyk6CisKIDIw MTItMTAtMTAgIE1pa2UgV2VzdCAgPG1rd3N0QGdvb2dsZS5jb20+CiAKICAgICAgICAgRWRpdG9y Q29tbWFuZCBjYWxscyBzZXRQcm9wZXJ0eSB3aXRoIHRoZSB3cm9uZyBwYXJhbWV0ZXJzLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dl YkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCmluZGV4IDJkY2Q0MmMxZDU3YzFhNTU1MTNlZjI3 ZGUxYTc5MWMxNDQzYTQ1ODMuLjk5ZDk5ZGY3NjQ0YjA5YTk1M2JlMDBhZmJmMGNkMmJlZTc2ZmQ4 ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTI1ODIsNyArMjU4Miwx MSBAQCBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlR2VzdHVyZUxvbmdQcmVzcyhjb25zdCBQbGF0 Zm9ybUdlc3R1cmVFdmVudCYgZ2VzdHVyZUV2ZQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAg ICAgfQogI2VuZGlmCisjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCiAgICAgcmV0dXJuIHNlbmRD b250ZXh0TWVudUV2ZW50Rm9yR2VzdHVyZShnZXN0dXJlRXZlbnQpOworI2Vsc2UKKyAgICByZXR1 cm4gZmFsc2U7CisjZW5kaWYKIH0KIAogYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVT Y3JvbGxVcGRhdGUoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmVudCkK