98888 2012-10-10 05:26:50 -0700 [Qt][WK2] REGRESSION(r130879): It made fast/events/touch/* tests crash 2012-10-10 06:44:07 -0700 1 1 1 Unclassified WebKit New Bugs 420+ All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 79668 98642 1 ossy abecsi abecsi jturcotte kenneth ossy webkit.review.bot oldest_to_newest 738859 0 ossy 2012-10-10 05:26:50 -0700 It is ridiculous that fixing a "regression caused one fail" caused 6 crashes. But now it happened, see this URL for details: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/9585 738862 1 abecsi 2012-10-10 05:31:37 -0700 That's what I was afraid of. Looks like an early return is missing somewhere, I'm going to take a look. 738864 2 ossy 2012-10-10 05:33:20 -0700 just a note: I prefer early testing ;-) (before commiting buggy patches) 738892 3 167988 jturcotte 2012-10-10 06:24:01 -0700 Created attachment 167988 Patch Hopefully that is the last iteration, this is getting pretty embarassing. 738908 4 167988 webkit.review.bot 2012-10-10 06:44:03 -0700 Comment on attachment 167988 Patch Clearing flags on attachment: 167988 Committed r130894: <http://trac.webkit.org/changeset/130894> 738909 5 webkit.review.bot 2012-10-10 06:44:07 -0700 All reviewed patches have been landed. Closing bug. 167988 2012-10-10 06:24:01 -0700 2012-10-10 06:44:03 -0700 Patch bug-98888-20121010152300.patch text/plain 6867 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjBlYzk3NjYzYWUwMzc0 Njg3ZTlmMTQ1NDkxNzlhMjU1OTZlZjdiMy4uYjcyZWFkYjQyY2FiYzExNjM0NWM4NGUwM2I4ZTY2 ZjFlMDQ0MjM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTEwICBKb2Nl bHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBkaWdpYS5jb20+CisKKyAgICAgICAgW1F0 XVtXSzJdIFJFR1JFU1NJT04ocjEzMDg3OSk6IEl0IG1hZGUgZmFzdC9ldmVudHMvdG91Y2gvKiB0 ZXN0cyBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTg4ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgbnVsbC1jaGVja3MgaW4gdGhlIGdlc3R1cmUgcmVjb2duaXplcnMgdG8gYWxsb3cgdGhl bSB3b3JraW5nIHdpdGhvdXQgYSBQYWdlVmlld3BvcnRDb250cm9sbGVyLgorICAgICAgICBUaGUg cGluY2ggYW5kIHBhbiBnZXN0dXJlIHJlY29nbml6ZXJzIGFyZW4ndCB1c2VkIGluIHRoYXQgY2Fz ZSB5ZXQsIGJ1dCB0aGV5IGNvdWxkIGV2ZW50dWFsbHkKKyAgICAgICAgYmUgdXNlZCB0byBzZW5k IHBpbmNoIGFuZCBwYW4gZ2VzdHVyZSBldmVudHMgdG8gdGhlIHdlYiBwcm9jZXNzLiBUaGV5IGFy ZSBjdXJyZW50bHkga2VwdCBhY3RpdmUKKyAgICAgICAgYmVjYXVzZSB3ZSBuZWVkIHRoZSB0YXAg Z2VzdHVyZSByZWNvZ25pemVyIGFuZCBpdHMgbG9naWMgaXMgYm91bmQgdG8gdGhvc2Ugb3RoZXIg cmVjb2duaXplcnMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRQYW5HZXN0dXJlUmVjb2du aXplci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0UGFuR2VzdHVyZVJlY29nbml6ZXI6OnVwZGF0 ZSk6CisgICAgICAgIChXZWJLaXQ6OlF0UGFuR2VzdHVyZVJlY29nbml6ZXI6OmZpbmlzaCk6Cisg ICAgICAgIChXZWJLaXQ6OlF0UGFuR2VzdHVyZVJlY29nbml6ZXI6OmNhbmNlbCk6CisgICAgICAg ICogVUlQcm9jZXNzL3F0L1F0UGluY2hHZXN0dXJlUmVjb2duaXplci5jcHA6CisgICAgICAgIChX ZWJLaXQ6OlF0UGluY2hHZXN0dXJlUmVjb2duaXplcjo6dXBkYXRlKToKKyAgICAgICAgKFdlYktp dDo6UXRQaW5jaEdlc3R1cmVSZWNvZ25pemVyOjpmaW5pc2gpOgorICAgICAgICAoV2ViS2l0OjpR dFBpbmNoR2VzdHVyZVJlY29nbml6ZXI6OmNhbmNlbCk6CisKIDIwMTItMTAtMDUgIEpvY2VseW4g VHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZp eCAiQVNTRVJUSU9OIEZBSUxFRDogIWRvY3VtZW50LT5pblBhZ2VDYWNoZSgpIiB3aGVuIGxvYWRp bmcgYSBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRQYW5H ZXN0dXJlUmVjb2duaXplci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRQYW5H ZXN0dXJlUmVjb2duaXplci5jcHAKaW5kZXggMGFhYTA2NjkwNGQ0OWEyYzYyOGYyYzQ2YmIyNTEw ZTJkZTY4OGRiOC4uYTljNGU3YTAwMjE3MDkxY2JjMTk3MjQ4NGU3MGQxM2JhNzE1YzNhOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFuR2VzdHVyZVJlY29nbml6 ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhbkdlc3R1cmVSZWNv Z25pemVyLmNwcApAQCAtMzgsOSArMzgsNiBAQCBRdFBhbkdlc3R1cmVSZWNvZ25pemVyOjpRdFBh bkdlc3R1cmVSZWNvZ25pemVyKFF0V2ViUGFnZUV2ZW50SGFuZGxlciogZXZlbnRIYW5kbAogCiBi b29sIFF0UGFuR2VzdHVyZVJlY29nbml6ZXI6OnVwZGF0ZShjb25zdCBRVG91Y2hFdmVudDo6VG91 Y2hQb2ludCYgdG91Y2hQb2ludCwgcWludDY0IGV2ZW50VGltZXN0YW1wTWlsbGlzKQogewotICAg IGlmICghdmlld3BvcnRDb250cm9sbGVyKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAg IG1fbGFzdFBvc2l0aW9uID0gdG91Y2hQb2ludC5wb3MoKTsKICAgICBtX2xhc3RFdmVudFRpbWVz dGFtcE1pbGxpcyA9IGV2ZW50VGltZXN0YW1wTWlsbGlzOwogCkBAIC00OCw3ICs0NSw4IEBAIGJv b2wgUXRQYW5HZXN0dXJlUmVjb2duaXplcjo6dXBkYXRlKGNvbnN0IFFUb3VjaEV2ZW50OjpUb3Vj aFBvaW50JiB0b3VjaFBvaW50LCBxCiAgICAgY2FzZSBOb0dlc3R1cmU6CiAgICAgICAgIG1fc3Rh dGUgPSBHZXN0dXJlUmVjb2duaXRpb25TdGFydGVkOwogICAgICAgICBtX2ZpcnN0U2NyZWVuUG9z aXRpb24gPSB0b3VjaFBvaW50LnNjcmVlblBvcygpOwotICAgICAgICB2aWV3cG9ydENvbnRyb2xs ZXIoKS0+Y2FuY2VsU2Nyb2xsQW5pbWF0aW9uKCk7CisgICAgICAgIGlmICh2aWV3cG9ydENvbnRy b2xsZXIoKSkKKyAgICAgICAgICAgIHZpZXdwb3J0Q29udHJvbGxlcigpLT5jYW5jZWxTY3JvbGxB bmltYXRpb24oKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGNhc2UgR2VzdHVyZVJlY29n bml0aW9uU3RhcnRlZDogewogICAgICAgICAvLyBUbyBzdGFydCB0aGUgZ2VzdHVyZSwgdGhlIGRl bHRhIGZyb20gc3RhcnQgaW4gc2NyZWVuIGNvb3JkaW5hdGVzCkBAIC01OCwxMSArNTYsMTMgQEAg Ym9vbCBRdFBhbkdlc3R1cmVSZWNvZ25pemVyOjp1cGRhdGUoY29uc3QgUVRvdWNoRXZlbnQ6OlRv dWNoUG9pbnQmIHRvdWNoUG9pbnQsIHEKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAg ICAgICBtX3N0YXRlID0gR2VzdHVyZVJlY29nbml6ZWQ7Ci0gICAgICAgIHZpZXdwb3J0Q29udHJv bGxlcigpLT5wYW5HZXN0dXJlU3RhcnRlZCh0b3VjaFBvaW50LnBvcygpLCBldmVudFRpbWVzdGFt cE1pbGxpcyk7CisgICAgICAgIGlmICh2aWV3cG9ydENvbnRyb2xsZXIoKSkKKyAgICAgICAgICAg IHZpZXdwb3J0Q29udHJvbGxlcigpLT5wYW5HZXN0dXJlU3RhcnRlZCh0b3VjaFBvaW50LnBvcygp LCBldmVudFRpbWVzdGFtcE1pbGxpcyk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KICAg ICBjYXNlIEdlc3R1cmVSZWNvZ25pemVkOgotICAgICAgICB2aWV3cG9ydENvbnRyb2xsZXIoKS0+ cGFuR2VzdHVyZVJlcXVlc3RVcGRhdGUodG91Y2hQb2ludC5wb3MoKSwgZXZlbnRUaW1lc3RhbXBN aWxsaXMpOworICAgICAgICBpZiAodmlld3BvcnRDb250cm9sbGVyKCkpCisgICAgICAgICAgICB2 aWV3cG9ydENvbnRyb2xsZXIoKS0+cGFuR2VzdHVyZVJlcXVlc3RVcGRhdGUodG91Y2hQb2ludC5w b3MoKSwgZXZlbnRUaW1lc3RhbXBNaWxsaXMpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBk ZWZhdWx0OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKQEAgLTc1LDggKzc1LDggQEAg dm9pZCBRdFBhbkdlc3R1cmVSZWNvZ25pemVyOjpmaW5pc2goY29uc3QgUVRvdWNoRXZlbnQ6OlRv dWNoUG9pbnQmIHRvdWNoUG9pbnQsIHEKICAgICBpZiAobV9zdGF0ZSA9PSBOb0dlc3R1cmUpCiAg ICAgICAgIHJldHVybjsKIAotICAgIEFTU0VSVCh2aWV3cG9ydENvbnRyb2xsZXIoKSk7Ci0gICAg dmlld3BvcnRDb250cm9sbGVyKCktPnBhbkdlc3R1cmVFbmRlZCh0b3VjaFBvaW50LnBvcygpLCBl dmVudFRpbWVzdGFtcE1pbGxpcyk7CisgICAgaWYgKHZpZXdwb3J0Q29udHJvbGxlcigpKQorICAg ICAgICB2aWV3cG9ydENvbnRyb2xsZXIoKS0+cGFuR2VzdHVyZUVuZGVkKHRvdWNoUG9pbnQucG9z KCksIGV2ZW50VGltZXN0YW1wTWlsbGlzKTsKICAgICByZXNldCgpOwogfQogCkBAIC04NSw4ICs4 NSwxMCBAQCB2b2lkIFF0UGFuR2VzdHVyZVJlY29nbml6ZXI6OmNhbmNlbCgpCiAgICAgaWYgKG1f c3RhdGUgPT0gTm9HZXN0dXJlKQogICAgICAgICByZXR1cm47CiAKLSAgICB2aWV3cG9ydENvbnRy b2xsZXIoKS0+cGFuR2VzdHVyZUVuZGVkKG1fbGFzdFBvc2l0aW9uLCBtX2xhc3RFdmVudFRpbWVz dGFtcE1pbGxpcyk7Ci0gICAgdmlld3BvcnRDb250cm9sbGVyKCktPnBhbkdlc3R1cmVDYW5jZWxs ZWQoKTsKKyAgICBpZiAodmlld3BvcnRDb250cm9sbGVyKCkpIHsKKyAgICAgICAgdmlld3BvcnRD b250cm9sbGVyKCktPnBhbkdlc3R1cmVFbmRlZChtX2xhc3RQb3NpdGlvbiwgbV9sYXN0RXZlbnRU aW1lc3RhbXBNaWxsaXMpOworICAgICAgICB2aWV3cG9ydENvbnRyb2xsZXIoKS0+cGFuR2VzdHVy ZUNhbmNlbGxlZCgpOworICAgIH0KICAgICByZXNldCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRQaW5jaEdlc3R1cmVSZWNvZ25pemVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBpbmNoR2VzdHVyZVJlY29nbml6ZXIuY3BwCmlu ZGV4IGExMDM2N2E0MGI1ZGY5M2QwMWU1Nzc1OTRmMjk0MDgyY2YyMDEzYzQuLjdmYTU4MDE0Zjdk YjRhZmNkNTQ5NmNkMzBkMThiYzQyNjI3ZTkyMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9xdC9RdFBpbmNoR2VzdHVyZVJlY29nbml6ZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBpbmNoR2VzdHVyZVJlY29nbml6ZXIuY3BwCkBAIC00OCw3 ICs0OCw2IEBAIFF0UGluY2hHZXN0dXJlUmVjb2duaXplcjo6UXRQaW5jaEdlc3R1cmVSZWNvZ25p emVyKFF0V2ViUGFnZUV2ZW50SGFuZGxlciogZXZlbnRICiAKIGJvb2wgUXRQaW5jaEdlc3R1cmVS ZWNvZ25pemVyOjp1cGRhdGUoY29uc3QgUVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQmIHBvaW50MSwg Y29uc3QgUVRvdWNoRXZlbnQ6OlRvdWNoUG9pbnQmIHBvaW50MikKIHsKLSAgICBBU1NFUlQodmll d3BvcnRDb250cm9sbGVyKCkpOwogICAgIGNvbnN0IHFyZWFsIGN1cnJlbnRGaW5nZXJEaXN0YW5j ZSA9IFFMaW5lRihwb2ludDEuc2NyZWVuUG9zKCksIHBvaW50Mi5zY3JlZW5Qb3MoKSkubGVuZ3Ro KCk7CiAgICAgc3dpdGNoIChtX3N0YXRlKSB7CiAgICAgY2FzZSBOb0dlc3R1cmU6CkBAIC02MCw3 ICs1OSw4IEBAIGJvb2wgUXRQaW5jaEdlc3R1cmVSZWNvZ25pemVyOjp1cGRhdGUoY29uc3QgUVRv dWNoRXZlbnQ6OlRvdWNoUG9pbnQmIHBvaW50MSwgY29uCiAgICAgICAgIGlmIChwaW5jaERpc3Rh bmNlIDwgcGluY2hJbml0aWFsVHJpZ2dlckRpc3RhbmNlVGhyZXNob2xkKQogICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwogICAgICAgICBtX3N0YXRlID0gR2VzdHVyZVJlY29nbml6ZWQ7Ci0gICAg ICAgIHZpZXdwb3J0Q29udHJvbGxlcigpLT5waW5jaEdlc3R1cmVTdGFydGVkKGNvbXB1dGVQaW5j aENlbnRlcihwb2ludDEsIHBvaW50MikpOworICAgICAgICBpZiAodmlld3BvcnRDb250cm9sbGVy KCkpCisgICAgICAgICAgICB2aWV3cG9ydENvbnRyb2xsZXIoKS0+cGluY2hHZXN0dXJlU3RhcnRl ZChjb21wdXRlUGluY2hDZW50ZXIocG9pbnQxLCBwb2ludDIpKTsKIAogICAgICAgICAvLyBXZSBy ZXNldCB0aGUgaW5pdGlhbCBzcGFuIGRpc3RhbmNlIHRvIHRoZSBjdXJyZW50IGRpc3RhbmNlIG9m IHRoZQogICAgICAgICAvLyB0b3VjaCBwb2ludHMgaW4gb3JkZXIgdG8gYXZvaWQgdGhlIGp1bXAg Y2F1c2VkIGJ5IHRoZSBldmVudHMgd2hpY2gKQEAgLTcyLDcgKzcyLDggQEAgYm9vbCBRdFBpbmNo R2VzdHVyZVJlY29nbml6ZXI6OnVwZGF0ZShjb25zdCBRVG91Y2hFdmVudDo6VG91Y2hQb2ludCYg cG9pbnQxLCBjb24KICAgICBjYXNlIEdlc3R1cmVSZWNvZ25pemVkOgogICAgICAgICBjb25zdCBx cmVhbCB0b3RhbFNjYWxlRmFjdG9yID0gY3VycmVudEZpbmdlckRpc3RhbmNlIC8gbV9pbml0aWFs RmluZ2VyRGlzdGFuY2U7CiAgICAgICAgIGNvbnN0IFFQb2ludEYgdG91Y2hDZW50ZXJJblZpZXdD b29yZGluYXRlcyA9IGNvbXB1dGVQaW5jaENlbnRlcihwb2ludDEsIHBvaW50Mik7Ci0gICAgICAg IHZpZXdwb3J0Q29udHJvbGxlcigpLT5waW5jaEdlc3R1cmVSZXF1ZXN0VXBkYXRlKHRvdWNoQ2Vu dGVySW5WaWV3Q29vcmRpbmF0ZXMsIHRvdGFsU2NhbGVGYWN0b3IpOworICAgICAgICBpZiAodmll d3BvcnRDb250cm9sbGVyKCkpCisgICAgICAgICAgICB2aWV3cG9ydENvbnRyb2xsZXIoKS0+cGlu Y2hHZXN0dXJlUmVxdWVzdFVwZGF0ZSh0b3VjaENlbnRlckluVmlld0Nvb3JkaW5hdGVzLCB0b3Rh bFNjYWxlRmFjdG9yKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIGJyZWFrOwogICAg IH0KQEAgLTg2LDggKzg3LDggQEAgdm9pZCBRdFBpbmNoR2VzdHVyZVJlY29nbml6ZXI6OmZpbmlz aCgpCiAgICAgaWYgKG1fc3RhdGUgPT0gTm9HZXN0dXJlKQogICAgICAgICByZXR1cm47CiAKLSAg ICBBU1NFUlQodmlld3BvcnRDb250cm9sbGVyKCkpOwotICAgIHZpZXdwb3J0Q29udHJvbGxlcigp LT5waW5jaEdlc3R1cmVFbmRlZCgpOworICAgIGlmICh2aWV3cG9ydENvbnRyb2xsZXIoKSkKKyAg ICAgICAgdmlld3BvcnRDb250cm9sbGVyKCktPnBpbmNoR2VzdHVyZUVuZGVkKCk7CiAgICAgcmVz ZXQoKTsKIH0KIApAQCAtOTYsOCArOTcsOCBAQCB2b2lkIFF0UGluY2hHZXN0dXJlUmVjb2duaXpl cjo6Y2FuY2VsKCkKICAgICBpZiAobV9zdGF0ZSA9PSBOb0dlc3R1cmUpCiAgICAgICAgIHJldHVy bjsKIAotICAgIEFTU0VSVCh2aWV3cG9ydENvbnRyb2xsZXIoKSk7Ci0gICAgdmlld3BvcnRDb250 cm9sbGVyKCktPnBpbmNoR2VzdHVyZUNhbmNlbGxlZCgpOworICAgIGlmICh2aWV3cG9ydENvbnRy b2xsZXIoKSkKKyAgICAgICAgdmlld3BvcnRDb250cm9sbGVyKCktPnBpbmNoR2VzdHVyZUNhbmNl bGxlZCgpOwogICAgIHJlc2V0KCk7CiB9CiAK