98877 2012-10-10 01:10:00 -0700 FontVerticalDataCache should allow zero as a key value 2012-10-10 15:17:19 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi tony webkit.review.bot oldest_to_newest 738712 0 bashi 2012-10-10 01:10:00 -0700 It seems that FontPlatformDataHarfBuzz::uniqueID() can be zero for valid instance. Since FontPlatformDataHarfBuzz::uniqueID() is used for a key of FontVerticalDataCache in some ports (chromium linux, android, blackberry), the cache should accept zero as a key value. 738721 1 167954 bashi 2012-10-10 01:15:59 -0700 Created attachment 167954 Patch 738727 2 bashi 2012-10-10 01:29:13 -0700 Hi Tony, Could you take a look? 739324 3 167954 bashi 2012-10-10 15:11:03 -0700 Comment on attachment 167954 Patch Thanks! 739330 4 167954 webkit.review.bot 2012-10-10 15:17:16 -0700 Comment on attachment 167954 Patch Clearing flags on attachment: 167954 Committed r130968: <http://trac.webkit.org/changeset/130968> 739331 5 webkit.review.bot 2012-10-10 15:17:19 -0700 All reviewed patches have been landed. Closing bug. 167954 2012-10-10 01:15:59 -0700 2012-10-10 15:17:16 -0700 Patch bug-98877-20121010171459.patch text/plain 2872 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTMwODQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDExMTE5NTM4NzU5OGUw OWJiNmI0MjVjNGE4NzFmM2VjYjlmMGVhNS4uMTIxNzcwNzU4ZGJhNTcyYzBlMzVmZTNiYTk5YzM5 OWQwZDEzMTZiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTEwICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4KKworICAgICAgICBGb250VmVydGlj YWxEYXRhQ2FjaGUgc2hvdWxkIGFsbG93IHplcm8gYXMgYSBrZXkgdmFsdWUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODc3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIFdURjo6VW5zaWduZWRXaXRo WmVyb0tleUhhc2hUcmFpdHMgZm9yIHR5cGUgZGVmaW5pdGlvbiBvZgorICAgICAgICBGb250VmVy dGljYWxEYXRhQ2FjaGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMg bm8gY2VydGFpbiB3YXkgdG8gbWFrZQorICAgICAgICBGb250UGxhdGZvcm1EYXRhSGFyZkJ1eno6 OnVuaXF1ZUlEKCkgYmUgemVyby4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRD YWNoZS5jcHA6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Rm9udFBsYXRmb3JtRGF0YTo6dmVydGljYWxEYXRhKTogUmVtb3ZlZCB6ZXJvIGNoZWNrIG9m IHVuaXF1ZUlEKCkuCisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpvcGVuVHlw ZVRhYmxlKTogRGl0dG8uCisKIDIwMTItMTAtMDkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFNob3VsZCByZWplY3QgaW52YWxpZCBkYXRlcyBjb25zdHJ1Y3Rl ZCB3aXRoIG11bHRpcGxlIGZpZWxkcyBVSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ZvbnRDYWNoZS5jcHAKaW5kZXggZDA0MzY1YTQyMGRhZDg3YzFmMTZiMTQ0NWJjOTg0 Mjg3ODkyMmZjOC4uM2ZlYTZjMjM1MWM2MmY1NmYzOTQyNWUxMGJlMWJiMGIyYzEwOTI2MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udENhY2hlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FjaGUuY3BwCkBAIC0y MjgsNyArMjI4LDcgQEAgRm9udFBsYXRmb3JtRGF0YSogRm9udENhY2hlOjpnZXRDYWNoZWRGb250 UGxhdGZvcm1EYXRhKGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgZm8KIH0KIAogI2lmIEVOQUJMRShP UEVOVFlQRV9WRVJUSUNBTCkKLXR5cGVkZWYgSGFzaE1hcDxGb250Q2FjaGU6OkZvbnRGaWxlS2V5 LCBPd25QdHI8T3BlblR5cGVWZXJ0aWNhbERhdGE+ID4gRm9udFZlcnRpY2FsRGF0YUNhY2hlOwor dHlwZWRlZiBIYXNoTWFwPEZvbnRDYWNoZTo6Rm9udEZpbGVLZXksIE93blB0cjxPcGVuVHlwZVZl cnRpY2FsRGF0YT4sIFdURjo6SW50SGFzaDxGb250Q2FjaGU6OkZvbnRGaWxlS2V5PiwgV1RGOjpV bnNpZ25lZFdpdGhaZXJvS2V5SGFzaFRyYWl0czxGb250Q2FjaGU6OkZvbnRGaWxlS2V5PiA+IEZv bnRWZXJ0aWNhbERhdGFDYWNoZTsKIAogRm9udFZlcnRpY2FsRGF0YUNhY2hlJiBmb250VmVydGlj YWxEYXRhQ2FjaGVJbnN0YW5jZSgpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRhSGFyZkJ1enouY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovRm9udFBsYXRmb3JtRGF0YUhh cmZCdXp6LmNwcAppbmRleCAyZDllODZhMzVmNzQ0NmRkN2UwZDBlZTFiNjU3OWJlYTEzZDhjZjQ1 Li5iOWQ1ZmM4ZTg1YjcyMDAzZWIyYjM1OGQ3YTI0MjE3MjNmMmVjNjlmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Gb250UGxhdGZvcm1EYXRh SGFyZkJ1enouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hhcmZi dXp6L0ZvbnRQbGF0Zm9ybURhdGFIYXJmQnV6ei5jcHAKQEAgLTM1MCwxNiArMzUwLDEyIEBAIHN0 YXRpYyBTa0ZvbnRUYWJsZVRhZyByZXZlcnNlQnl0ZU9yZGVyKHVpbnQzMl90IHRhYmxlVGFnKQog CiBjb25zdCBPcGVuVHlwZVZlcnRpY2FsRGF0YSogRm9udFBsYXRmb3JtRGF0YTo6dmVydGljYWxE YXRhKCkgY29uc3QKIHsKLSAgICBpZiAoIXVuaXF1ZUlEKCkpCi0gICAgICAgIHJldHVybiAwOwog ICAgIHJldHVybiBmb250Q2FjaGUoKS0+Z2V0VmVydGljYWxEYXRhKHVuaXF1ZUlEKCksICp0aGlz KTsKIH0KIAogUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IEZvbnRQbGF0Zm9ybURhdGE6Om9wZW5U eXBlVGFibGUodWludDMyX3QgdGFibGUpIGNvbnN0CiB7CiAgICAgUmVmUHRyPFNoYXJlZEJ1ZmZl cj4gYnVmZmVyOwotICAgIGlmICghdW5pcXVlSUQoKSkKLSAgICAgICAgcmV0dXJuIGJ1ZmZlci5y ZWxlYXNlKCk7CiAKICAgICBTa0ZvbnRUYWJsZVRhZyB0YWcgPSByZXZlcnNlQnl0ZU9yZGVyKHRh YmxlKTsKICAgICBjb25zdCBzaXplX3QgdGFibGVTaXplID0gU2tGb250SG9zdDo6R2V0VGFibGVT aXplKHVuaXF1ZUlEKCksIHRhZyk7Cg==