98875 2012-10-10 00:48:26 -0700 NEON intrinsics Gauss filter does not work properly 2012-10-17 01:10:43 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned dino webkit.review.bot zherczeg zimmermann oldest_to_newest 738688 0 rgabor 2012-10-10 00:48:26 -0700 NEON intrinsics Gauss filter does not work properly 738709 1 167950 rgabor 2012-10-10 01:08:27 -0700 Created attachment 167950 proposed patch The stride parameter was missing from the algorithm. I made a pixel check and now its working properly with this fix. 738715 2 webkit.review.bot 2012-10-10 01:11:42 -0700 Attachment 167950 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h:40: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 742884 3 167950 zherczeg 2012-10-16 00:17:53 -0700 Comment on attachment 167950 proposed patch fix the spaces, and r=me 742885 4 zherczeg 2012-10-16 00:18:29 -0700 And perhaps a little more explanation in the changelog. 743991 5 rgabor 2012-10-17 01:10:23 -0700 (In reply to comment #4) > And perhaps a little more explanation in the changelog. Thanks, I've added some more to it. Patch landed: http://trac.webkit.org/changeset/131562 167950 2012-10-10 01:08:27 -0700 2012-10-17 01:10:43 -0700 proposed patch gauss_fix.patch text/plain 3258 rgabor ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZDkwMzJmLi4zNjE2ODJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMTAtMTAgIEdhYm9yIFJhcGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgorCisg ICAgICAgIE5FT04gaW50cmluc2ljcyBHYXVzcyBmaWx0ZXIgZG9lcyBub3Qgd29yayBwcm9wZXJs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTg4NzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhpbmcg dGhlIE5FT04gaW50cmluc2ljcyBHYXVzcyBmaWx0ZXIKKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2ZpbHRlcnMvYXJtL0ZFR2F1c3NpYW5CbHVyTkVPTi5oOgorICAgICAgICAoV2ViQ29y ZTo6Ym94Qmx1ck5FT04pOgorCiAyMDEyLTEwLTA4ICBLaXJhbiBNdXBwYWxhICA8Y211cHBhbGFA YXBwbGUuY29tPgogCiAgICAgICAgIFRocm90dGxlIERPTSB0aW1lcnMgb24gaGlkZGVuIHBhZ2Vz LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9h cm0vRkVHYXVzc2lhbkJsdXJORU9OLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9maWx0ZXJzL2FybS9GRUdhdXNzaWFuQmx1ck5FT04uaAppbmRleCA5M2I0NmNmLi4wZTM4M2Ni IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2Fy bS9GRUdhdXNzaWFuQmx1ck5FT04uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9maWx0ZXJzL2FybS9GRUdhdXNzaWFuQmx1ck5FT04uaApAQCAtMzcsMTMgKzM3LDE0IEBA CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGlubGluZSB2b2lkIGJveEJsdXJORU9OKFVpbnQ4Q2xh bXBlZEFycmF5KiBzcmNQaXhlbEFycmF5LCBVaW50OENsYW1wZWRBcnJheSogZHN0UGl4ZWxBcnJh eSwKLSAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgZHgsIGludCBkeExlZnQsIGludCBkeFJp Z2h0LCBpbnQgc3RyaWRlLCBpbnQgc3RyaWRlTGluZSwgaW50IGVmZmVjdFdpZHRoLCBpbnQgZWZm ZWN0SGVpZ2h0KQorICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgZHgsIGludCBkeExl ZnQsIGludCBkeFJpZ2h0LCBpbnQgc3RyaWRlLCBpbnQgc3RyaWRlTGluZSwgaW50IGVmZmVjdFdp ZHRoLCBpbnQgZWZmZWN0SGVpZ2h0KQogewogICAgIHVpbnQzMl90KiBzb3VyY2VQaXhlbCA9IHJl aW50ZXJwcmV0X2Nhc3Q8dWludDMyX3QqPihzcmNQaXhlbEFycmF5LT5kYXRhKCkpOwogICAgIHVp bnQzMl90KiBkZXN0aW5hdGlvblBpeGVsID0gcmVpbnRlcnByZXRfY2FzdDx1aW50MzJfdCo+KGRz dFBpeGVsQXJyYXktPmRhdGEoKSk7CiAKICAgICBmbG9hdDMyeDRfdCBkZWx0YVggPSB2ZHVwcV9u X2YzMigxLjAgLyBkeCk7CiAgICAgaW50IHBpeGVsTGluZSA9IHN0cmlkZUxpbmUgLyA0OworICAg IGludCBwaXhlbFN0cmlkZSA9IHN0cmlkZSAvIDQ7CiAKICAgICBmb3IgKGludCB5ID0gMDsgeSA8 IGVmZmVjdEhlaWdodDsgKyt5KSB7CiAgICAgICAgIGludCBsaW5lID0geSAqIHBpeGVsTGluZTsK QEAgLTUxLDIxICs1MiwyMSBAQCBpbmxpbmUgdm9pZCBib3hCbHVyTkVPTihVaW50OENsYW1wZWRB cnJheSogc3JjUGl4ZWxBcnJheSwgVWludDhDbGFtcGVkQXJyYXkqIGRzdAogICAgICAgICAvLyBG aWxsIHRoZSBrZXJuZWwKICAgICAgICAgaW50IG1heEtlcm5lbFNpemUgPSBzdGQ6Om1pbihkeFJp Z2h0LCBlZmZlY3RXaWR0aCk7CiAgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbWF4S2VybmVs U2l6ZTsgKytpKSB7Ci0gICAgICAgICAgICBmbG9hdDMyeDRfdCBzb3VyY2VQaXhlbEFzRmxvYXQg PSBsb2FkUkdCQThBc0Zsb2F0KHNvdXJjZVBpeGVsICsgbGluZSArIGkpOworICAgICAgICAgICAg ZmxvYXQzMng0X3Qgc291cmNlUGl4ZWxBc0Zsb2F0ID0gbG9hZFJHQkE4QXNGbG9hdChzb3VyY2VQ aXhlbCArIGxpbmUgKyBpICogcGl4ZWxTdHJpZGUpOwogICAgICAgICAgICAgc3VtID0gdmFkZHFf ZjMyKHN1bSwgc291cmNlUGl4ZWxBc0Zsb2F0KTsKICAgICAgICAgfQogCiAgICAgICAgIC8vIEJs dXJyaW5nCiAgICAgICAgIGZvciAoaW50IHggPSAwOyB4IDwgZWZmZWN0V2lkdGg7ICsreCkgewot ICAgICAgICAgICAgaW50IHBpeGVsT2Zmc2V0ID0gbGluZSArIHg7CisgICAgICAgICAgICBpbnQg cGl4ZWxPZmZzZXQgPSBsaW5lICsgeCAqIHBpeGVsU3RyaWRlOwogICAgICAgICAgICAgZmxvYXQz Mng0X3QgcmVzdWx0ID0gdm11bHFfZjMyKHN1bSwgZGVsdGFYKTsKLSAgICAgICAgICAgIHN0b3Jl RmxvYXRBc1JHQkE4KHJlc3VsdCwgZGVzdGluYXRpb25QaXhlbCtwaXhlbE9mZnNldCk7CisgICAg ICAgICAgICBzdG9yZUZsb2F0QXNSR0JBOChyZXN1bHQsIGRlc3RpbmF0aW9uUGl4ZWwgKyBwaXhl bE9mZnNldCk7CiAgICAgICAgICAgICBpZiAoeCA+PSBkeExlZnQpIHsKLSAgICAgICAgICAgICAg ICBmbG9hdDMyeDRfdCBzb3VyY2VQaXhlbEFzRmxvYXQgPSBsb2FkUkdCQThBc0Zsb2F0KHNvdXJj ZVBpeGVsICsgcGl4ZWxPZmZzZXQgLSBkeExlZnQpOworICAgICAgICAgICAgICAgIGZsb2F0MzJ4 NF90IHNvdXJjZVBpeGVsQXNGbG9hdCA9IGxvYWRSR0JBOEFzRmxvYXQoc291cmNlUGl4ZWwgKyBw aXhlbE9mZnNldCAtIGR4TGVmdCAqIHBpeGVsU3RyaWRlKTsKICAgICAgICAgICAgICAgICBzdW0g PSB2c3VicV9mMzIoc3VtLCBzb3VyY2VQaXhlbEFzRmxvYXQpOwogICAgICAgICAgICAgfQogICAg ICAgICAgICAgaWYgKHggKyBkeFJpZ2h0IDwgZWZmZWN0V2lkdGgpIHsKLSAgICAgICAgICAgICAg ICBmbG9hdDMyeDRfdCBzb3VyY2VQaXhlbEFzRmxvYXQgPSBsb2FkUkdCQThBc0Zsb2F0KHNvdXJj ZVBpeGVsICsgcGl4ZWxPZmZzZXQgKyBkeFJpZ2h0KTsKKyAgICAgICAgICAgICAgICBmbG9hdDMy eDRfdCBzb3VyY2VQaXhlbEFzRmxvYXQgPSBsb2FkUkdCQThBc0Zsb2F0KHNvdXJjZVBpeGVsICsg cGl4ZWxPZmZzZXQgKyBkeFJpZ2h0ICogcGl4ZWxTdHJpZGUpOwogICAgICAgICAgICAgICAgIHN1 bSA9IHZhZGRxX2YzMihzdW0sIHNvdXJjZVBpeGVsQXNGbG9hdCk7CiAgICAgICAgICAgICB9CiAg ICAgICAgIH0K