9887 2006-07-12 21:27:26 -0700 REGRESSION: WebContinuousSpellCheckingEnabled should enable continuous spell checking on all text areas 2007-01-29 12:59:03 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ddkilzer webkit-unassigned adele idiotsalvation jon rachael sullivan vladimir.olexa webkit-bugs oldest_to_newest 49562 0 ddkilzer 2006-07-12 21:27:26 -0700 Setting the WebContinuousSpellCheckingEnabled default to 1 should enable continuous spell checking on all text fields and text areas in WebKit without having to change the setting through the contextual menu. The current production Safari 2.0.4 (419.3) on Mac OS X 10.4.7 (8J135/PowerPC) does this for text areas, but not text fields. On a locally-built WebKit r15401, neither text fields nor text areas have continuous spell checking on if this default is set. 49681 1 webkit-bugs 2006-07-13 11:35:54 -0700 Just to note, I do not believe this should be on for text fields by default. But it should be on for text areas by default. The former mimics the rest of Mac OS X. 49868 2 alice.barraclough 2006-07-14 17:06:11 -0700 <rdar://problem/4631821> 49958 3 ddkilzer 2006-07-15 12:47:30 -0700 Changing title of bug and removed NativeTextField keyword per Comment #1.  Production Safari only has continuous spell checking on text areas when WebContinuousSpellCheckingEnabled is set, not text fields. 55337 4 10520 vladimir.olexa 2006-09-12 19:46:40 -0700 Created attachment 10520 Proposed Patch Although, it has been mentioned this should be specific to TextAreas only, this patch makes changes globally. Meaning, if you change enable/disable spell checking on a text area, it will also enable/disable it on text fields. However, it does remember its state until it's changed again :) After discussion with Adele, maybe a separate bug can be filed (if it is, in fact, a bug) to make the setting separate from text fields. 55340 5 vladimir.olexa 2006-09-12 21:36:55 -0700 To me, having the text field and text area set separately seems more like a bug than a feature. When I first enabled the spell checker in shipping Safari on a text area and then later typed something in a field (e.g. subject line in an email client) I was very surprised the typed text wasn't checked automatically and that I was forced to enable it again. What do you guys think? 55386 6 sullivan 2006-09-13 05:53:39 -0700 For Safari's sake, I think a single setting to control both text fields and textareas would be best. I don't know if other WebKit clients might want to control these separately. 55679 7 Scott.Menor 2006-09-16 14:05:41 -0700 I agree with John and Vladimir - if selected, all editable text fields should be spellchecked and the setting should be persistent (it's frustrating to have to re-enable spellcheck for every field). It seems bizarre to think that someone would want to spellcheck textareas but not text input fields. Then again, since it doesn't do anything more than underline misspelled words without user interaction, it seems bizarre to me that anyone wouldn't want continuous spellcheck enabled all the time. 56507 8 10520 timothy 2006-09-25 22:24:29 -0700 Comment on attachment 10520 Proposed Patch isContinuousSpellCheckingEnabled is semi hot code, so it would be best to just have a file static BOOL continuousSpellCheckingEnabled. This will be faster than a lookup through NSUserDefaults. Also we usually don't store these toggled settings in a NSUserDefault, the application would normally do this and call setContinuousSpellCheckingEnabled with the default value. We don't have a default for setSmartInsertDeleteEnabled, etc. If we did add a new NSUserDefaults key, it should be added to WebPreferenceKeysPrivate.h. 56588 9 10792 vladimir.olexa 2006-09-26 22:02:39 -0700 Created attachment 10792 Patch Revised As discussed on IRC, just minor changes were made to this patch (only read from NSUserDefaults once per session) as shipping Safari does use WebContinuousSpellCheckingEnabled. 56624 10 10792 timothy 2006-09-27 10:48:42 -0700 Comment on attachment 10792 Patch Revised This looks good. We still should add WebContinuousSpellCheckingEnabled as a define in WebPreferenceKeysPrivate.h. 56635 11 10801 vladimir.olexa 2006-09-27 11:53:31 -0700 Created attachment 10801 Patch added a define in WebPreferencesPrivate.h 56636 12 10801 timothy 2006-09-27 11:58:22 -0700 Comment on attachment 10801 Patch Sorry. I meant WebPreferenceKeysPrivate.h. You will see other keys in there. 56649 13 10804 vladimir.olexa 2006-09-27 13:20:11 -0700 Created attachment 10804 Yet another Patch define moved to WebPrefenceKeysPrivate.h 54111 14 mrowe 2006-10-05 14:58:04 -0700 Vladimir, can you please be sure to double-check your patches for tabs in future? Landed in r16823. 54084 15 jon 2006-10-05 22:00:33 -0700 Patch for this bug doesn't reproduce the previous behavior. Before, only TextArea's always obeyed the spell checking preference. TextFields did not. And having spell checking active for TextFields is really something situational, since you type actual words in TextFields much less often than TextAreas. 53962 16 vladimir.olexa 2006-10-06 06:30:21 -0700 Jon, as you read the previous comments you'll see we were trying to figure out what the default behaviour should be. At the end, I think most people agreed that to have text areas and text fields set separately didn't make much sense and is kind of confusing for the user. Once you set it for text areas and you know it's working there, you go type something in the subject field (for example) and all of the sudden, nothing gets checked. So you either assume you've spelled everything correctly, or that the spell checker is not available/implemented for text fields, both of which may not be true. And regarding typing words in text fields much less than in text areas, I agree you type fewer words in fields than in areas, but they're words, nonetheless. 53963 17 sullivan 2006-10-06 07:03:13 -0700 There might be more cases where a one-line text field might be intended to hold non-words than a multi-line textarea, but we decided that it makes more sense for the setting to apply to both. 30959 18 sullivan 2007-01-29 12:59:03 -0800 *** Bug 9884 has been marked as a duplicate of this bug. *** 10520 2006-09-12 19:46:40 -0700 2006-09-26 22:02:39 -0700 Proposed Patch spell-checker-patch.txt text/plain 1999 vladimir.olexa SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTYzMzgpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTYgQEAKKzIwMDYtMDktMTIgIFZsYWRpbWlyIE9sZXhhICA8dmxhZGltaXIub2xleGFA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJQnVn OiBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODcKKwlD b250aW51b3VzIHNwZWxsIGNoZWNraW5nIG5vdyByZW1lbWJlcnMgdXNlcidzIHNldHRpbmcuIFRo ZSBjaGFuZ2UgaXMgYXBwbGllZCBnbG9iYWxseSwKKwltZWFuaW5nLCBib3RoIFRleHRBcmVhIGFu ZCBUZXh0RmllbGQgYXJlIGFmZmVjdGVkIHdoZW4gZWl0aGVyIG9mIHRoZW0gZW5hYmxlcy9kaXNh YmxlcworCXNwZWxsIGNoZWNraW5nLiAKKworICAgICAgICAqIFdlYlZpZXcvV2ViVmlldy5tOiAK KyAgICAgICAgKC1bV2ViVmlldyBzZXRDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQ6XSk6 CisgICAgICAgICgtW1dlYlZpZXcgaXNDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWRdKToK KwogPT09IFNhZmFyaS01MjEuMjYgPT09CiAKIDIwMDYtMDktMTEgIE1vcmdhbkwgIDxtb3JsbW9y QHlhaG9vLmNvbT4KSW5kZXg6IFdlYktpdC9XZWJWaWV3L1dlYlZpZXcubQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvV2ViVmlldy9XZWJWaWV3Lm0JKHJldmlzaW9uIDE2MzExKQorKysgV2ViS2l0L1dl YlZpZXcvV2ViVmlldy5tCSh3b3JraW5nIGNvcHkpCkBAIC0yOTEsNyArMjkxLDYgQEAgbWFjcm8o eWFua0FuZFNlbGVjdCkgXAogICAgIEJPT0wgaGFzU3BlbGxDaGVja2VyRG9jdW1lbnRUYWc7CiAg ICAgV2ViTlNJbnRlZ2VyIHNwZWxsQ2hlY2tlckRvY3VtZW50VGFnOwogCi0gICAgQk9PTCBjb250 aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQ7CiAgICAgQk9PTCBzbWFydEluc2VydERlbGV0ZUVu YWJsZWQ7CiAgICAgCiAgICAgQk9PTCBkYXNoYm9hcmRCZWhhdmlvckFsd2F5c1NlbmRNb3VzZUV2 ZW50c1RvQWxsV2luZG93czsKQEAgLTMxNTMsNyArMzE1Miw4IEBAIHN0YXRpYyBXZWJGcmFtZSAq aW5jcmVtZW50RnJhbWUoV2ViRnJhbWUKIAogLSAodm9pZClzZXRDb250aW51b3VzU3BlbGxDaGVj a2luZ0VuYWJsZWQ6KEJPT0wpZmxhZwogewotICAgIF9wcml2YXRlLT5jb250aW51b3VzU3BlbGxD aGVja2luZ0VuYWJsZWQgPSBmbGFnOworICAgIFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2Vy RGVmYXVsdHNdIHNldEJvb2w6ZmxhZyBmb3JLZXk6QCJXZWJDb250aW51b3VzU3BlbGxDaGVja2lu Z0VuYWJsZWQiXTsKKyAgICAKICAgICBpZiAoW3NlbGYgaXNDb250aW51b3VzU3BlbGxDaGVja2lu Z0VuYWJsZWRdKSB7CiAgICAgICAgIFtbc2VsZiBjbGFzc10gX3ByZWZsaWdodFNwZWxsQ2hlY2tl cl07CiAgICAgfSBlbHNlIHsKQEAgLTMxNjMsNyArMzE2Myw3IEBAIHN0YXRpYyBXZWJGcmFtZSAq aW5jcmVtZW50RnJhbWUoV2ViRnJhbWUKIAogLSAoQk9PTClpc0NvbnRpbnVvdXNTcGVsbENoZWNr aW5nRW5hYmxlZAogewotICAgIHJldHVybiBfcHJpdmF0ZS0+Y29udGludW91c1NwZWxsQ2hlY2tp bmdFbmFibGVkICYmIFtzZWxmIF9jb250aW51b3VzQ2hlY2tpbmdBbGxvd2VkXTsKKyAgICByZXR1 cm4gW1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gYm9vbEZvcktleTpAIldl YkNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCJdICYmIFtzZWxmIF9jb250aW51b3VzQ2hl Y2tpbmdBbGxvd2VkXTsKIH0KIAogLSAoV2ViTlNJbnRlZ2VyKXNwZWxsQ2hlY2tlckRvY3VtZW50 VGFnCg== 10792 2006-09-26 22:02:39 -0700 2006-09-27 11:53:31 -0700 Patch Revised spell-checker-patch-v2.txt text/plain 2802 vladimir.olexa SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTY1OTQpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTcgQEAKKzIwMDYtMDktMjcgIFZsYWRpbWlyIE9sZXhhICA8dmxhZGltaXIub2xleGFA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJQnVn OiBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODcKKwlD b250aW51b3VzIHNwZWxsIGNoZWNraW5nIG5vdyByZW1lbWJlcnMgdXNlcidzIHNldHRpbmcuIFRo ZSBjaGFuZ2UgaXMgYXBwbGllZCBnbG9iYWxseSwKKwltZWFuaW5nLCBib3RoIFRleHRBcmVhIGFu ZCBUZXh0RmllbGQgYXJlIGFmZmVjdGVkIHdoZW4gZWl0aGVyIG9mIHRoZW0gZW5hYmxlcy9kaXNh YmxlcworCXNwZWxsIGNoZWNraW5nLiAKKworICAgICAgICAqIFdlYlZpZXcvV2ViVmlldy5tOgor ICAgICAgICAoLVtXZWJWaWV3UHJpdmF0ZSBpbml0XSk6CisgICAgICAgICgtW1dlYlZpZXcgc2V0 Q29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkOl0pOgorICAgICAgICAoLVtXZWJWaWV3IGlz Q29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkXSk6CisKIDIwMDYtMDktMjYgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4K SW5kZXg6IFdlYktpdC9XZWJWaWV3L1dlYlZpZXcubQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvV2Vi Vmlldy9XZWJWaWV3Lm0JKHJldmlzaW9uIDE2NTk0KQorKysgV2ViS2l0L1dlYlZpZXcvV2ViVmll dy5tCSh3b3JraW5nIGNvcHkpCkBAIC0yOTEsOSArMjkxLDggQEAgbWFjcm8oeWFua0FuZFNlbGVj dCkgXAogICAgIEJPT0wgaGFzU3BlbGxDaGVja2VyRG9jdW1lbnRUYWc7CiAgICAgV2ViTlNJbnRl Z2VyIHNwZWxsQ2hlY2tlckRvY3VtZW50VGFnOwogCi0gICAgQk9PTCBjb250aW51b3VzU3BlbGxD aGVja2luZ0VuYWJsZWQ7CiAgICAgQk9PTCBzbWFydEluc2VydERlbGV0ZUVuYWJsZWQ7Ci0gICAg CisgICAgICAgIAogICAgIEJPT0wgZGFzaGJvYXJkQmVoYXZpb3JBbHdheXNTZW5kTW91c2VFdmVu dHNUb0FsbFdpbmRvd3M7CiAgICAgQk9PTCBkYXNoYm9hcmRCZWhhdmlvckFsd2F5c1NlbmRBY3Rp dmVOdWxsRXZlbnRzVG9QbHVnSW5zOwogICAgIEJPT0wgZGFzaGJvYXJkQmVoYXZpb3JBbHdheXNB Y2NlcHRzRmlyc3RNb3VzZTsKQEAgLTM2OCw2ICszNjcsOSBAQCBOU1N0cmluZyAqX1dlYk1haW5G cmFtZURvY3VtZW50S2V5ID0gICAgCiBAaW1wbGVtZW50YXRpb24gV2ViUHJvZ3Jlc3NJdGVtCiBA ZW5kCiAKKworc3RhdGljIEJPT0wgY29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkOworCiBA aW1wbGVtZW50YXRpb24gV2ViVmlld1ByaXZhdGUKIAogLSBpbml0IApAQCAtMzg0LDYgKzM4Niw3 IEBAIE5TU3RyaW5nICpfV2ViTWFpbkZyYW1lRG9jdW1lbnRLZXkgPSAgICAKICAgICBkYXNoYm9h cmRCZWhhdmlvckFsbG93V2hlZWxTY3JvbGxpbmcgPSBZRVM7CiAgICAgdGFiS2V5Q3ljbGVzVGhy b3VnaEVsZW1lbnRzID0gWUVTOwogICAgIHNob3VsZENsb3NlV2l0aFdpbmRvdyA9IG9iamNfY29s bGVjdGluZ19lbmFibGVkKCk7CisgICAgY29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkID0g W1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gYm9vbEZvcktleTpAIldlYkNv bnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCJdOwogCiAgICAgcmV0dXJuIHNlbGY7CiB9CkBA IC0zMTYyLDcgKzMxNjUsMTEgQEAgc3RhdGljIFdlYkZyYW1lICppbmNyZW1lbnRGcmFtZShXZWJG cmFtZQogCiAtICh2b2lkKXNldENvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZDooQk9PTClm bGFnCiB7Ci0gICAgX3ByaXZhdGUtPmNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCA9IGZs YWc7CisgICAgaWYgKGNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCAhPSBmbGFnKSB7Cisg ICAgICAgIGNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCA9IGZsYWc7CisgICAgICAgIFtb TlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIHNldEJvb2w6Y29udGludW91c1Nw ZWxsQ2hlY2tpbmdFbmFibGVkIGZvcktleTpAIldlYkNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5h YmxlZCJdOworICAgIH0KKyAgICAKICAgICBpZiAoW3NlbGYgaXNDb250aW51b3VzU3BlbGxDaGVj a2luZ0VuYWJsZWRdKSB7CiAgICAgICAgIFtbc2VsZiBjbGFzc10gX3ByZWZsaWdodFNwZWxsQ2hl Y2tlcl07CiAgICAgfSBlbHNlIHsKQEAgLTMxNzIsNyArMzE3OSw3IEBAIHN0YXRpYyBXZWJGcmFt ZSAqaW5jcmVtZW50RnJhbWUoV2ViRnJhbWUKIAogLSAoQk9PTClpc0NvbnRpbnVvdXNTcGVsbENo ZWNraW5nRW5hYmxlZAogewotICAgIHJldHVybiBfcHJpdmF0ZS0+Y29udGludW91c1NwZWxsQ2hl Y2tpbmdFbmFibGVkICYmIFtzZWxmIF9jb250aW51b3VzQ2hlY2tpbmdBbGxvd2VkXTsKKyAgICBy ZXR1cm4gKGNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCAmJiBbc2VsZiBfY29udGludW91 c0NoZWNraW5nQWxsb3dlZF0pOwogfQogCiAtIChXZWJOU0ludGVnZXIpc3BlbGxDaGVja2VyRG9j dW1lbnRUYWcK 10801 2006-09-27 11:53:31 -0700 2006-09-27 13:20:11 -0700 Patch spell-checker-patch-v3.txt text/plain 3512 vladimir.olexa SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTY1OTYpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTggQEAKKzIwMDYtMDktMjcgIFZsYWRpbWlyIE9sZXhhICA8dmxhZGltaXIub2xleGFA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJQnVn OiBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODcKKwlD b250aW51b3VzIHNwZWxsIGNoZWNraW5nIG5vdyByZW1lbWJlcnMgdXNlcidzIHNldHRpbmcuIFRo ZSBjaGFuZ2UgaXMgYXBwbGllZCBnbG9iYWxseSwKKwltZWFuaW5nLCBib3RoIFRleHRBcmVhIGFu ZCBUZXh0RmllbGQgYXJlIGFmZmVjdGVkIHdoZW4gZWl0aGVyIG9mIHRoZW0gZW5hYmxlcy9kaXNh YmxlcworCXNwZWxsIGNoZWNraW5nLiAKKworICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5j ZXNQcml2YXRlLmg6IGFkZGVkIGEgZGVmaW5lIGZvciBXZWJDb250aW51b3VzU3BlbGxDaGVja2lu Z0VuYWJsZWQKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubToKKyAgICAgICAgKC1bV2ViVmll d1ByaXZhdGUgaW5pdF0pOiByZWFkcyBXZWJDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQg ZnJvbSBOU1VzZXJEZWZhdWx0cworICAgICAgICAoLVtXZWJWaWV3IHNldENvbnRpbnVvdXNTcGVs bENoZWNraW5nRW5hYmxlZDpdKTogCisgICAgICAgICgtW1dlYlZpZXcgaXNDb250aW51b3VzU3Bl bGxDaGVja2luZ0VuYWJsZWRdKToKKwogMjAwNi0wOS0yNyAgTW9yZ2FuTCAgPG1vcmdhbmwud2Vi a2l0QHlhaG9vLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWosIGxhbmRlZCBieSBC cmFkeQpJbmRleDogV2ViS2l0L1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0L1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmgJKHJldmlzaW9u IDE2NTk2KQorKysgV2ViS2l0L1dlYlZpZXcvV2ViUHJlZmVyZW5jZXNQcml2YXRlLmgJKHdvcmtp bmcgY29weSkKQEAgLTQ0LDYgKzQ0LDggQEAKIAogQGludGVyZmFjZSBXZWJQcmVmZXJlbmNlcyAo V2ViUHJpdmF0ZSkKIAorI2RlZmluZSBXZWJDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQg IChAIldlYkNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCIpCisKIC8vIFByZWZlcmVuY2Vz IHRoYXQgbWlnaHQgYmUgcHVibGljIGluIGEgZnV0dXJlIHJlbGVhc2UKIC0gKEJPT0wpcmVzcGVj dFN0YW5kYXJkU3R5bGVLZXlFcXVpdmFsZW50czsKIC0gKHZvaWQpc2V0UmVzcGVjdFN0YW5kYXJk U3R5bGVLZXlFcXVpdmFsZW50czooQk9PTClmbGFnOwpJbmRleDogV2ViS2l0L1dlYlZpZXcvV2Vi Vmlldy5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9XZWJWaWV3L1dlYlZpZXcubQkocmV2aXNpb24g MTY1OTYpCisrKyBXZWJLaXQvV2ViVmlldy9XZWJWaWV3Lm0JKHdvcmtpbmcgY29weSkKQEAgLTI5 MSw5ICsyOTEsOCBAQCBtYWNybyh5YW5rQW5kU2VsZWN0KSBcCiAgICAgQk9PTCBoYXNTcGVsbENo ZWNrZXJEb2N1bWVudFRhZzsKICAgICBXZWJOU0ludGVnZXIgc3BlbGxDaGVja2VyRG9jdW1lbnRU YWc7CiAKLSAgICBCT09MIGNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZDsKICAgICBCT09M IHNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZDsKLSAgICAKKyAgICAgICAgCiAgICAgQk9PTCBkYXNo Ym9hcmRCZWhhdmlvckFsd2F5c1NlbmRNb3VzZUV2ZW50c1RvQWxsV2luZG93czsKICAgICBCT09M IGRhc2hib2FyZEJlaGF2aW9yQWx3YXlzU2VuZEFjdGl2ZU51bGxFdmVudHNUb1BsdWdJbnM7CiAg ICAgQk9PTCBkYXNoYm9hcmRCZWhhdmlvckFsd2F5c0FjY2VwdHNGaXJzdE1vdXNlOwpAQCAtMzY4 LDYgKzM2Nyw5IEBAIE5TU3RyaW5nICpfV2ViTWFpbkZyYW1lRG9jdW1lbnRLZXkgPSAgICAKIEBp bXBsZW1lbnRhdGlvbiBXZWJQcm9ncmVzc0l0ZW0KIEBlbmQKIAorCitzdGF0aWMgQk9PTCBjb250 aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQ7CisKIEBpbXBsZW1lbnRhdGlvbiBXZWJWaWV3UHJp dmF0ZQogCiAtIGluaXQgCkBAIC0zODQsNiArMzg2LDcgQEAgTlNTdHJpbmcgKl9XZWJNYWluRnJh bWVEb2N1bWVudEtleSA9ICAgIAogICAgIGRhc2hib2FyZEJlaGF2aW9yQWxsb3dXaGVlbFNjcm9s bGluZyA9IFlFUzsKICAgICB0YWJLZXlDeWNsZXNUaHJvdWdoRWxlbWVudHMgPSBZRVM7CiAgICAg c2hvdWxkQ2xvc2VXaXRoV2luZG93ID0gb2JqY19jb2xsZWN0aW5nX2VuYWJsZWQoKTsKKyAgICBj b250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJk VXNlckRlZmF1bHRzXSBib29sRm9yS2V5OldlYkNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxl ZF07CiAKICAgICByZXR1cm4gc2VsZjsKIH0KQEAgLTMxNjIsNyArMzE2NSwxMSBAQCBzdGF0aWMg V2ViRnJhbWUgKmluY3JlbWVudEZyYW1lKFdlYkZyYW1lCiAKIC0gKHZvaWQpc2V0Q29udGludW91 c1NwZWxsQ2hlY2tpbmdFbmFibGVkOihCT09MKWZsYWcKIHsKLSAgICBfcHJpdmF0ZS0+Y29udGlu dW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkID0gZmxhZzsKKyAgICBpZiAoY29udGludW91c1NwZWxs Q2hlY2tpbmdFbmFibGVkICE9IGZsYWcpIHsKKyAgICAgICAgY29udGludW91c1NwZWxsQ2hlY2tp bmdFbmFibGVkID0gZmxhZzsKKyAgICAgICAgW1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJE ZWZhdWx0c10gc2V0Qm9vbDpjb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQgZm9yS2V5Oldl YkNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZF07CisgICAgfQorICAgIAogICAgIGlmIChb c2VsZiBpc0NvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZF0pIHsKICAgICAgICAgW1tzZWxm IGNsYXNzXSBfcHJlZmxpZ2h0U3BlbGxDaGVja2VyXTsKICAgICB9IGVsc2UgewpAQCAtMzE3Miw3 ICszMTc5LDcgQEAgc3RhdGljIFdlYkZyYW1lICppbmNyZW1lbnRGcmFtZShXZWJGcmFtZQogCiAt IChCT09MKWlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkCiB7Ci0gICAgcmV0dXJuIF9w cml2YXRlLT5jb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQgJiYgW3NlbGYgX2NvbnRpbnVv dXNDaGVja2luZ0FsbG93ZWRdOworICAgIHJldHVybiAoY29udGludW91c1NwZWxsQ2hlY2tpbmdF bmFibGVkICYmIFtzZWxmIF9jb250aW51b3VzQ2hlY2tpbmdBbGxvd2VkXSk7CiB9CiAKIC0gKFdl Yk5TSW50ZWdlcilzcGVsbENoZWNrZXJEb2N1bWVudFRhZwo= 10804 2006-09-27 13:20:11 -0700 2006-09-27 13:51:07 -0700 Yet another Patch spell-checker-patch-v4.txt text/plain 3979 vladimir.olexa SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTY2MDApCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTggQEAKKzIwMDYtMDktMjcgIFZsYWRpbWlyIE9sZXhhICA8dmxhZGltaXIub2xleGFA Z21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJQnVn OiBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk4ODcKKwlD b250aW51b3VzIHNwZWxsIGNoZWNraW5nIG5vdyByZW1lbWJlcnMgdXNlcidzIHNldHRpbmcuIFRo ZSBjaGFuZ2UgaXMgYXBwbGllZCBnbG9iYWxseSwKKwltZWFuaW5nLCBib3RoIFRleHRBcmVhIGFu ZCBUZXh0RmllbGQgYXJlIGFmZmVjdGVkIHdoZW4gZWl0aGVyIG9mIHRoZW0gZW5hYmxlcy9kaXNh YmxlcworCXNwZWxsIGNoZWNraW5nLiAKKworICAgICAgICAqIFdlYlZpZXcvV2ViUHJlZmVyZW5j ZUtleXNQcml2YXRlLmg6IGFkZGVkIGEgZGVmaW5lIGZvciBXZWJDb250aW51b3VzU3BlbGxDaGVj a2luZ0VuYWJsZWQKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZpZXcubToKKyAgICAgICAgKC1bV2Vi Vmlld1ByaXZhdGUgaW5pdF0pOiByZWFkcyBXZWJDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJs ZWQgZnJvbSBOU1VzZXJEZWZhdWx0cworICAgICAgICAoLVtXZWJWaWV3IHNldENvbnRpbnVvdXNT cGVsbENoZWNraW5nRW5hYmxlZDpdKToKKyAgICAgICAgKC1bV2ViVmlldyBpc0NvbnRpbnVvdXNT cGVsbENoZWNraW5nRW5hYmxlZF0pOgorCiAyMDA2LTA5LTI3ICBNb3JnYW5MICA8bW9yZ2FubC53 ZWJraXRAeWFob28uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiwgbGFuZGVkIGJ5 IEJyYWR5CkluZGV4OiBXZWJLaXQvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZhdGUuaAko cmV2aXNpb24gMTY2MDApCisrKyBXZWJLaXQvV2ViVmlldy9XZWJQcmVmZXJlbmNlS2V5c1ByaXZh dGUuaAkod29ya2luZyBjb3B5KQpAQCAtNTcsNiArNTcsNyBAQAogI2RlZmluZSBXZWJLaXRCYWNr Rm9yd2FyZENhY2hlRXhwaXJhdGlvbkludGVydmFsS2V5IEAiV2ViS2l0QmFja0ZvcndhcmRDYWNo ZUV4cGlyYXRpb25JbnRlcnZhbEtleSIKICNkZWZpbmUgV2ViS2l0VGFiVG9MaW5rc1ByZWZlcmVu Y2VLZXkgQCJXZWJLaXRUYWJUb0xpbmtzUHJlZmVyZW5jZUtleSIKICNkZWZpbmUgV2ViS2l0UHJp dmF0ZUJyb3dzaW5nRW5hYmxlZFByZWZlcmVuY2VLZXkgQCJXZWJLaXRQcml2YXRlQnJvd3NpbmdF bmFibGVkIgorI2RlZmluZSBXZWJDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQgQCJXZWJD b250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQiCiAKIC8vIFRoZXNlIGFyZSBwcml2YXRlIGJv dGggYmVjYXVzZSBjYWxsZXJzIHNob3VsZCBiZSB1c2luZyB0aGUgY292ZXIgbWV0aG9kcyBhbmQg YmVjYXVzZSB0aGUKIC8vIGNvdmVyIG1ldGhvZHMgdGhlbXNlbHZlcyBhcmUgcHJpdmF0ZS4KSW5k ZXg6IFdlYktpdC9XZWJWaWV3L1dlYlZpZXcubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvV2ViVmll dy9XZWJWaWV3Lm0JKHJldmlzaW9uIDE2NjAwKQorKysgV2ViS2l0L1dlYlZpZXcvV2ViVmlldy5t CSh3b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCw3IEBACiAjaW1wb3J0ICJXZWJQbHVnaW5EYXRh YmFzZS5oIgogI2ltcG9ydCAiV2ViUG9saWN5RGVsZWdhdGUuaCIKICNpbXBvcnQgIldlYlByZWZl cmVuY2VzUHJpdmF0ZS5oIgorI2ltcG9ydCAiV2ViUHJlZmVyZW5jZUtleXNQcml2YXRlLmgiCiAj aW1wb3J0ICJXZWJSZXNvdXJjZUxvYWREZWxlZ2F0ZS5oIgogI2ltcG9ydCAiV2ViU2NyaXB0RGVi dWdEZWxlZ2F0ZVByaXZhdGUuaCIKICNpbXBvcnQgIldlYlNjcmlwdERlYnVnU2VydmVyUHJpdmF0 ZS5oIgpAQCAtMjkxLDkgKzI5Miw4IEBAIG1hY3JvKHlhbmtBbmRTZWxlY3QpIFwKICAgICBCT09M IGhhc1NwZWxsQ2hlY2tlckRvY3VtZW50VGFnOwogICAgIFdlYk5TSW50ZWdlciBzcGVsbENoZWNr ZXJEb2N1bWVudFRhZzsKIAotICAgIEJPT0wgY29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVk OwogICAgIEJPT0wgc21hcnRJbnNlcnREZWxldGVFbmFibGVkOwotICAgIAorICAgICAgICAKICAg ICBCT09MIGRhc2hib2FyZEJlaGF2aW9yQWx3YXlzU2VuZE1vdXNlRXZlbnRzVG9BbGxXaW5kb3dz OwogICAgIEJPT0wgZGFzaGJvYXJkQmVoYXZpb3JBbHdheXNTZW5kQWN0aXZlTnVsbEV2ZW50c1Rv UGx1Z0luczsKICAgICBCT09MIGRhc2hib2FyZEJlaGF2aW9yQWx3YXlzQWNjZXB0c0ZpcnN0TW91 c2U7CkBAIC0zNjgsNiArMzY4LDkgQEAgTlNTdHJpbmcgKl9XZWJNYWluRnJhbWVEb2N1bWVudEtl eSA9ICAgIAogQGltcGxlbWVudGF0aW9uIFdlYlByb2dyZXNzSXRlbQogQGVuZAogCisKK3N0YXRp YyBCT09MIGNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZDsKKwogQGltcGxlbWVudGF0aW9u IFdlYlZpZXdQcml2YXRlCiAKIC0gaW5pdCAKQEAgLTM4NCw2ICszODcsNyBAQCBOU1N0cmluZyAq X1dlYk1haW5GcmFtZURvY3VtZW50S2V5ID0gICAgCiAgICAgZGFzaGJvYXJkQmVoYXZpb3JBbGxv d1doZWVsU2Nyb2xsaW5nID0gWUVTOwogICAgIHRhYktleUN5Y2xlc1Rocm91Z2hFbGVtZW50cyA9 IFlFUzsKICAgICBzaG91bGRDbG9zZVdpdGhXaW5kb3cgPSBvYmpjX2NvbGxlY3RpbmdfZW5hYmxl ZCgpOworICAgIGNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCA9IFtbTlNVc2VyRGVmYXVs dHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIGJvb2xGb3JLZXk6V2ViQ29udGludW91c1NwZWxsQ2hl Y2tpbmdFbmFibGVkXTsKIAogICAgIHJldHVybiBzZWxmOwogfQpAQCAtMzE2Miw3ICszMTY2LDEx IEBAIHN0YXRpYyBXZWJGcmFtZSAqaW5jcmVtZW50RnJhbWUoV2ViRnJhbWUKIAogLSAodm9pZClz ZXRDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQ6KEJPT0wpZmxhZwogewotICAgIF9wcml2 YXRlLT5jb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQgPSBmbGFnOworICAgIGlmIChjb250 aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQgIT0gZmxhZykgeworICAgICAgICBjb250aW51b3Vz U3BlbGxDaGVja2luZ0VuYWJsZWQgPSBmbGFnOworICAgICAgICBbW05TVXNlckRlZmF1bHRzIHN0 YW5kYXJkVXNlckRlZmF1bHRzXSBzZXRCb29sOmNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxl ZCBmb3JLZXk6V2ViQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkXTsKKyAgICB9CisgICAg CiAgICAgaWYgKFtzZWxmIGlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdFbmFibGVkXSkgewogICAg ICAgICBbW3NlbGYgY2xhc3NdIF9wcmVmbGlnaHRTcGVsbENoZWNrZXJdOwogICAgIH0gZWxzZSB7 CkBAIC0zMTcyLDcgKzMxODAsNyBAQCBzdGF0aWMgV2ViRnJhbWUgKmluY3JlbWVudEZyYW1lKFdl YkZyYW1lCiAKIC0gKEJPT0wpaXNDb250aW51b3VzU3BlbGxDaGVja2luZ0VuYWJsZWQKIHsKLSAg ICByZXR1cm4gX3ByaXZhdGUtPmNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZCAmJiBbc2Vs ZiBfY29udGludW91c0NoZWNraW5nQWxsb3dlZF07CisgICAgcmV0dXJuIChjb250aW51b3VzU3Bl bGxDaGVja2luZ0VuYWJsZWQgJiYgW3NlbGYgX2NvbnRpbnVvdXNDaGVja2luZ0FsbG93ZWRdKTsK IH0KIAogLSAoV2ViTlNJbnRlZ2VyKXNwZWxsQ2hlY2tlckRvY3VtZW50VGFnCg==